)]}'
{"roles/build-test-packages/tasks/dlrn-build.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d423138ee576b2e3ec1cf92b8980826d9ce6becf","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  rescue:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    - debug:"},{"line_number":103,"context_line":"        msg: \"WARNING: Unable to build {{ artg_change.project }}. No pkg found.\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- name: Ensure artg_rdo_packages is defined"},{"line_number":106,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_872532b0","line":103,"updated":"2020-01-10 14:18:33.000000000","message":"maybe we need to tweak that though ... it could have been anything above right? like if git fails cos of a transient network issue?","commit_id":"60f3cd05b996ba16fa3a36707fab475669ba033d"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"04081775996280e5bb79b205269fb03dc449f62c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  rescue:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    - debug:"},{"line_number":103,"context_line":"        msg: \"WARNING: Unable to build {{ artg_change.project }}. No pkg found.\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- name: Ensure artg_rdo_packages is defined"},{"line_number":106,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_6756f6cf","line":103,"in_reply_to":"3fa7e38b_872532b0","updated":"2020-01-10 14:36:52.000000000","message":"I suggest to print here details that would help investigating on the failure like for example project_name_mapped.stderr when defined.\n\nI also agree with Marios regarding the fact there are many locations that would take to the rescue block, making hard to handle every one of such error individually. Do we want to ignore all those transient errors? What about package build errors? Aren\u0027t them interesting to capture our attention?","commit_id":"60f3cd05b996ba16fa3a36707fab475669ba033d"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"50b2144d83f8edc705cad1a6d28816e6bf5d4e18","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    - name: Map project name to DLRN project name"},{"line_number":35,"context_line":"      register: project_name_mapped"},{"line_number":36,"context_line":"      shell: \u003e"},{"line_number":37,"context_line":"        set -eo pipefail;"},{"line_number":38,"context_line":"        source {{ build_repo_dir }}/dlrn-venv/bin/activate;"},{"line_number":39,"context_line":"        rdopkg findpkg -s {{ artg_change.project | basename }} -l rdoinfo | grep ^name | awk \u0027{print $2}\u0027"},{"line_number":40,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_47af3a9c","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":24},"updated":"2020-01-10 14:59:17.000000000","message":"I would enable here shell debug tracing:\n  set -eox pipefail\n\nIn this way we would be able to see the actual command we executes","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7e88ddc56bd110457607ea4558a27aa6e39f0296","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    - name: Map project name to DLRN project name"},{"line_number":35,"context_line":"      register: project_name_mapped"},{"line_number":36,"context_line":"      shell: \u003e"},{"line_number":37,"context_line":"        set -eo pipefail;"},{"line_number":38,"context_line":"        source {{ build_repo_dir }}/dlrn-venv/bin/activate;"},{"line_number":39,"context_line":"        rdopkg findpkg -s {{ artg_change.project | basename }} -l rdoinfo | grep ^name | awk \u0027{print $2}\u0027"},{"line_number":40,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d9fb0e13","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":24},"in_reply_to":"3fa7e38b_47af3a9c","updated":"2020-01-10 16:03:39.000000000","message":"Done","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"50b2144d83f8edc705cad1a6d28816e6bf5d4e18","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  rescue:"},{"line_number":45,"context_line":"    - debug:"},{"line_number":46,"context_line":"        msg: \"WARNING: Unable to build {{ artg_change.project }}. No pkg found.\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- when:"},{"line_number":49,"context_line":"    - project_name_mapped is success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_071f0209","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":80},"updated":"2020-01-10 14:59:17.000000000","message":"I suggest to print here also the stderr of failing shell script to help debugging problems.","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7e88ddc56bd110457607ea4558a27aa6e39f0296","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  rescue:"},{"line_number":45,"context_line":"    - debug:"},{"line_number":46,"context_line":"        msg: \"WARNING: Unable to build {{ artg_change.project }}. No pkg found.\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- when:"},{"line_number":49,"context_line":"    - project_name_mapped is success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_b9009204","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":80},"in_reply_to":"3fa7e38b_071f0209","updated":"2020-01-10 16:03:39.000000000","message":"Done","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"50b2144d83f8edc705cad1a6d28816e6bf5d4e18","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Ensure artg_rdo_packages is defined"},{"line_number":111,"context_line":"  set_fact:"},{"line_number":112,"context_line":"    artg_rdo_packages: []"},{"line_number":113,"context_line":"  when: artg_rdo_packages is not defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a7f06e67","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":21},"updated":"2020-01-10 14:59:17.000000000","message":"This has to be set before the variable is used (see line 54)","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7e88ddc56bd110457607ea4558a27aa6e39f0296","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Ensure artg_rdo_packages is defined"},{"line_number":111,"context_line":"  set_fact:"},{"line_number":112,"context_line":"    artg_rdo_packages: []"},{"line_number":113,"context_line":"  when: artg_rdo_packages is not defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_dc29bc82","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":21},"in_reply_to":"3fa7e38b_a7f06e67","updated":"2020-01-10 16:03:39.000000000","message":"Done","commit_id":"edf079ac48e789b91857c1add882bf59275065f1"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"2dc07a415c9fd748deeddd093ace5a88c8714be5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      register: repo_built"},{"line_number":110,"context_line":"      when: artg_build_one|bool"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"- name: Ensure artg_rdo_packages is defined"},{"line_number":113,"context_line":"  set_fact:"},{"line_number":114,"context_line":"    artg_rdo_packages: []"},{"line_number":115,"context_line":"  when: artg_rdo_packages is not defined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_9e6fad28","line":112,"updated":"2020-01-13 08:03:19.000000000","message":"This is no more required as you defined artg_rdo_packages as default. Condition will be never true.","commit_id":"579584710717f6cdc2031c8641aeb60f374cb595"}],"zuul.d/layout.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"66130fcdc062a7304cbdc3c382b075daaa7b3fa6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"      # - tripleo-undercloud-jobs"},{"line_number":5,"context_line":"      # - tripleo-multinode-container-full"},{"line_number":6,"context_line":"      # - tripleo-multinode-experimental"},{"line_number":7,"context_line":"      # - tripleo-multinode-branchful"},{"line_number":8,"context_line":"      # - release-notes-jobs-python3"},{"line_number":9,"context_line":"      # - tripleo-standalone-scenarios-full"},{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        # - tripleo-ci-centos-7-standalone"},{"line_number":13,"context_line":"        - openstack-tox-linters"},{"line_number":14,"context_line":"        - openstack-tox-molecule"},{"line_number":15,"context_line":"        - tripleo-ci-centos-7-containers-undercloud-minion:"},{"line_number":16,"context_line":"            files:"},{"line_number":17,"context_line":"              - ^roles/.*minion.*$"},{"line_number":18,"context_line":"              - ^playbooks/.*minion.*$"},{"line_number":19,"context_line":"    gate:"},{"line_number":20,"context_line":"      queue: tripleo"},{"line_number":21,"context_line":"      jobs:"},{"line_number":22,"context_line":"        - openstack-tox-linters"},{"line_number":23,"context_line":"        - openstack-tox-molecule"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_6f2eccab","line":23,"range":{"start_line":2,"start_character":2,"end_line":23,"end_character":0},"updated":"2020-01-10 17:37:12.000000000","message":"expected a list for dictionary value @ data[\u0027templates\u0027]","commit_id":"109bfbd2bed64252b7cbdd03464b7681c7b2e76d"}]}