)]}'
{"roles/build-test-packages/tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"396fb137e5fa3af6b80696b069b1c0fa15ed5f28","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  debug:"},{"line_number":220,"context_line":"    var: artg_change_list"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"- name: Check loop devices stat"},{"line_number":223,"context_line":"  stat:"},{"line_number":224,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":225,"context_line":"  register: stat_loop_devices"},{"line_number":226,"context_line":"  with_sequence: start\u003d0 end\u003d11"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"- name: Set loop_devices_absent fact"},{"line_number":229,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_4db8bb29","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":31},"updated":"2020-04-21 09:53:55.000000000","message":"Using the stat module is a pretty heavy way to go about it - it does a checksum and all sorts of other stuff. The find module with a regex would be faster.\n\nHowever, this could all be done in a single task which will execute faster if done with a shell script, something like:\n\n  - name: Clean up loop devices created by mock\n    shell: |-\n      exit_code\u003d0\n      for d in $(find /dev -maxdepth 1 -regex \u0027/dev/loop[0-9]+\u0027); do\n        rm -f ${d}\n        exit_code\u003d2\n      done\n      exit ${exit_code}\n    register: _loop_cleanup\n    changed_when: _loop_cleanup.rc \u003d\u003d 2\n    failed_when: _loop_cleanup.rc not in [0,2]","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c5c61f16818d28f9c9065fb04a4171de876be07","unresolved":false,"context_lines":[{"line_number":223,"context_line":"  stat:"},{"line_number":224,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":225,"context_line":"  register: stat_loop_devices"},{"line_number":226,"context_line":"  with_sequence: start\u003d0 end\u003d11"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"- name: Set loop_devices_absent fact"},{"line_number":229,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_73363bb7","line":226,"updated":"2020-04-21 06:56:18.000000000","message":"was a bit concerned about the hard-coding here... \n\ni see it defaults to that in mock https://github.com/rpm-software-management/mock/blob/42df0034f0046fb84f989af83a9d2f2aa7085901/mock/py/mockbuild/util.py#L1229\n\nThe check here should be safe enough since you\u0027re doing stat if it doesn\u0027t exist no problem... main issue is if they increase that default","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"bfe4b3021d4e0a58c2306da1a0b1168e5a77c897","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  debug:"},{"line_number":220,"context_line":"    var: artg_change_list"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"- name: Check loop devices stat"},{"line_number":223,"context_line":"  stat:"},{"line_number":224,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":225,"context_line":"  register: stat_loop_devices"},{"line_number":226,"context_line":"  with_sequence: start\u003d0 end\u003d11"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"- name: Set loop_devices_absent fact"},{"line_number":229,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_7093cc50","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":31},"in_reply_to":"1f493fa4_4db8bb29","updated":"2020-04-21 12:21:50.000000000","message":"we don\u0027t want to delete all the loop devices, want to persist loop devices which were created outside of mock, so doesn\u0027t seem it will work just with single task.\n\nyes agree when going with stat it will take couple of more seconds but seems more cleaner than adding a shell script. Yes can try find module instead of stat if that helps?","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e9f4665c134330bf67b506ca02fd9bcedd9d1b40","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  debug:"},{"line_number":220,"context_line":"    var: artg_change_list"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"- name: Check loop devices stat"},{"line_number":223,"context_line":"  stat:"},{"line_number":224,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":225,"context_line":"  register: stat_loop_devices"},{"line_number":226,"context_line":"  with_sequence: start\u003d0 end\u003d11"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"- name: Set loop_devices_absent fact"},{"line_number":229,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_f6e23401","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":31},"in_reply_to":"1f493fa4_7093cc50","updated":"2020-04-21 13:00:10.000000000","message":"Ah, I didn\u0027t realise that the list was intentionally limited. OK, seems fair enough then. The find module will be faster and will not require the set_fact below (because it returns a simple list). To me that makes it more maintainable and simpler to grok, but it\u0027s po-ay-to po-ta-to.","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38239ec9141e9234e77379353e289e932ddd5777","unresolved":false,"context_lines":[{"line_number":223,"context_line":"  stat:"},{"line_number":224,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":225,"context_line":"  register: stat_loop_devices"},{"line_number":226,"context_line":"  with_sequence: start\u003d0 end\u003d11"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"- name: Set loop_devices_absent fact"},{"line_number":229,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_d33aaf32","line":226,"in_reply_to":"1f493fa4_73363bb7","updated":"2020-04-21 07:16:32.000000000","message":"hmm i get your point, i took the current default, and it should be safe for our cases in CI even if they increase the default as we already cleaning up 12 devices that\u0027s large enough for our usage of loop devices.","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c5c61f16818d28f9c9065fb04a4171de876be07","unresolved":false,"context_lines":[{"line_number":261,"context_line":"  register: repo_built_multi"},{"line_number":262,"context_line":"  when: not artg_build_one|bool"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"- name: Clean up loop devices created by mock"},{"line_number":265,"context_line":"  file:"},{"line_number":266,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":267,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_d3f46fd2","line":264,"range":{"start_line":264,"start_character":16,"end_line":264,"end_character":17},"updated":"2020-04-21 06:56:18.000000000","message":"\"Clean up {{ loop_devices_absent | length }} loop devices created by mock\"\n\n(just suggestion)","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e6470825bd0160708519bd4b94e04bb3fe46b0f8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"  register: repo_built_multi"},{"line_number":262,"context_line":"  when: not artg_build_one|bool"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"- name: Clean up loop devices created by mock"},{"line_number":265,"context_line":"  file:"},{"line_number":266,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":267,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_13fa5741","line":264,"range":{"start_line":264,"start_character":16,"end_line":264,"end_character":17},"in_reply_to":"1f493fa4_332153fd","updated":"2020-04-21 07:22:39.000000000","message":"ack yeah fair enough i +2 anyway so no strong objection :D","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38239ec9141e9234e77379353e289e932ddd5777","unresolved":false,"context_lines":[{"line_number":261,"context_line":"  register: repo_built_multi"},{"line_number":262,"context_line":"  when: not artg_build_one|bool"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"- name: Clean up loop devices created by mock"},{"line_number":265,"context_line":"  file:"},{"line_number":266,"context_line":"    path: \"/dev/loop{{ item }}\""},{"line_number":267,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_332153fd","line":264,"range":{"start_line":264,"start_character":16,"end_line":264,"end_character":17},"in_reply_to":"1f493fa4_d3f46fd2","updated":"2020-04-21 07:16:32.000000000","message":"I would avoid update if no strong objection as in logs length is getting reflected.\n2020-04-20 21:41:49.049102 | primary | TASK [build-test-packages : Clean up loop devices created by mock] *************\n2020-04-20 21:41:49.049244 | primary | Monday 20 April 2020  21:41:49 +0000 (0:00:00.057)       0:14:06.743 **********\n2020-04-20 21:41:49.581086 | primary | changed: [undercloud] \u003d\u003e (item\u003d0)\n2020-04-20 21:41:50.193919 | primary | changed: [undercloud] \u003d\u003e (item\u003d1)\n2020-04-20 21:41:50.700443 | primary | changed: [undercloud] \u003d\u003e (item\u003d2)\n2020-04-20 21:41:51.230321 | primary | changed: [undercloud] \u003d\u003e (item\u003d3)\n2020-04-20 21:41:51.724398 | primary | changed: [undercloud] \u003d\u003e (item\u003d4)\n2020-04-20 21:41:52.243278 | primary | changed: [undercloud] \u003d\u003e (item\u003d5)\n2020-04-20 21:41:52.782612 | primary | changed: [undercloud] \u003d\u003e (item\u003d6)\n2020-04-20 21:41:53.315066 | primary | changed: [undercloud] \u003d\u003e (item\u003d7)\n2020-04-20 21:41:53.819332 | primary | changed: [undercloud] \u003d\u003e (item\u003d8)\n2020-04-20 21:41:54.357884 | primary | changed: [undercloud] \u003d\u003e (item\u003d9)\n2020-04-20 21:41:54.888212 | primary | changed: [undercloud] \u003d\u003e (item\u003d10)\n2020-04-20 21:41:55.395944 | primary | changed: [undercloud] \u003d\u003e (item\u003d11)","commit_id":"c57822580d7524456922feb0fe2154a87a69e31a"}]}