)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54ff1e9392d2e42c17ce0051d3daf3e4d20f0c41","unresolved":false,"context_lines":[{"line_number":10,"context_line":"script to blocks for easier management and replacement by"},{"line_number":11,"context_line":"tripleo-operators later."},{"line_number":12,"context_line":"Leave whole prep-images script for backward compatibility and"},{"line_number":13,"context_line":"usage in dev environments."},{"line_number":14,"context_line":"Change-Id: I3a096772747f3d8c60e6f9e6ea168cdcaeedb045"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f493fa4_ba777da0","line":13,"updated":"2020-04-27 07:35:43.000000000","message":"tracked somewhere?","commit_id":"a0b4cc98d6c52687b5577d0e4cff4fee5faed15e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b0d9f233592942e1dc1aad8c50440734dfdba5d4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"script to blocks for easier management and replacement by"},{"line_number":11,"context_line":"tripleo-operators later."},{"line_number":12,"context_line":"Leave whole prep-images script for backward compatibility and"},{"line_number":13,"context_line":"usage in dev environments."},{"line_number":14,"context_line":"Change-Id: I3a096772747f3d8c60e6f9e6ea168cdcaeedb045"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1f493fa4_face252b","line":13,"in_reply_to":"1f493fa4_ba777da0","updated":"2020-04-27 08:23:52.000000000","message":"https://tree.taiga.io/project/tripleo-ci-board/task/1679","commit_id":"a0b4cc98d6c52687b5577d0e4cff4fee5faed15e"}],"roles/overcloud-prep-images/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c32268038aa1cd009b83f12c892ca6d72b2f5805","unresolved":false,"context_lines":[{"line_number":10,"context_line":"overcloud_image_upload_log: \"{{ working_dir }}/overcloud_image_upload.log\""},{"line_number":11,"context_line":"overcloud_glance_image_upload_script: overcloud-glance-image-upload.sh.j2"},{"line_number":12,"context_line":"overcloud_glance_image_upload_log: \"{{ working_dir }}/overcloud_glance_image_upload.log\""},{"line_number":13,"context_line":"overcloud_list_flavors_log: \"{{ working_dir }}/overcloud_list_flavors.log\""},{"line_number":14,"context_line":"overcloud_list_flavors_script: overcloud-list-flavors.sh.j2"},{"line_number":15,"context_line":"overcloud_import_nodes_script: overcloud-import-nodes.sh.j2"},{"line_number":16,"context_line":"overcloud_import_nodes_log: \"{{ working_dir }}/overcloud_import_nodes.log\""},{"line_number":17,"context_line":"root_device_size_script: root-device-size.sh.j2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_45fbfe77","line":14,"range":{"start_line":13,"start_character":59,"end_line":14,"end_character":57},"updated":"2020-04-27 08:57:41.000000000","message":"just different order to all the other things here","commit_id":"94e6bda48a8161a8d9dde45dd2ded107d8de28bb"}],"roles/overcloud-prep-images/tasks/overcloud-prep-images.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54ff1e9392d2e42c17ce0051d3daf3e4d20f0c41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f493fa4_7a48555b","updated":"2020-04-27 07:35:43.000000000","message":"i see.. so even though you\u0027re keeping https://review.opendev.org/#/c/723202/6/roles/overcloud-prep-images/templates/overcloud-prep-images.sh.j2 here you choose to call the individual scripts.\n\nAh, probably because you want to use the conditionals you added to all the tasks here, when calling from operator?","commit_id":"a0b4cc98d6c52687b5577d0e4cff4fee5faed15e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b0d9f233592942e1dc1aad8c50440734dfdba5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f493fa4_1a267116","in_reply_to":"1f493fa4_7a48555b","updated":"2020-04-27 08:23:52.000000000","message":"yes, almost every call here will be replaced by operator later","commit_id":"a0b4cc98d6c52687b5577d0e4cff4fee5faed15e"}],"roles/overcloud-prep-images/templates/overcloud-import-nodes.sh.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"374bf756d823ebb5c5675e5720a180611716e4e5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"## * Register nodes with Ironic."},{"line_number":18,"context_line":"## ::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% if release in [\u0027mitaka\u0027] %}"},{"line_number":21,"context_line":"openstack baremetal import --json instackenv.json"},{"line_number":22,"context_line":"openstack baremetal configure boot"},{"line_number":23,"context_line":"{% elif step_introspect|bool or step_introspect_with_retry|bool %}"},{"line_number":24,"context_line":"openstack overcloud node import instackenv.json"},{"line_number":25,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1f493fa4_acc73d64","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":34},"updated":"2020-04-27 17:09:31.000000000","message":"I don\u0027t think we need this anymore?","commit_id":"94e6bda48a8161a8d9dde45dd2ded107d8de28bb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6414b9fe8974dcd27ebd0bfbc0c6c81f3f25f1ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":"## * Register nodes with Ironic."},{"line_number":18,"context_line":"## ::"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% if release in [\u0027mitaka\u0027] %}"},{"line_number":21,"context_line":"openstack baremetal import --json instackenv.json"},{"line_number":22,"context_line":"openstack baremetal configure boot"},{"line_number":23,"context_line":"{% elif step_introspect|bool or step_introspect_with_retry|bool %}"},{"line_number":24,"context_line":"openstack overcloud node import instackenv.json"},{"line_number":25,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1f493fa4_2c120d63","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":34},"in_reply_to":"1f493fa4_acc73d64","updated":"2020-04-27 17:30:52.000000000","message":"right, but in this patch only breakdown, we\u0027ll remove it when moving to operators","commit_id":"94e6bda48a8161a8d9dde45dd2ded107d8de28bb"}]}