)]}'
{"roles/extras-common/defaults/main.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"bae2e386e89061cc2200c1defc12275545223aaa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"docker_registry_namespace: \"tripleo{{ release }}\""},{"line_number":41,"context_line":"# option enabled in standalone to build containers locally"},{"line_number":42,"context_line":"# push to local registry, bypass remote registries."},{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"build_container_images: \u003e-"},{"line_number":45,"context_line":"  {% if release in [\u0027queens\u0027, \u0027rocky\u0027, \u0027stein\u0027, \u0027train\u0027] -%}"},{"line_number":46,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_e894fbea","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":26},"updated":"2020-07-28 08:02:49.000000000","message":"extra","commit_id":"f1968d9b9c19694808170ee6c28a0deddc19143f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1b4ade75662e1631a75fe620f3a6f48555e02580","unresolved":false,"context_lines":[{"line_number":39,"context_line":"docker_registry_host: docker.io"},{"line_number":40,"context_line":"docker_registry_namespace: \"tripleo{{ release }}\""},{"line_number":41,"context_line":"# option enabled in standalone to build containers locally"},{"line_number":42,"context_line":"# push to local registry, bypass remote registries."},{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if release in [\u0027queens\u0027, \u0027rocky\u0027, \u0027stein\u0027, \u0027train\u0027] -%}"},{"line_number":45,"context_line":"  false"},{"line_number":46,"context_line":"  {%- else -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- endif -%}"},{"line_number":49,"context_line":"docker_image_tag: current-tripleo"},{"line_number":50,"context_line":"# docker prefix"},{"line_number":51,"context_line":"docker_prep_prefix: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_bcb7e4d8","line":48,"range":{"start_line":42,"start_character":0,"end_line":48,"end_character":15},"updated":"2020-07-28 08:51:30.000000000","message":"It is going to break multinode jobs so switching back to job.build_container_images","commit_id":"bef6cd1bafca75c81bb2048ce580b00ad656ccc3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e51348a6c945c0bfa0e136a84b16cd4f0a44744b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  build_container_images|default(false)|bool -%}"},{"line_number":58,"context_line":"  openstack-"},{"line_number":59,"context_line":"  {%- else -%}"},{"line_number":60,"context_line":"  {{ ansible_distribution | lower}}-binary-"},{"line_number":61,"context_line":"  {%- endif -%}"},{"line_number":62,"context_line":"# docker suffix"},{"line_number":63,"context_line":"docker_prep_suffix: \"\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_bc7ae5ed","line":60,"updated":"2020-08-03 06:24:29.000000000","message":"need a space between lower and }} ?","commit_id":"bfb08da916cfcee0e504e1b2d0602d51484ebe7f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d9bf444c3b2e451fa1085974b85c21ccff654f56","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  build_container_images|default(false)|bool -%}"},{"line_number":58,"context_line":"  openstack-"},{"line_number":59,"context_line":"  {%- else -%}"},{"line_number":60,"context_line":"  {{ ansible_distribution | lower}}-binary-"},{"line_number":61,"context_line":"  {%- endif -%}"},{"line_number":62,"context_line":"# docker suffix"},{"line_number":63,"context_line":"docker_prep_suffix: \"\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_b0be89b1","line":60,"in_reply_to":"9f560f44_bc7ae5ed","updated":"2020-08-03 08:22:43.000000000","message":"Done","commit_id":"bfb08da916cfcee0e504e1b2d0602d51484ebe7f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2f822a310e5ca01124a6bf19153c5eab1bf10418","unresolved":false,"context_lines":[{"line_number":40,"context_line":"docker_registry_namespace: \"tripleo{{ release }}\""},{"line_number":41,"context_line":"# option enabled in standalone to build containers locally"},{"line_number":42,"context_line":"# push to local registry, bypass remote registries."},{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if job is defined and"},{"line_number":45,"context_line":"  job.build_container_images is defined and"},{"line_number":46,"context_line":"  job.build_container_images|default(false)|bool -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  false"},{"line_number":50,"context_line":"  {%- endif -%}"},{"line_number":51,"context_line":"docker_image_tag: current-tripleo"},{"line_number":52,"context_line":"# docker prefix"},{"line_number":53,"context_line":"docker_prep_prefix: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_aee29d9e","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":15},"updated":"2020-08-04 05:17:38.000000000","message":"seems like plan changed with PS9:- https://review.opendev.org/#/c/743432/8..9/roles/extras-common/defaults/main.yml, this shouldn\u0027t be needed in role default to rely on job.build_container_images. Default false can be set as to treat it as alltogether different quickstart var.\n\nIf still want to set this way then https://review.opendev.org/#/c/743432/15/roles/standalone/tasks/main.yml@62 and below in docker_prep_prefix condition get\u0027s duplicated and just build_container_images|default(false)|bool should have been enough.","commit_id":"182e4fd6c1ef5c10b041ac299269b61abbd0a045"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"70b490834ea974484450f140033647d1c6f0482b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if job is defined and"},{"line_number":45,"context_line":"  job.build_container_images is defined and"},{"line_number":46,"context_line":"  job.build_container_images|default(false)|bool -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_add14c5a","line":46,"updated":"2020-08-17 20:58:14.000000000","message":"didn\u0027t you miss or \"build_container_images\" ?","commit_id":"5e093b07935ccb6136de67faabca564e109a6685"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"fc49b306b1bc1d3e0248eb28825f92a99021de2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if job is defined and"},{"line_number":45,"context_line":"  job.build_container_images is defined and"},{"line_number":46,"context_line":"  job.build_container_images|default(false)|bool -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_0df318e9","line":46,"in_reply_to":"9f560f44_add14c5a","updated":"2020-08-17 21:04:18.000000000","message":"If the plan is to update featureset052 the standalone config file w/ build_container_images then I think we\u0027re good here.  The explicit param overrides the default and build_container_images is true, if it\u0027s set in zuul we take the zuul setting... and if it\u0027s not defined in the featureset than it\u0027s false.\n\ndoes that jive w/ your thoughts?","commit_id":"5e093b07935ccb6136de67faabca564e109a6685"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7c6ff836ed9c18280ae3c5e4f43172d01b2f0d71","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# option enabled in standalone to build containers locally"},{"line_number":42,"context_line":"# push to local registry, bypass remote registries."},{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if job is defined and"},{"line_number":45,"context_line":"  job.build_container_images is defined and"},{"line_number":46,"context_line":"  job.build_container_images|default(false)|bool -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- else -%}"},{"line_number":49,"context_line":"  false"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_dbba486c","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":52},"updated":"2020-08-20 08:24:07.000000000","message":"all this is covered by \"job.build_container_images|default(false)|bool\"","commit_id":"6593fa49bbb8310edb5d0a3a46825d8c9fef42fa"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7c6ff836ed9c18280ae3c5e4f43172d01b2f0d71","unresolved":false,"context_lines":[{"line_number":51,"context_line":"docker_image_tag: current-tripleo"},{"line_number":52,"context_line":"# docker prefix"},{"line_number":53,"context_line":"docker_prep_prefix: \u003e-"},{"line_number":54,"context_line":"  {% if job is defined and"},{"line_number":55,"context_line":"  job.build_container_images is defined and"},{"line_number":56,"context_line":"  job.build_container_images|default(false)|bool or"},{"line_number":57,"context_line":"  build_container_images|default(false)|bool -%}"},{"line_number":58,"context_line":"  openstack-"},{"line_number":59,"context_line":"  {%- else -%}"},{"line_number":60,"context_line":"  {{ ansible_distribution | lower }}-binary-"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_1bacc033","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":48},"updated":"2020-08-20 08:24:07.000000000","message":"ditto","commit_id":"6593fa49bbb8310edb5d0a3a46825d8c9fef42fa"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2a27a25855f26a8c5d6bb61850cb08f1b2ef62db","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# option enabled in standalone to build containers locally"},{"line_number":42,"context_line":"# push to local registry, bypass remote registries."},{"line_number":43,"context_line":"build_container_images: \u003e-"},{"line_number":44,"context_line":"  {% if job is defined and"},{"line_number":45,"context_line":"  job.build_container_images is defined and"},{"line_number":46,"context_line":"  job.build_container_images|default(false)|bool -%}"},{"line_number":47,"context_line":"  true"},{"line_number":48,"context_line":"  {%- else -%}"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_6e93655d","line":45,"range":{"start_line":44,"start_character":8,"end_line":45,"end_character":43},"updated":"2020-09-22 13:52:13.000000000","message":"this check is not necessary, I think you can do just:\n\nbuild_container_images: \"{{ job.build_container_images|default(false)|bool }}\"","commit_id":"9b696afb8ab6ac8e366670e68137495640a283d9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2a27a25855f26a8c5d6bb61850cb08f1b2ef62db","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  {%- endif -%}"},{"line_number":51,"context_line":"docker_image_tag: current-tripleo"},{"line_number":52,"context_line":"# docker prefix"},{"line_number":53,"context_line":"docker_prep_prefix: \u003e-"},{"line_number":54,"context_line":"  {% if job is defined and"},{"line_number":55,"context_line":"  job.build_container_images is defined and"},{"line_number":56,"context_line":"  job.build_container_images|default(false)|bool or"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_8e135901","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":22},"updated":"2020-09-22 13:52:13.000000000","message":"let\u0027s not touch this part in this patch, it\u0027s not related","commit_id":"9b696afb8ab6ac8e366670e68137495640a283d9"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"2e3a710c27443a0a866dcb31ce72921a940147f2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  build_container_images|default(false)|bool -%}"},{"line_number":58,"context_line":"  openstack-"},{"line_number":59,"context_line":"  {%- else -%}"},{"line_number":60,"context_line":"  {{ ansible_distribution | lower }}-binary-"},{"line_number":61,"context_line":"  {%- endif -%}"},{"line_number":62,"context_line":"# docker suffix"},{"line_number":63,"context_line":"docker_prep_suffix: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9f560f44_6e72457e","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":44},"updated":"2020-09-22 13:47:30.000000000","message":"this is no longer true. master is always openstack-","commit_id":"9b696afb8ab6ac8e366670e68137495640a283d9"}],"roles/standalone/tasks/main.yml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"02a60780351738f7847ef1df208c2c532edea1e6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  when:"},{"line_number":198,"context_line":"    - standalone_container_prep_updates"},{"line_number":199,"context_line":"    - not job.build_container_images|default(false)|bool"},{"line_number":200,"context_line":"  block:"},{"line_number":201,"context_line":"    - name: Replace tag_from_label value"},{"line_number":202,"context_line":"      replace:"},{"line_number":203,"context_line":"        path: \"{{ working_dir }}/containers-prepare-parameters.yaml\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_41ba010a","line":200,"updated":"2020-08-17 16:53:39.000000000","message":"you missed here I think","commit_id":"182e4fd6c1ef5c10b041ac299269b61abbd0a045"}]}