)]}'
{"playbooks/tempest.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"9bd198bab901038cbf7e8a7b63965afa03d3f5d2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":29,"context_line":"  delegate_to: localhost"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# This will execute the validate-tempest"},{"line_number":32,"context_line":"- name: Execute validate-tempest (deprecated)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_6e3a9798","line":29,"range":{"start_line":28,"start_character":2,"end_line":29,"end_character":24},"updated":"2020-07-29 13:59:46.000000000","message":"I hope you are fully aware that these facts are now set to localhost and you need special way to access from tasks running on other hosts.","commit_id":"73dd41d06122d9e99991491a4467a92601722bf0"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"b1db785a1f3927d524eaa1463acae9dca2bf2b8c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":29,"context_line":"  delegate_to: localhost"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# This will execute the validate-tempest"},{"line_number":32,"context_line":"- name: Execute validate-tempest (deprecated)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_2efedfad","line":29,"range":{"start_line":28,"start_character":2,"end_line":29,"end_character":24},"in_reply_to":"9f560f44_6e3a9798","updated":"2020-07-29 14:04:21.000000000","message":"the tempest_test_whitelist, tempest_test_blacklist and tempest_skip_register?","commit_id":"73dd41d06122d9e99991491a4467a92601722bf0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"74b42562c678ec4122a9784c6808ca24fd38c6c2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    - name: Load tests to be skipped"},{"line_number":6,"context_line":"      vars:"},{"line_number":7,"context_line":"        list_skipped_release: \"{{ release }}\""},{"line_number":8,"context_line":"      include_role:"},{"line_number":9,"context_line":"        name: list_skipped"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - name: Add skiplist tests to tempest_test_blacklist - skip them"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_4084b25e","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":18},"updated":"2020-07-30 10:19:21.000000000","message":"is it just this bit that you need to delegate_to? \nPer sorin\u0027s earlier comment - does it work OK for you like this? Can you still access the facts you are setting below without problems? If not perhaps you can explore adding delegate_to just for the include_role if that is the relevant part.","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"532e32539b127fcb55ef906596995d86f44defef","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    - name: Load tests to be skipped"},{"line_number":6,"context_line":"      vars:"},{"line_number":7,"context_line":"        list_skipped_release: \"{{ release }}\""},{"line_number":8,"context_line":"      include_role:"},{"line_number":9,"context_line":"        name: list_skipped"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    - name: Add skiplist tests to tempest_test_blacklist - skip them"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_0b365be7","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":18},"in_reply_to":"9f560f44_4084b25e","updated":"2020-07-30 11:29:48.000000000","message":"Yes, basically, this run locally and just execute the tempest-skip python code that reads the yaml file and return the list of skipped tests. The variable is loaded and it\u0027s used in os_tempest, and it\u0027s working. As you can see in the results. I also tested it locally on my box, and it worked fine.","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"74b42562c678ec4122a9784c6808ca24fd38c6c2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"    list_skipped_yaml_file: \"{{ local_working_dir }}/usr/local/share/ansible/roles/validate-tempest/vars/tempest_skip.yml\""},{"line_number":29,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":30,"context_line":"  delegate_to: localhost"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_209edeb7","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":26},"updated":"2020-07-30 10:19:21.000000000","message":"what is this bit about please worth a note in the commit message","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"532e32539b127fcb55ef906596995d86f44defef","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"    list_skipped_yaml_file: \"{{ local_working_dir }}/usr/local/share/ansible/roles/validate-tempest/vars/tempest_skip.yml\""},{"line_number":29,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":30,"context_line":"  delegate_to: localhost"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_6b5a772a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":26},"in_reply_to":"9f560f44_209edeb7","updated":"2020-07-30 11:29:48.000000000","message":"This is documented on the list_skipped role, do you want me to document it here as well?","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eaa501a31ea1cd3ae39ef4886922599a3eedbad","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"    list_skipped_yaml_file: \"{{ local_working_dir }}/usr/local/share/ansible/roles/validate-tempest/vars/tempest_skip.yml\""},{"line_number":29,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":30,"context_line":"  delegate_to: localhost"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_8b7eeb68","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":26},"in_reply_to":"9f560f44_6b5a772a","updated":"2020-07-30 11:37:30.000000000","message":"what does it have to do with this change, \n\nwas my question","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2d8436af97fef86d4b6efe3d56b3acc50921ad28","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    # that this playbook will be executed the virtualenv python, which have the"},{"line_number":26,"context_line":"    # openstac-tempest-skiplist module"},{"line_number":27,"context_line":"    ansible_python_interpreter: \"{{ local_working_dir }}/bin/python\""},{"line_number":28,"context_line":"    list_skipped_yaml_file: \"{{ local_working_dir }}/usr/local/share/ansible/roles/validate-tempest/vars/tempest_skip.yml\""},{"line_number":29,"context_line":"  when: tempest_use_skiplist | default(true)"},{"line_number":30,"context_line":"  delegate_to: localhost"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_8bcc2bbd","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":26},"in_reply_to":"9f560f44_8b7eeb68","updated":"2020-07-30 11:40:42.000000000","message":"Sorry, the default value is zuul.projects[\u0027opendev.org/openstack/openstack-tempest-skiplist\u0027].src_dir, which is fine when you\u0027re running from standalone, but not when you use delegate_to. Basically, we are using the location of the yaml file from the one installed by quickstart. This is also gated in quickstart, so we are good to go here.","commit_id":"99f4e977336f932c0db59cc0d327a0303c24e73c"}]}
