)]}'
{"roles/standalone-upgrade/defaults/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"15611bd0f6cadd674d6eec925802108c798a0614","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# deployment role"},{"line_number":19,"context_line":"standalone_role: Standalone.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":22,"context_line":"standalone_selinux_mode: \u003e-"},{"line_number":23,"context_line":"   {% if osp_release is defined -%}"},{"line_number":24,"context_line":"   enforcing"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_91ad35ec","line":21,"updated":"2020-09-22 18:16:56.000000000","message":"We should use base os instead of osp release flag. That\u0027s actually what we do in the quickstart-extras role that configures this","commit_id":"58b614e1317b8ec75cb050c1df2520375f3427f6"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"fac31e4e45e5dcd35a4ebc4767e0c0db6599e071","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# deployment role"},{"line_number":19,"context_line":"standalone_role: Standalone.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":22,"context_line":"standalone_selinux_mode: \u003e-"},{"line_number":23,"context_line":"   {% if osp_release is defined -%}"},{"line_number":24,"context_line":"   enforcing"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_f536f8b3","line":21,"in_reply_to":"9f560f44_774af582","updated":"2020-09-24 06:50:39.000000000","message":"Thank you Alex and Wes for review.\n\nI have used osp_release to be consistent with Undercloud-deploy[1] and Overcloud-deploy[2] roles which are already using osp_release to toggle selinux mode.\n\nI will move standalone_selinux_mode: enforcing in the internal release files. I will abandon this patch.\n\n[1] https://tinyurl.com/y6njvyjd\n[2] https://tinyurl.com/yyoa3g7j","commit_id":"58b614e1317b8ec75cb050c1df2520375f3427f6"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"02f6bfaf3084f44cd8aca739e8d3656ecaff61aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# deployment role"},{"line_number":19,"context_line":"standalone_role: Standalone.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":22,"context_line":"standalone_selinux_mode: \u003e-"},{"line_number":23,"context_line":"   {% if osp_release is defined -%}"},{"line_number":24,"context_line":"   enforcing"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_774af582","line":21,"in_reply_to":"9f560f44_91ad35ec","updated":"2020-09-23 22:07:25.000000000","message":"osp_release is a convention only found in code.eng/tripleo-environments/config/release/$foo  IMHO it\u0027s actually safer to use osp_release. HOWEVER.. since this is a default variable. One should only need to SET standalone_selinux_mode: enforcing in the internal release files.  So -1 on this as well.. \n\nSet the variable properly in internal release config. :)","commit_id":"58b614e1317b8ec75cb050c1df2520375f3427f6"}]}