)]}'
{"roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"acc9e29a0f640c98ee4de1f1921378a3497ef284","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if job.consumer_job | default(false) | bool and job.registry_ip_address is defined %}"},{"line_number":5,"context_line":"  - {{ job.registry_ip_address }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% elif job.registry_ip_address is defined %}"},{"line_number":7,"context_line":"  - {{ docker_registry_host }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"{% if undercloud_docker_registry_mirror is defined and undercloud_docker_registry_mirror %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f681702_5beb5baf","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":7},"updated":"2020-10-16 07:40:46.000000000","message":"the elif is unnecessary here the if and elif are doing the same thing because docker_registry_host is already set to job.registry_ip_address... it should not have been used in the first place (i mean docker_registry_host) it leads to confusion like here.","commit_id":"a6b5b419e5b9da5728a506b326f41e1a5a223383"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"23c8fc5ba2aab6b3bea8398694abaf9a60e4d1f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if job.consumer_job | default(false) | bool and job.registry_ip_address is defined %}"},{"line_number":5,"context_line":"  - {{ job.registry_ip_address }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% elif job.registry_ip_address is defined %}"},{"line_number":7,"context_line":"  - {{ docker_registry_host }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"{% if undercloud_docker_registry_mirror is defined and undercloud_docker_registry_mirror %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f6b1bfe_60dc8274","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":45},"updated":"2020-10-15 04:12:02.000000000","message":"we can switch to registry_ip_address_branch, please update the patch based on this https://review.opendev.org/#/c/753708/23/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2","commit_id":"a6b5b419e5b9da5728a506b326f41e1a5a223383"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"32071e1122c292b352790496a053ed08b7e1cca3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if job.consumer_job | default(false) | bool and job.registry_ip_address is defined %}"},{"line_number":5,"context_line":"  - {{ job.registry_ip_address }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% elif job.registry_ip_address is defined %}"},{"line_number":7,"context_line":"  - {{ docker_registry_host }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"{% if undercloud_docker_registry_mirror is defined and undercloud_docker_registry_mirror %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f681702_1e1ef16f","line":6,"range":{"start_line":6,"start_character":3,"end_line":6,"end_character":7},"in_reply_to":"5f681702_5beb5baf","updated":"2020-10-16 10:11:17.000000000","message":"After the Folco\u0027s patch[1], i don\u0027t think we need this proposed changes. Adding only {{ docker_registry_host }} will work.\n\n[1] https://review.opendev.org/#/c/758214/3..4/roles/extras-common/defaults/main.yml","commit_id":"a6b5b419e5b9da5728a506b326f41e1a5a223383"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0aae3f175462ae63ac3304082ce935f30ea46b88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if job.consumer_job | default(false) | bool and job.registry_ip_address is defined %}"},{"line_number":5,"context_line":"  - {{ job.registry_ip_address }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% elif job.registry_ip_address is defined %}"},{"line_number":7,"context_line":"  - {{ docker_registry_host }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"{% if undercloud_docker_registry_mirror is defined and undercloud_docker_registry_mirror %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f6b1bfe_6f12ad5a","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":45},"in_reply_to":"7f6b1bfe_60dc8274","updated":"2020-10-15 10:46:57.000000000","message":"I think it\u0027s gonna change in Marios patches","commit_id":"a6b5b419e5b9da5728a506b326f41e1a5a223383"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6cd881e8a8ce4d30f27b850a3d9e23fc8d70c137","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if job.consumer_job | default(false) | bool and job.registry_ip_address is defined %}"},{"line_number":5,"context_line":"  - {{ job.registry_ip_address }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% elif job.registry_ip_address is defined %}"},{"line_number":7,"context_line":"  - {{ docker_registry_host }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"{% if undercloud_docker_registry_mirror is defined and undercloud_docker_registry_mirror %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f681702_bbca6f4c","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":45},"in_reply_to":"7f6b1bfe_6f12ad5a","updated":"2020-10-16 07:38:11.000000000","message":"thanks, yeah i don\u0027t think we need this one https://review.opendev.org/#/c/753708/26/roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2 that one is good to go and does the same","commit_id":"a6b5b419e5b9da5728a506b326f41e1a5a223383"}]}