)]}'
{"playbooks/multinode-multiple-overcloud.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dd3ea73c9b9f8a854200dd0acee45c893d9a13f4","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    stack_name: \"overcloud-two\""},{"line_number":46,"context_line":"    deploy_log: \"{{ working_dir }}/overcloud_two_deploy.log\""},{"line_number":47,"context_line":"    post_deploy_log: \"{{ working_dir }}/overcloud_two_deploy_post.log\""},{"line_number":48,"context_line":"    overcloud_cloud_name: overcloud-two.localdomain"},{"line_number":49,"context_line":"    overcloud_cloud_name_internal: overcloud-two.internalapi.localdomain"},{"line_number":50,"context_line":"    overcloud_cloud_name_storage: overcloud-two.storage.localdomain"},{"line_number":51,"context_line":"    overcloud_cloud_name_storage_management: overcloud-two.storagemgmt.localdomain"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"139ca917_085c178a","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":51},"updated":"2020-12-02 06:07:22.000000000","message":"Can we write it as overcloud_cloud_name: \"{{ stack_name }}.localdomain\"?\nand same for 49 to 52 line.","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7db4a2c7626a3c102cdcd48ff30b503190d6d7f3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    stack_name: \"overcloud-two\""},{"line_number":46,"context_line":"    deploy_log: \"{{ working_dir }}/overcloud_two_deploy.log\""},{"line_number":47,"context_line":"    post_deploy_log: \"{{ working_dir }}/overcloud_two_deploy_post.log\""},{"line_number":48,"context_line":"    overcloud_cloud_name: overcloud-two.localdomain"},{"line_number":49,"context_line":"    overcloud_cloud_name_internal: overcloud-two.internalapi.localdomain"},{"line_number":50,"context_line":"    overcloud_cloud_name_storage: overcloud-two.storage.localdomain"},{"line_number":51,"context_line":"    overcloud_cloud_name_storage_management: overcloud-two.storagemgmt.localdomain"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a60d91f_cd6513aa","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":51},"in_reply_to":"139ca917_085c178a","updated":"2020-12-02 09:13:10.000000000","message":"Done","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"23eee635ebf82d0e1ed2e9bc53531cbe89eab3bc","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# Deploy First stack - overcloud #"},{"line_number":14,"context_line":"##################################"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Deploy the overcloud"},{"line_number":17,"context_line":"  hosts: undercloud"},{"line_number":18,"context_line":"  gather_facts: false"},{"line_number":19,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fd6eb32b_5c6e6fb4","line":16,"updated":"2020-12-02 15:57:49.000000000","message":"Deploy the first overcloud","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Deploy First stack - overcloud #"},{"line_number":14,"context_line":"##################################"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Deploy the overcloud"},{"line_number":17,"context_line":"  hosts: undercloud"},{"line_number":18,"context_line":"  gather_facts: false"},{"line_number":19,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fe98c47e_bb36ff24","line":16,"in_reply_to":"fd6eb32b_5c6e6fb4","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"23eee635ebf82d0e1ed2e9bc53531cbe89eab3bc","unresolved":true,"context_lines":[{"line_number":38,"context_line":"# Deploy Second stack - overcloud-two #"},{"line_number":39,"context_line":"#######################################"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Deploy the overcloud"},{"line_number":42,"context_line":"  hosts: undercloud"},{"line_number":43,"context_line":"  gather_facts: false"},{"line_number":44,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ebc11f05_d20fe4c6","line":41,"updated":"2020-12-02 15:57:49.000000000","message":"Deploy the second overcloud - makes it clearer where we are in the process","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# Deploy Second stack - overcloud-two #"},{"line_number":39,"context_line":"#######################################"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Deploy the overcloud"},{"line_number":42,"context_line":"  hosts: undercloud"},{"line_number":43,"context_line":"  gather_facts: false"},{"line_number":44,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"27878cfa_16a4241a","line":41,"in_reply_to":"ebc11f05_d20fe4c6","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"}],"roles/overcloud-deploy/defaults/main.yml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"23eee635ebf82d0e1ed2e9bc53531cbe89eab3bc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/overcloud_deploy.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d62cdd66_a17181c6","line":7,"updated":"2020-12-02 15:57:49.000000000","message":"should this not be stack_name as well? why the two logs?","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d8b7f344c1a30c8d46d54ef34ca442483d463c0f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/overcloud_deploy.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e311da13_b143e6f1","line":7,"in_reply_to":"d62cdd66_a17181c6","updated":"2020-12-03 07:19:34.000000000","message":"+1 to use stack_name here itself instead of where it\u0027s called, or there is specific reason to not use it?","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/overcloud_deploy.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3560c045_2d88b43a","line":7,"in_reply_to":"e311da13_b143e6f1","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d8b7f344c1a30c8d46d54ef34ca442483d463c0f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/overcloud_deploy.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"second_stack_failed_deployments_log: \"{{ working_dir }}/second_stack_failed_deployments.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a38869bd_a88683ba","line":10,"updated":"2020-12-03 07:19:34.000000000","message":"here too.","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/overcloud_deploy.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"second_stack_failed_deployments_log: \"{{ working_dir }}/second_stack_failed_deployments.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8e44d38b_db7ba6cd","line":10,"in_reply_to":"a38869bd_a88683ba","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d8b7f344c1a30c8d46d54ef34ca442483d463c0f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"second_stack_failed_deployments_log: \"{{ working_dir }}/second_stack_failed_deployments.log\""},{"line_number":14,"context_line":"second_stack_failed_deployment_list: \"{{ working_dir }}/second_stack_failed_deployment_list.log\""},{"line_number":15,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a6c42d6e_79dda30d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":70},"updated":"2020-12-03 07:19:34.000000000","message":"can utilize these itself instead of creating additional vars. If want to use current names for single overcloud deployment can use some conditional to add prefix only for second overcloud deployment cases.","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: \"{{ stack_name }}-deploy-post.sh.j2\""},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/overcloud_deploy_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"second_stack_failed_deployments_log: \"{{ working_dir }}/second_stack_failed_deployments.log\""},{"line_number":14,"context_line":"second_stack_failed_deployment_list: \"{{ working_dir }}/second_stack_failed_deployment_list.log\""},{"line_number":15,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a5f975b4_b6d50285","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":70},"in_reply_to":"a6c42d6e_79dda30d","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1f84629290232a4c90bfeaa5136eaff5d7388ed","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Script and log locations used during the deploy process."},{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"8d9a351a_0e5cc266","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":46},"updated":"2020-12-03 09:31:52.000000000","message":"need to revert to original","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"83fb57d516615e6c26ee22eda7e01356fa31a0ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Script and log locations used during the deploy process."},{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9e72dfc0_9813de08","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":46},"in_reply_to":"8d9a351a_0e5cc266","updated":"2020-12-03 10:30:55.000000000","message":"Done","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1f84629290232a4c90bfeaa5136eaff5d7388ed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4d620e94_d74476cb","line":7,"updated":"2020-12-03 09:31:52.000000000","message":"_deploy.log","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"83fb57d516615e6c26ee22eda7e01356fa31a0ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"stack_name: \"overcloud\""},{"line_number":5,"context_line":"deploy_script: \"{{ stack_name }}-deploy.sh.j2\""},{"line_number":6,"context_line":"deploy_cell_script: overcloud-deploy-cell.sh.j2"},{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1911e36a_e841733e","line":7,"in_reply_to":"4d620e94_d74476cb","updated":"2020-12-03 10:30:55.000000000","message":"Done","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1f84629290232a4c90bfeaa5136eaff5d7388ed","unresolved":true,"context_lines":[{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4dc8518a_8f2b7334","line":10,"updated":"2020-12-03 09:31:52.000000000","message":"_deploy_post","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"83fb57d516615e6c26ee22eda7e01356fa31a0ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"deploy_log: \"{{ working_dir }}/{{ stack_name }}.log\""},{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"80c47590_0fa99d9b","line":10,"in_reply_to":"4dc8518a_8f2b7334","updated":"2020-12-03 10:30:55.000000000","message":"Done","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1f84629290232a4c90bfeaa5136eaff5d7388ed","unresolved":true,"context_lines":[{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""},{"line_number":14,"context_line":"failed_cell_deployments_log: \"{{ working_dir }}/failed_cell_deployments.log\""},{"line_number":15,"context_line":"tripleo_config_download_log: \"{{ working_dir }}/tripleo_config_download.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"b6078c4d_1ea72a54","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":70},"updated":"2020-12-03 09:31:52.000000000","message":"don\u0027t need to generalize these?","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"83fb57d516615e6c26ee22eda7e01356fa31a0ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":"deploy_cell_log: \"{{ working_dir }}/cell_deploy.log\""},{"line_number":9,"context_line":"post_deploy_script: overcloud-deploy-post.sh.j2"},{"line_number":10,"context_line":"post_deploy_log: \"{{ working_dir }}/{{ stack_name }}_post.log\""},{"line_number":11,"context_line":"failed_deployments_log: \"{{ working_dir }}/failed_deployments.log\""},{"line_number":12,"context_line":"failed_deployment_list: \"{{ working_dir }}/failed_deployment_list.log\""},{"line_number":13,"context_line":"failed_cell_deployment_list: \"{{ working_dir }}/failed_cell_deployment_list.log\""},{"line_number":14,"context_line":"failed_cell_deployments_log: \"{{ working_dir }}/failed_cell_deployments.log\""},{"line_number":15,"context_line":"tripleo_config_download_log: \"{{ working_dir }}/tripleo_config_download.log\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"008b34b6_97a2c607","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":70},"in_reply_to":"b6078c4d_1ea72a54","updated":"2020-12-03 10:30:55.000000000","message":"Earlier, I thought of these options:-\n\nOption 1:-\nleaving failed_deployments.log as it is, Because:-\n1)if playbook fails while deployment of first stack -\u003e playbook will never deploy overcloud-two -\u003e failed_deployments.log will consist failures of first stack\n2)if playbook fails while deployment of second stack -\u003e failed_deployments.log will consist failures of second stack\n3) if deployment don\u0027t fail -\u003e failed_deployments.log will not create\n\nOption 2:-\nReplacing to { stack_name }_failed_deployments.log\n\nI have updated with option 2, as just by the file name we will be able to tell that which stack failed.","commit_id":"f1dc8616bd06a1744a8e48670954732a25a351eb"}],"roles/overcloud-deploy/tasks/post-deploy.yml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"23eee635ebf82d0e1ed2e9bc53531cbe89eab3bc","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ working_dir }}/{{ stack_name }}-deploy-post.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e"},{"line_number":15,"context_line":"    {{ post_deploy_log }}"},{"line_number":16,"context_line":"  changed_when: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"415bd55c_b3de40e6","line":15,"updated":"2020-12-02 15:57:49.000000000","message":"do we need two of these as well?","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ working_dir }}/{{ stack_name }}-deploy-post.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e"},{"line_number":15,"context_line":"    {{ post_deploy_log }}"},{"line_number":16,"context_line":"  changed_when: true"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0d6bbdcf_18066b3c","line":15,"in_reply_to":"415bd55c_b3de40e6","updated":"2020-12-03 08:30:24.000000000","message":"In the latest patchset..\n\nWe have generalized the template: overcloud-deploy-post.sh.j2 which i.e create overcloud-deploy-post.sh or overcloud-two-deploy-post.sh depending on stack_name.\n\nFor sanity i think it will be better to create post deploy script with different stack names, or remove overcloud names from script all together.","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"}],"roles/overcloud-deploy/templates/overcloud-two-deploy-post.sh.j2":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dd3ea73c9b9f8a854200dd0acee45c893d9a13f4","unresolved":true,"context_lines":[{"line_number":32,"context_line":"$(openstack stack output show overcloud-two HostsEntry -f value -c output_value)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% if enable_pacemaker|bool and release \u003d\u003d \u0027mitaka\u0027 %}"},{"line_number":35,"context_line":"$(openstack stack output show overcloud-two PublicVip \\"},{"line_number":36,"context_line":"            -f value -c output_value) overcloud-public-vip"},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":"## END OVERCLOUD HOSTS    #nodocs"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"86e3cf64_dfd6e6c4","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":43},"updated":"2020-12-02 06:07:22.000000000","message":"{{ stack_name }}","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7db4a2c7626a3c102cdcd48ff30b503190d6d7f3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"$(openstack stack output show overcloud-two HostsEntry -f value -c output_value)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% if enable_pacemaker|bool and release \u003d\u003d \u0027mitaka\u0027 %}"},{"line_number":35,"context_line":"$(openstack stack output show overcloud-two PublicVip \\"},{"line_number":36,"context_line":"            -f value -c output_value) overcloud-public-vip"},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":"## END OVERCLOUD HOSTS    #nodocs"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"e424cbc3_6e2d404d","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":43},"in_reply_to":"86e3cf64_dfd6e6c4","updated":"2020-12-02 09:13:10.000000000","message":"Done","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dd3ea73c9b9f8a854200dd0acee45c893d9a13f4","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    ## * Source in the overcloud-two credentials."},{"line_number":49,"context_line":"    ## ::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    . {{ working_dir }}/overcloud-tworc"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    if ! openstack role show heat_stack_owner \u003e /dev/null 2\u003e\u00261; then"},{"line_number":54,"context_line":"        openstack role create heat_stack_owner"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"b0a59e41_e5098856","line":51,"range":{"start_line":51,"start_character":24,"end_line":51,"end_character":39},"updated":"2020-12-02 06:07:22.000000000","message":"{{ stack_name }}rc","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7db4a2c7626a3c102cdcd48ff30b503190d6d7f3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ## * Source in the overcloud-two credentials."},{"line_number":49,"context_line":"    ## ::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    . {{ working_dir }}/overcloud-tworc"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    if ! openstack role show heat_stack_owner \u003e /dev/null 2\u003e\u00261; then"},{"line_number":54,"context_line":"        openstack role create heat_stack_owner"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"acfd4c54_ace5fafd","line":51,"range":{"start_line":51,"start_character":24,"end_line":51,"end_character":39},"in_reply_to":"b0a59e41_e5098856","updated":"2020-12-02 09:13:10.000000000","message":"Done","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d8b7f344c1a30c8d46d54ef34ca442483d463c0f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"### --start_docs"},{"line_number":6,"context_line":"## Post overcloud deployment steps"},{"line_number":7,"context_line":"## \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1c80cfee_94e984df","line":4,"updated":"2020-12-03 07:19:34.000000000","message":"same for this too","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"### --start_docs"},{"line_number":6,"context_line":"## Post overcloud deployment steps"},{"line_number":7,"context_line":"## \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"5087a579_72dcd4aa","line":4,"in_reply_to":"1c80cfee_94e984df","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"}],"roles/overcloud-deploy/templates/overcloud-two-deploy.sh.j2":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"dd3ea73c9b9f8a854200dd0acee45c893d9a13f4","unresolved":true,"context_lines":[{"line_number":31,"context_line":"{% if baremetal_provision|bool %}"},{"line_number":32,"context_line":"## * Provision the baremetal nodes"},{"line_number":33,"context_line":"## ::"},{"line_number":34,"context_line":"openstack overcloud node provision --stack overcloud-two --output {{ working_dir }}/overcloud-two-baremetal-deployed.yaml {{ working_dir }}/overcloud-two_baremetal_deploy.yaml"},{"line_number":35,"context_line":"if [ $? -ne 0 ]; then"},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"93bb9ac2_7850fa07","line":34,"range":{"start_line":34,"start_character":43,"end_line":34,"end_character":57},"updated":"2020-12-02 06:07:22.000000000","message":"{{ stack_name }} Can we do the same all places where overcloud-two is used?","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7db4a2c7626a3c102cdcd48ff30b503190d6d7f3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{% if baremetal_provision|bool %}"},{"line_number":32,"context_line":"## * Provision the baremetal nodes"},{"line_number":33,"context_line":"## ::"},{"line_number":34,"context_line":"openstack overcloud node provision --stack overcloud-two --output {{ working_dir }}/overcloud-two-baremetal-deployed.yaml {{ working_dir }}/overcloud-two_baremetal_deploy.yaml"},{"line_number":35,"context_line":"if [ $? -ne 0 ]; then"},{"line_number":36,"context_line":"    exit 1"},{"line_number":37,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"cf55e096_0b08f8b8","line":34,"range":{"start_line":34,"start_character":43,"end_line":34,"end_character":57},"in_reply_to":"93bb9ac2_7850fa07","updated":"2020-12-02 09:13:10.000000000","message":"Done","commit_id":"341fb2da409c488e6bce66724d442792ce630192"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d8b7f344c1a30c8d46d54ef34ca442483d463c0f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -ux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"0f11906b_32c73a29","line":2,"updated":"2020-12-03 07:19:34.000000000","message":"let\u0027s modify existing template to make it generic for different overcloud instead of creating similar template.","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a309227143ad5d89becceda392598aedf0bea053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -ux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"b58cf57e_10d9346e","line":2,"in_reply_to":"0f11906b_32c73a29","updated":"2020-12-03 08:30:24.000000000","message":"Done","commit_id":"50d49762dbe5a6498ba2d25f792d8e108d726c0f"}]}