)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6c44433bb77bc6be48c6d76cad3514c52e5a0596","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable nested virt for standalone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For sc10 kvm jobs, we need to enable nested virt on the host."},{"line_number":10,"context_line":"It adds the execution point for the same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78d83052_d16bafa4","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":60},"updated":"2021-03-22 08:40:18.000000000","message":"is that a bug? is it a new job? was it previously working? etc 😊 please is there anything you can point to for the context here?","commit_id":"8bffb4dc159ef3da917dc3dca39a9fad31cf2323"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ec9e76078db272edb07ef5da5bbf4233dbd233a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable nested virt for standalone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For sc10 kvm jobs, we need to enable nested virt on the host."},{"line_number":10,"context_line":"It adds the execution point for the same."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8b7157_916ed8a7","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":60},"in_reply_to":"78d83052_d16bafa4","updated":"2021-03-22 10:48:16.000000000","message":"Done","commit_id":"8bffb4dc159ef3da917dc3dca39a9fad31cf2323"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ebdb5fdf972c3310d8873d320f17230ee884a4e6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-01 15:00:07 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable nested virt for standalone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For sc10 kvm jobs, we need to enable nested virt on the host."},{"line_number":10,"context_line":"It adds the execution point for the same."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0d51179a_cc2b4ca8","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":33},"updated":"2021-04-02 06:50:19.000000000","message":"\"... for standalone scenario10 Octavia jobs\"","commit_id":"d1926099cba31397de599bc543b2347770da36f3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0c898f11086b9f198d8fbfd1a1ca1e1e0368fc82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-01 15:00:07 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable nested virt for standalone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For sc10 kvm jobs, we need to enable nested virt on the host."},{"line_number":10,"context_line":"It adds the execution point for the same."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4363702b_603021de","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":33},"in_reply_to":"0d51179a_cc2b4ca8","updated":"2021-04-05 12:51:10.000000000","message":"Done","commit_id":"d1926099cba31397de599bc543b2347770da36f3"}],"playbooks/multinode-standalone.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5784b84c4e6113c4f50b280c92c4b37919d312d6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - tripleo-inventory"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Enable nested virtualization on the host"},{"line_number":13,"context_line":"  hosts: undercloud"},{"line_number":14,"context_line":"  gather_facts: true"},{"line_number":15,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"db9f4fc5_df254af2","line":12,"updated":"2021-03-23 16:29:23.000000000","message":"On upstream machines it\u0027s supported on specific clouds, so it may work or not to work, never know.\nOn vexx it should be enabled by default, probably better to include in image if it\u0027s not?","commit_id":"4c76a3329d622c062d13bf3f68901e240eb30cbc"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"4e7b8edb9a7cd754ead058ebe9b1383c15551a81","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  gather_facts: true"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Prepare the undercloud for installation"},{"line_number":21,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c2a53aaa_7a9ee924","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":17},"updated":"2021-03-22 12:16:04.000000000","message":"why is there a new tag here? this should just be a turned on/off w/ the established variables  When you update a tag you need to also update https://opendev.org/openstack/tripleo-quickstart/src/branch/master/quickstart.sh#L15-L16 btw","commit_id":"4c76a3329d622c062d13bf3f68901e240eb30cbc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8103f79a8c48b8974fc13db931fd418e5d42ac7d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  gather_facts: true"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Prepare the undercloud for installation"},{"line_number":21,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"99a219e4_6a2f666c","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"0fea9835_d40e8961","updated":"2021-04-01 09:35:37.000000000","message":"Added tq review here: https://review.opendev.org/c/openstack/tripleo-quickstart/+/784323","commit_id":"4c76a3329d622c062d13bf3f68901e240eb30cbc"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"28c23d7d240c4993acb4ada14d9ed5b3b54deeed","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  gather_facts: true"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Prepare the undercloud for installation"},{"line_number":21,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0fea9835_d40e8961","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"2997262d_7f45f557","updated":"2021-03-22 12:51:31.000000000","message":"I have added a separate tag here as we are going to use it for one job sc10 kvm only, so didnot added a conditional here","commit_id":"4c76a3329d622c062d13bf3f68901e240eb30cbc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f88ba639e8e92ec488b8d4b3e640342327af02a7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  gather_facts: true"},{"line_number":15,"context_line":"  roles:"},{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Prepare the undercloud for installation"},{"line_number":21,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2997262d_7f45f557","line":18,"range":{"start_line":17,"start_character":2,"end_line":18,"end_character":17},"in_reply_to":"c2a53aaa_7a9ee924","updated":"2021-03-22 12:24:46.000000000","message":"I\u0027s also vote for a when clause here","commit_id":"4c76a3329d622c062d13bf3f68901e240eb30cbc"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ebdb5fdf972c3310d8873d320f17230ee884a4e6","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - download_amphora is defined"},{"line_number":21,"context_line":"    - download_amphora|bool"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b5b23fc3_6afa3ddc","line":19,"updated":"2021-04-02 06:50:19.000000000","message":"This conditional has nothing about \u0027when kvm job\u0027 though ? Is it OK to enable this in the \u0027normal\u0027 scen10 jobs?","commit_id":"d1926099cba31397de599bc543b2347770da36f3"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"dbf93dd015f714896a86b7050dd22fb85266a562","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - download_amphora is defined"},{"line_number":21,"context_line":"    - download_amphora|bool"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fab58761_4c7c90f6","line":19,"in_reply_to":"28af7f82_62a7c57b","updated":"2021-04-06 06:48:29.000000000","message":"right but this is my point. i.e. this conditional means it will be enabled for all scen10 jobs not just \u0027the kvm ones\u0027 ?\n\nEDIT: ah... are you relying on \u0027tags\u0027 to make sure this is only executed for those \u0027kvm\u0027 cases ? \nEDIT2: yes there https://review.rdoproject.org/r/c/rdo-jobs/+/32631/1/zuul.d/standalone-jobs.yaml","commit_id":"d1926099cba31397de599bc543b2347770da36f3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0c898f11086b9f198d8fbfd1a1ca1e1e0368fc82","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    - parts/kvm"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - nested_virt"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - download_amphora is defined"},{"line_number":21,"context_line":"    - download_amphora|bool"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"28af7f82_62a7c57b","line":19,"in_reply_to":"b5b23fc3_6afa3ddc","updated":"2021-04-05 12:51:10.000000000","message":"We cannot enable it for all sc10 jobs as all upstream cloud does not support nested virt","commit_id":"d1926099cba31397de599bc543b2347770da36f3"}]}