)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"60ba2b3677d5dad52e3a004b0e4978229d47f3f5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"deps installation so that we can consume the changes in the deployment"},{"line_number":17,"context_line":"via updated rpm installed from gating repo."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In order to do that, it moves build-test-packages roles task after repo"},{"line_number":20,"context_line":"setup to install latest packages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d1393d7a_4eb48a93","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":65},"updated":"2021-07-08 07:21:05.000000000","message":"agree with Sagi comment if you have posted some testproject for this can you add it here for reviewers to check ?","commit_id":"7bd816e6e8ea7a8820370df615f3c355e449ebd7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2aceb091a82ce6930a00ebca1ad874d050e7e5fc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"deps installation so that we can consume the changes in the deployment"},{"line_number":17,"context_line":"via updated rpm installed from gating repo."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In order to do that, it moves build-test-packages roles task after repo"},{"line_number":20,"context_line":"setup to install latest packages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e65a766e_c5383975","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":65},"in_reply_to":"3ab55880_b7be4081","updated":"2021-07-27 09:00:34.000000000","message":"i don\u0027t see the test link in the latest commit message though","commit_id":"7bd816e6e8ea7a8820370df615f3c355e449ebd7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"20247eea76eaedffffd928566a6c6f47a1518b26","unresolved":true,"context_lines":[{"line_number":16,"context_line":"deps installation so that we can consume the changes in the deployment"},{"line_number":17,"context_line":"via updated rpm installed from gating repo."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In order to do that, it moves build-test-packages roles task after repo"},{"line_number":20,"context_line":"setup to install latest packages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3ab55880_b7be4081","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":65},"in_reply_to":"d1393d7a_4eb48a93","updated":"2021-07-26 10:22:48.000000000","message":"Sure will do that.","commit_id":"7bd816e6e8ea7a8820370df615f3c355e449ebd7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"60ba2b3677d5dad52e3a004b0e4978229d47f3f5","unresolved":true,"context_lines":[{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/790701"},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-operator-ansible/+/791118"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":28,"context_line":"Change-Id: I4f9f3f13346761d3dec35844234cb6ae03ad4107"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dafd353b_92ed961a","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":10},"updated":"2021-07-08 07:21:05.000000000","message":"this one has DNM will you update that or remove it here? just for testing?","commit_id":"7bd816e6e8ea7a8820370df615f3c355e449ebd7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"20247eea76eaedffffd928566a6c6f47a1518b26","unresolved":true,"context_lines":[{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/790701"},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-operator-ansible/+/791118"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":28,"context_line":"Change-Id: I4f9f3f13346761d3dec35844234cb6ae03ad4107"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7679c30c_1e366de3","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":10},"in_reply_to":"dafd353b_92ed961a","updated":"2021-07-26 10:22:48.000000000","message":"It was just for testing, May be I can add reverse it.","commit_id":"7bd816e6e8ea7a8820370df615f3c355e449ebd7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2aceb091a82ce6930a00ebca1ad874d050e7e5fc","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It also removes tripleo-operator-ansible from cloning on nodepool."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/790701"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":27,"context_line":"Change-Id: I4f9f3f13346761d3dec35844234cb6ae03ad4107"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c3d5c776_ebe892ae","line":24,"updated":"2021-07-27 09:00:34.000000000","message":"please also add something like \"tested in \u003ctestproject\u003e\" or whatever","commit_id":"f2f418a8fde0eeb483cd93d963a84409652832d7"}],"playbooks/ovb-setup.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e7ba966b5f663660496d8652cee0a2b493430ea5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# Small playbook with logic for when to build images or not."},{"line_number":44,"context_line":"# The logic there can be completely overridden by setting the"},{"line_number":45,"context_line":"# to_build variable."},{"line_number":46,"context_line":"- include: to-build-or-not-to-build.yml"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Run DLRN gate role and install repo"},{"line_number":49,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3ea3c2bf_e6a49740","side":"PARENT","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":39},"updated":"2021-07-28 14:07:18.000000000","message":"where did this go?","commit_id":"7e896d63ed7330ac19035414793a6777fe5180e3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a557af2c854f1fdd25e19102344de48e0ee5c89a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# Small playbook with logic for when to build images or not."},{"line_number":44,"context_line":"# The logic there can be completely overridden by setting the"},{"line_number":45,"context_line":"# to_build variable."},{"line_number":46,"context_line":"- include: to-build-or-not-to-build.yml"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Run DLRN gate role and install repo"},{"line_number":49,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d318ad59_810aecd7","side":"PARENT","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":39},"in_reply_to":"3ea3c2bf_e6a49740","updated":"2021-07-28 14:08:26.000000000","message":"https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/790926/13/playbooks/ovb-setup.yml#17","commit_id":"7e896d63ed7330ac19035414793a6777fe5180e3"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"1774cd67452df34d62b090569799cb5e5def3be3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# Small playbook with logic for when to build images or not."},{"line_number":15,"context_line":"# The logic there can be completely overridden by setting the"},{"line_number":16,"context_line":"# to_build variable."},{"line_number":17,"context_line":"- include: to-build-or-not-to-build.yml"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Setup the undercloud"},{"line_number":20,"context_line":"  hosts: undercloud"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"34c0e53d_ab7c0121","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":39},"updated":"2021-08-05 12:04:52.000000000","message":"AFAIK, that should not pass the linter due to use of discouraged import. Read notes from https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_module.html\n\nshould\n- have a \"name:\"\n- use \"import_playbook:\" module name","commit_id":"6beefc96384900154a4a49b966c5a8b9a92af1f9"}],"roles/undercloud-setup/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0018a08dcbabb21b0fa095d00eb2bead49bbc504","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  include_role:"},{"line_number":17,"context_line":"    name: repo-setup"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Run DLRN gate role"},{"line_number":20,"context_line":"  vars:"},{"line_number":21,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":22,"context_line":"  include_role:"},{"line_number":23,"context_line":"    name: build-test-packages"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Install gated repo"},{"line_number":26,"context_line":"  include_role:"},{"line_number":27,"context_line":"    name: install-built-repo"},{"line_number":28,"context_line":"  when: compressed_gating_repo is defined"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Including package_installs tasks"},{"line_number":31,"context_line":"  include: package_installs.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"246a1ea3_46432f3c","line":28,"range":{"start_line":19,"start_character":0,"end_line":28,"end_character":41},"updated":"2021-05-13 11:04:30.000000000","message":"need tags \"- build\"","commit_id":"bc48720583d61b01465350cd2f2db8b77a7bd874"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b0cc298f3f8ebe2841079c00dad9216633e7eae7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  include_role:"},{"line_number":17,"context_line":"    name: repo-setup"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Run DLRN gate role"},{"line_number":20,"context_line":"  vars:"},{"line_number":21,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":22,"context_line":"  include_role:"},{"line_number":23,"context_line":"    name: build-test-packages"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Install gated repo"},{"line_number":26,"context_line":"  include_role:"},{"line_number":27,"context_line":"    name: install-built-repo"},{"line_number":28,"context_line":"  when: compressed_gating_repo is defined"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Including package_installs tasks"},{"line_number":31,"context_line":"  include: package_installs.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5cc8b2ab_88c821a1","line":28,"range":{"start_line":19,"start_character":0,"end_line":28,"end_character":41},"in_reply_to":"246a1ea3_46432f3c","updated":"2021-05-13 12:24:40.000000000","message":"Done","commit_id":"bc48720583d61b01465350cd2f2db8b77a7bd874"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9ae5efd0fc0cc1c381f29acd9014b0b1df3ab2c2","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Run build-test-packages only when consumer job is not in play"},{"line_number":30,"context_line":"- name: Run DLRN gate role"},{"line_number":31,"context_line":"  when: job is defined and not job.consumer_job | default(false) | bool"},{"line_number":32,"context_line":"  vars:"},{"line_number":33,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":34,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5089a1db_319d8795","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":71},"updated":"2021-08-03 10:17:01.000000000","message":"let\u0027s avoid additional condition for consumer_job and fix it such that tags are considered, currently build tag is not passed in jobs but still build-test-packages is getting executed, so need to fix that itself.\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8eb/801296/2/check/tripleo-ci-centos-8-standalone/8eb1155/logs/quickstart_files/playbook_executions.log, with --tags standalone these tasks shouldn\u0027t have been executed, likely it\u0027s caused by include_role","commit_id":"742b1b13a83a4d1febf8a4301b8a88ed366109d8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c603d04efadac01960f34391c2d11ff3589e2e87","unresolved":true,"context_lines":[{"line_number":29,"context_line":"- name: Run DLRN gate role"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":32,"context_line":"  import_role:"},{"line_number":33,"context_line":"    name: build-test-packages"},{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - build"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fc45c7f4_f7b86f7a","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":13},"updated":"2021-08-04 07:16:08.000000000","message":"why do we prefer the import role what changed/happened","commit_id":"fc07f22d5d424032d028ae8914b5e75ceebd63a0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"1774cd67452df34d62b090569799cb5e5def3be3","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# to_build is enabled via featureset files or featureset overrides"},{"line_number":20,"context_line":"- name: Execute build test packages"},{"line_number":21,"context_line":"  tags: build"},{"line_number":22,"context_line":"  block:"},{"line_number":23,"context_line":"    - name: Set variables for gating repos for ovb jobs"},{"line_number":24,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"56b2b814_e506d792","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":13},"updated":"2021-08-05 12:04:52.000000000","message":"What is the purpose of a block without conditions?\n\nThat is the meaning of \"build\"? Using it at block level does not imply it would be inherited to all children? This means there is some duplication here. I would see either no block, or using tags only inside block and not on children.\n\nAm I wrong?","commit_id":"6beefc96384900154a4a49b966c5a8b9a92af1f9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"efd18ca520577adeb51c59a55b62776e3e6f5b9e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    - build"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Run DLRN gate role"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":32,"context_line":"  include_role:"},{"line_number":33,"context_line":"    name: build-test-packages"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"77eca93d_85a8f7a8","line":30,"updated":"2021-08-10 14:34:02.000000000","message":"missed when: build_test_packages|default(false)|bool","commit_id":"4c225d64654bffc057daf89edaecb866b8890d3b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"300b63ad6703133157e9183ba4f2fd9c71acc828","unresolved":true,"context_lines":[{"line_number":29,"context_line":"- name: Run DLRN gate role"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    artg_compressed_gating_repo: \"${HOME}/gating_repo.tar.gz\""},{"line_number":32,"context_line":"  include_role:"},{"line_number":33,"context_line":"    name: build-test-packages"},{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    - build"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"8e11f5f8_80197eb3","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":14},"updated":"2021-08-10 06:49:25.000000000","message":"back to include now it was import at some point","commit_id":"4c225d64654bffc057daf89edaecb866b8890d3b"}]}