)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eeb4848afbcc9a2672845c78b9e10b81e35f8a8b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Used by https://review.opendev.org/c/openstack/tripleo-quickstart/+/791486"},{"line_number":10,"context_line":"The intent is to use this for now and work towards getting into"},{"line_number":11,"context_line":"tripleo-repos rpm in the long run (and then removing this install)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib843f59f16ad30c07296a4328b3547396b94f71a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"cd7cc5a1_66b4f587","line":12,"updated":"2021-06-07 11:30:49.000000000","message":"needs depends-on @ tripleo-ci/+/791908 adding","commit_id":"852e39c24e0697616960eac60f4ce70e822279ad"}],"playbooks/multinode-standalone-ipa.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eeb4848afbcc9a2672845c78b9e10b81e35f8a8b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    - tripleo-inventory"},{"line_number":9,"context_line":"  tags:"},{"line_number":10,"context_line":"    - standalone"},{"line_number":11,"context_line":"  tasks:"},{"line_number":12,"context_line":"    - include_tasks: tasks/install-tripleo-get-hash.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install tripleo-get-hash on all nodes"},{"line_number":15,"context_line":"  hosts: all:!localhost:!127.0.0.2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c528c915_606d9152","line":12,"range":{"start_line":11,"start_character":1,"end_line":12,"end_character":6},"updated":"2021-06-07 11:30:49.000000000","message":"and that","commit_id":"852e39c24e0697616960eac60f4ce70e822279ad"}],"playbooks/multinode-standalone-repoclosure.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eeb4848afbcc9a2672845c78b9e10b81e35f8a8b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    inventory: multinode"},{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - tripleo-inventory"},{"line_number":11,"context_line":"  tasks:"},{"line_number":12,"context_line":"    - include_tasks: tasks/install-tripleo-get-hash.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install tripleo-get-hash on all nodes"},{"line_number":15,"context_line":"  hosts: all:!localhost:!127.0.0.2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"65c16e3d_4af53c16","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":15},"updated":"2021-06-07 11:30:49.000000000","message":"and that","commit_id":"852e39c24e0697616960eac60f4ce70e822279ad"}],"playbooks/multinode-standalone.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ec5010d802cb84226e2e6a6b265f9d9045e4b3ed","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    - include_tasks: tasks/install-tripleo-get-hash.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install tripleo-get-hash on all nodes"},{"line_number":15,"context_line":"  hosts: all"},{"line_number":16,"context_line":"  gather_facts: false"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - standalone"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4c096c8b_674bd938","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":12},"updated":"2021-06-03 11:40:13.000000000","message":"make it  all:!localhost:!127.0.0.2","commit_id":"96d376a00f10a47f71ab73a45200be8bbefb40c4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eeb4848afbcc9a2672845c78b9e10b81e35f8a8b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    inventory: multinode"},{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - tripleo-inventory"},{"line_number":11,"context_line":"  tasks:"},{"line_number":12,"context_line":"    - include_tasks: tasks/install-tripleo-get-hash.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Install tripleo-get-hash on all nodes"},{"line_number":15,"context_line":"  hosts: all:!localhost:!127.0.0.2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3d9988f2_d1971185","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":4},"updated":"2021-06-07 11:30:49.000000000","message":"remove that one","commit_id":"852e39c24e0697616960eac60f4ce70e822279ad"}],"playbooks/multinode-undercloud.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"84bbe52680a976b58fbf44daf01b7d1045fe90cf","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - tripleo-inventory"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Install tripleo-get-hash on all nodes"},{"line_number":13,"context_line":"  hosts: all:!localhost:!127.0.0.2"},{"line_number":14,"context_line":"  gather_facts: false"},{"line_number":15,"context_line":"  tags:"},{"line_number":16,"context_line":"    - undercloud-setup"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"76b41e2a_35d41aa0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":4},"updated":"2021-08-04 09:27:01.000000000","message":"now we are using an ansible galaxy build, we need to run this only on the ansible controller so undercloud","commit_id":"d8e4a66c71a1a9bee2c4ad23cf7edc16ce415fb1"}],"playbooks/tasks/install-tripleo-get-hash.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eeb4848afbcc9a2672845c78b9e10b81e35f8a8b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  when: zuul is defined"},{"line_number":13,"context_line":"  failed_when: false"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- debug:  # REMOVE ME BEFORE MERGE"},{"line_number":16,"context_line":"    var: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4b223983_d0ec4e12","line":16,"range":{"start_line":15,"start_character":2,"end_line":16,"end_character":27},"updated":"2021-06-07 11:30:49.000000000","message":"remove now","commit_id":"852e39c24e0697616960eac60f4ce70e822279ad"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e2d8672cf071ad9e736906c0e5e116b32c5a627c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"8ab44eaa_c556321f","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2021-07-13 12:33:27.000000000","message":"why do we use \"sudo\" instead of \"become: true\"? It\u0027s an anti-pattern in ansible","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89d188d73367dc3a5c166b77c03aa86c37d92ad0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d38f99e4_f48718b0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"8ab44eaa_c556321f","updated":"2021-07-13 12:47:53.000000000","message":"ok i can do that","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e221153fe33586675eb5e36f6f0b54fc639908f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"afc9d402_473ea579","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"d38f99e4_f48718b0","updated":"2021-07-15 11:46:31.000000000","message":"as commented there https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/793331/14#message-81b5251748548484c041a2705f9ce93ee11c710d i moved it back to sudo in the latest version after trying become.\n\nyou can see it executing on the content provider at https://review.opendev.org/c/openstack/tripleo-quickstart/+/791486\n\n        * https://9aca0d17822e3e334dca-b5c65296db2329c92cd45b6c6555ad39.ssl.cf1.rackcdn.com/791486/31/check/tripleo-ci-centos-8-content-provider/5055513/job-output.txt\n\n        * 2021-07-14 11:59:32.818371 | primary | TASK [install tripleo-get-hash from git checkout] ******************************\n2021-07-14 11:59:32.818381 | primary | Wednesday 14 July 2021  11:59:32 +0000 (0:00:00.054)       0:00:0s4.759 ********\n2021-07-14 11:59:35.777895 | primary | changed: [undercloud]\n\n        * 2021-07-14 11:59:42.176023 | primary | TASK [repo-setup : Get DLRN hash current-tripleo using tripleo_get_hash] *******\n2021-07-14 11:59:42.176035 | primary | Wednesday 14 July 2021  11:59:42 +0000 (0:00:00.094)       0:00:14.117 ********\n2021-07-14 11:59:43.150342 | primary | ok: [undercloud]","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f8b29d44176fa1cd49066ccfef4d3e891534cfe","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4102397b_f7016505","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":8},"updated":"2021-07-13 12:40:43.000000000","message":"lets remove that too","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e2d8672cf071ad9e736906c0e5e116b32c5a627c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"072639b3_64a72e35","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"updated":"2021-07-13 12:33:27.000000000","message":"nit: actually all these steps should be in \"setup.py install\", why do we do it manually here?","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89d188d73367dc3a5c166b77c03aa86c37d92ad0","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d15ba481_cbba3944","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"in_reply_to":"072639b3_64a72e35","updated":"2021-07-13 12:47:53.000000000","message":"the install python3-requests is needed for subnodes since they don\u0027t get the requirements we lay down for the primary node\n\nthe mkdir and moving the module to the right place is because otherwise the executor couldn\u0027t locate the module. I\u0027ve brought this to scrum a few times already - basically this will all go away we want to find some better way of installing this module - possibilities include having a dedicated role for installing it, to moving the plugin to be a lookup instead. \n\nthis review is so we can actually wire it up and start using it in our jobs, via the patch that depends-on this one there https://review.opendev.org/c/openstack/tripleo-quickstart/+/791486 \n\nI\u0027ll update and try the become instaed of sudo to tidy it up a bit at least","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b53142bbf84691da06b44786bfbfa8c5e668c1c5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"cb47f2e9_6ba6b6cc","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"in_reply_to":"40bdbf58_4c1443f3","updated":"2021-07-14 11:23:12.000000000","message":"yes and we have that already in https://opendev.org/openstack/tripleo-repos/src/branch/master/tripleo-get-hash/setup.cfg#L21-L34\nbut zuul cannot find the module when I just install it using the setup.cfg - I tried changing the module path there too https://review.opendev.org/c/openstack/tripleo-quickstart/+/791486/30/ansible.cfg but still didn\u0027t find it.\n\nThis was the only way I could get it to find and use the module. I don\u0027t like it either but it will allow us to start using the module (so we can see and fix any problems there) and finding a better way to install it is under discussion/consideration in the meantime.","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8e221153fe33586675eb5e36f6f0b54fc639908f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d2050dbb_0ddf09f6","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"in_reply_to":"6c2f5cae_41740962","updated":"2021-07-15 11:46:31.000000000","message":"s/zuul/ansible controller or user ... the thing that runs ansible. couldn\u0027t find the module.","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"48dc2bbebde4957a2ce7ffb5169d250b4adda8ca","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6c2f5cae_41740962","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"in_reply_to":"cb47f2e9_6ba6b6cc","updated":"2021-07-14 14:14:23.000000000","message":"I don\u0027t understand the answer. Why should zuul find something? It\u0027s running in nested ansible. I think there is a misunderstanding, maybe you install it as root but it doesn\u0027t find when running as user?","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f81de6fba80b0dac6ff0eb3fd5143580831c4125","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: install tripleo-get-hash from git checkout"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"40bdbf58_4c1443f3","line":8,"range":{"start_line":5,"start_character":3,"end_line":8,"end_character":50},"in_reply_to":"d15ba481_cbba3944","updated":"2021-07-13 14:37:45.000000000","message":"I mean all this should be part of setup.cfg file which we use here to install anyway.\nSee for example https://github.com/openstack/tripleo-operator-ansible/blob/master/setup.cfg#L23-L28\nI won\u0027t block on that, but seems for me more \"right\" way to install scripts. Maybe better to do it in followup.","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f8b29d44176fa1cd49066ccfef4d3e891534cfe","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    sudo ls -l /usr/share/ansible/plugins/modules/"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":11,"context_line":"  register: tgh_install_result"},{"line_number":12,"context_line":"  when: zuul is defined"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"d6b0b0da_07405206","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":30},"updated":"2021-07-13 12:40:43.000000000","message":"no longer used lets remove that one","commit_id":"66b9fd8cd86f2a3f028d4a47885b4f2cfa7f0658"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"81b5251748548484c041a2705f9ce93ee11c710d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"  args:"},{"line_number":9,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  when: zuul is defined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c72ae175_4f44685c","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":8},"updated":"2021-07-14 11:14:48.000000000","message":"going to move this back to using sudo\n\nIt can\u0027t find the module like this - see result at https://9ff2dfa6cdeb14d022ab-8a1c4cf257ef0eefc83c1c1874a2940a.ssl.cf2.rackcdn.com/791486/30/check/tripleo-ci-centos-8-content-provider/2830361/job-output.txt\n\n         * 2021-07-13 13:41:05.163701 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {\n2021-07-13 13:41:05.163785 | primary |     \"reason\": \"couldn\u0027t resolve module/action \u0027tripleo_get_hash\u0027. This often indicates a misspelling, missing collection, or incorrect module path.\\n\\nThe error appears to be in \u0027/home/zuul/src/opendev.org/openstack/tripleo-quickstart/roles/repo-setup/tasks/get-dlrn-hash.yml\u0027: line 28, column 7, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n    - name: \u0027Get DLRN hash {{ dlrn_hash_tag }} using tripleo_get_hash\u0027\\n      ^ here\\nWe could be wrong, but this one looks like it might be an issue with\\nmissing quotes. Always quote template expression brackets when they\\nstart a value. For instance:\\n\\n    with_items:\\n      - {{ foo }}\\n\\nShould be written as:\\n\\n    with_items:\\n      - \\\"{{ foo }}\\\"\\n\"\n\n\nI guess with \"sudo\" it is still executing as the zuul user, but with become: it uses root user so could be because of that.","commit_id":"7644749896301299f825d3e67d3be20a86631177"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"48dc2bbebde4957a2ce7ffb5169d250b4adda8ca","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"  args:"},{"line_number":9,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  when: zuul is defined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"00d110c0_549c5c91","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":8},"in_reply_to":"c72ae175_4f44685c","updated":"2021-07-14 14:14:23.000000000","message":"How is that related? I don\u0027t see this task executed at all in logs. Become runs with sudo.","commit_id":"7644749896301299f825d3e67d3be20a86631177"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ffd75705dab0a8d768c8014951138c601a656da1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"  args:"},{"line_number":9,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":10,"context_line":"  when: zuul is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5d9b2a93_72bbe2ec","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":127},"updated":"2021-07-15 14:06:56.000000000","message":"Once tripleo_repos is a collection we would only need to do:\n```\nansible-galaxy collection build .\nansible-galaxy collection install *.tar.gz\n```\n\nIn fact that could be a single line on Ansible 2.10+, but the two step example above works with 2.9+.","commit_id":"284b904ead21a8bcf2de1c55c13a1d4ed33f231b"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7a0154258358edfa1ef7219db33e1e865c1d342a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    sudo dnf install -y python3-requests"},{"line_number":5,"context_line":"    sudo python3 setup.py install"},{"line_number":6,"context_line":"    sudo mkdir -p /usr/share/ansible/plugins/modules/"},{"line_number":7,"context_line":"    sudo cp /usr/local/share/ansible/plugins/modules/tripleo_get_hash.py /usr/share/ansible/plugins/modules/tripleo_get_hash.py"},{"line_number":8,"context_line":"  args:"},{"line_number":9,"context_line":"    chdir: \"{{ zuul.projects[\u0027opendev.org/openstack/tripleo-repos\u0027].src_dir }}/tripleo-get-hash/\""},{"line_number":10,"context_line":"  when: zuul is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"503667f4_64444279","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":127},"in_reply_to":"5d9b2a93_72bbe2ec","updated":"2021-07-19 15:16:09.000000000","message":"Considering that merging https://review.opendev.org/c/openstack/tripleo-repos/+/801029 will break this task, I suggest postponing merging and wait for the module reorganisation to happen.","commit_id":"284b904ead21a8bcf2de1c55c13a1d4ed33f231b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"09ccddb218517ec18f713d6b6d40f76ff7316df3","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  shell: |"},{"line_number":5,"context_line":"    set -ex"},{"line_number":6,"context_line":"    dnf install -y python3-requests"},{"line_number":7,"context_line":"    # install triple_repos package (provides CLIs)"},{"line_number":8,"context_line":"    python3 setup.py install"},{"line_number":9,"context_line":"    ansible --version"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ec6ae63b_bcac4acf","line":6,"updated":"2021-08-04 09:24:55.000000000","message":"may also need to also add py-yaml here \n(sync call marios sorin)","commit_id":"d8e4a66c71a1a9bee2c4ad23cf7edc16ce415fb1"}]}