)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d709dabd17875b284252791c2c2d12d41b5a39e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"46b78028_d660498b","updated":"2021-10-18 08:55:29.000000000","message":"check experimental","commit_id":"481e47d86b4b19286276849596812a4b9a975160"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1b8854011c08f0c3208aa7ee87f6b52859e3516c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"39384dfc_e905db69","updated":"2021-10-18 08:55:20.000000000","message":"check rdo experimental","commit_id":"481e47d86b4b19286276849596812a4b9a975160"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"099db77caa226af234b2db15385be93cb8a7e6c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a836c6c7_c8c61489","updated":"2021-10-13 10:06:01.000000000","message":"check rdo experimental","commit_id":"481e47d86b4b19286276849596812a4b9a975160"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"baf1ba889308a5425b3d73fbdd5bfbcdabddd7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"74d88c98_072f5c4b","updated":"2021-10-13 10:05:45.000000000","message":"recheck","commit_id":"481e47d86b4b19286276849596812a4b9a975160"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"96437e25614d0f5edad844fd36092240e733dde6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"94093537_12c325ea","updated":"2021-10-18 08:55:05.000000000","message":"recheck","commit_id":"481e47d86b4b19286276849596812a4b9a975160"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7be5a6633751a51bc771923450d920d94e70fcef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2aa54c39_64c83f44","updated":"2021-10-26 08:10:49.000000000","message":"check rdo experimental","commit_id":"b9a191d3281ef661d836e18efc7803f6dd00ec80"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"675943a0b7ef5089b01aa021fd4e5eeabae6f3d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"57b8be7b_0d8055f1","updated":"2021-10-25 10:44:48.000000000","message":"check rdo experimental","commit_id":"b9a191d3281ef661d836e18efc7803f6dd00ec80"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8da18c63d185823859eae5a2c861d8a0e31f5837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"9f8a9bc5_248b5702","updated":"2021-11-03 11:00:57.000000000","message":"check rdo experimental","commit_id":"55f5e07a6ee67e6506b86347b81a36d44c1d7857"}],"roles/undercloud-setup/tasks/package_installs.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aa4bd23f20fb39c92a93352641722c32dd015dfc","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Install ansible-core 2.11 to override the default Ansible"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  when: release not in [\u0027queens\u0027, \u0027rocky\u0027, \u0027stein\u0027, \u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027]"},{"line_number":24,"context_line":"  block:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    - name: Remove existing RPM and PIP modules"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"041c69dc_4480c65b","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":49},"updated":"2021-09-06 07:44:02.000000000","message":"please remove these ones they no longer apply/exist","commit_id":"31cc1f2d2bff6564fa7bba1d37262e94863515a0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"978638c8f506b2d1c3ef728eee5958507b1102c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Install ansible-core 2.11 to override the default Ansible"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  when: release not in [\u0027queens\u0027, \u0027rocky\u0027, \u0027stein\u0027, \u0027train\u0027, \u0027ussuri\u0027, \u0027victoria\u0027]"},{"line_number":24,"context_line":"  block:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    - name: Remove existing RPM and PIP modules"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"62e3034d_9fcdb23c","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":49},"in_reply_to":"041c69dc_4480c65b","updated":"2021-10-04 14:36:55.000000000","message":"Done","commit_id":"31cc1f2d2bff6564fa7bba1d37262e94863515a0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aa4bd23f20fb39c92a93352641722c32dd015dfc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      shell: |"},{"line_number":28,"context_line":"        rpm -e ansible --nodeps"},{"line_number":29,"context_line":"        $(command -v pip3 || command -v pip) uninstall ansible"},{"line_number":30,"context_line":"      failed_when: false  # ignore when pip can\u0027t find"},{"line_number":31,"context_line":"      changed_when: true"},{"line_number":32,"context_line":"      tags:"},{"line_number":33,"context_line":"        - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ed672211_9d87c7d9","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":52},"updated":"2021-09-06 07:44:02.000000000","message":"cant we use || true in the bash instead of failed_when false?\n\n        $(command -v pip3 || command -v pip) uninstall ansible || true \n\ni think should work?\n\nunless we really don\u0027t care if we leave some of the old ansible around i.e. if there is a problem with the rpm -e ansible ? But I am guessing we want it clean for the 2.11 install so perhaps better to error if there is some problem removing?","commit_id":"31cc1f2d2bff6564fa7bba1d37262e94863515a0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"978638c8f506b2d1c3ef728eee5958507b1102c6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      shell: |"},{"line_number":28,"context_line":"        rpm -e ansible --nodeps"},{"line_number":29,"context_line":"        $(command -v pip3 || command -v pip) uninstall ansible"},{"line_number":30,"context_line":"      failed_when: false  # ignore when pip can\u0027t find"},{"line_number":31,"context_line":"      changed_when: true"},{"line_number":32,"context_line":"      tags:"},{"line_number":33,"context_line":"        - skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e77a1310_5adcca8a","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":52},"in_reply_to":"ed672211_9d87c7d9","updated":"2021-10-04 14:36:55.000000000","message":"I remove both PIP install and RPM so we don\u0027t have any leftovers from ansible. Sometimes it can be installed in both ways, so this task ensures it\u0027s not there anymore.\nIt\u0027s better to use \"failed_when\" then bash specifics. Also it doesn\u0027t consider this task as a failure in console if \"failed_when: false\"","commit_id":"31cc1f2d2bff6564fa7bba1d37262e94863515a0"}]}