)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"49e94902be7aa48e55fe4141c6b5fb6d8ddfa974","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add release_numbering \u0026 release_minor support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With this patch we are adding support for release_numbering"},{"line_number":10,"context_line":"\u0026 release_minor for downstream."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We will pass these parameters through downstream release config"},{"line_number":13,"context_line":"files, should be transparent for upstream."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"30dc9302_ee31dcae","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":31},"updated":"2021-07-06 11:16:38.000000000","message":"Tested in downstream testproject:-\n\nWithout this patch:-\nopenstack-tripleo-common-11.7.1-0.20210705163854.fe21645.el8.x86_64\n\nWith this patch:-\nopenstack-tripleo-common-11.7.1-2.20210706110732.fe21645.el8.x86_64\n\nNotice 11.7.1-0 vs 11.7.1-2","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e5f30e305a0e236bba30ca42086851a6cef3d25d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"With this patch we are adding support for release_numbering"},{"line_number":10,"context_line":"\u0026 release_minor for downstream."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We will pass these parameters through downstream release config"},{"line_number":13,"context_line":"files, should be transparent for upstream."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"• `release_numbering` defines the algorithm used by DLRN to assign"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7b9c1d_a25896af","line":12,"updated":"2021-07-06 14:08:55.000000000","message":"These seems to be useful doc in the commit message, Can we move these vars in roles/build-test-packages/defaults/main.yaml and move the code comments[Line no: 15 to 32] there so that people does not have to run git bisect to figure out what does these var means?","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"052df53f9b76905e3a632b57ce9852ed93999a21","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With this patch we are adding support for release_numbering"},{"line_number":10,"context_line":"\u0026 release_minor for downstream."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We will pass these parameters through downstream release config"},{"line_number":13,"context_line":"files, should be transparent for upstream."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"• `release_numbering` defines the algorithm used by DLRN to assign"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a232da76_1f4bdbfd","line":12,"in_reply_to":"df7b9c1d_a25896af","updated":"2021-07-07 05:41:12.000000000","message":"Hello Chandan,\n\nThank you for review.\n\nI have added comment abouts where we can details about these param in dlrn docs with url and provided some information about override for downstream case.","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"}],"roles/build-test-packages/templates/projects.ini.j2":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"ffd47b3e4a73bc652702f3f1438678f727f97e6d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"downstream_distgit_key\u003dosp-distgit"},{"line_number":34,"context_line":"use_upstream_spec\u003dtrue"},{"line_number":35,"context_line":"downstream_spec_replace_list\u003d^%global with_doc.+/%global with_doc 0,^%global rhosp.*/%global rhosp 1"},{"line_number":36,"context_line":"release_numbering\u003d{{ release_numbering | default(\u00270.date.hash\u0027) }}"},{"line_number":37,"context_line":"release_minor\u003d{{ release_minor | default(\u00270\u0027) }}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[gitrepo_driver]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7b71c89f_90e6e413","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":48},"updated":"2021-07-06 10:30:56.000000000","message":"Looks like i added these param under wrong section.\n\nThese param should go to [DEFAULT] section as per https://dlrn.readthedocs.io/_/downloads/en/latest/pdf/","commit_id":"f40814cb04e276bc0ca38acc0e876262c37059d8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2fa3e9d20623814aadfbf7947fc8bf5f7ae81e31","unresolved":true,"context_lines":[{"line_number":24,"context_line":"fallback_to_master\u003d1"},{"line_number":25,"context_line":"use_components\u003d{{ use_components }}"},{"line_number":26,"context_line":"{% if osp_release is defined %}"},{"line_number":27,"context_line":"release_numbering\u003d{{ release_numbering | default(\u00270.date.hash\u0027) }}"},{"line_number":28,"context_line":"release_minor\u003d{{ release_minor | default(\u00270\u0027) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[downstream_driver]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e0364a83_0c2f3232","line":27,"range":{"start_line":27,"start_character":50,"end_line":27,"end_character":51},"updated":"2021-07-06 14:07:58.000000000","message":"since release_minor is being set here and downstream builds rely on it, may be better to set default to minor.date.hash itself to avoid specifying these params for each release.\nand also release_minor to set to default based on osp_release var to avoid always specify for each release unless and until have some exception. also adding @jpena as he have more context on those params and downstream builds.","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"052df53f9b76905e3a632b57ce9852ed93999a21","unresolved":false,"context_lines":[{"line_number":24,"context_line":"fallback_to_master\u003d1"},{"line_number":25,"context_line":"use_components\u003d{{ use_components }}"},{"line_number":26,"context_line":"{% if osp_release is defined %}"},{"line_number":27,"context_line":"release_numbering\u003d{{ release_numbering | default(\u00270.date.hash\u0027) }}"},{"line_number":28,"context_line":"release_minor\u003d{{ release_minor | default(\u00270\u0027) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[downstream_driver]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8090b27d_12ea6549","line":27,"range":{"start_line":27,"start_character":50,"end_line":27,"end_character":51},"in_reply_to":"1d572ac3_2cf7d038","updated":"2021-07-07 05:41:12.000000000","message":"Thank you Yatin and Javier for suggestions.\n\nYour suggestions make absolute sense and with them we don\u0027t have to define these param in downstream release files.\n\nI have upload the patchset based on your suggestion. Please relook if this is okay.","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"ec7003961b9ec685f584e6d865ef3f5c2d7a39f9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"fallback_to_master\u003d1"},{"line_number":25,"context_line":"use_components\u003d{{ use_components }}"},{"line_number":26,"context_line":"{% if osp_release is defined %}"},{"line_number":27,"context_line":"release_numbering\u003d{{ release_numbering | default(\u00270.date.hash\u0027) }}"},{"line_number":28,"context_line":"release_minor\u003d{{ release_minor | default(\u00270\u0027) }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[downstream_driver]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1d572ac3_2cf7d038","line":27,"range":{"start_line":27,"start_character":50,"end_line":27,"end_character":51},"in_reply_to":"e0364a83_0c2f3232","updated":"2021-07-06 14:45:35.000000000","message":"The current default values match the DLRN projects.ini defaults.\n\nHowever, if we\u0027re only setting them when osp_release is defined, we could hardcode release_numbering\u003dminor.date.hash and then just set the release_minor value based on the OSP version (e.g. 0 for 16.0, 1 for 16.1, etc).","commit_id":"0e3cf2d69ddec659967bc2b06f67c5d16fe93ea1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2029413644b6f1272324050e936cde7bdc604516","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# and then just set the release_minor value based on the OSP version"},{"line_number":33,"context_line":"# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc)."},{"line_number":34,"context_line":"release_numbering\u003dminor.date.hash"},{"line_number":35,"context_line":"release_minor\u003d{{\u00270\u0027 if \u0027.\u0027 not in osp_release.split(\u0027-\u0027)[1] else osp_release.split(\u0027-\u0027)[1].split(\u0027.\u0027)[1] }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[downstream_driver]"},{"line_number":38,"context_line":"info_files\u003dosp.yml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"17198386_fc68e457","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":17},"updated":"2021-07-07 07:08:19.000000000","message":"was there no error on the missing space here?","commit_id":"b0ee2586da55567809ba2e479895a152e3a1ad6e"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"feecce00f618772dcd046033320c002bafbc8a7e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# and then just set the release_minor value based on the OSP version"},{"line_number":33,"context_line":"# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc)."},{"line_number":34,"context_line":"release_numbering\u003dminor.date.hash"},{"line_number":35,"context_line":"release_minor\u003d{{\u00270\u0027 if \u0027.\u0027 not in osp_release.split(\u0027-\u0027)[1] else osp_release.split(\u0027-\u0027)[1].split(\u0027.\u0027)[1] }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[downstream_driver]"},{"line_number":38,"context_line":"info_files\u003dosp.yml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e9b386db_9a61fd45","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":17},"in_reply_to":"17198386_fc68e457","updated":"2021-07-07 07:19:57.000000000","message":"Thank marios, I will add the extra space but there were no errors(tested in downstream):-\n\nDownstream patch id: 252664\n\ntripleo-ci-rhel-8-standalone-rhos-16.2/413443d/logs/delorean_logs/projects.ini\n~~~\n# Details about `release_numbering` and `release_minor` can be found at\n# at https://dlrn.readthedocs.io/en/latest/installation.html\n# There default values are `0.date.hash` and `0` respectively.\n# We are only setting these for downstream case when osp_release\n# is defined. For downstream case, we are hardcoding release_numbering\u003dminor.date.hash\n# and then just set the release_minor value based on the OSP version\n# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc).\nrelease_numbering\u003dminor.date.hash\nrelease_minor\u003d2\n~~~","commit_id":"b0ee2586da55567809ba2e479895a152e3a1ad6e"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"5e607a50c2368099eafec03c6f613a27d9f97c32","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# and then just set the release_minor value based on the OSP version"},{"line_number":33,"context_line":"# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc)."},{"line_number":34,"context_line":"release_numbering\u003dminor.date.hash"},{"line_number":35,"context_line":"release_minor\u003d{{\u00270\u0027 if \u0027.\u0027 not in osp_release.split(\u0027-\u0027)[1] else osp_release.split(\u0027-\u0027)[1].split(\u0027.\u0027)[1] }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[downstream_driver]"},{"line_number":38,"context_line":"info_files\u003dosp.yml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ae4a4f8_c78282c3","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":17},"in_reply_to":"e9b386db_9a61fd45","updated":"2021-07-07 07:20:28.000000000","message":"Thank you*","commit_id":"b0ee2586da55567809ba2e479895a152e3a1ad6e"},{"author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"change_message_id":"0bedf2ad3a84141d7a17b3ef80765db601bfbae2","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# and then just set the release_minor value based on the OSP version"},{"line_number":33,"context_line":"# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc)."},{"line_number":34,"context_line":"release_numbering\u003dminor.date.hash"},{"line_number":35,"context_line":"release_minor\u003d{{ \u00270\u0027 if \u0027.\u0027 not in osp_release.split(\u0027-\u0027)[1] else osp_release.split(\u0027-\u0027)[1].split(\u0027.\u0027)[1] }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[downstream_driver]"},{"line_number":38,"context_line":"info_files\u003dosp.yml"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"68103f51_06050df3","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":59},"updated":"2021-07-07 07:54:33.000000000","message":"Just to confirm, osp_release will have a \"osp-16.1\" format, right? If so, it\u0027s fine for me.","commit_id":"4907eec94012574e98d104a93ecf88550b41fb07"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c68bb865748f96c94d50e27912cb80f09e370987","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# and then just set the release_minor value based on the OSP version"},{"line_number":33,"context_line":"# (e.g. 0 for 16/16.0, 1 for 16.1, 2 for 16.2 etc)."},{"line_number":34,"context_line":"release_numbering\u003dminor.date.hash"},{"line_number":35,"context_line":"release_minor\u003d{{ \u00270\u0027 if \u0027.\u0027 not in osp_release.split(\u0027-\u0027)[1] else osp_release.split(\u0027-\u0027)[1].split(\u0027.\u0027)[1] }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[downstream_driver]"},{"line_number":38,"context_line":"info_files\u003dosp.yml"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ddc4661f_1d2a54a7","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":59},"in_reply_to":"68103f51_06050df3","updated":"2021-07-07 08:00:50.000000000","message":"yes it\u0027s similar like rhos-16.2, rhos-17 etc","commit_id":"4907eec94012574e98d104a93ecf88550b41fb07"}]}