)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a7b872164ef736a620f5cf6eb8665a1f2b17f680","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to build containers before undercloud-install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If build_container_images is true build containers"},{"line_number":10,"context_line":"and use these build containers instead of downloading"},{"line_number":11,"context_line":"containers and running container updates."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7c9af7b0_1bd67d2d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":50},"updated":"2021-10-25 05:35:37.000000000","message":"any more context on why/where the change is needed?\n\nAFAICS we are only setting this for the content provider [1] and a dedicated standalone-build job [2]\n\nwhere do we set this or need to set this for the undercloud? \n\n[1] https://opendev.org/openstack/tripleo-ci/src/commit/99470767acdef55ac237115c0556f847654b8f06/zuul.d/content-provider.yaml#L22 \n[2] https://opendev.org/openstack/tripleo-ci/src/commit/99470767acdef55ac237115c0556f847654b8f06/zuul.d/standalone-jobs.yaml#L60","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"09b990c18c2cd1ae1798583d0817669ff6015830","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to build containers before undercloud-install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If build_container_images is true build containers"},{"line_number":10,"context_line":"and use these build containers instead of downloading"},{"line_number":11,"context_line":"containers and running container updates."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"097f2ce1_712a8c69","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":50},"in_reply_to":"7c9af7b0_1bd67d2d","updated":"2021-10-25 05:40:28.000000000","message":"Needed for RDO jobs to build containers and deploy them https://review.rdoproject.org/r/c/rdoinfo/+/36340, https://review.rdoproject.org/r/c/rdo-jobs/+/36336/6/zuul.d/rdoinfo-jobs.yaml#335, In RDO we were already using build/deploy for standalone but this was missing in undercloud deploy jobs, so this patch adds that.\n\nThis should also enable quickstart based deploys when wanted to build/deploy containers instead of already promoted containers.","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7173a807b28c12fc109f813f4bb0a2a9403c5003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bbfac87f_05efd143","updated":"2021-10-25 05:27:32.000000000","message":"Looks good!\n\nhttps://logserver.rdoproject.org/40/36340/1/experimental/rdoinfo-tripleo-xena-release-centos-8-undercloud-containers/d679441/logs/undercloud/home/zuul/undercloud.conf.txt.gz\n~~~\ncontainer_insecure_registries \u003d 127.0.0.1:5001\n~~~\n\n\n\nhttps://logserver.rdoproject.org/40/36340/1/experimental/rdoinfo-tripleo-xena-release-centos-8-undercloud-containers/d679441/logs/undercloud/home/zuul/containers-prepare-parameter.yaml.txt.gz\n~~~\nparameter_defaults:\n  DockerInsecureRegistryAddress:\n  - 127.0.0.1:5001\n.\n.\n  ContainerImagePrepare:\n  - push_destination: false\n~~~\n\n\nhttps://logserver.rdoproject.org/40/36340/1/experimental/rdoinfo-tripleo-xena-release-centos-8-undercloud-containers/d679441/logs/undercloud/var/log/extra/podman/podman_allinfo.log.txt.gz\n~~~\n127.0.0.1:5001/tripleoxena/openstack-designate-backend-bind9     cloudsig-xena  d97a9c72d9df  14 minutes ago  893 MB\n~~~","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"45e4079dda26e634c896ea07d8868db1f029b7b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0d093f44_fd4e80ae","updated":"2021-10-21 14:06:29.000000000","message":"Tested with https://review.rdoproject.org/r/c/rdoinfo/+/36340 https://logserver.rdoproject.org/40/36340/1/experimental/rdoinfo-tripleo-xena-release-centos-8-undercloud-containers/d679441/logs/undercloud/home/zuul/containers-prepare-parameter.yaml.txt.gz","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"63b2b5ea68a96a300341b2a6c29d2a44f97ca740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0664e56_f79834ed","updated":"2021-10-26 06:31:31.000000000","message":"ok but inline sanity check please on the consumer job conditional","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e4d4bca8f3dccac440a9cfc0e9a7529a537bc9f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"517685a4_1e00f9de","updated":"2021-10-21 04:10:36.000000000","message":"recheck","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7f51b3dc24a81a522fcd5c6c1e76c01c40921d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f1eb8d2b_c96ad8e1","updated":"2021-10-21 09:08:29.000000000","message":"recheck","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"}],"roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"63b2b5ea68a96a300341b2a6c29d2a44f97ca740","unresolved":true,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if build_container_images|default(false)|bool or job.consumer_job|default(false)|bool %}"},{"line_number":5,"context_line":"  - {{ local_registry_ip }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% if job.consumer_job | default(false) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"874a5842_8407f4ae","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":68},"updated":"2021-10-26 06:31:31.000000000","message":"why that part ... if it is a consumer job it will use the registry from the content provider per the clause on the next line 7 below...","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2f7841f60548611b912cd2c91c7991eda174eddc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if build_container_images|default(false)|bool or job.consumer_job|default(false)|bool %}"},{"line_number":5,"context_line":"  - {{ local_registry_ip }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% if job.consumer_job | default(false) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"c88241db_c1d204c2","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":68},"in_reply_to":"2fcb98f3_9a800462","updated":"2021-10-26 08:40:30.000000000","message":"Thank you Marios \u0026 Yatin for looking into this, I think we can clean this up in a follow up patch.\nI went over blame but not able to find out how it got added:\nhttps://opendev.org/openstack/tripleo-quickstart-extras/commit/bbee06f544ae2cb7772dfeaaee200af46cbe6faa - standalone: add support to build containers before deployment\nand then\nhttps://opendev.org/openstack/tripleo-quickstart-extras/commit/c0278f637bab07dfa8ee931d74b1282d6e197089 - Add native variable to locally build containers","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f5614c957dcfa0dcae88b10c133bde631aa984ad","unresolved":true,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if build_container_images|default(false)|bool or job.consumer_job|default(false)|bool %}"},{"line_number":5,"context_line":"  - {{ local_registry_ip }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% if job.consumer_job | default(false) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"2fcb98f3_9a800462","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":68},"in_reply_to":"4ce73aed_e314245e","updated":"2021-10-26 07:08:26.000000000","message":"hmm ok thanks for checking\ni don\u0027t think we should need the local registry here in the case of the consumer job but I won\u0027t block.","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8f3eb7472a4b2567d560fecbbf7eb0574a64b09a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if build_container_images|default(false)|bool or job.consumer_job|default(false)|bool %}"},{"line_number":5,"context_line":"  - {{ local_registry_ip }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% if job.consumer_job | default(false) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"4ce73aed_e314245e","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":68},"in_reply_to":"874a5842_8407f4ae","updated":"2021-10-26 06:50:35.000000000","message":"I tried to be consistent with standalone deploys in this https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/standalone/templates/standalone_config.yaml.j2#L15-L20 , didn\u0027t digged why it\u0027s being like this in standalone but seeing code seems it\u0027s possible to both build containers and consume from registry in both CI and non CI cases.\n\nI think we can keep it consistent and if needed can cleanup both places as follow up, wdyt?","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d14e197946320cbf25b04e883168ef7dd6c5f11e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  DockerInsecureRegistryAddress:"},{"line_number":3,"context_line":"  - {{ local_docker_registry_host }}:8787"},{"line_number":4,"context_line":"{% if build_container_images|default(false)|bool or job.consumer_job|default(false)|bool %}"},{"line_number":5,"context_line":"  - {{ local_registry_ip }}:{{ local_registry_port }}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% if job.consumer_job | default(false) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"d8ebdf5c_200cc83b","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":68},"in_reply_to":"c88241db_c1d204c2","updated":"2021-11-01 13:24:23.000000000","message":"Pushed https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816123","commit_id":"68af35edf1c8885ebd9a0d836e61509276cad5ee"}]}