)]}' {"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4673c634e59e18a1a2c155178e24c9df0a68784f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77753d33_a047d752","updated":"2021-10-29 10:54:00.000000000","message":"https://e63daf97f32f2cebe260-b80014e5a7a6453c822c4dc8f22159da.ssl.cf1.rackcdn.com/815654/2/check/openstack-tox-linters/fb0d49e/job-output.txt\n```\nWARNING Listing 3 violation(s) that are fatal\n2021-10-28 12:37:20.797553 | ubuntu-focal | You can skip specific rules or tags by adding them to your configuration file:\n2021-10-28 12:37:20.797557 | ubuntu-focal |\n2021-10-28 12:37:20.797575 | ubuntu-focal | ┌──────────────────────────────────────────────────────────────────────────────┐\n2021-10-28 12:37:20.797585 | ubuntu-focal | │ # .ansible-lint │\n2021-10-28 12:37:20.797595 | ubuntu-focal | │ warn_list: # or \u0027skip_list\u0027 to silence them completely │\n2021-10-28 12:37:20.797600 | ubuntu-focal | │ - \u0027305\u0027 # Use shell only when shell functionality is required │\n2021-10-28 12:37:20.797603 | ubuntu-focal | │ - \u0027502\u0027 # All tasks should be named │\n2021-10-28 12:37:20.797608 | ubuntu-focal | └──────────────────────────────────────────────────────────────────────────────┘\n2021-10-28 12:37:20.797612 | ubuntu-focal | \u001b[0;34mplaybooks/tasks/tempest.yml\u001b[0m:\u001b[0;36m266\u001b[0m: [\u001b[1;31mE305\u001b[0m] \u001b[0;31mUse shell only when shell functionality is required\u001b[0m\n2021-10-28 12:37:20.797616 | ubuntu-focal | \u001b[0;34mplaybooks/tasks/tempest.yml\u001b[0m:\u001b[0;36m270\u001b[0m: [\u001b[1;31mE502\u001b[0m] \u001b[0;31mAll tasks should be named\u001b[0m\n2021-10-28 12:37:20.797621 | ubuntu-focal | \u001b[0;34mplaybooks/tasks/tempest.yml\u001b[0m:\u001b[0;36m277\u001b[0m: [\u001b[1;31mE305\u001b[0m] \u001b[0;31mUse shell only when shell functionality is required\u001b[\n\n```","commit_id":"1409b231a31e7bb686359f00633c47f0648700f1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3f608eaf2777df5c320d13eb95a3d434a6aa03b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2dbb1a18_d86c5106","updated":"2022-01-05 11:11:38.000000000","message":"Please have a look at comments!","commit_id":"7637e27e03fdfec3ae730c6c2ada6fceee87f7e7"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"19840fb1a65859fb91c9c008efa883ddb5bf2f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8657d896_059889ac","updated":"2022-01-10 12:36:12.000000000","message":"https://53801f6f9c8bf0e364b2-594e2b182145c9c989109e5862503d2d.ssl.cf2.rackcdn.com/815654/4/check/tripleo-ci-centos-8-containers-multinode/6054881/job-output.txt\n\n```\nTASK [Run overcloud_network_discovery role] ************************************\n2022-01-06 13:54:33.723513 | primary | Thursday 06 January 2022 13:54:33 +0000 (0:00:00.044) 0:56:28.737 ******\n2022-01-06 13:54:33.841464 | primary |\n2022-01-06 13:54:33.841537 | primary | TASK [overcloud-network-discovery : generate netstat script] *******************\n2022-01-06 13:54:33.841551 | primary | Thursday 06 January 2022 13:54:33 +0000 (0:00:00.118) 0:56:28.855 ******\n2022-01-06 13:54:36.530935 | primary | changed: [undercloud]\n2022-01-06 13:54:36.542504 | primary |\n2022-01-06 13:54:36.542562 | primary | TASK [overcloud-network-discovery : execute the netstat script] ****************\n2022-01-06 13:54:36.542574 | primary | Thursday 06 January 2022 13:54:36 +0000 (0:00:02.700) 0:56:31.556 ******\n2022-01-06 13:54:38.937203 | primary | changed: [undercloud]\n2022-01-06 13:54:38.949496 | primary |\n2022-01-06 13:54:38.949550 | primary | TASK [overcloud-network-discovery : kill netstat] ******************************\n2022-01-06 13:54:38.949562 | primary | Thursday 06 January 2022 13:54:38 +0000 (0:00:02.407) 0:56:33.963 ******\n2022-01-06 13:54:38.989592 | primary | skipping: [undercloud]\n2022-01-06 13:54:39.000921 | primary |\n2022-01-06 13:54:39.000971 | primary | TASK [overcloud-network-discovery : copy log file to /var/log/] ****************\n2022-01-06 13:54:39.000984 | primary | Thursday 06 January 2022 13:54:38 +0000 (0:00:00.049) 0:56:34.013 ******\n2022-01-06 13:54:39.032463 | primary | skipping: [undercloud]\n```\nLogs are not getting collected. Something is missing here.\nHint: https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-network-discovery/tasks/netstat.yml#L29","commit_id":"aba6d358e9e0c139bba0ba1a8c1d1903431d8f2a"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"cbd1c5566a97032db063a49f8fd10dea7983afd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2f9fed5e_aa91b654","updated":"2022-01-06 11:07:26.000000000","message":"recheck","commit_id":"aba6d358e9e0c139bba0ba1a8c1d1903431d8f2a"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e214d7da59426345bd42600b1f68bcc159716429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45d2c26b_70244a55","updated":"2022-01-11 10:45:50.000000000","message":"So, I thought this was supposed to run netstat while tempest is running, basically, it\u0027s running netstat, then kill it, collect the logs, and then execute tempest, is this the real intention? If so, I\u0027ll move my vote to +1","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"be02b776d8f0a12af95b9533a57640c0d47abd41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31403ae2_172cacb1","updated":"2022-01-11 12:09:51.000000000","message":"good point","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7e4b5ec7cda46745476bac9d2ebc986e7b780f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"95beaf61_c68c5c73","updated":"2022-01-11 07:25:37.000000000","message":"https://b74777c6605f5b952b4e-e8158ca75f6bfe1eab8b9d0a8cfa2de1.ssl.cf5.rackcdn.com/815654/5/check/tripleo-ci-centos-9-containers-multinode/ce4e066/logs/undercloud/var/log/netstat_audit.log\n","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"8b9f7fdc4d2f44e9ce3969d6332f6104819eeb8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3d585c04_a569746a","updated":"2022-01-11 05:09:18.000000000","message":"recheck","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"72db55ea95260f17c464632a818698c8635e0165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a42ad010_4e7a72c7","in_reply_to":"2891ff8d_baff9dd9","updated":"2022-01-12 14:46:44.000000000","message":"Yes, here the intention is to run netstat while tempest is running. I have updated the patchset accordingly.","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"34183c4b54e4acccabe1510367ba4dbbe6ffe72e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2891ff8d_baff9dd9","in_reply_to":"45d2c26b_70244a55","updated":"2022-01-12 11:28:30.000000000","message":"We should run netstat then run tempest and once tempest finishes, we can kill netstat.","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"3ff47ea522867333f440d16333adaeb5a2d05740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6750cc53_ef6b2293","in_reply_to":"95beaf61_c68c5c73","updated":"2022-01-11 10:34:26.000000000","message":"Finally, we can see netstat report :)","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f74441b198ae26ebd595348da71f89420879ee64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64920297_2ea0e9f6","updated":"2022-01-17 11:18:16.000000000","message":"https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_398/815654/6/check/tripleo-ci-centos-8-containers-multinode/398c5f0/job-output.txt\n```\n TASK [Run overcloud_network_discovery role to kill netstat service] ************\n2022-01-12 22:48:43.755774 | primary | Wednesday 12 January 2022 22:48:43 +0000 (0:00:00.081) 1:17:38.352 *****\n2022-01-12 22:48:44.241049 | primary |\n2022-01-12 22:48:44.241110 | primary | TASK [overcloud-network-discovery : generate netstat script] *******************\n2022-01-12 22:48:44.241266 | primary | Wednesday 12 January 2022 22:48:44 +0000 (0:00:00.485) 1:17:38.837 *****\n2022-01-12 22:48:44.284782 | primary | skipping: [undercloud]\n2022-01-12 22:48:44.304414 | primary |\n2022-01-12 22:48:44.304478 | primary | TASK [overcloud-network-discovery : execute the netstat script] ****************\n2022-01-12 22:48:44.304542 | primary | Wednesday 12 January 2022 22:48:44 +0000 (0:00:00.063) 1:17:38.901 *****\n2022-01-12 22:48:44.344462 | primary | skipping: [undercloud]\n2022-01-12 22:48:44.362430 | primary |\n2022-01-12 22:48:44.362489 | primary | TASK [overcloud-network-discovery : kill netstat] ******************************\n2022-01-12 22:48:44.362626 | primary | Wednesday 12 January 2022 22:48:44 +0000 (0:00:00.057) 1:17:38.959 *****\n2022-01-12 22:48:45.919036 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"killall\", \"-9\", \"netstat\"], \"delta\": \"0:00:00.026960\", \"end\": \"2022-01-12 22:48:45.684634\", \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2022-01-12 22:48:45.657674\", \"stderr\": \"netstat: no process found\", \"stderr_lines\": [\"netstat: no process found\"], \"stdout\": \"\", \"stdout_lines\": []}\n2022-01-12 22:48:45.919148 | primary | ...ignoring\n2022-01-12 22:48:45.936647 | primary |\n```\nIt got killed before tempest finishes i think.","commit_id":"87fa6bd5f6b05265d270054fbd4d4d0e02211d69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b1448f470d77adc1cb2cc7538da2087f3b6c0d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1b76290e_e379ba9b","updated":"2022-01-20 05:53:05.000000000","message":"2022-01-19 14:04:48.372488 | primary | TASK [os_tempest : Fail if tempest tests did not succeed] **********************\n2022-01-19 14:04:48.372524 | primary | Wednesday 19 January 2022 14:04:48 +0000 (0:00:00.087) 1:13:58.583 *****\n2022-01-19 14:04:48.471429 | primary | ok: [undercloud] \u003d\u003e {\n2022-01-19 14:04:48.471530 | primary | \"changed\": false,\n2022-01-19 14:04:48.471623 | primary | \"msg\": \"All assertions passed\"\n2022-01-19 14:04:48.471661 | primary | }\n2022-01-19 14:04:48.491807 | primary |\n2022-01-19 14:04:48.491883 | primary | TASK [os_tempest : Cleanup leftover resources] *********************************\n2022-01-19 14:04:48.491915 | primary | Wednesday 19 January 2022 14:04:48 +0000 (0:00:00.120) 1:13:58.703 *****\n2022-01-19 14:04:48.547909 | primary | skipping: [undercloud]\n2022-01-19 14:04:48.589911 | primary |\n2022-01-19 14:04:48.590025 | primary | TASK [Run overcloud_network_discovery role to kill netstat service] ************\n2022-01-19 14:04:48.590060 | primary | Wednesday 19 January 2022 14:04:48 +0000 (0:00:00.096) 1:13:58.800 *****\n2022-01-19 14:04:49.265746 | primary |\n2022-01-19 14:04:49.265853 | primary | TASK [overcloud-network-discovery : generate netstat script] *******************\n2022-01-19 14:04:49.265885 | primary | Wednesday 19 January 2022 14:04:49 +0000 (0:00:00.676) 1:13:59.477 *****\n2022-01-19 14:04:49.316781 | primary | skipping: [undercloud]\n2022-01-19 14:04:49.336714 | primary |\n2022-01-19 14:04:49.336793 | primary | TASK [overcloud-network-discovery : execute the netstat script] ****************\n2022-01-19 14:04:49.336831 | primary | Wednesday 19 January 2022 14:04:49 +0000 (0:00:00.071) 1:13:59.548 *****\n2022-01-19 14:04:49.403964 | primary | skipping: [undercloud]\n2022-01-19 14:04:49.546622 | primary |\n2022-01-19 14:04:49.546705 | primary | TASK [overcloud-network-discovery : kill netstat] ******************************\n2022-01-19 14:04:49.546747 | primary | Wednesday 19 January 2022 14:04:49 +0000 (0:00:00.209) 1:13:59.758 *****\n2022-01-19 14:04:51.845001 | primary | changed: [undercloud]\n2022-01-19 14:04:51.870762 | primary |\n2022-01-19 14:04:51.870850 | primary | TASK [overcloud-network-discovery : copy log file to /var/log/] ****************\n2022-01-19 14:04:51.870876 | primary | Wednesday 19 January 2022 14:04:51 +0000 (0:00:02.323) 1:14:02.082 *****\n2022-01-19 14:04:53.897187 | primary | changed: [undercloud]\n2022-01-19 14:04:53.952753 | primary |","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1286c7dfc24460008fd73a025c6481c4589dce7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6f0e877b_5e81bc40","updated":"2022-01-26 07:27:53.000000000","message":"not sure about the nohup otherwise looks OK ","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"646c0f6114a1a15097415f5af2b206e83fa7ec52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"430c287b_d126a2ca","updated":"2022-02-14 11:26:52.000000000","message":"After discussing with Marios, netstat is getting refreshed after 60 secs, net stat logs are there, We can find out later why netstat is getting killed after tempest run.\n\nMerging it.","commit_id":"ec65d258abbb9f7a8ad6141a36bccc40ac540695"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"03059a0a2f9f0154b564fe785f86832cdcb7802f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2c282684_5427feba","updated":"2022-02-14 07:58:31.000000000","message":"looks OK ? https://e56852c75e2c91dac38a-f8f2325f9cdf23e3484fa164239be565.ssl.cf2.rackcdn.com/815654/9/check/tripleo-ci-centos-8-containers-multinode/3e4b93c/logs/undercloud/var/log/netstat_audit.log","commit_id":"ec65d258abbb9f7a8ad6141a36bccc40ac540695"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4a3db08e853dfd5f1a71e564b69bc7d05260f0c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2684f072_17ea45f7","updated":"2022-02-14 08:02:28.000000000","message":"netstat is getting killed automatically I think","commit_id":"ec65d258abbb9f7a8ad6141a36bccc40ac540695"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"cca2692a5983cdbb8b4317ea7107f85f11ff722c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"609c3d39_d7ad7c28","updated":"2022-02-11 12:21:54.000000000","message":"recheck","commit_id":"ec65d258abbb9f7a8ad6141a36bccc40ac540695"}],"playbooks/tasks/tempest.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b340aa4a57b6edcdf88fe17aaa84ea0c76b40677","unresolved":true,"context_lines":[{"line_number":248,"context_line":" when:"},{"line_number":249,"context_line":" - ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":" - name: start netstat logging in the background"},{"line_number":252,"context_line":" shell: |"},{"line_number":253,"context_line":" set -e"},{"line_number":254,"context_line":" nohup /usr/bin/netstat -lnp -c 60 \u0026\u003e /var/log/netstat_audit.log \u0026"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a4bef483_dacf49ed","line":251,"updated":"2021-11-09 10:15:57.000000000","message":"I was going through https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/playbooks/baremetal-full-overcloud-validate.yml#L30 we already have code for running netstat We can reuse that https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-network-discovery no need to implement again.","commit_id":"1409b231a31e7bb686359f00633c47f0648700f1"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"12e0c22971ebc2bcad957396befb732142aa2d85","unresolved":false,"context_lines":[{"line_number":248,"context_line":" when:"},{"line_number":249,"context_line":" - ansible_distribution_major_version is version(\u00278\u0027, \u0027\u003c\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":" - name: start netstat logging in the background"},{"line_number":252,"context_line":" shell: |"},{"line_number":253,"context_line":" set -e"},{"line_number":254,"context_line":" nohup /usr/bin/netstat -lnp -c 60 \u0026\u003e /var/log/netstat_audit.log \u0026"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7b1f7e23_27c959ce","line":251,"in_reply_to":"a4bef483_dacf49ed","updated":"2022-02-10 11:49:38.000000000","message":"Ack","commit_id":"1409b231a31e7bb686359f00633c47f0648700f1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3f608eaf2777df5c320d13eb95a3d434a6aa03b6","unresolved":true,"context_lines":[{"line_number":251,"context_line":" - name: Run overcloud_network_discovery role"},{"line_number":252,"context_line":" vars:"},{"line_number":253,"context_line":" ansible_become: true"},{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" include_role:"},{"line_number":257,"context_line":" name: overcloud-network-discovery "},{"line_number":258,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e3212bf8_e9a113b8","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":26},"updated":"2022-01-05 11:11:38.000000000","message":"I am not sure these two vars are needed here. \n\nIn order to execute this role: we also need to add execute_netstat|bool https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-network-discovery/defaults/main.yml#L5","commit_id":"7637e27e03fdfec3ae730c6c2ada6fceee87f7e7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"12e0c22971ebc2bcad957396befb732142aa2d85","unresolved":false,"context_lines":[{"line_number":251,"context_line":" - name: Run overcloud_network_discovery role"},{"line_number":252,"context_line":" vars:"},{"line_number":253,"context_line":" ansible_become: true"},{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" include_role:"},{"line_number":257,"context_line":" name: overcloud-network-discovery "},{"line_number":258,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f2379264_0c0215eb","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":26},"in_reply_to":"e3212bf8_e9a113b8","updated":"2022-02-10 11:49:38.000000000","message":"Done","commit_id":"7637e27e03fdfec3ae730c6c2ada6fceee87f7e7"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"392e1e493bebc7ff48831a14fb44f2f79065ac11","unresolved":true,"context_lines":[{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" include_role:"},{"line_number":257,"context_line":" name: overcloud-network-discovery "},{"line_number":258,"context_line":""},{"line_number":259,"context_line":" - name: Run os_tempest role"},{"line_number":260,"context_line":" vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e2145b1d_b6b2837f","line":257,"range":{"start_line":257,"start_character":41,"end_line":257,"end_character":42},"updated":"2021-11-29 13:48:26.000000000","message":"nit","commit_id":"7637e27e03fdfec3ae730c6c2ada6fceee87f7e7"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"12e0c22971ebc2bcad957396befb732142aa2d85","unresolved":false,"context_lines":[{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" include_role:"},{"line_number":257,"context_line":" name: overcloud-network-discovery "},{"line_number":258,"context_line":""},{"line_number":259,"context_line":" - name: Run os_tempest role"},{"line_number":260,"context_line":" vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5133a30f_9e0c72e9","line":257,"range":{"start_line":257,"start_character":41,"end_line":257,"end_character":42},"in_reply_to":"e2145b1d_b6b2837f","updated":"2022-02-10 11:49:38.000000000","message":"Done","commit_id":"7637e27e03fdfec3ae730c6c2ada6fceee87f7e7"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"e214d7da59426345bd42600b1f68bcc159716429","unresolved":true,"context_lines":[{"line_number":252,"context_line":" vars:"},{"line_number":253,"context_line":" ansible_become: true"},{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" execute_netstat: true"},{"line_number":257,"context_line":" kill_netstat: true"},{"line_number":258,"context_line":" include_role:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"eb7676d4_25c83ee2","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"updated":"2022-01-11 10:45:50.000000000","message":"This is not required","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"72db55ea95260f17c464632a818698c8635e0165","unresolved":false,"context_lines":[{"line_number":252,"context_line":" vars:"},{"line_number":253,"context_line":" ansible_become: true"},{"line_number":254,"context_line":" debug: true"},{"line_number":255,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":256,"context_line":" execute_netstat: true"},{"line_number":257,"context_line":" kill_netstat: true"},{"line_number":258,"context_line":" include_role:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3c3bbb33_d15f1c16","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"in_reply_to":"eb7676d4_25c83ee2","updated":"2022-01-12 14:46:44.000000000","message":"Done","commit_id":"7b8acf0f8c61fc9e6d47846358e9dfacc7db4ac9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"23b47553f2bc166c2cd54c5f6d1bb1a1e8c53632","unresolved":true,"context_lines":[{"line_number":259,"context_line":" vars:"},{"line_number":260,"context_line":" ansible_become: true"},{"line_number":261,"context_line":" debug: true"},{"line_number":262,"context_line":" execute_netstat: true"},{"line_number":263,"context_line":" kill_netstat: false"},{"line_number":264,"context_line":" include_role:"},{"line_number":265,"context_line":" name: overcloud-network-discovery"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ef0661cb_b6c1c667","line":262,"updated":"2022-01-17 11:25:28.000000000","message":"Not sure https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-network-discovery/defaults/main.yml#L3 after 60 sec it gets ended here.","commit_id":"87fa6bd5f6b05265d270054fbd4d4d0e02211d69"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1286c7dfc24460008fd73a025c6481c4589dce7","unresolved":true,"context_lines":[{"line_number":259,"context_line":" vars:"},{"line_number":260,"context_line":" ansible_become: true"},{"line_number":261,"context_line":" debug: true"},{"line_number":262,"context_line":" execute_netstat: true"},{"line_number":263,"context_line":" kill_netstat: false"},{"line_number":264,"context_line":" include_role:"},{"line_number":265,"context_line":" name: overcloud-network-discovery"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d3d7c3cd_746b0ef7","line":262,"in_reply_to":"01188f19_0ae235ea","updated":"2022-01-26 07:27:53.000000000","message":"why do we need the nohup I don\u0027t follow.\n\nthe 60 seconds isn\u0027t a timeout it is the delay between printing the info again (we pass -c 60 by default). https://opendev.org/openstack/tripleo-quickstart-extras/src/commit/a9d386b70961d6cf5c5ddac8b14b90ac22ebafc3/roles/overcloud-network-discovery/templates/execute_netstat.sh.j2#L4\n\nif we want the info printed more often then we can lower it e.g. every 5 or 10 seconds... ?","commit_id":"87fa6bd5f6b05265d270054fbd4d4d0e02211d69"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"9d62bf276460f61ef56e4921434fbc90eaffd403","unresolved":false,"context_lines":[{"line_number":259,"context_line":" vars:"},{"line_number":260,"context_line":" ansible_become: true"},{"line_number":261,"context_line":" debug: true"},{"line_number":262,"context_line":" execute_netstat: true"},{"line_number":263,"context_line":" kill_netstat: false"},{"line_number":264,"context_line":" include_role:"},{"line_number":265,"context_line":" name: overcloud-network-discovery"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7e798b8a_bdc7bcff","line":262,"in_reply_to":"d3d7c3cd_746b0ef7","updated":"2022-02-10 11:44:17.000000000","message":"Ack","commit_id":"87fa6bd5f6b05265d270054fbd4d4d0e02211d69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"489a7251627c4b824e414dc3f2968e42bac18c36","unresolved":true,"context_lines":[{"line_number":259,"context_line":" vars:"},{"line_number":260,"context_line":" ansible_become: true"},{"line_number":261,"context_line":" debug: true"},{"line_number":262,"context_line":" execute_netstat: true"},{"line_number":263,"context_line":" kill_netstat: false"},{"line_number":264,"context_line":" include_role:"},{"line_number":265,"context_line":" name: overcloud-network-discovery"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"01188f19_0ae235ea","line":262,"in_reply_to":"ef0661cb_b6c1c667","updated":"2022-01-17 14:49:24.000000000","message":"May be we use nohup command and run this command in the background https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/overcloud-network-discovery/tasks/netstat.yml#L13\n\nlike:\n```\nnohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026 \n\n```","commit_id":"87fa6bd5f6b05265d270054fbd4d4d0e02211d69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4a3db08e853dfd5f1a71e564b69bc7d05260f0c0","unresolved":true,"context_lines":[{"line_number":273,"context_line":" tempest_run: \u0027yes\u0027"},{"line_number":274,"context_line":" include_role:"},{"line_number":275,"context_line":" name: os_tempest"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":" - name: Run overcloud_network_discovery role to kill netstat service"},{"line_number":278,"context_line":" vars:"},{"line_number":279,"context_line":" ansible_become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2e763a21_210d9ee9","line":276,"updated":"2022-02-14 08:02:28.000000000","message":"Somehow netstat is getting killed \nhttps://e56852c75e2c91dac38a-f8f2325f9cdf23e3484fa164239be565.ssl.cf2.rackcdn.com/815654/9/check/tripleo-ci-centos-8-containers-multinode/3e4b93c/job-output.txt\n```\nTASK [overcloud-network-discovery : kill netstat] ******************************\n2022-02-11 15:29:57.586145 | primary | Friday 11 February 2022 15:29:57 +0000 (0:00:00.059) 1:10:20.075 *******\n2022-02-11 15:29:59.182426 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"killall\", \"-9\", \"netstat\"], \"delta\": \"0:00:00.026536\", \"end\": \"2022-02-11 15:29:58.941773\", \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2022-02-11 15:29:58.915237\", \"stderr\": \"netstat: no process found\", \"stderr_lines\": [\"netstat: no process found\"], \"stdout\": \"\", \"stdout_lines\": []}\n2022-02-11 15:29:59.182927 | primary | ...ignoring\n```\nJust after the tempest finishes.\n\nThe ansible needs to kill the netstat process which is not happening.","commit_id":"ec65d258abbb9f7a8ad6141a36bccc40ac540695"}],"roles/overcloud-network-discovery/tasks/netstat.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9cfb009724a551141c6ac8616b16accd2412d877","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- name: execute the netstat script"},{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dcca0661_e596c2e2","line":13,"range":{"start_line":12,"start_character":1,"end_line":13,"end_character":59},"updated":"2022-02-08 09:55:58.000000000","message":"just for example how we run dstat: https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/validate-perf/tasks/main.yml","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1286c7dfc24460008fd73a025c6481c4589dce7","unresolved":true,"context_lines":[{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"69f680a0_b4afc770","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":9},"updated":"2022-01-26 07:27:53.000000000","message":"why do we want to do that","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3be9f44bb4b21fd1b0200ff18aa8bbd0f739dd26","unresolved":true,"context_lines":[{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6cd11a9f_c1a1914e","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":9},"in_reply_to":"69f680a0_b4afc770","updated":"2022-02-07 14:30:11.000000000","message":"No need to use nohup here.","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"778bd619efefebd3db0dcd4763d751ad23c77a24","unresolved":true,"context_lines":[{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"82c9ce13_1630a52e","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":9},"in_reply_to":"6cd11a9f_c1a1914e","updated":"2022-02-08 07:23:52.000000000","message":"yeah i think it was added as a misunderstanding - see my other comment there (and earlier comments by Chandan) https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/815654/6/playbooks/tasks/tempest.yml#262","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"9d62bf276460f61ef56e4921434fbc90eaffd403","unresolved":false,"context_lines":[{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d103ffde_b04c053e","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":9},"in_reply_to":"82c9ce13_1630a52e","updated":"2022-02-10 11:44:17.000000000","message":"Ack","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"12e0c22971ebc2bcad957396befb732142aa2d85","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: execute the netstat script"},{"line_number":10,"context_line":" become: true"},{"line_number":11,"context_line":" shell: \u003e"},{"line_number":12,"context_line":" set -o pipefail \u0026\u0026"},{"line_number":13,"context_line":" nohup {{ netstat_dest_directory }}/execute_netstat.sh \u0026"},{"line_number":14,"context_line":" changed_when: true"},{"line_number":15,"context_line":" async: 0"},{"line_number":16,"context_line":" poll: 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"905184fd_36a71589","line":13,"range":{"start_line":12,"start_character":1,"end_line":13,"end_character":59},"in_reply_to":"dcca0661_e596c2e2","updated":"2022-02-10 11:49:38.000000000","message":"Done","commit_id":"ad768538dbdc64d628dccc1da1012c14f0adc4c1"}]}