)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6571f37d117d6215a74cca63b373070127f05c4d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It adds the playbook to deploy single compute node"},{"line_number":10,"context_line":"using tripleo-ansible standalone playbooks on the host itself."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":13,"context_line":"Change-Id: I476c7299dec209c89db87e2182a35ec6a4924f92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bbb9356c_9542bebd","line":11,"updated":"2022-07-12 03:55:33.000000000","message":"logs and tp: https://review.opendev.org/c/openstack/tripleo-ci/+/849405/1#message-fb6cb733e1726a38f65c6d148bfd473db923b55c","commit_id":"769108176ef37cbe5cdaaf480f396da7ffe954d0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"399bb96c41f3631e0451e0f199d19dc399d9bda7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It adds the playbook to deploy single compute node"},{"line_number":10,"context_line":"using tripleo-ansible standalone playbooks on the host itself."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":13,"context_line":"Change-Id: I476c7299dec209c89db87e2182a35ec6a4924f92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bf97b00a_0ea9d20b","line":11,"in_reply_to":"bbb9356c_9542bebd","updated":"2022-10-18 04:31:47.000000000","message":"Done","commit_id":"769108176ef37cbe5cdaaf480f396da7ffe954d0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"82df8cbc0411d236d248b5cad1b9d1a7098ff1ba","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"It will be used in tripleo-external-compute-deployment-pipeline"},{"line_number":21,"context_line":"job template[1]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1]. https://review.opendev.org/c/openstack/tripleo-ci/+/843836"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":108,"id":"49a21b8a_29ac2336","line":22,"updated":"2022-10-18 11:35:23.000000000","message":"Below is the test results: https://review.rdoproject.org/r/c/testproject/+/45547/19#message-d5fc185833f7499e555b4c75cb99fa2a0d2e86fb\n\n```\ntripleo-ci-centos-9-standalone-external-compute-target-host1 https://review.rdoproject.org/zuul/build/913dc661b46046619e52694a03f12fec : SUCCESS in 1h 14m 33s\n```\nand\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/home/zuul/deploy_compute.sh.txt.gz\n\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/home/zuul/deploy_compute.log.txt.gz\n\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/var/log/containers/","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a5b944b841e260366535e6018623e90e5bc12110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"aeb472cb_8d44a8bd","updated":"2022-09-21 07:22:23.000000000","message":"first pass ","commit_id":"a3df9a8e5fbb268cce7ce125caef31c76cc4c45a"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"1b415f663faa05f3c2cc7828ba59b095c8440bcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"2b2d7dde_e6ac9d84","updated":"2022-10-11 07:11:41.000000000","message":"Took first pass,\n\nSome queries/comments inline:-","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b4a088bb33e5dd9dda32efa52661420d468f99d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":85,"id":"71931cd8_23ccbe66","updated":"2022-10-12 07:56:10.000000000","message":"setting -w till I clean up few stuff","commit_id":"c337c3971e417daa8556e6b18e9015de109e23e6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9ffb98c82904f69bbf1827ad7875afe7e688c93d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":88,"id":"8990530e_de2a5d55","updated":"2022-10-12 13:50:00.000000000","message":"so I believe before we can start merging this and deps, we need https://review.rdoproject.org/r/c/testproject/+/45547 passing, right?","commit_id":"bccf2ff7bc08412fa97108072f0dcea23002d65d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d12a7019a2a23ec16a1ee229200fe152ab3506a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":88,"id":"ab55df95_0ac4816b","in_reply_to":"8990530e_de2a5d55","updated":"2022-10-17 11:26:50.000000000","message":"Yes correct and the jobs are passing now on testproject https://review.rdoproject.org/r/c/testproject/+/45547/17#message-002743e1e58a754ba921cb63c77ba8cb6528d342\n```\ntripleo-ci-centos-9-standalone-external-compute-target-host1 https://review.rdoproject.org/zuul/build/d7ba5dbb79ab4a2f960951b824b30f55 : SUCCESS in 1h 29m 51s\ntripleo-ci-centos-9-standalone-external-compute-allinone1 https://review.rdoproject.org/zuul/build/33fd86f33b524ee991b51ea6ef8a1a05 : SUCCESS in 41m 52s\n```","commit_id":"bccf2ff7bc08412fa97108072f0dcea23002d65d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bcecc27fc4ff84b7a5e5544a4eb233f7ec59ebc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":103,"id":"15fef770_764a56f7","updated":"2022-10-17 07:02:41.000000000","message":"another pass :) ~1 month after my first\n\nsome inline comments for consideration","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f72497e0366c533f780214c0c17e80c8dac390b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":104,"id":"d3589212_91edc036","updated":"2022-10-18 04:34:43.000000000","message":"Thank you Marios and Bogdan for the review. I have renamed the role from standalone-roles to external-data-plane-management to avoid confusion between standalone role.","commit_id":"a06b614207960b667318539d49dbf91ce79d910e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f37aeff80b1a2122e646cbcfaea26d2ec374a0b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":106,"id":"c7625b93_48f73d1c","updated":"2022-10-18 06:22:25.000000000","message":"thanks for update \n\nlooks good but its a pretty big patch will need at least another pass and would be good to get some more reviews","commit_id":"bc76df661e87bf7f15c63744b03f017d14af6864"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8d4f60c516ca2dd6e1162b3b2a12f8d597189ad9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":108,"id":"c8565a30_c6e189d3","updated":"2022-10-18 12:33:34.000000000","message":"Thank you Mikolaj for the review. Updated it in new patchset. Will post the testproject results soon.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0c4ed5c6a67a3aafd5c97470e1504d2140de40d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":108,"id":"e9c1a851_7aee95dd","updated":"2022-10-18 11:45:12.000000000","message":"well done","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"67bf93de254b2f1e59c6d07d9e721ba0da90eb45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":108,"id":"0d8260fa_05bb140c","in_reply_to":"c8565a30_c6e189d3","updated":"2022-10-18 15:57:07.000000000","message":"I think I got the issue\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/93b3fab/logs/subnode-1/var/log/extra/network.txt.gz\n```\n4: br-ex: \u003cBROADCAST,MULTICAST,UP,LOWER_UP\u003e mtu 1350 qdisc noqueue state UNKNOWN group default qlen 1000\n    inet 172.16.1.3/24 scope global br-ex\n       valid_lft forever preferred_lft forever\n````\nBut in multinode job\nhttps://logserver.rdoproject.org/openstack-component-octavia/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-containers-multinode-octavia-master/257e61a/logs/subnode-1/var/log/extra/network.txt.gz\n\n```\n4: br-ex: \u003cBROADCAST,MULTICAST,UP,LOWER_UP\u003e mtu 1350 qdisc noqueue state UNKNOWN group default qlen 1000\n    inet 192.168.24.3/24 scope global br-ex\n       valid_lft forever preferred_lft forever\n    inet 192.168.24.11/32 scope global br-ex\n       valid_lft forever preferred_lft forever\n```\nNeed to change the job parenting to fix the issue.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54b63f1925f3928bf8e404ba330fd0b5d8354e73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":111,"id":"9b27986b_ccfa384d","updated":"2022-10-19 07:45:47.000000000","message":"lgtm cant spot any more nits","commit_id":"8dd8fd018974554be1eccec57acd3fb205374afb"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"659090344a20719bd6fa2b1b9240c20ebfaf2907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":116,"id":"b0082571_e9193d4c","updated":"2022-10-20 11:15:52.000000000","message":"Looks good to me.\n\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/var/log/containers/nova/nova-compute.log.txt.gz need change in ctlplane , from comments looks like it will be updated in follow ups.","commit_id":"ccaabd8c1ef36a09e1077c809480cd2f7508b03e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"61252ce4dbf8ae1840b3f0cb0b11928e0caf2616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":116,"id":"4e79cb8a_0f891d31","updated":"2022-10-20 08:26:28.000000000","message":"recheck","commit_id":"ccaabd8c1ef36a09e1077c809480cd2f7508b03e"}],"playbooks/deploy-standalone-compute.yml":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"252d1ddde0996410b90482384a7ae231ec8eb462","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  tasks:"},{"line_number":15,"context_line":"    - name: Run External Data Plane management role"},{"line_number":16,"context_line":"      include_role:"},{"line_number":17,"context_line":"        name: external-data-plane-management"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# On subnode-1"},{"line_number":20,"context_line":"# It bootstrap the node and install required packages"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"f4682b59_95f627b1","line":17,"updated":"2022-10-18 09:35:12.000000000","message":"Would it possible to import an existing multinode-standalone-pre.yaml playbook instead of rewriting more or less the same logic to role and including the role. The only difference is that  multine-standalone-pre imports content-provider-containers.yml as a last step.\nIs this additional import a reason why you decided not to import this playbook?","commit_id":"194a5c994828e7732582316559fe1774566fee4d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"2bade23249bf44da5077df886b5842b74fdb6753","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  tasks:"},{"line_number":15,"context_line":"    - name: Run External Data Plane management role"},{"line_number":16,"context_line":"      include_role:"},{"line_number":17,"context_line":"        name: external-data-plane-management"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# On subnode-1"},{"line_number":20,"context_line":"# It bootstrap the node and install required packages"}],"source_content_type":"text/x-yaml","patch_set":107,"id":"ac8f7b5f_069d6655","line":17,"in_reply_to":"f4682b59_95f627b1","updated":"2022-10-18 09:55:14.000000000","message":"Thank you Mikolaj for reviewing it.\nI did took a look at that playbook (It does more than that)\nhttps://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/playbooks/multinode-standalone-pre.yml - is specifically written for content provider job, \n- Where it first discovers the branch and sets the proper branch, then run tripleo-inventory, undercloud-setup.\n\nBut EDPM role needs to \ntripleo-inventory and undercloud-setup that\u0027s why I have not used.\n\nOne thing I can do in a separate review  is to move this undercloud-setup and tripleo-inventory piece in a separate playbook or re-use the task from edpm role.","commit_id":"194a5c994828e7732582316559fe1774566fee4d"}],"playbooks/external-compute-same-host.yml":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"1b415f663faa05f3c2cc7828ba59b095c8440bcb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Tasks to deploy external data plane deployment on same node"},{"line_number":3,"context_line":"# Required vars needed in Job varibale"},{"line_number":4,"context_line":"# While deploying compute services on single node"},{"line_number":5,"context_line":"# job.compute_on_same_host: false"},{"line_number":6,"context_line":"# While deploying compute services on deployed standalone"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"160639f6_ee68683e","line":3,"range":{"start_line":3,"start_character":30,"end_line":3,"end_character":38},"updated":"2022-10-11 07:11:41.000000000","message":"typo","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"1b415f663faa05f3c2cc7828ba59b095c8440bcb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# Required vars needed in Job varibale"},{"line_number":4,"context_line":"# While deploying compute services on single node"},{"line_number":5,"context_line":"# job.compute_on_same_host: false"},{"line_number":6,"context_line":"# While deploying compute services on deployed standalone"},{"line_number":7,"context_line":"# job.compute_on_same_host: true"},{"line_number":8,"context_line":"# job.standalone_as_compute_node: true"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"021cf847_d637bada","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":57},"updated":"2022-10-11 07:11:41.000000000","message":"Default standalone role already have compute services installed, Will you install the default standalone role or remove compute services from standalone role(and then deploy compute services on it via external compute deployment compute steps)?","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c89b9ad654d81e68f467e11227e9dda604ffb183","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# Required vars needed in Job varibale"},{"line_number":4,"context_line":"# While deploying compute services on single node"},{"line_number":5,"context_line":"# job.compute_on_same_host: false"},{"line_number":6,"context_line":"# While deploying compute services on deployed standalone"},{"line_number":7,"context_line":"# job.compute_on_same_host: true"},{"line_number":8,"context_line":"# job.standalone_as_compute_node: true"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"6453e41b_7bd84b4c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":57},"in_reply_to":"021cf847_d637bada","updated":"2022-10-11 15:20:25.000000000","message":"You mean it have compute services in tripleo heat templates? But that should be fine, as this CI is not using tht inputs","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"37cb270625f1f5def7e6359bd3e3e1c1cbb2b418","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Required vars needed in Job varibale"},{"line_number":4,"context_line":"# While deploying compute services on single node"},{"line_number":5,"context_line":"# job.compute_on_same_host: false"},{"line_number":6,"context_line":"# While deploying compute services on deployed standalone"},{"line_number":7,"context_line":"# job.compute_on_same_host: true"},{"line_number":8,"context_line":"# job.standalone_as_compute_node: true"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"73edcde9_cc9ae722","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":57},"in_reply_to":"18306528_25178e46","updated":"2022-10-12 13:42:45.000000000","message":"Done","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6044cb80dd259c7e27abfaef1274b4978a2b31cf","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# Required vars needed in Job varibale"},{"line_number":4,"context_line":"# While deploying compute services on single node"},{"line_number":5,"context_line":"# job.compute_on_same_host: false"},{"line_number":6,"context_line":"# While deploying compute services on deployed standalone"},{"line_number":7,"context_line":"# job.compute_on_same_host: true"},{"line_number":8,"context_line":"# job.standalone_as_compute_node: true"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"18306528_25178e46","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":57},"in_reply_to":"6453e41b_7bd84b4c","updated":"2022-10-12 06:35:36.000000000","message":"I am removing this scenario I will focus on one job which deploys standalone and deploy external compute on other host.","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"}],"playbooks/multinode-standalone-compute.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"abd0c5cb421af32fe214a87a6e037e4396bb6b69","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - standalone"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap Compute node"},{"line_number":13,"context_line":"  hosts: undercloud"},{"line_number":14,"context_line":"  tags:"},{"line_number":15,"context_line":"    - standalone"},{"line_number":16,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"706bc1d8_976453bd","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":19},"updated":"2022-07-13 07:18:18.000000000","message":"k i was confused by this but then i saw the name of this file.\n\nmy confusion was \u0027compute node\u0027 vs \u0027undercloud\u0027 but they are the same? right? \"standalone-compute node\" ?","commit_id":"769108176ef37cbe5cdaaf480f396da7ffe954d0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"feb197ac4228d48723a225cdac939a9136c1156f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - standalone"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Bootstrap Compute node"},{"line_number":13,"context_line":"  hosts: undercloud"},{"line_number":14,"context_line":"  tags:"},{"line_number":15,"context_line":"    - standalone"},{"line_number":16,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"64a4c42b_3ed5f29c","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":19},"in_reply_to":"706bc1d8_976453bd","updated":"2022-07-13 10:25:34.000000000","message":"yes they are the same. I have renamed the playbook to standalone-compute.yml playbook in new patchset. We are actually deploying the compute services on the localhost.","commit_id":"769108176ef37cbe5cdaaf480f396da7ffe954d0"}],"playbooks/standalone-compute.yml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"364c48b95cc715c5b82716919ed8dc494d123e03","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# It will create a pre-provisioned node with proper"},{"line_number":13,"context_line":"# packages and repos enabled."},{"line_number":14,"context_line":"- name: Create a Pre-povisioned node for compute deployment"},{"line_number":15,"context_line":"  hosts: undercloud"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    - standalone"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5f49846f_ac9d67f5","line":14,"updated":"2022-07-13 11:25:53.000000000","message":"pre-provisioned","commit_id":"9ad0d4a5d232eac1ab0e2ee02130e317047ff3e0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9e5790297793acb60b9f91b5381ec5e83575206f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# It will create a pre-provisioned node with proper"},{"line_number":13,"context_line":"# packages and repos enabled."},{"line_number":14,"context_line":"- name: Create a Pre-povisioned node for compute deployment"},{"line_number":15,"context_line":"  hosts: undercloud"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    - standalone"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9e2002e5_0ec785c7","line":14,"in_reply_to":"5f49846f_ac9d67f5","updated":"2022-08-30 12:51:31.000000000","message":"Done","commit_id":"9ad0d4a5d232eac1ab0e2ee02130e317047ff3e0"}],"roles/external-data-plane-management/README.md":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54b63f1925f3928bf8e404ba330fd0b5d8354e73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":111,"id":"e690a1bc_fedffa20","line":15,"updated":"2022-10-19 07:45:47.000000000","message":"would be good to document some of those vars (defaults/main) but it can also be in followup patches not a blocker","commit_id":"8dd8fd018974554be1eccec57acd3fb205374afb"}],"roles/external-data-plane-management/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f37aeff80b1a2122e646cbcfaea26d2ec374a0b8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""},{"line_number":5,"context_line":"tripleo_nova_compute_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-compute:{{ docker_image_tag }}\""},{"line_number":6,"context_line":"tripleo_nova_libvirt_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-libvirt:{{ docker_image_tag }}\""},{"line_number":7,"context_line":"tripleo_nova_libvirt_container_config_image: \"{{ tripleo_nova_libvirt_container_image }}\""},{"line_number":8,"context_line":"tripleo_ovn_controller_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-ovn-controller:{{ docker_image_tag }}\""},{"line_number":9,"context_line":"deploy_standalone: false"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":106,"id":"564f0e83_cd67940a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2022-10-18 06:22:25.000000000","message":"what is the point of this one? why not just use tripleo_nova_libvirt_container_image \n\ni.e. why do we need both tripleo_nova_libvirt_container_image and tripleo_nova_libvirt_container_config_image","commit_id":"bc76df661e87bf7f15c63744b03f017d14af6864"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54b63f1925f3928bf8e404ba330fd0b5d8354e73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""},{"line_number":5,"context_line":"tripleo_nova_compute_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-compute:{{ docker_image_tag }}\""},{"line_number":6,"context_line":"tripleo_nova_libvirt_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-libvirt:{{ docker_image_tag }}\""},{"line_number":7,"context_line":"tripleo_nova_libvirt_container_config_image: \"{{ tripleo_nova_libvirt_container_image }}\""},{"line_number":8,"context_line":"tripleo_ovn_controller_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-ovn-controller:{{ docker_image_tag }}\""},{"line_number":9,"context_line":"deploy_standalone: false"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":106,"id":"1a49e702_bd8ebd2f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"in_reply_to":"564f0e83_cd67940a","updated":"2022-10-19 07:45:47.000000000","message":"k looks like you removed this in the latest patch so marking resolved","commit_id":"bc76df661e87bf7f15c63744b03f017d14af6864"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"70a6ddc8983536767a7c2f3d86f10b92cba08fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Containers images used in deployment"},{"line_number":3,"context_line":"tripleo_iscsid_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-iscsid:{{ docker_image_tag }}\""},{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""},{"line_number":5,"context_line":"tripleo_nova_compute_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-compute:{{ docker_image_tag }}\""},{"line_number":6,"context_line":"tripleo_nova_libvirt_container_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-nova-libvirt:{{ docker_image_tag }}\""},{"line_number":7,"context_line":"tripleo_ovn_controller_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-ovn-controller:{{ docker_image_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":107,"id":"ff294662_6e7f5cee","line":4,"range":{"start_line":4,"start_character":101,"end_line":4,"end_character":106},"updated":"2022-10-18 09:46:04.000000000","message":"ah wrong image name, https://review.opendev.org/c/openstack/tripleo-ansible/+/841997/22/tripleo_ansible/roles/tripleo_logrotate_crond/defaults/main.yml#30\n```\ntripleo_logrotate_crond_image: \"quay.io/tripleomastercentos9/openstack-cron:current-tripleo\"\n```","commit_id":"194a5c994828e7732582316559fe1774566fee4d"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"79d4e1dcf84b99d05051a3e87a6c05dd270178fe","unresolved":true,"context_lines":[{"line_number":18,"context_line":"tripleo_network_config_template: templates/ci/multinode.j2"},{"line_number":19,"context_line":"neutron_public_interface_name: eth0"},{"line_number":20,"context_line":"ctlplane_dns_nameservers:"},{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"cde9685c_df63d768","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":16},"updated":"2022-10-18 12:04:16.000000000","message":"It seems this variable is not taken into account:\n```\n\u0027{ctlplane_dns_nameservers: [\u0027127.0.0.1\u0027, \u00271.1.1.1\u0027]}\u0027\n```\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/home/zuul/deploy_compute.sh.txt.gz\n\nAs a result nova_compute can\u0027t resolve address to connect  to standalone.ctlplane.localdomain\n\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/var/log/containers/nova/nova-compute.log.txt.gz","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"88f3c8d3a2f7d434a908b02589432e524e627671","unresolved":false,"context_lines":[{"line_number":18,"context_line":"tripleo_network_config_template: templates/ci/multinode.j2"},{"line_number":19,"context_line":"neutron_public_interface_name: eth0"},{"line_number":20,"context_line":"ctlplane_dns_nameservers:"},{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"b109b01c_f5109015","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":16},"in_reply_to":"775fa753_92621bd2","updated":"2022-10-20 08:03:56.000000000","message":"Ok, I\u0027m fine with that. Great job on creating this job.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"549966a078142c3f6ff67a7213132c71b5c34d03","unresolved":true,"context_lines":[{"line_number":18,"context_line":"tripleo_network_config_template: templates/ci/multinode.j2"},{"line_number":19,"context_line":"neutron_public_interface_name: eth0"},{"line_number":20,"context_line":"ctlplane_dns_nameservers:"},{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"775fa753_92621bd2","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":16},"in_reply_to":"a4b1ac8e_953760f9","updated":"2022-10-20 07:57:13.000000000","message":"So based on latest tp: https://review.rdoproject.org/r/c/testproject/+/45547\ntripleo-ci-centos-9-standalone-external-compute-target-host1\tSUCCESS 1h 30m 17s\n\nhttps://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/b4ae54c/logs/subnode-1/var/log/containers/nova/nova-compute.log.txt.gz\n\nabove issue is gone now.\n```\n2022-10-20 07:31:35.039 2 ERROR oslo.messaging._drivers.impl_rabbit [None req-8fb01299-eaa7-4eda-8910-efcba2067985 - - - - - -] Connection failed: [Errno 113] EHOSTUNREACH (retrying in 1.0 seconds): OSError: [Errno 113] EHOSTUNREACH\n```\n\nI think we can get this patch in and followup in  a new review.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e44fff2e8b804a72f544e3f4e9f9772758c1936c","unresolved":true,"context_lines":[{"line_number":18,"context_line":"tripleo_network_config_template: templates/ci/multinode.j2"},{"line_number":19,"context_line":"neutron_public_interface_name: eth0"},{"line_number":20,"context_line":"ctlplane_dns_nameservers:"},{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"a4b1ac8e_953760f9","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":16},"in_reply_to":"cde9685c_df63d768","updated":"2022-10-18 12:13:54.000000000","message":"Due to https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/general_config/featureset053.yml#L28, fs have higher precedence over role var, this value is not taken into account.\n\nMay be I can swap the default value.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"79d4e1dcf84b99d05051a3e87a6c05dd270178fe","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"},{"line_number":25,"context_line":"tripleo_selinux_mode: permissive"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"f4d9da32_6b894680","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"updated":"2022-10-18 12:04:16.000000000","message":"You don\u0027t need this override. Correct value is present in inventory: https://logserver.rdoproject.org/47/45547/19/check/tripleo-ci-centos-9-standalone-external-compute-target-host1/913dc66/logs/subnode-1/usr/share/ansible/tripleo-inventory/99-standalone-vars.gz","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"88f3c8d3a2f7d434a908b02589432e524e627671","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"},{"line_number":25,"context_line":"tripleo_selinux_mode: permissive"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"9e36a07f_9b845408","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"in_reply_to":"78e04a05_d0894094","updated":"2022-10-20 08:03:56.000000000","message":"Ack","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e44fff2e8b804a72f544e3f4e9f9772758c1936c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  - 192.168.24.1"},{"line_number":22,"context_line":"dns_search_domains: []"},{"line_number":23,"context_line":"tripleo_ovn_dbs:"},{"line_number":24,"context_line":"  - 192.168.24.1"},{"line_number":25,"context_line":"tripleo_selinux_mode: permissive"}],"source_content_type":"text/x-yaml","patch_set":108,"id":"78e04a05_d0894094","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":16},"in_reply_to":"f4d9da32_6b894680","updated":"2022-10-18 12:13:54.000000000","message":"This value is needed if we do allinone standalone compute deployment . I will make it conditional to set this value only when deploy_standalone is set to false.","commit_id":"686dc038612b6ed71b48ec88c97c3183bf421f69"}],"roles/external-data-plane-management/tasks/compute_services_on_target_host.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"54b63f1925f3928bf8e404ba330fd0b5d8354e73","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    src: deploy_compute.sh.j2"},{"line_number":54,"context_line":"    dest: \"{{ working_dir }}/deploy_compute.sh\""},{"line_number":55,"context_line":"    mode: 0755"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Run deploy_compute.sh script"},{"line_number":58,"context_line":"  shell: \u003e"},{"line_number":59,"context_line":"    set -o pipefail \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":111,"id":"0fa3f454_cf955e77","line":56,"updated":"2022-10-19 07:45:47.000000000","message":"thanks for update will be nicer to have the resolved vars in the deploy_compute.sh for debug","commit_id":"8dd8fd018974554be1eccec57acd3fb205374afb"}],"roles/standalone-roles/defaults/main.yml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b2727a893db1644b099af507f6094664d4f5e20e","unresolved":true,"context_lines":[{"line_number":8,"context_line":"tripleo_ovn_controller_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-ovn-controller:{{ docker_image_tag }}\""},{"line_number":9,"context_line":"deploy_standalone: true"},{"line_number":10,"context_line":"standalone_hostname: \"standalone.oooq\""},{"line_number":11,"context_line":"tripleo_ovn_dbs:"},{"line_number":12,"context_line":"  - 192.168.24.1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# tripleo-standalone-vars script related vars"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"b57e6485_2e035f5f","line":11,"updated":"2022-10-11 04:15:10.000000000","message":"+1 Yeah, this should work for the standalone CI use case. Let\u0027s see how it goes.","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8937540301b97b0863b5bfe67dad4af345993653","unresolved":false,"context_lines":[{"line_number":8,"context_line":"tripleo_ovn_controller_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-ovn-controller:{{ docker_image_tag }}\""},{"line_number":9,"context_line":"deploy_standalone: true"},{"line_number":10,"context_line":"standalone_hostname: \"standalone.oooq\""},{"line_number":11,"context_line":"tripleo_ovn_dbs:"},{"line_number":12,"context_line":"  - 192.168.24.1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# tripleo-standalone-vars script related vars"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"27fea1e2_6b7ec137","line":11,"in_reply_to":"b57e6485_2e035f5f","updated":"2022-10-12 13:47:08.000000000","message":"Done","commit_id":"7a57b06cf7607b99cc9520adbc7bb1fda0e11eb1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e0a8683963f7cb3506be292cb4a7e44611788f29","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Containers images used in deployment"},{"line_number":3,"context_line":"tripleo_iscsid_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-iscsid:{{ docker_image_tag }}\""},{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":79,"id":"bc48a008_7188e268","line":1,"updated":"2022-10-11 15:18:49.000000000","message":"so if it fails with ctlplane_dns_nameservers undefined [0], you could add some default for it here? Likely [\"192.168.24.1\"]\n\n[0] https://logserver.rdoproject.org/47/45547/7/check/tripleo-ci-centos-9-standalone-external-compute-target-host/8fa903d/logs/subnode-1/home/zuul/overcloud_compute.log.txt.gz\n\n \"AnsibleUndefinedVariable: \u0027ctlplane_dns_nameservers\u0027 is undefined\"","commit_id":"5bca5b1d0e04e548f3542a2d39d8bfce2edb5464"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b4a088bb33e5dd9dda32efa52661420d468f99d6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Containers images used in deployment"},{"line_number":3,"context_line":"tripleo_iscsid_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-iscsid:{{ docker_image_tag }}\""},{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":79,"id":"a0fedb7e_816752cb","line":1,"in_reply_to":"58c68973_56bed6a2","updated":"2022-10-12 07:56:10.000000000","message":"Moving it to Featureset files sounds good,","commit_id":"5bca5b1d0e04e548f3542a2d39d8bfce2edb5464"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3572fdfcc76dc53e069c391ba69c42e2617d459f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Containers images used in deployment"},{"line_number":3,"context_line":"tripleo_iscsid_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-iscsid:{{ docker_image_tag }}\""},{"line_number":4,"context_line":"tripleo_logrotate_crond_image: \"{{ docker_registry_host }}/{{ docker_registry_namespace }}/openstack-crond:{{ docker_image_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":79,"id":"58c68973_56bed6a2","line":1,"in_reply_to":"bc48a008_7188e268","updated":"2022-10-11 15:26:06.000000000","message":"or rather this https://review.opendev.org/c/openstack/tripleo-quickstart/+/854337/14/config/general_config/featureset053.yml#28 ?","commit_id":"5bca5b1d0e04e548f3542a2d39d8bfce2edb5464"}],"roles/standalone-roles/tasks/compute_services_on_target_host.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bcecc27fc4ff84b7a5e5544a4eb233f7ec59ebc1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  lineinfile:"},{"line_number":32,"context_line":"    path: \"/usr/share/ansible/tripleo-inventory/02-computes\""},{"line_number":33,"context_line":"    search_string: \u0027localhost:\u0027"},{"line_number":34,"context_line":"    # 4 spaces is added to place at proper hostname position"},{"line_number":35,"context_line":"    line: \"    {{ target_host }}:\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Rename the host_vars file to target host"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"d2481e31_c13aafd4","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":8},"updated":"2022-10-17 07:02:41.000000000","message":"seems a bit fragile\nI see you are trying to add into https://review.opendev.org/c/openstack/tripleo-ansible/+/840509/52/tripleo_ansible/inventory/02-computes#9  so 4 spaces should be at the same level as \u0027localhost\u0027 \n\nperhaps as a followup (add TODO(chkumar) if you agree) you can explore using something like inifile instead?","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f72497e0366c533f780214c0c17e80c8dac390b7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  lineinfile:"},{"line_number":32,"context_line":"    path: \"/usr/share/ansible/tripleo-inventory/02-computes\""},{"line_number":33,"context_line":"    search_string: \u0027localhost:\u0027"},{"line_number":34,"context_line":"    # 4 spaces is added to place at proper hostname position"},{"line_number":35,"context_line":"    line: \"    {{ target_host }}:\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Rename the host_vars file to target host"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"db2db90a_469d835f","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":8},"in_reply_to":"d2481e31_c13aafd4","updated":"2022-10-18 04:34:43.000000000","message":"Done","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bcecc27fc4ff84b7a5e5544a4eb233f7ec59ebc1","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    state: absent"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Deploy overcloud compute node"},{"line_number":50,"context_line":"  shell: \u003e"},{"line_number":51,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":52,"context_line":"    sudo ansible-playbook -i /usr/share/ansible/tripleo-inventory"},{"line_number":53,"context_line":"    -e tripleo_selinux_mode\u003d{{ tripleo_selinux_mode }}"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"4eddf158_6fd4109e","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":7},"updated":"2022-10-17 07:02:41.000000000","message":"again as followup - might be nice to capture these values for debug into a compute_deploy.sh?\n\ni.e. output this deploy command to a file and then execute that instead of running directly in the task","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d12a7019a2a23ec16a1ee229200fe152ab3506a1","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    state: absent"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Deploy overcloud compute node"},{"line_number":50,"context_line":"  shell: \u003e"},{"line_number":51,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":52,"context_line":"    sudo ansible-playbook -i /usr/share/ansible/tripleo-inventory"},{"line_number":53,"context_line":"    -e tripleo_selinux_mode\u003d{{ tripleo_selinux_mode }}"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"6c26b91e_0fb796f2","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":7},"in_reply_to":"4eddf158_6fd4109e","updated":"2022-10-17 11:26:50.000000000","message":"Thank you marios for the suggestion, I will update it in next patchset!","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"31796e86fcb418f8851b4a2541d7ed765f0a2bb9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    state: absent"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Deploy overcloud compute node"},{"line_number":50,"context_line":"  shell: \u003e"},{"line_number":51,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":52,"context_line":"    sudo ansible-playbook -i /usr/share/ansible/tripleo-inventory"},{"line_number":53,"context_line":"    -e tripleo_selinux_mode\u003d{{ tripleo_selinux_mode }}"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"83936d4c_21018814","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":7},"in_reply_to":"6c26b91e_0fb796f2","updated":"2022-10-18 04:30:29.000000000","message":"Done","commit_id":"9806cf83140fc82972fc8c114b0686b3f2bc2d9b"}],"roles/standalone-roles/tasks/main.yml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"aaf10b4584d03109c5edd322d7724cd733ad296a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name: \"{{ item }}\""},{"line_number":6,"context_line":"    state: present"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - ansible-collection-containers-podman"},{"line_number":9,"context_line":"    - python3-tenacity"},{"line_number":10,"context_line":"    - tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"e973b998_a2bbfa5c","line":7,"updated":"2022-10-04 07:13:22.000000000","message":"We should use loop instead of with_items. But doing it this way means that we invoked one instance of dnf install for each package. We would be better off passing this as a list in the name section, or defining this as a list variable so that we can install all of the packages at once.\n\nSee the note on this page for example:\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/dnf_module.html#notes","commit_id":"f2d30efd4453a061a3dcc1b1545de6d8d6e1c25c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c116771e87832be119ee5669f28d088dbd981ab3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name: \"{{ item }}\""},{"line_number":6,"context_line":"    state: present"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - ansible-collection-containers-podman"},{"line_number":9,"context_line":"    - python3-tenacity"},{"line_number":10,"context_line":"    - tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"92958cd2_100c88b5","line":7,"in_reply_to":"8f9808f2_e2c16270","updated":"2022-10-12 14:58:39.000000000","message":"Done","commit_id":"f2d30efd4453a061a3dcc1b1545de6d8d6e1c25c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4f29816ae886f997d70906d718494eadf649d76c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name: \"{{ item }}\""},{"line_number":6,"context_line":"    state: present"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - ansible-collection-containers-podman"},{"line_number":9,"context_line":"    - python3-tenacity"},{"line_number":10,"context_line":"    - tripleo-ansible"}],"source_content_type":"text/x-yaml","patch_set":54,"id":"8f9808f2_e2c16270","line":7,"in_reply_to":"e973b998_a2bbfa5c","updated":"2022-10-04 07:27:48.000000000","message":"Thanks Brendan, TIL :-)","commit_id":"f2d30efd4453a061a3dcc1b1545de6d8d6e1c25c"}],"roles/undercloud-setup/meta/main.yml":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"1b415f663faa05f3c2cc7828ba59b095c8440bcb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"},{"line_number":4,"context_line":"  - container-prep"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"cf7ccbe3_44976048","side":"PARENT","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":18},"updated":"2022-10-11 07:11:41.000000000","message":"Undercloud role doesn\u0027t need this as a dependency?\n\nIn commit msg: \n~~~\nNote: container-prep is dropped as a dependency from standalone roles. As it is not needed.\n~~~\n\nDo you mean to say \"container-prep is dropped as a dependency from undercloud* role?","commit_id":"7142f40c51122eb2dad09161c231a96cedff6542"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c116771e87832be119ee5669f28d088dbd981ab3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"},{"line_number":4,"context_line":"  - container-prep"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"4629c953_11ba0864","side":"PARENT","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":18},"in_reply_to":"80819e91_ee501022","updated":"2022-10-12 14:58:39.000000000","message":"Done","commit_id":"7142f40c51122eb2dad09161c231a96cedff6542"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1dfff8f72158330eb43a584447a3b73944fb6dce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"},{"line_number":4,"context_line":"  - container-prep"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"80819e91_ee501022","side":"PARENT","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":18},"in_reply_to":"cf7ccbe3_44976048","updated":"2022-10-12 07:58:02.000000000","message":"Yes correct container-prep is dropped as a dependency from undercloud. Will update in new series.","commit_id":"7142f40c51122eb2dad09161c231a96cedff6542"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f37aeff80b1a2122e646cbcfaea26d2ec374a0b8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"},{"line_number":4,"context_line":"  - container-prep"}],"source_content_type":"text/x-yaml","patch_set":106,"id":"4534d58b_fbec3242","side":"PARENT","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":18},"updated":"2022-10-18 06:22:25.000000000","message":"how is it related to this patch","commit_id":"7142f40c51122eb2dad09161c231a96cedff6542"}]}