)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"39fe340ab9b41a3b3bbec87739f9b7a4ed4ceec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d64e0a2e_b1c008b6","updated":"2022-06-17 12:15:43.000000000","message":"lgtm, just ","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b7b1c3cc0ecd8342e8e34ec5679bfb368f1d686a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc3c66fb_6a139d7b","updated":"2022-06-16 22:22:04.000000000","message":"periodic job tested by\n  https://review.rdoproject.org/r/c/testproject/+/36256","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f2400550d7f012ed3bb14a776ee3bf9c4aebf4af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad010090_548edb0f","updated":"2022-06-17 10:41:21.000000000","message":"recheck","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"7c03945153972eba98e58f168e998f9131d68b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"628b2866_b9fd37c0","updated":"2022-06-17 15:07:27.000000000","message":"From log [1] I see that container_namespace is not set and the override has no effect. I need to investigate further because from [1] I see:\n\n\n```\nTASK [tripleo.operator.tripleo_ceph_deploy : Show the openstack overcloud ceph deploy environment] ***\nFriday 17 June 2022  10:40:46 -0400 (0:00:00.042)       0:07:17.154 *********** \nok: [undercloud] \u003d\u003e {\n    \"_deploy_env\": {\n        \"CEPHADM_EXTRA_ARGS\": \"--log-to-file --skip-mon-network\",\n        \"CEPHADM_SSH_USER\": \"ceph-admin\",\n        \"CEPH_CRUSH_HIERARCHY\": null,\n        \"CEPH_MON_IP\": \"192.168.42.1\",\n        \"CEPH_OSD_SPEC\": null,\n        \"CEPH_SPEC\": \"/home/zuul/ceph_spec.yaml\",\n        \"CEPH_VIP\": null,\n        \"CLUSTER\": null,\n        \"CLUSTER_NETWORK_NAME\": \"storage\",\n        \"CONFIG\": \"/home/zuul/initial_ceph.conf\",\n        \"CONTAINER_IMAGE\": null,\n        \"CONTAINER_IMAGE_PREPARE\": \"/home/zuul/containers-prepare-parameters.yaml\",\n        \"CONTAINER_TAG\": null,\n        \"DAEMONS\": null,\n        \"DEPLOYED_CEPH\": \"/home/zuul/deployed_ceph.yaml\",\n        \"DEPLOY_ROLES_FILE\": null,\n        \"DEPLOY_STACK\": \"standalone\",\n        \"DEPLOY_WORKING_DIR\": null,\n        \"NETWORK_DATA\": \"/home/zuul/network_data.yaml\",\n        \"PUBLIC_NETWORK_NAME\": null,\n        \"REGISTRY_PASSWORD\": null,\n        \"REGISTRY_URL\": null,\n        \"REGISTRY_USERNAME\": null\n    }\n}\n```\n\nbut no CONTAINER_NAMESPACE is set.\n\n[1] https://logserver.rdoproject.org/56/36256/94/check/periodic-tripleo-ci-centos-9-scenario001-standalone-master/cd9fb13/logs/quickstart_install.log","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4d9181402646ec7b97a30ebd556b3237fefec5cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73ef4c4f_1b2f8e72","updated":"2022-06-17 15:09:30.000000000","message":"I suspect it fallbacks to \"omit\" here:\n\n```\ntripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit) }}\"\n```\n\nso I need to figure out in the first place whether \"standalone_container_ceph_updates\" is set and if it\u0027s true.","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"90e8ed31fb8a206523d8c8fa89d3fd9e8930ae9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a852074_75bb7886","updated":"2022-06-17 15:27:47.000000000","message":"Let\u0027s check the next iteration of https://review.rdoproject.org/r/c/testproject/+/36256","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0450d640717fc0a6e236a51e8406eea583062975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2bee8351_8c5ee94b","updated":"2022-06-17 16:37:58.000000000","message":"scenario001 failed but ... Ceph looks good [1] and:\n\n```\nTASK [tripleo.operator.tripleo_ceph_deploy : Show the openstack overcloud ceph deploy environment] ***\nFriday 17 June 2022  11:34:39 -0400 (0:00:00.053)       0:07:58.193 *********** \nok: [undercloud] \u003d\u003e {\n    \"_deploy_env\": {\n        \"CEPHADM_EXTRA_ARGS\": \"--log-to-file --skip-mon-network\",\n        \"CEPHADM_SSH_USER\": \"ceph-admin\",\n        \"CEPH_CRUSH_HIERARCHY\": null,\n        \"CEPH_MON_IP\": \"192.168.42.1\",\n        \"CEPH_OSD_SPEC\": null,\n        \"CEPH_SPEC\": \"/home/zuul/ceph_spec.yaml\",\n        \"CEPH_VIP\": null,\n        \"CLUSTER\": null,\n        \"CLUSTER_NETWORK_NAME\": \"storage\",\n        \"CONFIG\": \"/home/zuul/initial_ceph.conf\",\n        \"CONTAINER_IMAGE\": null,\n        \"CONTAINER_IMAGE_PREPARE\": \"/home/zuul/containers-prepare-parameters.yaml\",\n        \"CONTAINER_NAMESPACE\": \"quay.rdoproject.org/tripleomastercentos9\",\n        \"CONTAINER_TAG\": null,\n        \"DAEMONS\": null,\n        \"DEPLOYED_CEPH\": \"/home/zuul/deployed_ceph.yaml\",\n        \"DEPLOY_ROLES_FILE\": null,\n        \"DEPLOY_STACK\": \"standalone\",\n        \"DEPLOY_WORKING_DIR\": null,\n        \"NETWORK_DATA\": \"/home/zuul/network_data.yaml\",\n        \"PUBLIC_NETWORK_NAME\": null,\n        \"REGISTRY_PASSWORD\": null,\n        \"REGISTRY_URL\": null,\n        \"REGISTRY_USERNAME\": null\n    }\n}\n\nTASK [tripleo.operator.tripleo_ceph_deploy : Write reproducer script] **********\nFriday 17 June 2022  11:34:39 -0400 (0:00:00.053)       0:07:58.247 *********** \nchanged: [undercloud]\n\nTASK [tripleo.operator.tripleo_ceph_deploy : Run Ceph Deploy] ******************\nFriday 17 June 2022  11:34:40 -0400 (0:00:01.490)       0:07:59.738 *********** \nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nASYNC POLL on undercloud: jid\u003d483533043050.78508 started\u003d1 finished\u003d0\nok: [undercloud]\n```\n\n\n[1] https://logserver.rdoproject.org/56/36256/95/check/periodic-tripleo-ci-centos-9-scenario001-standalone-master/7e50184/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-a2ucdah0/cephadm/cephadm_command.log.txt.gz","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4c270677713e40896bd421ef97825e6b3d10ff78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"869d7a91_9dc7a343","in_reply_to":"73ef4c4f_1b2f8e72","updated":"2022-06-17 15:15:58.000000000","message":"I see two issues here:\n\n1. we can\u0027t pass the container_namespace parameter and \"omit\" the value, otherwise we see the last failure\n\n2. the variable [1] is false by default, and we need to set it explicitly to true in the job definition.","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1c0499e9baa130041e979e72bc3b9a532eca2e58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d185217_4b3db274","updated":"2022-06-17 21:02:01.000000000","message":"The fix for the periodic ceph jobs works but it breaks non-periodic ceph jobs 001/004/010 all failed with:\n\n  \"openstack overcloud ceph deploy: error: argument --container-namespace: expected one argument\"], \"stdout\": \"\", \"stdout_lines\": []}\n\nomit is not working as I had hoped because --container-namespace is still getting passed even when we don\u0027t want to pass it. ","commit_id":"9ca35c4fcbcd312c29965d21c1dee830b4c3aa7c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"48f11cb1ee9730f2046066a3ed8f16bcf8e50f39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d073b1d0_da42130e","in_reply_to":"3d185217_4b3db274","updated":"2022-06-17 21:52:24.000000000","message":"oh! I think I see what\u0027s going on there: the \"omit\" filter, in this case, is applied within the ternary operator, which means if \"tandalone_container_ceph_updates\" is false, the value is omitted (resulting in an empty string), but the variable is created in any case.\nLet me try an update, but feel free to revert the patch if we have a better idea!","commit_id":"9ca35c4fcbcd312c29965d21c1dee830b4c3aa7c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"db6ac3db3080da6e6eb352fc8259c6bc5f4cdca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0508521b_d8e10003","in_reply_to":"d073b1d0_da42130e","updated":"2022-06-18 07:01:17.000000000","message":"my theory was actually wrong, and even having the simple form \"variable | default(omit)\" doesn\u0027t work as expected (--container-namespace is still getting passed).\nI\u0027m going to restore the previous PS and try a different approach rather than omit.","commit_id":"9ca35c4fcbcd312c29965d21c1dee830b4c3aa7c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"30190e3f25abc86cbff278a1c9c941723b43c3b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a478b333_065c182b","updated":"2022-06-18 10:37:41.000000000","message":"Ok, time for some good news:\n\n\n1. scenario001 by zuul [1]: Looks good, ceph is deployed and  \n\n```\n\"CONTAINER_NAMESPACE\": \"23.253.108.6:5001/tripleomastercentos9\" \n```\n\nwhich means we rely on content provider.\n\n\n2. scenario001 by testproject [2][3]:\n\n```\n \"CONTAINER_NAMESPACE\": \"quay.rdoproject.org/tripleomastercentos9\"\n```\n\nNote that in the testproject we explicitly added: \"standalone_container_ceph_updates: true\" in the .zuul.yaml definition.\n\nAs per [3], HEALTH_OK during the overcloud deploy phase.\n\n\n3. scenario010 failing while ceph user is created: this is an intermittent issue tracked here: https://bugs.launchpad.net/tripleo/+bug/1979093 and should be investigated elsewhere.\n\n\nProgress here!! :D \n\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c0b/846231/7/check/tripleo-ci-centos-9-scenario001-standalone/c0bfe6b/logs/quickstart_install.log\n\n[2] https://logserver.rdoproject.org/56/36256/96/check/periodic-tripleo-ci-centos-9-scenario001-standalone-master/9374a98/logs/quickstart_install.log\n\n[3] https://logserver.rdoproject.org/56/36256/96/check/periodic-tripleo-ci-centos-9-scenario001-standalone-master/9374a98/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-l3bzfsf7/cephadm/cephadm_command.log.txt.gz","commit_id":"d66f2aa18c00fd9e6b73529e5b853503c127a74d"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"f4380da4c8701fcba44622cea2390962dbc5b502","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"59118c5f_5583da12","in_reply_to":"a478b333_065c182b","updated":"2022-06-18 10:38:28.000000000","message":"^^^^^^^ fultonj/rlandy FYI ^^^^^^","commit_id":"d66f2aa18c00fd9e6b73529e5b853503c127a74d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c4299134ccecf81f7a8a5fefddd2b283e9e95a53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bb5ff259_c4cfacdf","updated":"2022-06-22 19:55:55.000000000","message":"Intermittent failure of ceph-user creation (LP 1979093) should be addressed by:\n\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/846530\n\nwhich is tested by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/834354\n","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"7e77adf6e6a9d66412ae5ddfcc9a6cfe7cef2b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0c6ebaa5_c3cb931e","updated":"2022-06-23 12:55:57.000000000","message":"Removing +w as per further comments!","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd3288c12037d45c86cd26d7e515d77e99af557a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34c7dad4_5dde6c8d","updated":"2022-06-20 10:06:38.000000000","message":"expediting merge as this blocks promotions apparently (arxcruz|rover pinged me is why i am here right now ;))\n\n","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"36f0138ce0a7b1f33357748433c148779d2d3aa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e252fd38_ec0368be","updated":"2022-06-23 12:03:32.000000000","message":"hey John, sorry for taking so long to review this patch. Can you check if my understanding is correct? ","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"ce0dcf8bcc862c1e6409001327434fb7f1a091f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"18014847_39d229a8","updated":"2022-06-23 11:12:31.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"50f0818f379fc4c8f1dc12141570b0290e985895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"203ed597_ce26dbf3","updated":"2022-06-21 18:42:29.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c0e8d93782277329febb8d84db1be2d6d9204e68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a624c97_6fa8124c","updated":"2022-06-21 07:23:24.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"82d8ed873cc67183007d5636025d6587e48a324c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4c3d4d1f_f17f3a3d","updated":"2022-06-20 21:04:08.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":31075,"name":"Pooja Jadhav","email":"pojadhav@redhat.com","username":"pojadhav"},"change_message_id":"c2d58e78f9d7108cbb38c6779316369fa068bf13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c6e1b01_9772e146","updated":"2022-06-22 12:22:09.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e128fd4c137b97b1fb6c9e085144d295df040e40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ced9432f_f36f5785","updated":"2022-06-22 18:00:22.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f7754a927561937420f57022c614af35236726b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"de121675_382af2df","updated":"2022-06-20 14:12:40.000000000","message":"recheck","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b989ecddc63aea8f040805fcf1924948d9f9c5e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"aeafb1e7_bad73ec1","updated":"2022-06-20 14:12:28.000000000","message":"tripleo-ci-centos-9-scenario010-standalone failed on intermittent user creation bug which may be helped by https://review.opendev.org/c/openstack/tripleo-ansible/+/846530.\n","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"238302233f5c922abc46f89686a38ba126dd84f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"979ff3f5_852a154f","updated":"2022-06-21 15:35:08.000000000","message":"waiting for waiting for https://review.rdoproject.org/r/c/nfvinfo/+/43673","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7492e1681d93c981272660408ae07cf01eb3410f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bb8b6945_c3159b21","updated":"2022-06-23 18:41:41.000000000","message":"Still waiting for results of https://review.rdoproject.org/r/c/testproject/+/36256/102 but the code lgtm.","commit_id":"43a818138173195e00710bc48ba8d1fd1c7d34e8"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"586153a46ed80bb40957851b7185f59575f6f3e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b6bcf30b_5da8b2da","updated":"2022-06-23 20:48:33.000000000","message":"recheck","commit_id":"43a818138173195e00710bc48ba8d1fd1c7d34e8"}],"roles/standalone/tasks/ceph-install.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"79fd0eb4532e4e610ec6a8bddc1c3b6be19f4821","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5dd12c0a_6579b82b","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"updated":"2022-06-16 22:13:50.000000000","message":"I am assuming that standalone_container_ceph_updates is true for periodic jobs","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a451ca280fd2d76084758c29db00a5e44b35e8b3","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c237c8e_d7b8c263","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"5dd12c0a_6579b82b","updated":"2022-06-16 22:30:08.000000000","message":"(standalone_container_ceph_updates|default(false)|bool)\n\nMight want to switch it to ^","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3ca02286a12f6ec4a0fcfca5851d44daabac8819","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be94a180_0c533fd6","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"65cbfa79_ab0210f0","updated":"2022-06-17 12:43:11.000000000","message":"++ thanks John for clarifying it!","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fa8e8dc69b6e3338b2d6d3a4bf39dd44ee7d3517","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fbe77d31_8eb7b31e","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"6c237c8e_d7b8c263","updated":"2022-06-17 06:16:52.000000000","message":"I see, so if standalone_container_ceph_updates is true we update the ceph references for the ceph namespace like [1]\n\n[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/standalone/tasks/containers.yml#L128","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"39fe340ab9b41a3b3bbec87739f9b7a4ed4ceec9","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f58b1ada_0664896e","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"be66d6de_b4ca2cca","updated":"2022-06-17 12:15:43.000000000","message":"Thanks John, just wondering if [4] is then ignored as we\u0027re using the tripleo.operator here","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"582d50844e2225c0b294a63fb745da7e1aaca4e2","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"65cbfa79_ab0210f0","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"f58b1ada_0664896e","updated":"2022-06-17 12:25:27.000000000","message":"What this new line in TQE does results in the following happening in 4:\n\nif standalone_container_ceph_updates is true:\nextra_vars[\u0027tripleo_cephadm_container_ns\u0027] \u003d \u0027quay.rdoproject.org/tripleomastercentos9\u0027\n\nif standalone_container_ceph_updates is false:\nextra_vars[\u0027tripleo_cephadm_container_ns\u0027] \u003d container_dict[\u0027ceph_namespace\u0027]\n\nWhere container_dict represents what was in containers-prepare-parameters.yaml\n\nI wrote the above in pseudo code so I could share variables across projects to make the logic more clear.\n\n\n[4] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v2/overcloud_ceph.py#L564-L566","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"00aa16605149c93bcb136155033c3104e49e3e7f","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be66d6de_b4ca2cca","line":130,"range":{"start_line":130,"start_character":46,"end_line":130,"end_character":79},"in_reply_to":"fbe77d31_8eb7b31e","updated":"2022-06-17 12:07:29.000000000","message":"Yes. In more detail, the following happens in order:\n\nA. As per [1], containers-prepare-parameters.yaml has its ceph_namespace updated\nB. Then \u0027openstack overcloud ceph deploy\u0027 is called which triggers python-tripleoclient\nC. As per [2], python-tripleoclient will parse containers-image-prepare.\nD. As per [3], it will then substitute whatever container_namespace was set with push_destination (because containers-prepare-parameters.yaml has push_destination for periodic jobs)\nE. As per [4], it will then ignore that substitution and set namespace to parsed_args.container_namespace\nF. Then when Ansible is called to bootstrap ceph with extra_vars with the namespace\n\nWhen standalone_container_ceph_updates is false, --containers-name is not passed so the same thing as above happens but without E.\n\n[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/standalone/tasks/containers.yml#L128\n\n[2] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v2/overcloud_ceph.py#L558-L562\n\n[3] https://github.com/openstack/python-tripleoclient/blob/c5392335c163e6cfde576a0227b778073d7f3715/tripleoclient/utils.py#L3148-L3170\n\n[4] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v2/overcloud_ceph.py#L564-L566","commit_id":"cd80d72ac4a875ed3696e59e0a1b6573264c746c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4872e7833ecd8decfa90a11b18a237ec8d9ad4b4","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b036290c_9cc69fde","line":130,"range":{"start_line":130,"start_character":50,"end_line":130,"end_character":88},"updated":"2022-06-17 15:37:32.000000000","message":"omit is the right filter to make sure the parameter is not used when the boolean is false, however we should probably provide a default(false) before | ternary.","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"720dee4d512bf923f682dde8208be0afab672f8a","unresolved":true,"context_lines":[{"line_number":127,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":128,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":129,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":130,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1d239d66_4ef20ddd","line":130,"range":{"start_line":130,"start_character":50,"end_line":130,"end_character":88},"in_reply_to":"b036290c_9cc69fde","updated":"2022-06-17 17:07:32.000000000","message":"Agreed. Thanks, I was thinking something similar.","commit_id":"46ba5913371533fa1d2e22180d101e1e1e3d7fdd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd3288c12037d45c86cd26d7e515d77e99af557a","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    ssh_key: /home/zuul/.ssh/ceph-admin-id_rsa"},{"line_number":103,"context_line":"    ssh_opt: \"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- name: Deploy Ceph via tripleo-operator-ansible"},{"line_number":107,"context_line":"  collections:"},{"line_number":108,"context_line":"    - tripleo.operator"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c83759bd_8c161f0a","line":105,"updated":"2022-06-20 10:06:38.000000000","message":"unrelated/unnecessary line","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"36f0138ce0a7b1f33357748433c148779d2d3aa3","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"509f2465_212552d7","line":131,"range":{"start_line":131,"start_character":100,"end_line":131,"end_character":166},"updated":"2022-06-23 12:03:32.000000000","message":"IIUC, this should be \"ternary(\u0027docker_ceph_namespace\u0027, \u0027quay.rdoproject.org/tripleomastercentos9\u0027)\"\n\nwhich means that when \u0027standalone_container_ceph_updates\u0027 is false, you use quay as  namespace. \u0027standalone_container_ceph_updates\u0027 does not defaults to true on periodic, and looks like your testproject was green because you set in vars standalone_container_ceph_updates to true[1].\n\n[1] https://review.rdoproject.org/r/c/testproject/+/36256/100/.zuul.yaml#7","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"12dec5edcc05429cfade7d4ca8bff28511c077b3","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0180e836_c43c3ae5","line":131,"range":{"start_line":131,"start_character":144,"end_line":131,"end_character":165},"updated":"2022-06-18 19:23:00.000000000","message":"Thank you Francesco!","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cd3288c12037d45c86cd26d7e515d77e99af557a","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8cdbede7_d3ecec0e","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":83},"updated":"2022-06-20 10:06:38.000000000","message":"had to go looking for it but where do we set that?\n\nhttps://codesearch.opendev.org/?q\u003dstandalone_container_ceph_updates\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nlooks like nowhere?\n\n\n[EDIT]: well not upstream but we have in rdo and dstream\nhttps://codesearch.rdoproject.org/codesearch/?q\u003dstandalone_container_ceph_updates","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"72edc8210ae11ff4066ac030bd4967788eb99eed","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"eb0a8be8_cd0b0726","line":131,"range":{"start_line":131,"start_character":100,"end_line":131,"end_character":166},"in_reply_to":"3a3413d7_9dec48da","updated":"2022-06-23 13:50:04.000000000","message":"@Doug, so we need to swap quay/docker_ceph_namespace and remove \u0027standalone_container_ceph_updates\u0027 from [1] ?\n\n[1] https://review.rdoproject.org/r/c/testproject/+/36256/100/.zuul.yaml","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"631f00a48e69493596fa2a2ce09c4e58d4155dc8","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a3413d7_9dec48da","line":131,"range":{"start_line":131,"start_character":100,"end_line":131,"end_character":166},"in_reply_to":"509f2465_212552d7","updated":"2022-06-23 12:54:45.000000000","message":"ack agree, if you want quay to be default for the default case of standalone_container_ceph_updates false you should switch it","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8684b77f0247761ebfc09fb3f9dfbf0aaca33eaa","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(\u0027quay.rdoproject.org/tripleomastercentos9\u0027, docker_ceph_namespace) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e8f5c460_e456c7d5","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":83},"in_reply_to":"8cdbede7_d3ecec0e","updated":"2022-06-20 10:07:49.000000000","message":"Done","commit_id":"0e36183c7a91df51f262c3354a6d8121aa14a7c9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7492e1681d93c981272660408ae07cf01eb3410f","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    tripleo_ceph_deploy_generate_scripts: true"},{"line_number":129,"context_line":"    tripleo_ceph_deploy_network_data: \"{{ network_data }}\""},{"line_number":130,"context_line":"    tripleo_ceph_deploy_cluster_network_name: storage"},{"line_number":131,"context_line":"    tripleo_ceph_deploy_container_namespace: \"{{ (standalone_container_ceph_updates|bool) | ternary(docker_ceph_namespace, \u0027quay.rdoproject.org/tripleomastercentos9\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d2fdd936_4a149270","line":131,"range":{"start_line":131,"start_character":151,"end_line":131,"end_character":157},"updated":"2022-06-23 18:41:41.000000000","message":"As rlandy mentioned in #tripleo, this will need to be updated for {{release}}, once ceph-install patches merges into stable/wallaby. For now, both master and wallaby consume same ceph release, but we expect them to diverge in a near future.","commit_id":"43a818138173195e00710bc48ba8d1fd1c7d34e8"}]}