)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"09464f151c59245b282ed9dac4928528529626f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59200b48_2093743a","updated":"2022-06-30 11:09:27.000000000","message":"Hey Cedric,\n\nThis patch looks good to me, but just a note that in upstream we also have different standalone scenarios, We will need a separate patch to toggle firewall engine for standalone jobs.\n\nHolding my +2 here to confirm the plan to toggle for standalone scenarios?\n","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2d6937aa0036f2b08112ae8ccbc58a074ccded83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57d54c4b_5c7c594e","updated":"2022-06-22 06:30:28.000000000","message":"check-rdo","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2b91a942578d6745880c0c33122deb748e1b750b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0f9dc7f_31de08c9","in_reply_to":"59200b48_2093743a","updated":"2022-06-30 11:26:01.000000000","message":"so the goal here is to toggle a bunch of jobs to nftables, ensure things are stable with it; once we\u0027re good and all is green \"for some times\" (say a week?), we\u0027ll be able to set the actual default in t-h-t.\n\nThis means we probably(?) don\u0027t need to switch every single job manually to nftables, but a selected amount of them.\nSoo. Yeah. This one just offers the support in order to switch \"a certain amount of jobs\" - and we\u0027ll indeed need some more patches to switch the selected ones to nftables before the big leap.\n\nDoes it make sens? The goal here is to really move at a pace we can support in order to fix things that may break in an easy way, instead of blowing up the whole CI ;).","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"10e0884402f97c4db4d3559434171b3ba2a009c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21b3ff2f_de2a3b18","in_reply_to":"a0f9dc7f_31de08c9","updated":"2022-06-30 11:33:13.000000000","message":"Thanks for your answer Cedric.\n\nThis patch won\u0027t affect anything because undercloud_firewall_engine is not defined currently, We can do testing based on undercloud_firewall_engine var.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e70/847002/2/check/tripleo-ci-centos-9-undercloud-containers/e703e0e/logs/undercloud/home/zuul/undercloud-parameter-defaults.yaml","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"}],"roles/undercloud-deploy/templates/undercloud-parameter-defaults.yaml.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0a5fbc61b35fa63a19a05deab081b9a352f8ec8c","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027MasqueradeNetworks\u0027: masquerade_nets }) %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{# TODO(cjeanner) remove this block once nftables is default #}"},{"line_number":28,"context_line":"{% if undercloud_firewall_engine is defined %}"},{"line_number":29,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027FirewallEngine\u0027: undercloud_firewall_engine}) %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{{ undercloud_parameter_defaults | to_nice_json }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"b66c07d4_fbf2c3fd","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"updated":"2022-06-24 06:55:05.000000000","message":"are we planning to set this in one of the jobs? like in zuul job vars?\n\nalso do we need to guard against empty string (is defined and |length kind of thing)","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f66615a7ab484e3af8fd030706b1db758eb6b095","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027MasqueradeNetworks\u0027: masquerade_nets }) %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{# TODO(cjeanner) remove this block once nftables is default #}"},{"line_number":28,"context_line":"{% if undercloud_firewall_engine is defined %}"},{"line_number":29,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027FirewallEngine\u0027: undercloud_firewall_engine}) %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{{ undercloud_parameter_defaults | to_nice_json }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f7b7a32_2279e241","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"in_reply_to":"7443897c_2e8726fc","updated":"2022-06-27 14:57:49.000000000","message":"it\u0027s a one-direction, supporting both has little to no sense in the end, especially since iptables isn\u0027t \"iptables\", but a wrapper around \"nftables\" called \"iptables-nft\". There\u0027s still the iptables-legacy, but we don\u0027t install it anyway.\n\nBasically, we\u0027re removing a compatibility layer.","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b70937364b3a38242f08ea3bb526bc45aa5723a7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027MasqueradeNetworks\u0027: masquerade_nets }) %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{# TODO(cjeanner) remove this block once nftables is default #}"},{"line_number":28,"context_line":"{% if undercloud_firewall_engine is defined %}"},{"line_number":29,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027FirewallEngine\u0027: undercloud_firewall_engine}) %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{{ undercloud_parameter_defaults | to_nice_json }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"486fdb11_cb32ad03","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"in_reply_to":"9f7b7a32_2279e241","updated":"2022-06-27 14:59:01.000000000","message":"Ack","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"da09cbd72417563b0c858cf538602cf3a5a65dd3","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027MasqueradeNetworks\u0027: masquerade_nets }) %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{# TODO(cjeanner) remove this block once nftables is default #}"},{"line_number":28,"context_line":"{% if undercloud_firewall_engine is defined %}"},{"line_number":29,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027FirewallEngine\u0027: undercloud_firewall_engine}) %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{{ undercloud_parameter_defaults | to_nice_json }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d1be08bd_05259377","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"in_reply_to":"b66c07d4_fbf2c3fd","updated":"2022-06-27 13:42:37.000000000","message":"Goal is to move jobs to nftables - so yeah, we\u0027ll consume this one as we\u0027re moving a selected amount of jobs to this engine and \"sit for a while\". This can also be testprojects, but I\u0027d rather get actual jobs in order to ensure everything\u0027s working before the big jump.\n\nI can add the |length check as well, but iirc, empty string is undefined. Since it\u0027s a temporary thing, we MAY be safe as-is.","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"589cd54dcd36eae665c590f413574171322b9cf4","unresolved":true,"context_lines":[{"line_number":25,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027MasqueradeNetworks\u0027: masquerade_nets }) %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"{# TODO(cjeanner) remove this block once nftables is default #}"},{"line_number":28,"context_line":"{% if undercloud_firewall_engine is defined %}"},{"line_number":29,"context_line":"{% set _ \u003d undercloud_parameter_defaults[\u0027parameter_defaults\u0027].update({\u0027FirewallEngine\u0027: undercloud_firewall_engine}) %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{{ undercloud_parameter_defaults | to_nice_json }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7443897c_2e8726fc","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"in_reply_to":"d1be08bd_05259377","updated":"2022-06-27 14:55:47.000000000","message":"Is move to nftables one-direction? Are we gonna need to support nftables and iptables?","commit_id":"bd772df0ebd836bb5125cc61f513d1f0eb07f9a6"}]}