)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ff40b284b2fde216208b66a05e561650db8b29f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"54ebf109_dba689e5","updated":"2022-07-01 15:15:20.000000000","message":"What is the problem you\u0027re trying to solve? Could you explain it in the commit msg?","commit_id":"72548cb1b0cbf9f71f3464d3405113b3303b4d93"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2cd4348bc3f37be4bbe6d4a6538b8e9b064d5103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f4c14113_eb9f77bf","in_reply_to":"54ebf109_dba689e5","updated":"2022-07-01 18:38:54.000000000","message":"AH,sorry, I will abandon this since we will propose something a little bit different.\nWe were testing to build a package on a specific branch, for openstack/ansible-collections-openstack, which is hardcoded today [1]. The idea is to have a dependency job testing ACO on master branch, for example.\nUsing this role was a way to easy build the ref that we want [2], without too much extra code.\nWe found an issue in the role too, where \u0027artg_change_list\u0027 ends up with zuul depends-on patches only.\n\n[1] https://github.com/redhat-openstack/rdoinfo/blob/master/tags/zed-uc.yml#L5\n[2] https://review.rdoproject.org/r/c/testproject/+/38639/22/.zuul.yaml#7\n[3] https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/847419/8/roles/build-test-packages/tasks/main.yml#221","commit_id":"72548cb1b0cbf9f71f3464d3405113b3303b4d93"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f145cc080e41d729127e7381c9f1cf8ecb91ffa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0cf27ca2_5cba2eb6","in_reply_to":"b07be86b_9da01ece","updated":"2022-07-12 16:38:20.000000000","message":"I\u0027ve restored this patch as, after some discussion on IRC, it seems to be the easiest approach to accomplish what we\u0027re looking for. I\u0027ve updated the commit message with some more context about this change.","commit_id":"72548cb1b0cbf9f71f3464d3405113b3303b4d93"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"291c6f2c039a3579b924cc40835266ae01ec7252","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b07be86b_9da01ece","in_reply_to":"f4c14113_eb9f77bf","updated":"2022-07-04 12:57:40.000000000","message":"not sure what and why that\u0027s needed as zuul should auto setup the source if it\u0027s part of zuul projects, but anyway if want to test master version, can use different tag i.e zed instead of zed-uc https://github.com/redhat-openstack/rdoinfo/blob/master/tags/zed.yml#L4","commit_id":"72548cb1b0cbf9f71f3464d3405113b3303b4d93"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8046e53bf2f8a98cba97041b61ae9ca977a9db37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9566b7d4_aabace13","updated":"2022-07-14 20:03:31.000000000","message":"I think that we should try to reuse artg_change_list isntead of creating a new parameter, wdyt?","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d3d7268ff3c855cf6d69ac477ef1176c80cabf73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e5921cc4_70c1e66d","updated":"2022-07-15 07:02:57.000000000","message":"Looks good, waiting for addressing rlandy and doug suggestion","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"41dcd9e8b6fbec2cbf4fba6b906d3070ed21584a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"43f6592a_e01e4004","updated":"2022-07-14 13:10:37.000000000","message":"Thank you, Rafael!\n\nTestproject [1] shows that this patch is working as expected: RPMs for ansible-collections-openstack and python3-openstacksdk are built from source [2]:\n\n  ansible-collections-openstack.noarch        1.7.2-0.20220714112503.7ec8e4d.el9    @gating-repo                       \n  python3-openstacksdk.noarch                 0.99.1-0.20220714112848.9e9fc98.el9   @gating-repo                       \n\nNote, the job in that testproject [1] fails but this is exactly what should happen when change is working which it is!\n\n[1] https://review.rdoproject.org/r/c/testproject/+/38639/22\n[2] https://logserver.rdoproject.org/39/38639/22/check/periodic-tripleo-ci-centos-9-standalone-master-force-collection-master/1239489/logs/undercloud/var/log/extra/package-list-installed.txt.gz","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a1ae2c4db83db6723da894b4a6b37488bf4dff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"39a2b9db_ece2d10d","updated":"2022-07-15 14:26:12.000000000","message":"This has been superseded by\nhttps://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/849945","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"db1726e0aaf08c8340687bab05b5c835168c56f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fec6f978_12ea604e","in_reply_to":"9566b7d4_aabace13","updated":"2022-07-15 07:31:17.000000000","message":"Adressed in Ronelle\u0027s comment thread:\n\n  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/847419/comments/20481c65_ade878a8","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"}],"roles/build-test-packages/defaults/main.yml":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cba07a87b7b910facf8dd88846dbfe71be55a258","unresolved":true,"context_lines":[{"line_number":8,"context_line":"artg_compressed_gating_repo: \"/home/stack/gating_repo.tar.gz\""},{"line_number":9,"context_line":"artg_build_one: true"},{"line_number":10,"context_line":"artg_rdo_packages: []"},{"line_number":11,"context_line":"artg_extra_change_list: []"},{"line_number":12,"context_line":"ansible_coll_packages: []"},{"line_number":13,"context_line":"dlrn_target: \u003e-"},{"line_number":14,"context_line":"  {%- if (ansible_distribution \u003d\u003d \"RedHat\") and"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"20481c65_ade878a8","line":11,"updated":"2022-07-14 19:12:27.000000000","message":"why not just augment the current artg_change_list?","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"db1726e0aaf08c8340687bab05b5c835168c56f4","unresolved":true,"context_lines":[{"line_number":8,"context_line":"artg_compressed_gating_repo: \"/home/stack/gating_repo.tar.gz\""},{"line_number":9,"context_line":"artg_build_one: true"},{"line_number":10,"context_line":"artg_rdo_packages: []"},{"line_number":11,"context_line":"artg_extra_change_list: []"},{"line_number":12,"context_line":"ansible_coll_packages: []"},{"line_number":13,"context_line":"dlrn_target: \u003e-"},{"line_number":14,"context_line":"  {%- if (ansible_distribution \u003d\u003d \"RedHat\") and"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7b36e588_3882f8dc","line":11,"in_reply_to":"20481c65_ade878a8","updated":"2022-07-15 07:31:17.000000000","message":"Role build-test-packages overwrites variable artg_change_list with changes defined in \u0027Depends-On:\u0027 statements in the commit message of the patch being checked. This overwriting logic could be done by design, which is why we did not touch this and instead added an extra variable.\n\nAs requested, I created a separate patch which appends \u0027Depends-On:\u0027 changes to the artg_change_list variable. Thus we no longer need this additional variable artg_extra_change_list. I submitted it as a separate change because I do not want to void votes on this patch here. The new patch is at:\n\n  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/849945\n\nA testproject for the new patch is at:\n\n  https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657/2\n\nI will add another comment here once Zuul has finished the testproject.","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"88a7205de0e3a360108085822053ff11e3215fb5","unresolved":true,"context_lines":[{"line_number":8,"context_line":"artg_compressed_gating_repo: \"/home/stack/gating_repo.tar.gz\""},{"line_number":9,"context_line":"artg_build_one: true"},{"line_number":10,"context_line":"artg_rdo_packages: []"},{"line_number":11,"context_line":"artg_extra_change_list: []"},{"line_number":12,"context_line":"ansible_coll_packages: []"},{"line_number":13,"context_line":"dlrn_target: \u003e-"},{"line_number":14,"context_line":"  {%- if (ansible_distribution \u003d\u003d \"RedHat\") and"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c87872cd_08a232c0","line":11,"in_reply_to":"7b36e588_3882f8dc","updated":"2022-07-15 10:10:31.000000000","message":"The testproject [1] of the other patch [4] has finished and the latter works as expected. Variable artg_change_list is updated with openstacksdk as shown in the debug output [2] under \u0027TASK [build-test-packages : Print out the change list]\u0027:\n\n  \"artg_change_list\": [\n      {\n          \"branch\": \"master\",\n          \"host\": \"https://opendev.org\",\n          \"project\": \"openstack/openstacksdk\",\n          \"refspec\": \"+refs/heads/*:refs/remotes/origin/*\"\n      },\n      {\n          \"branch\": \"master\",\n          \"host\": \"https://review.opendev.org\",\n          \"project\": \"openstack/tripleo-quickstart-extras\",\n          \"refspec\": \"refs/changes/45/849945/1\"\n      },\n      {\n          \"branch\": \"master\",\n          \"host\": \"https://review.opendev.org\",\n          \"project\": \"openstack/ansible-collections-openstack\",\n          \"refspec\": \"refs/changes/57/849657/2\"\n      }\n  ]\n\nRPMs are built as requested [3]:\n\n  ansible-collections-openstack.noarch        1.7.2-0.20220715075159.ba8de18.el9    @gating-repo\n  python3-openstacksdk.noarch                 0.99.1-0.20220715074659.9e9fc98.el9   @gating-repo\n\nThe job tripleo-ci-centos-9-standalone-osa fails as expected [1]:\n\n  [undercloud -\u003e undercloud]: FAILED! \u003d\u003e {\"attempts\": 5, \"changed\": false, \"extra_data\": {\"data\": [\"tenant_id\"], \"details\": \"None\", \"response\": \"None\"}, \"msg\": \"Invalid query params: tenant_id\"}\n\nIt must fail because not all modules in Ansible OpenStack collection have been ported to the new openstacksdk 0.99.0 yet.\n\n[1] https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657/2\n[2] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c95/849657/2/check/tripleo-ci-centos-9-standalone-osa/c956e9a/job-output.txt\n[3] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c95/849657/2/check/tripleo-ci-centos-9-standalone-osa/c956e9a/logs/undercloud/var/log/extra/package-list-installed.txt\n[4] https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/849945","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"}],"roles/build-test-packages/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"28287cdbce3338fd87e713b66f75f7dfdc68f656","unresolved":true,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- name: get changes defined in zuul job vars"},{"line_number":214,"context_line":"  set_fact:"},{"line_number":215,"context_line":"    artg_change_list: \"{{ artg_change_list + (job[\u0027artg_extra_change_list\u0027] | default([])) }}\""},{"line_number":216,"context_line":"  when:"},{"line_number":217,"context_line":"    - job is defined"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f5db59f4_d05d460e","line":215,"updated":"2022-07-13 09:54:12.000000000","message":"Maybe document the new variable \u0027artg_extra_change_list\u0027 in https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/build-test-packages/README.md ?","commit_id":"f23d425642745ec88c45996fcc7fb47f8b5a16e1"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8833e57cf9fb55fffb54a22c51644cc37a75e722","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- name: get changes defined in zuul job vars"},{"line_number":214,"context_line":"  set_fact:"},{"line_number":215,"context_line":"    artg_change_list: \"{{ artg_change_list + (job[\u0027artg_extra_change_list\u0027] | default([])) }}\""},{"line_number":216,"context_line":"  when:"},{"line_number":217,"context_line":"    - job is defined"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"66b8b96a_8b4aadb4","line":215,"in_reply_to":"f5db59f4_d05d460e","updated":"2022-07-14 08:36:39.000000000","message":"Rafael\u0027s latest patchset adds it to the docs. Thanks!","commit_id":"f23d425642745ec88c45996fcc7fb47f8b5a16e1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8046e53bf2f8a98cba97041b61ae9ca977a9db37","unresolved":true,"context_lines":[{"line_number":165,"context_line":"  set_fact:"},{"line_number":166,"context_line":"    gerrit_host: \"{{ lookup(\u0027env\u0027, \u0027GERRIT_HOST\u0027) }}\""},{"line_number":167,"context_line":"    zuul_changes: \"{{ lookup(\u0027env\u0027, \u0027ZUUL_CHANGES\u0027) }}\""},{"line_number":168,"context_line":"    artg_change_list: \"{{ artg_change_list|default([]) }}\""},{"line_number":169,"context_line":"    cacheable: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"- name: Parse Jenkins changes"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"0facf2f8_119c2d52","line":168,"updated":"2022-07-14 20:03:31.000000000","message":"artg_change_list|job.artg_change_list|default([])\n\n+ change on line 209","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"db1726e0aaf08c8340687bab05b5c835168c56f4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"  set_fact:"},{"line_number":166,"context_line":"    gerrit_host: \"{{ lookup(\u0027env\u0027, \u0027GERRIT_HOST\u0027) }}\""},{"line_number":167,"context_line":"    zuul_changes: \"{{ lookup(\u0027env\u0027, \u0027ZUUL_CHANGES\u0027) }}\""},{"line_number":168,"context_line":"    artg_change_list: \"{{ artg_change_list|default([]) }}\""},{"line_number":169,"context_line":"    cacheable: true"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"- name: Parse Jenkins changes"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ea75290c_f25de517","line":168,"in_reply_to":"0facf2f8_119c2d52","updated":"2022-07-15 07:31:17.000000000","message":"Right, thanks Douglas 😊 Adressed in Ronelle\u0027s comment thread:\n\n  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/847419/comments/20481c65_ade878a8","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8046e53bf2f8a98cba97041b61ae9ca977a9db37","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"- name: Cache artg_change_list if change list is prepared"},{"line_number":208,"context_line":"  set_fact:"},{"line_number":209,"context_line":"    artg_change_list: \"{{ artg_change_list_prep }}\""},{"line_number":210,"context_line":"    cacheable: true"},{"line_number":211,"context_line":"  when: artg_change_list_prep is defined"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ce638477_1a451b77","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":51},"updated":"2022-07-14 20:03:31.000000000","message":"This line might be the issue, we should append \"artg_change_list_prep\" to \"artg_change_list\". You may not need to add a new extra parameter.","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"db1726e0aaf08c8340687bab05b5c835168c56f4","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"- name: Cache artg_change_list if change list is prepared"},{"line_number":208,"context_line":"  set_fact:"},{"line_number":209,"context_line":"    artg_change_list: \"{{ artg_change_list_prep }}\""},{"line_number":210,"context_line":"    cacheable: true"},{"line_number":211,"context_line":"  when: artg_change_list_prep is defined"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1fd45ac7_60328dfb","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":51},"in_reply_to":"ce638477_1a451b77","updated":"2022-07-15 07:31:17.000000000","message":"Thank you, Douglas! Adressed in Ronelle\u0027s comment thread:\n\n  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/847419/comments/20481c65_ade878a8","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a436743f68db2fb015339a62141054bc1d1007e9","unresolved":true,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- name: get extra changes, e.g. defined in zuul job vars"},{"line_number":214,"context_line":"  set_fact:"},{"line_number":215,"context_line":"    artg_change_list: \"{{ artg_change_list + job.artg_extra_change_list|default(artg_extra_change_list) }}\""},{"line_number":216,"context_line":"    cacheable: true"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"- name: Detect github PRs from commit message"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3af7e4ae_ccbc3b07","line":215,"updated":"2022-07-15 06:42:17.000000000","message":"as others have already commented... if all we need here is to add the \u0027extra\u0027 change to the artg_change_list then why can\u0027t we just use artg_change_list in the first place\nperhaps there is some reason we can\u0027t re-use the existing var?","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"db1726e0aaf08c8340687bab05b5c835168c56f4","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"- name: get extra changes, e.g. defined in zuul job vars"},{"line_number":214,"context_line":"  set_fact:"},{"line_number":215,"context_line":"    artg_change_list: \"{{ artg_change_list + job.artg_extra_change_list|default(artg_extra_change_list) }}\""},{"line_number":216,"context_line":"    cacheable: true"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"- name: Detect github PRs from commit message"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bdb2c080_ecb5c839","line":215,"in_reply_to":"3af7e4ae_ccbc3b07","updated":"2022-07-15 07:31:17.000000000","message":"Adressed in Ronelle\u0027s comment thread:\n\n  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/847419/comments/20481c65_ade878a8","commit_id":"9cfb099187630e31adbb5c736d56e1df1fea608e"}]}