)]}'
{"config/general_config/ceph.yml":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"089eacdc40b4284976789d3fcb845f56dadab34f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  -e /usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"network_isolation: true"},{"line_number":23,"context_line":"enable_pacemaker: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_d2e38ba2","line":23,"updated":"2016-06-24 13:58:37.000000000","message":"now that we have this defaulted I think we should not include it everywhere","commit_id":"7f4ef9b5a1c88fecc58c63971d42804e169b4058"}],"roles/tripleo/undercloud/tasks/post-install.yml":[{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"3a68c6b9f85e5c071697f19ae0313f200640bda5","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: enable pacemaker"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    extra_args: \u003e-"},{"line_number":52,"context_line":"      {{ extra_args }}"},{"line_number":53,"context_line":"      -e /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml"},{"line_number":54,"context_line":"  when: enable_pacemaker"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_ee5d3148","line":51,"updated":"2016-06-23 18:53:49.000000000","message":"This seems like an elegant way of extending extra_args...","commit_id":"db5c47223c854b9456b5261456e6a146b14634d4"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"089eacdc40b4284976789d3fcb845f56dadab34f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      -e $HOME/network-environment.yaml"},{"line_number":47,"context_line":"  when: network_isolation"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: enable pacemaker"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    extra_args: \u003e-"},{"line_number":52,"context_line":"      {{ extra_args }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_0d9df8bb","line":49,"updated":"2016-06-24 13:58:37.000000000","message":"I actually think this should not go in the undercloud role. The above task provides a bad example. We do not use these facts until the overcloud role, so we should set them there.\n\nI also wonder if we shouldn\u0027t then make a pacemaker_args key and add it to the overcloud role defaults.\n\nWe should probably implement this in the external overcloud role, as the intention is to switch to that fairly soon, and then we don\u0027t need to fix this twice.","commit_id":"7f4ef9b5a1c88fecc58c63971d42804e169b4058"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"cec2be5998b5404404944f269c9b8a7c92795bc6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      -e $HOME/network-environment.yaml"},{"line_number":47,"context_line":"  when: network_isolation"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: enable pacemaker"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    extra_args: \u003e-"},{"line_number":52,"context_line":"      {{ extra_args }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_437a2f78","line":49,"in_reply_to":"3aaa91ec_0d9df8bb","updated":"2016-06-24 14:32:28.000000000","message":"I totally agree with that.\nThose tasks should not be here, but the main goal here is to deployment the Overcloud with pacemaker in a short term.\nI think it would be better to fix that in a dedicated review.","commit_id":"7f4ef9b5a1c88fecc58c63971d42804e169b4058"}]}