)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"db41f1df55f77ff49ac52684ae1b2f38a9c3c6c9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: shell script to merge roles into extras"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a shell scrip that is designed to merge all the individual roles"},{"line_number":10,"context_line":"into tripleo-quickstart-extras."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Please review and look for:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a629dbe_7286c714","line":9,"updated":"2016-11-14 11:47:26.000000000","message":"s/scrip/script/","commit_id":"a4d13762eccd4e9a5c7750278e7169350db30569"}],"merge-roles.sh":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# overcloud"},{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_8ada7215","line":8,"updated":"2016-11-11 18:03:03.000000000","message":"I wonder if all of the utility roles should have \"utility-\" in front, or perhaps \"tools-\"","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# overcloud"},{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_5d88f9c6","line":8,"in_reply_to":"9a629dbe_8ada7215","updated":"2016-11-14 11:00:39.000000000","message":"I have a grudge against categories/names/folders called utility or misc(ellaneous).\n\nutility:\n    (noun) the state of being useful, profitable, or beneficial.\n    (adjective) useful, especially through being able to perform several functions.\n\nSo it\u0027s pretty much \"useful thing\". By this logic all our roles are utilities, or neither of them are. The name of the role or a category should justify its existence or it\u0027s not named well, for example you point that out with gate very appropriately below.\n\nI think of these one-off roles as a category with one item.","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_2a37a64d","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":43},"updated":"2016-11-11 18:03:03.000000000","message":"I wonder if gate should be renamed to \"build-test-packages\" since that is what is really doing?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_2aade69a","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"updated":"2016-11-11 18:03:03.000000000","message":"I wonder if this should be \"ovb-setup\"?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_4a985a78","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":70},"updated":"2016-11-11 18:03:03.000000000","message":"image-build does not need to move over","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_f87c7bed","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":43},"in_reply_to":"9a629dbe_2a37a64d","updated":"2016-11-14 11:00:39.000000000","message":"The \"gate\" role had a dual purpose: gate roles, build packages. By using this repo for all roles that becomes unnecessary, so I guess we can get rid of it and your suggestion clarifies its new purpose a lot better.","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_58dac7ea","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"in_reply_to":"9a629dbe_2aade69a","updated":"2016-11-14 11:00:39.000000000","message":"+1 for ovb-setup","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec35a779d5b1fd94fbf65dc1519ef164eaa55af","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_4ddeb4dd","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"in_reply_to":"9a629dbe_2aade69a","updated":"2016-11-11 18:38:29.000000000","message":"I\u0027d agree since this role is now being moved directly into quickstart.\nThe original aim was for the role to be a more general heat stack provisioner","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_587647d9","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":70},"in_reply_to":"9a629dbe_4a985a78","updated":"2016-11-14 11:00:39.000000000","message":"removed \"image-build\"","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_b802030a","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"in_reply_to":"9a629dbe_4ddeb4dd","updated":"2016-11-14 11:00:39.000000000","message":"Ronelle, which comment are you referring to? ovb-setup? So should we move it over here or that will be in quickstart proper?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_ea8dae31","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":53},"updated":"2016-11-11 18:03:03.000000000","message":"could this be \"overcloud-scale\"? nodes seems a bit redundant as what else would we scale?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_8a751233","line":12,"range":{"start_line":12,"start_character":62,"end_line":12,"end_character":75},"updated":"2016-11-11 18:03:03.000000000","message":"undercloud-validate-ipmi?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_a333b8f5","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":53},"in_reply_to":"9a629dbe_0d591c8e","updated":"2016-11-14 11:00:39.000000000","message":"I\u0027ll add \"validate-ipmi\" to the utilities section then and won\u0027t prefix it. Or should I prefix it with \"undercloud-\"?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_a34ad853","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":53},"in_reply_to":"9a629dbe_ea8dae31","updated":"2016-11-14 11:00:39.000000000","message":"+1 for overcloud-scale","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec35a779d5b1fd94fbf65dc1519ef164eaa55af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat image-build reboot\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_0d591c8e","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":53},"in_reply_to":"9a629dbe_ea8dae31","updated":"2016-11-11 18:38:29.000000000","message":"validate-ipmi is a pre-undercloud install step, not post deployment. if we have no access to the overcloudnodes, no point in installing (type idea)","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"1ec35a779d5b1fd94fbf65dc1519ef164eaa55af","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"git clone https://git.openstack.org/openstack/tripleo-quickstart-extras"},{"line_number":18,"context_line":"pushd tripleo-quickstart-extras"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_0de75cac","line":15,"updated":"2016-11-11 18:38:29.000000000","message":"rasca has baremetal undercloud roles (if they still exist)?","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# baremetal"},{"line_number":15,"context_line":"ROLES\u003d\"$ROLES baremetal-prep-virthost overcloud-prep-baremetal\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"git clone https://git.openstack.org/openstack/tripleo-quickstart-extras"},{"line_number":18,"context_line":"pushd tripleo-quickstart-extras"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_a361f8d5","line":15,"in_reply_to":"9a629dbe_0de75cac","updated":"2016-11-14 11:00:39.000000000","message":"I\u0027ll add rasca as reviewers to see if we\u0027re missing anything.","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"72d609c2fd64e26e81befa211e43e6d5ed64390b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    elif [ \"$role\" \u003d \"tempest\" ]; then"},{"line_number":31,"context_line":"        newrole\u003dvalidate-tempest"},{"line_number":32,"context_line":"    elif [ \"$role\" \u003d \"overcloud-validate\" ]; then"},{"line_number":33,"context_line":"        newrole\u003dvalidate-pingtest"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"        newrole\u003d$role"},{"line_number":36,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_2ab6c6f8","line":33,"updated":"2016-11-11 18:03:03.000000000","message":"I wonder if we could name this something like \"validate-simple\" or \"validate-simple-heat\". I think I prefer the former, as this validates more than heat.\n\nIn any case it is much more than a ping test.","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"048702526f798e18016d725a897b2942c1f1bdb9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    elif [ \"$role\" \u003d \"tempest\" ]; then"},{"line_number":31,"context_line":"        newrole\u003dvalidate-tempest"},{"line_number":32,"context_line":"    elif [ \"$role\" \u003d \"overcloud-validate\" ]; then"},{"line_number":33,"context_line":"        newrole\u003dvalidate-pingtest"},{"line_number":34,"context_line":"    else"},{"line_number":35,"context_line":"        newrole\u003d$role"},{"line_number":36,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_63ae00e9","line":33,"in_reply_to":"9a629dbe_2ab6c6f8","updated":"2016-11-14 11:00:39.000000000","message":"validate-simple sounds fine to me","commit_id":"1433864a4b52b8f81b8d76ccc2bd4a783aa54452"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"00728465ed9cd6ce6ee74ab8b50548b3bf03489e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ROLES\u003d\"overcloud-prep-config overcloud-prep-flavors overcloud-prep-images overcloud-prep-network overcloud ssl\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# utility"},{"line_number":9,"context_line":"ROLES\u003d\"$ROLES cleanup-nfo collect-logs gate provision-heat\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# post deployment"},{"line_number":12,"context_line":"ROLES\u003d\"$ROLES overcloud-upgrade overcloud-scale-nodes tempest validate-ipmi overcloud-validate overcloud-validate-ha\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a629dbe_5739ad40","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"updated":"2016-11-14 14:12:15.000000000","message":"\"provision-heat\" is not a single role, it contains several roles. Any recommendation how to handle that?\n\nhttps://github.com/rdo-ci/ansible-role-tripleo-provision-heat/tree/master/roles\n\nThe same is true for the \"reboot\" repo that I removed until we figure it out: https://github.com/redhat-openstack/ansible-role-tripleo-reboot","commit_id":"a4d13762eccd4e9a5c7750278e7169350db30569"}]}