)]}'
{"config/general_config/featureset001.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"27a7038658d114007131f72a8ad7b963c3d04ba9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"run_tempest: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# This enables the run of several tripleo-validations tests"},{"line_number":30,"context_line":"run_tripleo_validations: True"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# keep the doc gen settings at the bottom of the config file."},{"line_number":33,"context_line":"# options below direct automatic doc generation by tripleo-collect-logs"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bff0334d_59a1e793","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":29},"updated":"2017-04-09 11:24:36.000000000","message":"If it\u0027s ovb job in tripelo-ci, I don\u0027t think we want to run validations there, it\u0027s already very close to time limit.","commit_id":"b7375735984778ce8489a8f0ed6817f0d4dcbd5a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"999738cd2b4b7c9f07e65442e41912ca92a955cd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"extra_args: \u003e-"},{"line_number":29,"context_line":"  --ntp-server pool.ntp.org"},{"line_number":30,"context_line":"test_ping: true"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# This enables the run of several tripleo-validations tests through Mistral"},{"line_number":33,"context_line":"run_tripleo_validations: True"},{"line_number":34,"context_line":"# This enables the run of tripleo-validations negative tests through shell"},{"line_number":35,"context_line":"# scripts"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"ff346bd7_c8132f0d","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":1},"updated":"2017-07-24 10:36:17.000000000","message":"Let\u0027s not enable it on OVB, we don\u0027t have enough time. Maybe after moving to rdo cloud. Let\u0027s enable it for multinode only right now.","commit_id":"0f994a24a4b825c19eb712191e06339d672b10f4"}],"doc/source/feature-configuration.rst":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"a5edeec19a8315ad3bb48f6eed0865edcb32d121","unresolved":false,"context_lines":[{"line_number":40,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":41,"context_line":"| tempest         |        |        |        |        |        |        |        |        |        |"},{"line_number":42,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":43,"context_line":"| validations     | X      | X      | X      | X      | X      | X      | X      | X      | X      |"},{"line_number":44,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":45,"context_line":"| scenario001     |        |        |        |        | X      |        |        |        |        |"},{"line_number":46,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dfeb2761_874acf7d","line":43,"updated":"2017-03-31 11:18:01.000000000","message":"How much time does the validation add to the runs? I\u0027m not sure it\u0027s necessary to do it in all the jobs.","commit_id":"79cafe827ba711e09023434e06c4ab277c0e898c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"27a7038658d114007131f72a8ad7b963c3d04ba9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":41,"context_line":"| tempest         |        |        |        |        |        |        |        |        |        |"},{"line_number":42,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":43,"context_line":"| validations     | X      | X      |        |        |        |        |        |        |        |"},{"line_number":44,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"},{"line_number":45,"context_line":"| scenario001     |        |        |        |        | X      |        |        |        |        |"},{"line_number":46,"context_line":"+-----------------+--------+--------+--------+--------+--------+--------+--------+--------+--------+"}],"source_content_type":"text/x-rst","patch_set":25,"id":"bff0334d_39aaa370","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":22},"updated":"2017-04-09 11:24:36.000000000","message":"ditto","commit_id":"b7375735984778ce8489a8f0ed6817f0d4dcbd5a"}],"doc/source/validations.rst":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ca9dbd9a4828bcbcf99d4c3a923233bbe9a0de2e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"-----------------------------------"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This is a collection of Ansible playbooks to detect and report potential issues"},{"line_number":8,"context_line":"during TripleO deployments."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The validations will help to detect issues early in the deployment process and"},{"line_number":11,"context_line":"prevent field engineers from wasting time on misconfiguration or hardware issues"}],"source_content_type":"text/x-rst","patch_set":43,"id":"1f1a1f67_0ddba57d","line":8,"updated":"2017-07-20 08:21:03.000000000","message":"please consider also pointing at https://docs.openstack.org/tripleo-docs/latest/install/validations/validations.html","commit_id":"e2ced0e3bedec9ad332cb8b96e75fa7af1ca8140"}],"playbooks/quickstart-extras.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"f368b399755f79f899c6ee3bf1eb666a10aae6cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              tasks_from: \"run-validations-script\""},{"line_number":73,"context_line":"            vars:"},{"line_number":74,"context_line":"              group: \"pre-deploy\""},{"line_number":75,"context_line":"              validations:"},{"line_number":76,"context_line":"                - 512e"},{"line_number":77,"context_line":"                - ceilometerdb-size"},{"line_number":78,"context_line":"                - dhcp-provisioning"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba2be162_ac988bc1","line":75,"updated":"2017-03-02 17:36:03.000000000","message":"The validation config should be moved from the playbook to a config file.","commit_id":"5ace298ccd0e7a84c1c69154a2d9d8bdc95557c4"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"a7530035cc77b71af7d700a4ceee84cebda00b89","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              tasks_from: \"run-validations-script\""},{"line_number":73,"context_line":"            vars:"},{"line_number":74,"context_line":"              group: \"pre-deploy\""},{"line_number":75,"context_line":"              validations:"},{"line_number":76,"context_line":"                - 512e"},{"line_number":77,"context_line":"                - ceilometerdb-size"},{"line_number":78,"context_line":"                - dhcp-provisioning"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba2be162_756aa4b4","line":75,"in_reply_to":"ba2be162_ac988bc1","updated":"2017-03-03 15:51:38.000000000","message":"That code was part of the first approach and first patchsets (from 2016) and are now useless! dropped those lines in the last patchset. Just forgot to remove them!","commit_id":"5ace298ccd0e7a84c1c69154a2d9d8bdc95557c4"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"3e780ade89d20b5a5bc5c9505472515fbc6947ed","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - tripleo-validations"},{"line_number":101,"context_line":"  vars:"},{"line_number":102,"context_line":"    validations_group_name: \u0027post-deployment\u0027"},{"line_number":103,"context_line":"  roles:"},{"line_number":104,"context_line":"    - { role: tripleo-validations, when: run_tripleo_validations|bool }"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"dfeb2761_c71e976f","line":102,"updated":"2017-03-31 11:19:49.000000000","message":"I came up with the same idea in the extras change before I saw your comment here, so it looks like this makes sense for both of us. :)","commit_id":"8056cbc39fa2d8ebab41a10074b9f18f21db3e40"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"4fff5935ef3fba9570ac284e20cb0762b5ac1841","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  tags:"},{"line_number":100,"context_line":"    - tripleo-validations"},{"line_number":101,"context_line":"  vars:"},{"line_number":102,"context_line":"    validations_group_name: \u0027post-deployment\u0027"},{"line_number":103,"context_line":"  roles:"},{"line_number":104,"context_line":"    - { role: tripleo-validations, when: run_tripleo_validations|bool }"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ffe62b97_f8570e26","line":102,"updated":"2017-03-30 13:28:06.000000000","message":"maybe we could make validations_groups a list, and just check at each of these role inclusions if the type we want is in the list?\n\n\nlike in the defaults:\n\nvalidations_groups:\n- pre-introspection\n- pre-deployment\n- post-deployment\n\nthen in this playbook we would check if the step is in the list:\n\nwhen: \u0027post-deployment\u0027 in validations_groups","commit_id":"8056cbc39fa2d8ebab41a10074b9f18f21db3e40"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"a5edeec19a8315ad3bb48f6eed0865edcb32d121","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  roles:"},{"line_number":19,"context_line":"    - undercloud-deploy"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Setup tripleo-validations script on the undercloud"},{"line_number":22,"context_line":"- name: Configure tripleo-validations"},{"line_number":23,"context_line":"  hosts: undercloud"},{"line_number":24,"context_line":"  gather_facts: no"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"dfeb2761_c750d735","line":21,"updated":"2017-03-31 11:18:01.000000000","message":"Please remove redundant comments throughout the change. Use only the task name.","commit_id":"79cafe827ba711e09023434e06c4ab277c0e898c"}],"roles/common/defaults/main.yml":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"a5edeec19a8315ad3bb48f6eed0865edcb32d121","unresolved":false,"context_lines":[{"line_number":189,"context_line":"libvirt_uri: qemu:///session"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# This enables the run of several tripleo-validations tests"},{"line_number":192,"context_line":"run_tripleo_validations: True"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"dfeb2761_a745d372","line":192,"updated":"2017-03-31 11:18:01.000000000","message":"I think this should be enabled per configuration (a.k.a. featureset) and not enabled globally.","commit_id":"79cafe827ba711e09023434e06c4ab277c0e898c"}]}
