)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5986f53fd306fc6d73a68666f21fcc89fce20422","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- instead of the nebulous names \"non_root_user\" and \"ssh_user\", we now"},{"line_number":19,"context_line":"  have \"virthost_user\" and \"undercloud_user\"."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- we have \"virthost_working_dir\" and \"undercloud_working_dir\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- some tasks have been relocated from provision to libvirt/setup,"},{"line_number":24,"context_line":"  reflecting the fact that they need to run per-remote-user rather"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_1b46dd4e","line":21,"updated":"2017-03-04 08:28:11.000000000","message":"As to a new-comer, those names looked confusing to me as well. This looks much clear.","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"}],"roles/environment/setup/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5986f53fd306fc6d73a68666f21fcc89fce20422","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  async: 7200"},{"line_number":98,"context_line":"  poll: 0"},{"line_number":99,"context_line":"# We\u0027re going to want to store things in `virthost_working_dir` so ensure it"},{"line_number":100,"context_line":"# exists first.  `working_dir` is a directory on the virthost."},{"line_number":101,"context_line":"- name: Ensure remote working dir exists"},{"line_number":102,"context_line":"  file:"},{"line_number":103,"context_line":"    path: \"{{ virthost_working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_bb44f149","line":100,"updated":"2017-03-04 08:28:11.000000000","message":"not sure why linter complains here, may be cuz of removed `changed_when: false` ? And why no more of becoming?\n\nThe \"`working_dir` is a directory on the virthost\" also reads confusing. You\u0027ve reworked the working_dir to be either undercloud_* or virthost_* one, haven\u0027t you?","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"95050c0808b7e82fd9b4579d959d5e1e46493a29","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  async: 7200"},{"line_number":98,"context_line":"  poll: 0"},{"line_number":99,"context_line":"# We\u0027re going to want to store things in `virthost_working_dir` so ensure it"},{"line_number":100,"context_line":"# exists first.  `working_dir` is a directory on the virthost."},{"line_number":101,"context_line":"- name: Ensure remote working dir exists"},{"line_number":102,"context_line":"  file:"},{"line_number":103,"context_line":"    path: \"{{ virthost_working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_865c347e","line":100,"in_reply_to":"ba2be162_bb44f149","updated":"2017-03-04 12:53:19.000000000","message":"The removed changed_when was a rebasing error.  I\u0027ll have to fix that.","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5986f53fd306fc6d73a68666f21fcc89fce20422","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# exists first.  `working_dir` is a directory on the virthost."},{"line_number":101,"context_line":"- name: Ensure remote working dir exists"},{"line_number":102,"context_line":"  file:"},{"line_number":103,"context_line":"    path: \"{{ virthost_working_dir }}\""},{"line_number":104,"context_line":"    state: directory"},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_3b9e41b9","line":103,"updated":"2017-03-04 08:28:11.000000000","message":"if I follow defaults right, it needs\n\nowner: \"{{ virthost_user }}\"\ngroup: \"{{ virthost_group }}\"\n\nditto to the convert_image_working_dir around","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"95050c0808b7e82fd9b4579d959d5e1e46493a29","unresolved":false,"context_lines":[{"line_number":100,"context_line":"# exists first.  `working_dir` is a directory on the virthost."},{"line_number":101,"context_line":"- name: Ensure remote working dir exists"},{"line_number":102,"context_line":"  file:"},{"line_number":103,"context_line":"    path: \"{{ virthost_working_dir }}\""},{"line_number":104,"context_line":"    state: directory"},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_c652ac66","line":103,"in_reply_to":"ba2be162_3b9e41b9","updated":"2017-03-04 12:53:19.000000000","message":"Good catch.","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"}],"roles/libvirt/setup/undercloud/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5986f53fd306fc6d73a68666f21fcc89fce20422","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    ansible_private_key_file: \"{{ undercloud_key }}\""},{"line_number":324,"context_line":"    ansible_ssh_extra_args: \u0027-F \"{{ local_working_dir }}/ssh.config.ansible\"\u0027"},{"line_number":325,"context_line":"    undercloud_ip: \"{{ undercloud_ip }}\""},{"line_number":326,"context_line":"    working_dir: \"{{ undercloud_working_dir }}\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"- name: Generate ssh configuration"},{"line_number":329,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_bbe0712a","line":326,"updated":"2017-03-04 08:28:11.000000000","message":"could you clarify the use cases left for the original working_dir var? it has been reworked to virthost_/undercloud_ ...","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"95050c0808b7e82fd9b4579d959d5e1e46493a29","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    ansible_private_key_file: \"{{ undercloud_key }}\""},{"line_number":324,"context_line":"    ansible_ssh_extra_args: \u0027-F \"{{ local_working_dir }}/ssh.config.ansible\"\u0027"},{"line_number":325,"context_line":"    undercloud_ip: \"{{ undercloud_ip }}\""},{"line_number":326,"context_line":"    working_dir: \"{{ undercloud_working_dir }}\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"- name: Generate ssh configuration"},{"line_number":329,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_064924b7","line":326,"in_reply_to":"ba2be162_bbe0712a","updated":"2017-03-04 12:53:19.000000000","message":"Because the tripleo-inventory role is a mess and this allows it to work correctly with having to be rewritten completely. In particular, it always uses \"working_dir\" but may run on different hosts (e.g., the local host, or the overcloud, etc).  Making working_dir a host fact solves the problem nicely.  This also allows the roles in tripleo-quickstart-extras to continue working.","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"}],"roles/provision/local/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5986f53fd306fc6d73a68666f21fcc89fce20422","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    ansible_fqdn: \"{{ virthost }}\""},{"line_number":47,"context_line":"    ansible_user: \"root\""},{"line_number":48,"context_line":"    ansible_host: \"{{ virthost }}\""},{"line_number":49,"context_line":"    working_dir: \"{{ virthost_working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_dbc28584","line":49,"updated":"2017-03-04 08:28:11.000000000","message":"ditto","commit_id":"f0cbf42c9e0c8ef5fea8780f6e227afa28d1e997"}],"roles/provision/teardown/tasks/main.yml":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"587515536e74a410b704ea81b07c147f2dfc81c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Check that the non-root user exists."},{"line_number":2,"context_line":"- name: Get UID of non-root user"},{"line_number":3,"context_line":"  command: \u003e"},{"line_number":4,"context_line":"    id -u {{ virthost_user }}"},{"line_number":5,"context_line":"  register: virthost_uid"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_6fc91726","line":2,"updated":"2017-03-09 18:47:59.000000000","message":"Do we want to update the task names accordingly as well?","commit_id":"4d07c3a9c6f69693ceec65df0721320f6516cbeb"},{"author":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"change_message_id":"706b3346b8efe5f91207b74e96a9a10c4631c0e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Check that the non-root user exists."},{"line_number":2,"context_line":"- name: Get UID of non-root user"},{"line_number":3,"context_line":"  command: \u003e"},{"line_number":4,"context_line":"    id -u {{ virthost_user }}"},{"line_number":5,"context_line":"  register: virthost_uid"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_676cce35","line":2,"in_reply_to":"9a30ddce_6fc91726","updated":"2017-03-10 02:25:26.000000000","message":"That\u0027s not a bad idea.","commit_id":"4d07c3a9c6f69693ceec65df0721320f6516cbeb"}],"roles/provision/user/tasks/main.yml":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"587515536e74a410b704ea81b07c147f2dfc81c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Create a non-root user on the target host.  This is the user that"},{"line_number":2,"context_line":"# will own the virtual infrastructure on which we deploy openstack."},{"line_number":3,"context_line":"- name: Create non-root group"},{"line_number":4,"context_line":"  group:"},{"line_number":5,"context_line":"    name: \"{{ virthost_group }}\""},{"line_number":6,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_af586f8b","line":3,"updated":"2017-03-09 18:47:59.000000000","message":"Same -- might want to update task names","commit_id":"4d07c3a9c6f69693ceec65df0721320f6516cbeb"}]}