)]}'
{"roles/libvirt/setup/overcloud/tasks/main.yml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9f1e4e5432586c12155c273b1ffccadb6dab8de2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - \"{{ extradisks_list }}\""},{"line_number":59,"context_line":"      register: overcloud_attach_disk"},{"line_number":60,"context_line":"      changed_when: overcloud_attach_disk.rc \u003d\u003d 0"},{"line_number":61,"context_line":"      failed_when: overcloud_attach_disk.rc !\u003d 0 and \u0027target {{ item[1] }} already exists\u0027 not in overcloud_attach_disk.stderr"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Generate the `instackenv.json` configuration file.  Note that this"},{"line_number":64,"context_line":"# task *must* occur after the above overcloud tasks, because if"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_f9164149","line":61,"updated":"2017-07-18 06:44:13.000000000","message":"it would have been better if the exit code was different than 1\n\nwhat worries me is that I tried this locally and the error message was different:\n\nerror: XML error: target \u0027vdb\u0027 duplicated for disk sources \u0027/mnt/vms/tichawi.qcow2\u0027 and \u0027/mnt/vms/tichawi.qcow2\u0027\n\nnot sure if you can look for both sentences?","commit_id":"1ebed09524facf09077dba7696cad925da40aa1f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"4fae0a69c8cbc32ce69f83de88f1577e4b22d83e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - \"{{ extradisks_list }}\""},{"line_number":59,"context_line":"      register: overcloud_attach_disk"},{"line_number":60,"context_line":"      changed_when: overcloud_attach_disk.rc \u003d\u003d 0"},{"line_number":61,"context_line":"      failed_when: overcloud_attach_disk.rc !\u003d 0 and \u0027target {{ item[1] }} already exists\u0027 not in overcloud_attach_disk.stderr"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Generate the `instackenv.json` configuration file.  Note that this"},{"line_number":64,"context_line":"# task *must* occur after the above overcloud tasks, because if"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_116abb18","line":61,"in_reply_to":"1f1a1f67_78b6748c","updated":"2017-07-19 14:45:40.000000000","message":"libvirt 3.5.0-1","commit_id":"1ebed09524facf09077dba7696cad925da40aa1f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"78d18ddbeacbdd315977859527466d1eb5688c8c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - \"{{ extradisks_list }}\""},{"line_number":59,"context_line":"      register: overcloud_attach_disk"},{"line_number":60,"context_line":"      changed_when: overcloud_attach_disk.rc \u003d\u003d 0"},{"line_number":61,"context_line":"      failed_when: overcloud_attach_disk.rc !\u003d 0 and \u0027target {{ item[1] }} already exists\u0027 not in overcloud_attach_disk.stderr"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Generate the `instackenv.json` configuration file.  Note that this"},{"line_number":64,"context_line":"# task *must* occur after the above overcloud tasks, because if"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_78b6748c","line":61,"in_reply_to":"1f1a1f67_f9164149","updated":"2017-07-19 13:30:23.000000000","message":"Just curious, but what version of virsh do you have? I\u0027ve got v2.0.0 (CentOS 7.3).\n\nYeah, I wasn\u0027t excited about using the error message but, as you stated, the error code doesn\u0027t help. It seems the error message isn\u0027t a reliable way of detecting whether a disk is already attached. I\u0027ll work on an alternate approach that\u0027s more reliable.","commit_id":"1ebed09524facf09077dba7696cad925da40aa1f"}]}