)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"140e960e7a5638121001e5984af174887a3dfacc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoids use of ignore_errors while loading OS specific variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements pattern described in"},{"line_number":10,"context_line":"https://github.com/ansible/ansible/issues/38227#issuecomment-378358165"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Example of confusing output before this change:"},{"line_number":13,"context_line":"https://ci.centos.org/job/tripleo-quickstart-extras-gate-master-delorean-full-featureset052/1604/consoleFull"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1635e642","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":20},"updated":"2018-11-12 08:09:22.000000000","message":"can you maybe add one sentence about this pattern and what it means for the loaded variables?","commit_id":"43f9cf61265ab695de384a1396c4aeaf025818b0"}],"roles/environment/tasks/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"140e960e7a5638121001e5984af174887a3dfacc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"{{ vars_item }}\""},{"line_number":3,"context_line":"  when: vars_item | length"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"      vars_item: \"{{ lookup(\u0027first_found\u0027, vars_search) }}\""},{"line_number":6,"context_line":"      vars_search:"},{"line_number":7,"context_line":"          files: \"{{ item }}\""},{"line_number":8,"context_line":"          paths:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_76269a24","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":6},"updated":"2018-11-12 08:09:22.000000000","message":"is this over-indented?","commit_id":"43f9cf61265ab695de384a1396c4aeaf025818b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"57a639dbfd9057ad1b56f1ffdea48871ff40c06d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"{{ vars_item }}\""},{"line_number":3,"context_line":"  when: vars_item | length"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"      vars_item: \"{{ lookup(\u0027first_found\u0027, vars_search) }}\""},{"line_number":6,"context_line":"      vars_search:"},{"line_number":7,"context_line":"          files: \"{{ item }}\""},{"line_number":8,"context_line":"          paths:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f0104bad","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":6},"in_reply_to":"3f79a3b5_3f93124f","updated":"2018-11-14 08:47:39.000000000","message":"well fair. i pointed it out because i noticed it and literally everywhere else (yeah ok challenge accepted maybe you can find another place but it would be very few) is using the 2 space indent\n\nif you believe this is the _right_ way then yeah it would be worth leading a campaign to change it in all the places.\n\nOtherwise if you don\u0027t really care/mind then it is cheap to fix. just saying.","commit_id":"43f9cf61265ab695de384a1396c4aeaf025818b0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"1b42cc8a72b439b13861fcc268244c306194a878","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"{{ vars_item }}\""},{"line_number":3,"context_line":"  when: vars_item | length"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"      vars_item: \"{{ lookup(\u0027first_found\u0027, vars_search) }}\""},{"line_number":6,"context_line":"      vars_search:"},{"line_number":7,"context_line":"          files: \"{{ item }}\""},{"line_number":8,"context_line":"          paths:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3f93124f","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":6},"in_reply_to":"3f79a3b5_76269a24","updated":"2018-11-12 13:15:31.000000000","message":"Does it pass linting? Yes. So is ok.\n\nIf we are about to harden the code style, I am all for it, but this has to go in a separated change that would *prevent* regression, not here.","commit_id":"43f9cf61265ab695de384a1396c4aeaf025818b0"},{"author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"change_message_id":"009af6ad1def286e44272a0b18df671324bbbf0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Include OS specific variables"},{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_6689e527","line":2,"updated":"2018-11-14 10:19:07.000000000","message":"I think we don\u0027t need \"vars/\" prefix here, at least for playbooks it works, it goes directly to vars directory.","commit_id":"5db35ed1ebbca9c232a80c77b48217b8a5045bae"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7660d0c1f8f940400f25479b42b194acf9ee67c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Include OS specific variables"},{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_644d4bc5","line":2,"in_reply_to":"3f79a3b5_6689e527","updated":"2018-11-15 11:24:00.000000000","message":"+1","commit_id":"5db35ed1ebbca9c232a80c77b48217b8a5045bae"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7660d0c1f8f940400f25479b42b194acf9ee67c0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":6,"context_line":"      - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":7,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":8,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.replace(\u0027.\u0027, \u0027-\u0027) | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_a49603ee","line":8,"range":{"start_line":5,"start_character":8,"end_line":8,"end_character":109},"updated":"2018-11-15 11:24:00.000000000","message":"The common practice is to use \"with_first_found\" and have this list in reverse order","commit_id":"5db35ed1ebbca9c232a80c77b48217b8a5045bae"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b49f1e07b093800a05e1ae936beae713cfbd7cc6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":6,"context_line":"      - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":7,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":8,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.replace(\u0027.\u0027, \u0027-\u0027) | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfdaf3ff_0cf69dfa","line":8,"range":{"start_line":5,"start_character":8,"end_line":8,"end_character":109},"in_reply_to":"3f79a3b5_79f5ed51","updated":"2019-01-18 12:12:31.000000000","message":"This is exactly that this does: allow user to define/override variable at more granular levels.","commit_id":"5db35ed1ebbca9c232a80c77b48217b8a5045bae"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7b163fb12f4bf6e9a4d3fba7a58025a84ffde11a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":6,"context_line":"      - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":7,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":8,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.replace(\u0027.\u0027, \u0027-\u0027) | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_79f5ed51","line":8,"range":{"start_line":5,"start_character":8,"end_line":8,"end_character":109},"in_reply_to":"3f79a3b5_a49603ee","updated":"2018-11-15 17:16:40.000000000","message":"So what if you only want to override some of the vars? I think doing this is better as it\u0027s more hiera-like in the inheritance. \n\nSpecifically you can define something for all redhat but tweak only a single variable in redhat-7.6.yaml","commit_id":"5db35ed1ebbca9c232a80c77b48217b8a5045bae"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9527df678c95e6e6bd3ea684634580587f492cfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Include OS specific variables"},{"line_number":2,"context_line":"  include_vars: \"vars/{{ item }}\""},{"line_number":3,"context_line":"  failed_when: false"},{"line_number":4,"context_line":"  loop:"},{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_d451d437","line":2,"updated":"2019-06-27 06:57:35.000000000","message":"wow old review just popped back into my list :D\n\nso the only comment i can see here that isn\u0027t addressed is if that vars/ is necessary\n\nif it doesn\u0027t hurt then fine for me","commit_id":"a20a7cbf0986e321a67ed36a6e57ce3321a5f6ce"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"28c5ffc3f1a8eead28991248661822b44b2edb7f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":6,"context_line":"      - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":7,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":8,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0:2] | join(\u0027-\u0027) | lower }}.yml\""},{"line_number":9,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0:3] | join(\u0027-\u0027) | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_4382aeca","line":8,"updated":"2019-07-04 15:50:13.000000000","message":"why the two extra vars?","commit_id":"a20a7cbf0986e321a67ed36a6e57ce3321a5f6ce"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"f920558604839678ada6043bb33f53b900393803","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":6,"context_line":"      - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":7,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":8,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0:2] | join(\u0027-\u0027) | lower }}.yml\""},{"line_number":9,"context_line":"      - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0:3] | join(\u0027-\u0027) | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_63600a34","line":8,"in_reply_to":"7faddb67_4382aeca","updated":"2019-07-04 15:53:41.000000000","message":"This allows for future overrides for minor versions. Added here in order to document the full pattern, even if currently we do not have any overrides.\n\nWhen we add ones, we would not have to modify the pattern.","commit_id":"a20a7cbf0986e321a67ed36a6e57ce3321a5f6ce"}]}