)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"610b8ed933c0040c089e3a32e467965b5e6bf69e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add git-review to dependencies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"git-review is required for working with Gerrit,"},{"line_number":10,"context_line":"in particular in reproducer."},{"line_number":11,"context_line":"Change-Id: Ibc2fb717ad132f1f56fec2e462df85da2e53e671"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_f5407908","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":47},"updated":"2019-02-28 12:37:10.000000000","message":"While I love git-review and find it very useful, I am not sure why it should be listed here as a direct dependency of tripleo-quickstart. \n\nAt this moment git-review is not usable in CI because it requires to speak with gerrit via SSH, something that is not configured at least upstream (also infra team stated that this is even not desired).\n\nI do not see the git-review tool being used in this repository, so is not a dependency to list here.\n\nPlease note that I am not against using git-review myself, just that I think this is not the right place to list it. If we need it in a specific workflow, we need to install it at part of that workflow, not a a generic dependency.\n\nFor me, even if we use it in reproducer, it would count as a weak-dependency. That is because people using quickstart do not need it and normal-CI does not need it.","commit_id":"0d2b64c96c4dc5895570ffc15ac4fa8c9008b9b8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"93fe14a565b11429bddef468bf0082924a9a13b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add git-review to dependencies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"git-review is required for working with Gerrit,"},{"line_number":10,"context_line":"in particular in reproducer."},{"line_number":11,"context_line":"Change-Id: Ibc2fb717ad132f1f56fec2e462df85da2e53e671"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_ab0e122f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":47},"in_reply_to":"9fdfeff1_f5407908","updated":"2019-02-28 13:51:06.000000000","message":"we don\u0027t use it in quickstart.sh, but we do use it in reproducer and should have it as a dependency.","commit_id":"0d2b64c96c4dc5895570ffc15ac4fa8c9008b9b8"}]}
