)]}'
{"molecule/install-deps.sh":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    echo \"INFO: Skip cloning repo as sibling already found\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    pushd .. \u003e/dev/null"},{"line_number":8,"context_line":"    git clone https://github.com/openstack/tripleo-quickstart-extras.git"},{"line_number":9,"context_line":"    popd \u003e/dev/null"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9fb8cfa7_55cfc7af","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":32},"updated":"2019-06-17 17:07:48.000000000","message":"not github please, we have to use opendev","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    echo \"INFO: Skip cloning repo as sibling already found\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    pushd .. \u003e/dev/null"},{"line_number":8,"context_line":"    git clone https://github.com/openstack/tripleo-quickstart-extras.git"},{"line_number":9,"context_line":"    popd \u003e/dev/null"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9fb8cfa7_29365bb6","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":32},"in_reply_to":"9fb8cfa7_55cfc7af","updated":"2019-06-19 10:29:36.000000000","message":"Done","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"}],"molecule/repo-setup/molecule.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  command: bash molecule/install-deps.sh"},{"line_number":9,"context_line":"driver:"},{"line_number":10,"context_line":"  name: docker"},{"line_number":11,"context_line":"log: true"},{"line_number":12,"context_line":"platforms:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  - name: centos7-master"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_5544a71b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":1},"updated":"2019-06-17 17:07:48.000000000","message":"is indentation correct?","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  command: bash molecule/install-deps.sh"},{"line_number":9,"context_line":"driver:"},{"line_number":10,"context_line":"  name: docker"},{"line_number":11,"context_line":"log: true"},{"line_number":12,"context_line":"platforms:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  - name: centos7-master"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_e9828300","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":1},"in_reply_to":"9fb8cfa7_5544a71b","updated":"2019-06-19 10:29:36.000000000","message":"Nope, this has to go under provisioner. I also added https://github.com/ansible/molecule/issues/2113 to improve the schema validation and avoid such bugs.","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"}],"molecule/repo-setup/playbook.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # TODO: this should be made by the role:"},{"line_number":8,"context_line":"    - name: ensure directory exists"},{"line_number":9,"context_line":"      file:"},{"line_number":10,"context_line":"        path: /home/stack"},{"line_number":11,"context_line":"        state: directory"},{"line_number":12,"context_line":"        mode: 0755"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_b552c3dd","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"updated":"2019-06-17 17:07:48.000000000","message":"why \"stack\"?","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # TODO: this should be made by the role:"},{"line_number":8,"context_line":"    - name: ensure directory exists"},{"line_number":9,"context_line":"      file:"},{"line_number":10,"context_line":"        path: /home/stack"},{"line_number":11,"context_line":"        state: directory"},{"line_number":12,"context_line":"        mode: 0755"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_69c45341","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"in_reply_to":"9fb8cfa7_b552c3dd","updated":"2019-06-19 10:29:36.000000000","message":"repo-setup-\u003ecommon-extra-\u003ecommon which has stack user in its defaults.\n\nThat is why I added the TODO message. Please keep in mind that the scope of this change is to enable molecule to run this role, not to fix role bugs. That is only a temporary hack to make it run. Once we have the job we can work on addresing that issue (and quickly test the effect of the change)","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"}],"roles/repo-setup/defaults/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - queens"},{"line_number":12,"context_line":"  - rocky"},{"line_number":13,"context_line":"  - stein"},{"line_number":14,"context_line":"release: master"},{"line_number":15,"context_line":"dlrn_hash_tag: current-tripleo"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"repo_cmd_before: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_355813f9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":15},"updated":"2019-06-17 17:07:48.000000000","message":"this is set only in periodic jobs, defining it here can break logic in very unexpected places and ways.","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  - queens"},{"line_number":12,"context_line":"  - rocky"},{"line_number":13,"context_line":"  - stein"},{"line_number":14,"context_line":"release: master"},{"line_number":15,"context_line":"dlrn_hash_tag: current-tripleo"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"repo_cmd_before: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_292adbe6","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":15},"in_reply_to":"9fb8cfa7_355813f9","updated":"2019-06-19 10:29:36.000000000","message":"Done","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":"repo_cmd_before: |"},{"line_number":18,"context_line":"  {% if ansible_pkg_mgr \u003d\u003d \"yum\" %}"},{"line_number":19,"context_line":"  sudo {{ ansible_pkg_mgr }} install -y yum-plugin-priorities;"},{"line_number":20,"context_line":"  {% else %}"},{"line_number":21,"context_line":"  sudo {{ ansible_pkg_mgr }} install -y dnf-plugins-core;"},{"line_number":22,"context_line":"  {% endif %}"},{"line_number":23,"context_line":"  sudo {{ ansible_pkg_mgr }} clean all;"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_7503ebbf","line":20,"range":{"start_line":20,"start_character":3,"end_line":20,"end_character":12},"updated":"2019-06-17 17:07:48.000000000","message":"maybe better \"elif\", but not critical","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"repo_cmd_before: |"},{"line_number":18,"context_line":"  {% if ansible_pkg_mgr \u003d\u003d \"yum\" %}"},{"line_number":19,"context_line":"  sudo {{ ansible_pkg_mgr }} install -y yum-plugin-priorities;"},{"line_number":20,"context_line":"  {% else %}"},{"line_number":21,"context_line":"  sudo {{ ansible_pkg_mgr }} install -y dnf-plugins-core;"},{"line_number":22,"context_line":"  {% endif %}"},{"line_number":23,"context_line":"  sudo {{ ansible_pkg_mgr }} clean all;"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_69d9b320","line":20,"range":{"start_line":20,"start_character":3,"end_line":20,"end_character":12},"in_reply_to":"9fb8cfa7_7503ebbf","updated":"2019-06-19 10:29:36.000000000","message":"Done","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"}],"roles/repo-setup/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c319b6ecfc0365cb57310657e74944a0a6d378ff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  when: repo_inject_image_path is defined"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: validate repo-setup"},{"line_number":17,"context_line":"  uri:"},{"line_number":18,"context_line":"    url: https://trunk.rdoproject.org/{{ ansible_distribution|lower }}{{ ansible_distribution_major_version|lower }}-{{ release }}/{{ dlrn_hash_path|default(dlrn_hash_tag, true) }}"},{"line_number":19,"context_line":"    method: HEAD"},{"line_number":20,"context_line":"    status_code: 200"},{"line_number":21,"context_line":"  register: result"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- debug:"},{"line_number":24,"context_line":"    var: result"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_552b472f","line":21,"range":{"start_line":17,"start_character":4,"end_line":21,"end_character":18},"updated":"2019-06-17 17:07:48.000000000","message":"Not sure how it validates repo-setup role. The role create repo files, I think they should be validated.","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b8c23948069eeb318c25b1f407858e21434153f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  when: repo_inject_image_path is defined"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: validate repo-setup"},{"line_number":17,"context_line":"  uri:"},{"line_number":18,"context_line":"    url: https://trunk.rdoproject.org/{{ ansible_distribution|lower }}{{ ansible_distribution_major_version|lower }}-{{ release }}/{{ dlrn_hash_path|default(dlrn_hash_tag, true) }}"},{"line_number":19,"context_line":"    method: HEAD"},{"line_number":20,"context_line":"    status_code: 200"},{"line_number":21,"context_line":"  register: result"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- debug:"},{"line_number":24,"context_line":"    var: result"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_0987d7d9","line":21,"range":{"start_line":17,"start_character":4,"end_line":21,"end_character":18},"in_reply_to":"9fb8cfa7_552b472f","updated":"2019-06-19 10:29:36.000000000","message":"I agree with you but that is the minimal thing I could do to add some validation of the URL. \n\nI know that this may not catch other errors but is more than what we used to have.","commit_id":"de55091ba90f5e50625fe3d195e98f3252b7e5fc"}],"zuul.d/molecule.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"eae24c20fef804f3022ed0928e5fb60e0e6b7d8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      jobs:"},{"line_number":11,"context_line":"        - tripleo-ci-molecule"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- job:"},{"line_number":14,"context_line":"    name: tripleo-ci-molecule"},{"line_number":15,"context_line":"    nodeset: ubuntu-bionic"},{"line_number":16,"context_line":"    pre-run: playbooks/tox-molecule/pre-run.yml"},{"line_number":17,"context_line":"    run: playbooks/tox-molecule/run.yml"},{"line_number":18,"context_line":"    # side project(s) needed because have role dependencies in them"},{"line_number":19,"context_line":"    required-projects:"},{"line_number":20,"context_line":"      - openstack-infra/tripleo-quickstart-extras"},{"line_number":21,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5fc1f717_4d60b90e","line":21,"range":{"start_line":13,"start_character":2,"end_line":21,"end_character":0},"updated":"2019-03-29 12:46:42.000000000","message":"Unknown project openstack-infra/tripleo-quickstart-extras","commit_id":"68f537cd1b545c0697897a9b9615b20b1defc6ed"}]}