)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"da04df2b91338315e407f0f1d5b31c30e024cbe8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-05-20 13:52:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM, update dep installs for rhel-8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7b7dd615a5fb982395b7bcc77e2a764e17824233"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_e25b712b","line":8,"updated":"2019-05-21 12:15:04.000000000","message":"lets add https://tree.taiga.io/project/tripleo-ci-board/task/988","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"}],"bindep.txt":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8a0f1fef2ce369fe1f77b0f363e92cc16b823e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bfb3d3c7_4c77163c","updated":"2019-05-21 11:07:10.000000000","message":"i think this we keep as is","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a0a5e805373fdd9aa7dc05278bd0495dbb3221c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bfb3d3c7_d750630d","in_reply_to":"bfb3d3c7_4c77163c","updated":"2019-05-21 18:59:41.000000000","message":"yes - this stays","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"}],"install-deps.sh":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3e56cd9535c146f63fe1d0b1f9cba3f3168518f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            VIRTUALENV_PACKAGE\u003dpython3-virtualenv"},{"line_number":107,"context_line":"            PIP_PACKAGE\u003dpython3-pip"},{"line_number":108,"context_line":"        else"},{"line_number":109,"context_line":"            PYTHON_PACKAGES+\u003d(\"libselinux-python\")"},{"line_number":110,"context_line":"            SETUPTOOLS_PACKAGE\u003dpython-setuptools"},{"line_number":111,"context_line":"            VIRTUALENV_PACKAGE\u003dpython-virtualenv"},{"line_number":112,"context_line":"            PIP_PACKAGE\u003dpython-pip"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bfb3d3c7_c07aed22","side":"PARENT","line":109,"updated":"2019-05-21 08:02:14.000000000","message":"so why was the python_cmd conditional failing here why did you have to hard code it to py3","commit_id":"ea6191e46d7ffd22c791f8eddf4da675e3c4f704"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3e56cd9535c146f63fe1d0b1f9cba3f3168518f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    rpm -q sudo || $(package_manager) install -y sudo"},{"line_number":97,"context_line":"    sudo -n true \u0026\u0026 passwordless_sudo\u003d\"1\" || passwordless_sudo\u003d\"0\""},{"line_number":98,"context_line":"    if [[ \"$passwordless_sudo\" \u003d\u003d \"1\" ]] || [ \"$USER_OVERRIDE_SUDO_CHECK\" \u003d\u003d \"1\" ]; then"},{"line_number":99,"context_line":"        # possible bug in ansible, f29 python 3 env fails"},{"line_number":100,"context_line":"        # w/o both python-libselinux packages installed"},{"line_number":101,"context_line":"        # https://bugs.launchpad.net/tripleo/+bug/1812324"},{"line_number":102,"context_line":"        PYTHON_PACKAGES+\u003d(\"python3-libselinux\")"},{"line_number":103,"context_line":"        PYTHON_PACKAGES+\u003d(\"python3-PyYAML\")"},{"line_number":104,"context_line":"        SETUPTOOLS_PACKAGE\u003dpython3-setuptools"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bfb3d3c7_0089e521","line":101,"range":{"start_line":99,"start_character":15,"end_line":101,"end_character":47},"updated":"2019-05-21 08:02:14.000000000","message":"if we are going to keep this part of the review (do we care about f29 - as long as it doesn\u0027t break f28 jobs right?) then also remove reference to the bug since you\u0027re removed the workaround for it","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"}],"roles/tripleo-inventory/tasks/inventory.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f3e56cd9535c146f63fe1d0b1f9cba3f3168518f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        ansible_user: \"{{ overcloud_user | default(\u0027heat-admin\u0027) }}\""},{"line_number":39,"context_line":"        ansible_private_key_file: \"{{ overcloud_key }}\""},{"line_number":40,"context_line":"        ansible_ssh_extra_args: \u0027-F \"{{ local_working_dir }}/ssh.config.ansible\"\u0027"},{"line_number":41,"context_line":"        ansible_python_interpreter: \"/usr/bin/{{ lookup(\u0027env\u0027,\u0027python_cmd\u0027) }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- when: inventory \u003d\u003d \u0027multinode\u0027"},{"line_number":44,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_208f4924","line":41,"updated":"2019-05-21 08:02:14.000000000","message":"this bit we can keep i think","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8a0f1fef2ce369fe1f77b0f363e92cc16b823e0a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        ansible_user: \"{{ overcloud_user | default(\u0027heat-admin\u0027) }}\""},{"line_number":39,"context_line":"        ansible_private_key_file: \"{{ overcloud_key }}\""},{"line_number":40,"context_line":"        ansible_ssh_extra_args: \u0027-F \"{{ local_working_dir }}/ssh.config.ansible\"\u0027"},{"line_number":41,"context_line":"        ansible_python_interpreter: \"/usr/bin/{{ lookup(\u0027env\u0027,\u0027python_cmd\u0027) }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- when: inventory \u003d\u003d \u0027multinode\u0027"},{"line_number":44,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_ecafea91","line":41,"in_reply_to":"bfb3d3c7_208f4924","updated":"2019-05-21 11:07:10.000000000","message":"well, I\u0027m trying to set it there https://code.engineering.redhat.com/gerrit/#/c/167407/9/config/release/rhos-15.yml@10 now if it works can we remove this? or maybe make it ansible_python_interpreter: {{ ansible_python_interpreter|default ... }}","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"a0a5e805373fdd9aa7dc05278bd0495dbb3221c6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        ansible_user: \"{{ overcloud_user | default(\u0027heat-admin\u0027) }}\""},{"line_number":39,"context_line":"        ansible_private_key_file: \"{{ overcloud_key }}\""},{"line_number":40,"context_line":"        ansible_ssh_extra_args: \u0027-F \"{{ local_working_dir }}/ssh.config.ansible\"\u0027"},{"line_number":41,"context_line":"        ansible_python_interpreter: \"/usr/bin/{{ lookup(\u0027env\u0027,\u0027python_cmd\u0027) }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- when: inventory \u003d\u003d \u0027multinode\u0027"},{"line_number":44,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_3741bf3a","line":41,"in_reply_to":"bfb3d3c7_ecafea91","updated":"2019-05-21 18:59:41.000000000","message":"removing this","commit_id":"3244115abd7ecf70b5b2045a048331f6fc08ba88"}]}