)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8316e0ad7c625d5e950b7a6ece6b96a9fa207432","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    virsh vol-info --pool \u0027{{ libvirt_volume_pool }}\u0027"},{"line_number":16,"context_line":"    \u0027{{ supplemental_node.name }}.qcow2\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And because virt-install creates a pool of it\u0027s choosing unknown to"},{"line_number":19,"context_line":"oooq the pool is never cleaned up, a resource leakage."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch uses virsh to create the supplemental volume in the"},{"line_number":22,"context_line":"libvirt_volume_pool where all the other node volumes are located and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_05eb4512","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":54},"updated":"2019-08-25 09:47:35.000000000","message":"this sentence is completely unclear to me","commit_id":"8298e3775254840cf0a36cfb5f26f92770ca980a"},{"author":{"_account_id":8116,"name":"John Dennis","email":"jdennis@redhat.com","username":"jdennis"},"change_message_id":"3a84e4aec4dda8b74cf25c1ece6c38b001f7eeb0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    virsh vol-info --pool \u0027{{ libvirt_volume_pool }}\u0027"},{"line_number":16,"context_line":"    \u0027{{ supplemental_node.name }}.qcow2\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And because virt-install creates a pool of it\u0027s choosing unknown to"},{"line_number":19,"context_line":"oooq the pool is never cleaned up, a resource leakage."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch uses virsh to create the supplemental volume in the"},{"line_number":22,"context_line":"libvirt_volume_pool where all the other node volumes are located and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_131141b0","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":54},"in_reply_to":"7faddb67_05eb4512","updated":"2019-08-26 17:08:07.000000000","message":"What I was trying to say succinctly is this: If you don\u0027t specify a pool virt-install will manufacture one for you under the covers and use it as a favor. However, the virt-install manufactured pool is not known to oooq. During the clean up phase of oooq it will destroy resources it knows about (including the libvirt_volume_pool). But because the pool manufactured by virt-install is not present in the set of resources oooq will deallocate during clean up the pool is effectively orphaned and hence is a leaked resource.","commit_id":"8298e3775254840cf0a36cfb5f26f92770ca980a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"383bc336ffc8b8a824f578530c677df5837054c5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    virsh vol-info --pool \u0027{{ libvirt_volume_pool }}\u0027"},{"line_number":16,"context_line":"    \u0027{{ supplemental_node.name }}.qcow2\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And because virt-install creates a pool of it\u0027s choosing unknown to"},{"line_number":19,"context_line":"oooq the pool is never cleaned up, a resource leakage."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch uses virsh to create the supplemental volume in the"},{"line_number":22,"context_line":"libvirt_volume_pool where all the other node volumes are located and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_1b6e1300","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":54},"in_reply_to":"7faddb67_131141b0","updated":"2019-08-28 13:32:53.000000000","message":"I think you could write this in commit, we\u0027re not limited in commit length :) But up to you, not critical","commit_id":"8298e3775254840cf0a36cfb5f26f92770ca980a"}]}