)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9335f314d2cf07086a81a3b841e9c158e19599e5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-01-15 11:24:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding molecule test for fetch-images role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I53bbbfa17203191b98595b2125dee3bf312fd912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_1ccd9eb9","line":8,"updated":"2020-01-20 08:34:06.000000000","message":"# COOL_STORY_BRO!","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be5c02a1ca98bbc6ef9ad0f53b5f2812a161cf0a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-01-20 09:50:30 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding molecule test for fetch-images role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I53bbbfa17203191b98595b2125dee3bf312fd912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_9aadfda5","line":8,"updated":"2020-01-21 09:08:54.000000000","message":"please add a sentence - for your consideration: \"adds a molecule scenario using the docker driver for the fetch-images role. Avoids fetching from network and uses file:://  ... \"","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"}],"roles/fetch-images/defaults/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c31583d8c483c59743d55a0ca953a0e2cf251dc7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: centos-7-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_21ff4bb2","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":24},"updated":"2020-01-15 14:49:45.000000000","message":"it looks like cirros image below. And why do we need it in defaults?","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"60d20545c6a556c7f75f0dbe5e12e8eae560cc68","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: centos-7-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_41a047a5","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":24},"in_reply_to":"3fa7e38b_21ff4bb2","updated":"2020-01-15 14:55:36.000000000","message":"Best practice, there\u0027s no defaults for images, so if it\u0027s unset, it will fail","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9335f314d2cf07086a81a3b841e9c158e19599e5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: centos-7-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_bcbb2a0e","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":24},"in_reply_to":"3fa7e38b_41a047a5","updated":"2020-01-20 08:34:06.000000000","message":"ok but please let\u0027s call it cirros-image since that\u0027s what it is set to? Or i\u0027m missing something","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c6b29997c482dd45cf9bfecfc772d9b8dc056051","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: centos-7-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_7ce932a9","line":8,"range":{"start_line":8,"start_character":10,"end_line":8,"end_character":24},"in_reply_to":"3fa7e38b_bcbb2a0e","updated":"2020-01-20 09:00:37.000000000","message":"Yeah, if it\u0027s cirros let\u0027s call it cirros :)","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e7384d2324430820226864c317f45093f40e8b1d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: cirros-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_fc0be278","line":11,"range":{"start_line":8,"start_character":2,"end_line":11,"end_character":46},"updated":"2020-01-20 09:05:22.000000000","message":"let\u0027s just leave it empty if it\u0027s not used, I don\u0027t think we need to put here data that we never use.","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"af039907ea6cd8b7887a36456796058c210a8fa4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: cirros-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_e326cc22","line":11,"range":{"start_line":8,"start_character":2,"end_line":11,"end_character":46},"in_reply_to":"3fa7e38b_5ca6b656","updated":"2020-01-21 12:17:26.000000000","message":"That\u0027s totally fine to put this example in README of the role, but not in defaults.","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5413ac98bb9c8cb6215ba581b45a3049fe12523d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"image_cache_expire_days: 14"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"images:"},{"line_number":8,"context_line":"  - name: cirros-image"},{"line_number":9,"context_line":"    url: \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\""},{"line_number":10,"context_line":"    type: img"},{"line_number":11,"context_line":"    md5sum: \u0027ee1eca47dc88f4879d8a229cc70a07c6\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5ca6b656","line":11,"range":{"start_line":8,"start_character":2,"end_line":11,"end_character":46},"in_reply_to":"3fa7e38b_fc0be278","updated":"2020-01-20 09:14:55.000000000","message":"I rather not, this is good for documentation as well, it took me a while to understand what the variable images is a list of dictionaries with these keys (name, url, type and md5sum).","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"}],"roles/fetch-images/molecule/default/playbook.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c31583d8c483c59743d55a0ca953a0e2cf251dc7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Create stack user (required to test this role)"},{"line_number":6,"context_line":"      user:"},{"line_number":7,"context_line":"        name: stack"},{"line_number":8,"context_line":"        comment: Stack user"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Create dummy image file"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_e1d61327","line":7,"range":{"start_line":5,"start_character":5,"end_line":7,"end_character":19},"updated":"2020-01-15 14:49:45.000000000","message":"it\u0027s not required for this role, we use zuul user with it in CI","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"60d20545c6a556c7f75f0dbe5e12e8eae560cc68","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Create stack user (required to test this role)"},{"line_number":6,"context_line":"      user:"},{"line_number":7,"context_line":"        name: stack"},{"line_number":8,"context_line":"        comment: Stack user"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - name: Create dummy image file"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_e1ab736e","line":7,"range":{"start_line":5,"start_character":5,"end_line":7,"end_character":19},"in_reply_to":"3fa7e38b_e1d61327","updated":"2020-01-15 14:55:36.000000000","message":"Yes, but the test run in a docker container, that doesn\u0027t have the zuul user, so it fails because there\u0027s no noon root user. When run using zuul vm image, this is not required.","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"34e5becaa1ca2d84ef38cc84d53477e384725ee1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          - name: centos-7-image"},{"line_number":24,"context_line":"            url: \"file:///tmp/image-test.img\""},{"line_number":25,"context_line":"            type: img"},{"line_number":26,"context_line":"            md5sum: \u0027d3b07384d113edec49eaa6238ad5ff00\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_4314d250","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":53},"updated":"2020-01-15 10:29:49.000000000","message":"That is not ok. You should not repeat the value of the default value here, the scope is to test the defaults.\n\nYou either call the role with both URL+md5, or none but clearly you do not want to create a tight coupling between values from defaults and your test.\n\nOtherwise you force anyone updating the defaults to update the test, even if he put the correct md5 in the defaults.","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"0c93dd182c8a6f92fdba896ec7649eeae78c934b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          - name: centos-7-image"},{"line_number":24,"context_line":"            url: \"file:///tmp/image-test.img\""},{"line_number":25,"context_line":"            type: img"},{"line_number":26,"context_line":"            md5sum: \u0027d3b07384d113edec49eaa6238ad5ff00\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_aea80dda","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":53},"in_reply_to":"3fa7e38b_4314d250","updated":"2020-01-15 10:37:52.000000000","message":"i did not get, i\u0027m adding a dummy one there because we should not rely on download the image, plus, the time will increase","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"7f2b5000d3d60a728ba3555d072ce91375174302","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          - name: centos-7-image"},{"line_number":24,"context_line":"            url: \"file:///tmp/image-test.img\""},{"line_number":25,"context_line":"            type: img"},{"line_number":26,"context_line":"            md5sum: \u0027d3b07384d113edec49eaa6238ad5ff00\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8cd74ff5","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":53},"in_reply_to":"3fa7e38b_aea80dda","updated":"2020-01-15 22:09:16.000000000","message":"I think Sorin is saying both the image and md5sum should be default variables just in case someone wants to try their own url fwiw :)","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f06ae6547ed1ffa646b825ba8f55d29b7e9aa8b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      vars:"},{"line_number":20,"context_line":"        # This image is not a real image, it\u0027s just for"},{"line_number":21,"context_line":"        # test purpose"},{"line_number":22,"context_line":"        images:"},{"line_number":23,"context_line":"          - name: centos-7-image"},{"line_number":24,"context_line":"            url: \"file:///tmp/image-test.img\""},{"line_number":25,"context_line":"            type: img"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_fbb2e104","line":22,"updated":"2020-01-22 07:47:30.000000000","message":"maybe add image_cache_dir into vars pointing to somewhere you will be able to assert? This is with respect to the discussion in https://review.opendev.org/#/c/681211/4..6/roles/fetch-images/molecule/default/verify.yml","commit_id":"748291acc03063b0558fe18e5cfdff3327d4edef"}],"roles/fetch-images/molecule/default/verify.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c31583d8c483c59743d55a0ca953a0e2cf251dc7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_c1dd1740","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":16},"updated":"2020-01-15 14:49:45.000000000","message":":)","commit_id":"366a489da4842b0f67a629cbab8263cc1d455506"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e7384d2324430820226864c317f45093f40e8b1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_dc086681","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"updated":"2020-01-20 09:05:22.000000000","message":"can we at least check that it\u0027s downloaded?","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"af039907ea6cd8b7887a36456796058c210a8fa4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_c30ab076","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"in_reply_to":"3fa7e38b_1a6fcd61","updated":"2020-01-21 12:17:26.000000000","message":"Ok, but is there any way to check that role actually worked? Otherwise what is the point in having molecule test for it if it doesn\u0027t test actually?","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"a5babc184c566516a04176938d5c1733ab6077b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1a6fcd61","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"in_reply_to":"3fa7e38b_3a1089f4","updated":"2020-01-21 09:12:49.000000000","message":"There\u0027s no cache dir in the docker image...","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f06ae6547ed1ffa646b825ba8f55d29b7e9aa8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1bb81de6","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"in_reply_to":"3fa7e38b_c30ab076","updated":"2020-01-22 07:47:30.000000000","message":"hmmm so i can see the tasks being executed at https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b80/681211/6/check/openstack-tox-molecule/b8055d9/tox/reports.html\n\nand looks like the image ends up in /var/cache\n\nyou can control where it gets cached to with image_cache_dir\nso maybe set a different path that your container can reach and then you can assert that?","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5413ac98bb9c8cb6215ba581b45a3049fe12523d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_fcb5227e","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"in_reply_to":"3fa7e38b_dc086681","updated":"2020-01-20 09:14:55.000000000","message":"This will make the test rely on a internet connection, usually, the image is already cached by other job. I don\u0027t know if that\u0027s what we want to test here. What do you think?","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be5c02a1ca98bbc6ef9ad0f53b5f2812a161cf0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Verify"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3a1089f4","line":9,"range":{"start_line":7,"start_character":2,"end_line":9,"end_character":16},"in_reply_to":"3fa7e38b_fcb5227e","updated":"2020-01-21 09:08:54.000000000","message":"I am fine with using file:// @ https://review.opendev.org/#/c/681211/4/roles/fetch-images/molecule/default/playbook.yml\n\nBUT\n\nwhat about adding some assertions that the image was fetched correctly though? the image cache dir should be checked etc?","commit_id":"421fc40d4615cfc3869b21c87b339ba489559899"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d5c3d8e29db7824ddffb511cdbbc31794e785973","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - name: Example assertion"},{"line_number":8,"context_line":"    assert:"},{"line_number":9,"context_line":"      that: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_3abe49ce","line":9,"updated":"2020-01-21 09:09:54.000000000","message":"seems you updated as i was reviewing v4 please check my comments there thanks","commit_id":"d8efa47fc60518e167e8707b5604e61cec5e3eb8"}]}