)]}'
{"config/general_config/featureset038.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"5771d8d40d5eee7891dd72b8ee059e02bdfd4589","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  {% if release in [\u0027queens\u0027, \u0027rocky\u0027] -%}"},{"line_number":131,"context_line":"  \u0027/usr/share/openstack-octavia-amphora-images/amphora-x64-haproxy.qcow2\u0027"},{"line_number":132,"context_line":"  {%- else -%}"},{"line_number":133,"context_line":"  {{ working_dir }}/amphora.qcow2"},{"line_number":134,"context_line":"  {%- endif -%}"},{"line_number":135,"context_line":"test_ping: false"},{"line_number":136,"context_line":"download_amphora: true"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_c8535d14","line":133,"updated":"2020-01-08 18:52:42.000000000","message":"So if this variable is required in more than just this one featureset, you have some options.\n\nIf it\u0027s just for upstream ci and not something a user would want or need. ( not recommended )\n\nhttps://opendev.org/openstack/tripleo-ci/src/branch/master/toci-quickstart/config/testenv/multinode.yml\n\nIf you want the variable to generally be available to any job or any run for the overcloud deployment. Feel free to move it here:\n\nhttps://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/roles/extras-common/defaults/main.yml\n\nIf you only want the feature enabled in certain featuresets you can have the path always defined, but a toggle variable like.. \"use_amphora\" in the featureset.","commit_id":"77045d6b2006787a2eb215cc18114e4fc3d710b4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"02fd52afdb4f185930e810ca548cab0db3235c9a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  {% if release in [\u0027queens\u0027, \u0027rocky\u0027] -%}"},{"line_number":131,"context_line":"  \u0027/usr/share/openstack-octavia-amphora-images/amphora-x64-haproxy.qcow2\u0027"},{"line_number":132,"context_line":"  {%- else -%}"},{"line_number":133,"context_line":"  {{ working_dir }}/amphora.qcow2"},{"line_number":134,"context_line":"  {%- endif -%}"},{"line_number":135,"context_line":"test_ping: false"},{"line_number":136,"context_line":"download_amphora: true"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_fe882126","line":133,"in_reply_to":"3fa7e38b_c8535d14","updated":"2020-02-17 16:26:08.000000000","message":"It is only relevant to octavia feature sets and while introduced for the purposed of CI, it is generally usable for any octavia deployment using quickstart - so it looks like option 2 is the better choice. Thanks! It also means the var can be put in the patch where it is first used, fwict making this unnecessary","commit_id":"77045d6b2006787a2eb215cc18114e4fc3d710b4"}]}