)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"782df4b870bbb39c095d63416de775b12c432774","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle pip being installed as /usr/bin/pip3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a thing that centos-8 does"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic53be3203a1d4d75df3e26e70629ab6344b45280"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_568f2320","line":9,"updated":"2020-02-12 07:09:39.000000000","message":"#cool story bro ;)","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"}],"install-deps.sh":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"b1e0a95164c523139b3dd509a82ad388355fe962","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            sudo easy_install pip"},{"line_number":148,"context_line":"        else"},{"line_number":149,"context_line":"            sudo $(package_manager) install $PIP_PACKAGE"},{"line_number":150,"context_line":"            if [ -e \"/usr/bin/pip3\" ] \u0026\u0026 [ ! -e \"/usr/bin/pip\" ]; then"},{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_d8f276e4","line":153,"range":{"start_line":150,"start_character":0,"end_line":153,"end_character":14},"updated":"2020-02-11 07:04:21.000000000","message":"That is clearly interesting but I am not sure if it would not create problems. Do we have any systems where we need more than a single version of python?","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"782df4b870bbb39c095d63416de775b12c432774","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            sudo easy_install pip"},{"line_number":148,"context_line":"        else"},{"line_number":149,"context_line":"            sudo $(package_manager) install $PIP_PACKAGE"},{"line_number":150,"context_line":"            if [ -e \"/usr/bin/pip3\" ] \u0026\u0026 [ ! -e \"/usr/bin/pip\" ]; then"},{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_d66d5368","line":153,"range":{"start_line":150,"start_character":0,"end_line":153,"end_character":14},"in_reply_to":"3fa7e38b_91792d82","updated":"2020-02-12 07:09:39.000000000","message":"i had to go read up on alternatives a bit... should the priority be higher ... though probably not going to be that many pip alternative here ;)","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"186a8609d166318ad11647e9c87e59800569345e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            sudo easy_install pip"},{"line_number":148,"context_line":"        else"},{"line_number":149,"context_line":"            sudo $(package_manager) install $PIP_PACKAGE"},{"line_number":150,"context_line":"            if [ -e \"/usr/bin/pip3\" ] \u0026\u0026 [ ! -e \"/usr/bin/pip\" ]; then"},{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_91792d82","line":153,"range":{"start_line":150,"start_character":0,"end_line":153,"end_character":14},"in_reply_to":"3fa7e38b_d8f276e4","updated":"2020-02-11 19:56:24.000000000","message":"If the py2.7 pip is installed as /usr/bin/pip then this block won\u0027t trigger, if it is installed as /usr/bin/pip2 then I think it is reasonable that the py3 pip is available as the default pip, and pip2 is still able to be run.","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"782df4b870bbb39c095d63416de775b12c432774","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    MISSING_MODULES\u003d()"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_369aa75f","line":154,"updated":"2020-02-12 07:09:39.000000000","message":"wondering if your logic needs to be outside the if..else altogether i.e. even if easy_install pip we might need to do the alternatives install?","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"7a4ae10e9bd7c8638a5a346e850b7088a4ccf75b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    MISSING_MODULES\u003d()"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_7dfa2944","line":154,"in_reply_to":"3fa7e38b_17bd1466","updated":"2020-02-13 10:11:20.000000000","message":"Stop using pip/virtualenv and call them only as modules, that is the only portable way. There are too many possible variations for command names and locations.\n\nAvoid calling a command, when you can rely on python to find the module.","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"639cf98986a4098e04835e24240cd0f524268967","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    MISSING_MODULES\u003d()"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_9c913253","line":154,"in_reply_to":"3fa7e38b_369aa75f","updated":"2020-02-12 18:55:22.000000000","message":"I\u0027m assuming the /usr/bin/pip3 is a rpm policy thing where all python packages come as python3-* and python2-* variants and need to be parallel installable.\n\neasy_install is from the python ecosystem, so it will always install /usr/bin/pip which whatever default python.","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f75582c883fc66429eaab3b5e34dcaef5e67766a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                # centos-8 installs pip as pip3"},{"line_number":152,"context_line":"                sudo alternatives --install /usr/bin/pip pip /usr/bin/pip3 1"},{"line_number":153,"context_line":"            fi"},{"line_number":154,"context_line":"        fi"},{"line_number":155,"context_line":"    }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    MISSING_MODULES\u003d()"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_17bd1466","line":154,"in_reply_to":"3fa7e38b_9c913253","updated":"2020-02-13 07:34:22.000000000","message":"thanks makes sense.\n\ndont change it, but if you did it should still be fine, i.e. if your assumption is correct you\u0027d catch it with your \"\u0026 !\u003d /usr/bin/pip\" ... if your assumption is incorrect then we\u0027d still get the behaviour you want, i.e. it\u0027d do alternatives if there is no /usr/bin/pip/","commit_id":"c0c068c0ae0b24433f2d6b93537136d12f79dff2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8aa367f128b8154b39891ab59a7dc9d285c8a645","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    # the option is provided."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    # Allow to user to override the python version"},{"line_number":252,"context_line":"    export USER_PYTHON_OVERRIDE\u003dpython2"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    # This will allow the user to be prompted for commands"},{"line_number":255,"context_line":"    # requiring sudo vs. skipping the install assuming the"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_942752b7","side":"PARENT","line":252,"updated":"2020-03-16 08:19:41.000000000","message":"not really looked at this recently or i can\u0027t remember... but it isn\u0027t even interactive I mean isn\u0027t that just hard-coding python2? so what is \u0027Allow to user to override\u0027 about","commit_id":"7db44e9456c0d65fcb926ad4e07224846659d135"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6ed112395487cb241940aae71eeb0a637906a820","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    # the option is provided."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    # Allow to user to override the python version"},{"line_number":252,"context_line":"    export USER_PYTHON_OVERRIDE\u003dpython2"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    # This will allow the user to be prompted for commands"},{"line_number":255,"context_line":"    # requiring sudo vs. skipping the install assuming the"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_99df7e39","side":"PARENT","line":252,"in_reply_to":"1fa4df85_942752b7","updated":"2020-03-16 19:45:14.000000000","message":"Exactly, this seems to be providing a variable for the user to set then hard coding the value in everything which calls it","commit_id":"7db44e9456c0d65fcb926ad4e07224846659d135"}]}