)]}'
{"config/general_config/featureset064.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"312f52ae06b3b88dc5a0aa19607884a16c4d047e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_3bcae619","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"updated":"2020-03-18 07:43:25.000000000","message":"is that the only difference from featureset062?\n\nif so we can perhaps not use a new featureset and instead pass it with featureset_override.\n\nIf that is the only difference I can help you do that ^^ instead. [m@localhost general_config]$ diff featureset062.yml featureset064.yml \n1,5c1,3\n\u003c ####################################################################################################\n\u003c # FEATURESET062 - TRIPLEO STANDALONE FOR OCTAVIA - TRACKS SCENARIO 10\n\u003c # This is a modified version of featureset 052 (standalone) so changes made\n\u003c # to that featureset should be examined to see if they are relevant here.\n\u003c ####################################################################################################\n---\n\u003e ########################################################\n\u003e # FEATURESET064 - TRIPLEO STANDALONE UPGRADE FOR OCTAVIA\n\u003e ########################################################\n11,14d8\n\u003c toci_vxlan_networking: false\n\u003c enable_vbmc: false\n\u003c deploy_supplemental_node: false\n\u003c undercloud_setup: true\n19a14,23\n\u003e # docker / podman configuration\n\u003e standalone_container_cli: \u003e-\n\u003e   {% if release in [\u0027rocky\u0027] -%}\n\u003e   docker\n\u003e   {%- else -%}\n\u003e   podman\n\u003e   {%- endif -%}\n\u003e \n\u003e standalone_upgrade: true\n\u003e \n40a45\n\u003e tempest_os_cloud: standalone\n50,57d54\n\u003c tempest_os_cloud: standalone\n\u003c \n\u003c standalone_container_cli: \u003e-\n\u003c   {% if release in [\u0027rocky\u0027] -%}\n\u003c   docker\n\u003c   {%- else -%}\n\u003c   podman\n\u003c   {%- endif -%}","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"638274db855e31956230e8e9507188c04d00f05d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_b486d312","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"in_reply_to":"1fa4df85_34c4235f","updated":"2020-03-19 08:42:07.000000000","message":"Ok, I am supportive of allowing override of that flag. I thought that having it blacklisted was intentional and for a good reason. I\u0027ll submit a patch asap.","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"28a27002724e767ee468ff436988b615904e1ff1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_4c3a8a98","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"in_reply_to":"1fa4df85_3bcae619","updated":"2020-03-18 10:21:50.000000000","message":"Yes,\"standalone_upgrade\" is the only difference. We cannot reuse same featureset. See https://review.opendev.org/#/c/710473/2/zuul.d/standalone-jobs.yaml@626","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6455d0712f9266f991af611bf9e14fe40910d585","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_34c4235f","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"in_reply_to":"1fa4df85_4c3a8a98","updated":"2020-03-19 08:38:56.000000000","message":"we can fix that though and add standalone-upgrade into the allowed featureset_override list see my comment at https://review.opendev.org/#/c/710473/2/zuul.d/standalone-jobs.yaml@626\n\nthat\u0027s what i meant by ping me we can add it if that is the only difference","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ce2e148abb9c72fd2c5b3dde88a22f81288c21fd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_b437b34d","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"in_reply_to":"1fa4df85_9498776a","updated":"2020-03-19 08:54:55.000000000","message":"https://review.opendev.org/713801","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d22b349b316d03ca827535c02eb9bcb281f032e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  podman"},{"line_number":20,"context_line":"  {%- endif -%}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"standalone_upgrade: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# custom env files"},{"line_number":25,"context_line":"standalone_custom_env_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_9498776a","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":22},"in_reply_to":"1fa4df85_b486d312","updated":"2020-03-19 08:47:22.000000000","message":"i just added folks from the tripleo-ci team so they can\u0027t complain about it later and ping the oooq channel ... for the record ;)\n\n10:40 \u003c marios\u003e fellow tripleo-ci folks please check https://review.opendev.org/#/c/710556/2 when you get a chance (I just added you)  cgoncalves is adding a new FS but the only diff is \u0027standalone-upgrade\u0027 so IMO we should just add to allowed_overrides\n\n\n\nso it *used* to be that featuresets were the single source of truth for the features in a job. However we recently started allowing featureset_overrides, especially when jobs had the same featureset but different (tripleo-heat-template) environment files.\n\nNot everyone in the team is happy with that which is why i added them here. However since we started adding the overrides we\u0027ve just continued to add them in the allowed list \u0027as the need arises\u0027.\n\nI think avoiding to maintain an extra featureset, update it everytime somethign changes in the deployment/new version whatever, is a good enough reason here.","commit_id":"1a4ee6e39c9a4fab07db43173c72c5aca53d4093"}]}