)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"192bf5392046f00e0fdfb354f81f1d7b4f2d90de","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We use these a lot and are duplicating unnecessarily across"},{"line_number":10,"context_line":"multiple files hurting  maintainability and making errors likely"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6f48aaf198cbfba8d8099c84aa3d769767bdd0ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_25bf7aaa","line":11,"updated":"2020-04-02 08:42:20.000000000","message":"posted this after reviewing https://review.opendev.org/#/c/713753/3","commit_id":"b37d5e29ddda92c96a74c872046895c163c4eb22"}],"roles/repo-setup/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0d381111f939ac1c7873cedf4aba4de02a20dd5a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - promoted-components"},{"line_number":64,"context_line":"  - component-ci-testing"},{"line_number":65,"context_line":"expected_commit_distro_hash_regex: \"[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}\""},{"line_number":66,"context_line":"expected_commit_hash_regex: \"[a-zA-Z0-9]{32}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_1a43ad43","line":66,"updated":"2020-04-02 13:24:14.000000000","message":"see ykarel comments at \nhttps://review.opendev.org/#/c/713753/3/roles/repo-setup/tasks/get-dlrn-hash.yml@7\n\nlets add ^$ into those\n\n16:23 \u003c marios\u003e ykarel: yeah i see what you mean by $ will help \n16:23 \u003c openstackgerrit\u003e Takashi Kajinami proposed openstack/puppet-tripleo master: Autonatically set memcache_servers for keystone \n                         cache  https://review.opendev.org/716999\n16:23 \u003c marios\u003e ykarel: i can \u0027fix\u0027 in the followup (my patch)","commit_id":"b37d5e29ddda92c96a74c872046895c163c4eb22"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ea0578df4cc113ba79fe25f102cad801dd49f7f6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - promoted-components"},{"line_number":64,"context_line":"  - component-ci-testing"},{"line_number":65,"context_line":"expected_commit_distro_hash_regex: \"[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\""},{"line_number":66,"context_line":"expected_commit_hash_regex: \"[a-zA-Z0-9]{32}$\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_9ad5fd1e","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":13},"updated":"2020-04-02 13:29:32.000000000","message":"16:24 \u003c ykarel\u003e marios, also that is not commit hash, more good to use aggregate_hash\n16:26 \u003c ykarel\u003e marios, yes i mean for name of expected_commit_hash_regex: \"[a-zA-Z0-9]{32}$\"\n16:26 \u003c ykarel\u003e also use ^ as start\n16:26 \u003c ykarel\u003e else it will not be strict\n16:26 \u003c ykarel\u003e expected_agg_hash_regex: \"^[a-zA-Z0-9]{32}$\"\n16:27 \u003c ykarel\u003e like ^^ or aggregate_hash instead of agg_hash\n16:28 \u003c marios\u003e ykarel: ack","commit_id":"4a8430a54f44943b27aeb4cf4906473ec0c60820"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6b2ffa2dfb9c95f0648029941ea3e73336e9c81a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - promoted-components"},{"line_number":64,"context_line":"  - component-ci-testing"},{"line_number":65,"context_line":"expected_commit_distro_hash_regex: \"[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\""},{"line_number":66,"context_line":"expected_aggregate_hash_regex: \"[a-zA-Z0-9]{32}$\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_7c0c6693","line":66,"updated":"2020-04-03 06:25:57.000000000","message":"for expected_aggregate_hash_regex we need ^ in beginning as this is subset of other regex. In last comment i mentioned only expected_commit_distro_hash_regex.","commit_id":"9b9fc1a06494d8b1ae5570f2c1bce872d2e7ff08"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6f80f118eb2132a133eef87a4a2c03d45c558520","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - promoted-components"},{"line_number":64,"context_line":"  - component-ci-testing"},{"line_number":65,"context_line":"expected_commit_distro_hash_regex: \"[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\""},{"line_number":66,"context_line":"expected_aggregate_hash_regex: \"[a-zA-Z0-9]{32}$\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_5b5ebbe9","line":66,"in_reply_to":"df33271e_7c0c6693","updated":"2020-04-03 16:05:53.000000000","message":"ack \u0027full match\u0027 if its the aggregate gotcha","commit_id":"9b9fc1a06494d8b1ae5570f2c1bce872d2e7ff08"}],"roles/repo-setup/tasks/get-dlrn-hash-newest.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ba72852a77024e385b1009819f7b809cf8c32716","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          dlrn_base\u003d${dlrn_base/https:\\/\\/trunk.rdoproject.org/$NODEPOOL_RDO_PROXY}"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        curl -s --fail --show-error ${dlrn_base}/{{ dlrn_hash_tag_newest }}/delorean.repo \\"},{"line_number":32,"context_line":"        | grep baseurl | grep -Eo {{ expected_commit_distro_hash_regex }}"},{"line_number":33,"context_line":"      register: full_hash_newest_result"},{"line_number":34,"context_line":"      retries: 5"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_e423cb54","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":73},"updated":"2020-04-02 14:58:20.000000000","message":"this will not work with \"^[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\" as baseurl do not start with commit_distro_hash it just ends with it. for commit_distro_hash case u can remove ^$","commit_id":"f5a7d7f05863016379206b6ffba08bd2fc067135"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"dcbdb3483abecdfc3b57f845f755e2922c389216","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          dlrn_base\u003d${dlrn_base/https:\\/\\/trunk.rdoproject.org/$NODEPOOL_RDO_PROXY}"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        curl -s --fail --show-error ${dlrn_base}/{{ dlrn_hash_tag_newest }}/delorean.repo \\"},{"line_number":32,"context_line":"        | grep baseurl | grep -Eo {{ expected_commit_distro_hash_regex }}"},{"line_number":33,"context_line":"      register: full_hash_newest_result"},{"line_number":34,"context_line":"      retries: 5"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_7c0d86e6","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":73},"in_reply_to":"df33271e_e423cb54","updated":"2020-04-03 05:54:13.000000000","message":"Done","commit_id":"f5a7d7f05863016379206b6ffba08bd2fc067135"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"88b73bb84f8de6785786cfa8499d9c83edaafad0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          dlrn_base\u003d${dlrn_base/https:\\/\\/trunk.rdoproject.org/$NODEPOOL_RDO_PROXY}"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        curl -s --fail --show-error ${dlrn_base}/{{ dlrn_hash_tag_newest }}/delorean.repo \\"},{"line_number":32,"context_line":"        | grep baseurl | grep -Eo {{ expected_commit_distro_hash_regex }}"},{"line_number":33,"context_line":"      register: full_hash_newest_result"},{"line_number":34,"context_line":"      retries: 5"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_8895048a","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":73},"updated":"2020-04-09 17:18:08.000000000","message":"You miss the quotes, probalby you want \"| quote\", see https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html","commit_id":"97a4242f1a4007c2396d51897bdb2af2cf79fedb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cf15134469160f989541cefad1059b4a7e9f54ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          dlrn_base\u003d${dlrn_base/https:\\/\\/trunk.rdoproject.org/$NODEPOOL_RDO_PROXY}"},{"line_number":30,"context_line":"        fi"},{"line_number":31,"context_line":"        curl -s --fail --show-error ${dlrn_base}/{{ dlrn_hash_tag_newest }}/delorean.repo \\"},{"line_number":32,"context_line":"        | grep baseurl | grep -Eo {{ expected_commit_distro_hash_regex }}"},{"line_number":33,"context_line":"      register: full_hash_newest_result"},{"line_number":34,"context_line":"      retries: 5"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df33271e_f6ec6abc","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":73},"in_reply_to":"df33271e_8895048a","updated":"2020-04-10 08:23:13.000000000","message":"hmm... nice catch ... i was wondering about just adding \" but looks like it doesn\u0027t work as nicely (that leads to escaped \\\"):\n\nwith \n\ngrep baseurl | grep -Eo \"{{ expected_commit_distro_hash_regex }}\"$\n\n\nTASK [debug] *********************************************************************************************\nok: [127.0.0.1] \u003d\u003e {\n    \"a_fact\": \"curl -s --fail --show-error ${HOME}/Downloads/playbook/play.yaml \\\\\\n| grep baseurl | grep -Eo \\\"[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\\\"\\n\"\n}\n\n\nbut with  | quote its nicer \n\n\n\n\nTASK [debug] *********************************************************************************************\nok: [127.0.0.1] \u003d\u003e {\n    \"a_fact\": \"curl -s --fail --show-error ${HOME}/Downloads/playbook/play.yaml \\\\\\n| grep baseurl | grep -Eo \u0027[a-zA-Z0-9]{40}_[a-zA-Z0-9]{8}$\u0027\\n\"\n}","commit_id":"97a4242f1a4007c2396d51897bdb2af2cf79fedb"}]}