)]}'
{"quickstart.sh":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"66cd0c32a7736a4c506483d38b9c4485ce1edd9d","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    pushd $OOOQ_DIR"},{"line_number":132,"context_line":"        export TARGET_RELEASE\u003d$(awk \u0027/release:/ { print $2}\u0027 config/release/$OPT_RELEASE.yml)"},{"line_number":133,"context_line":"        export PIP_CONSTRAINT\u003d${PIP_CONSTRAINT:-https://releases.openstack.org/constraints/upper/${TARGET_RELEASE:-master}}"},{"line_number":134,"context_line":"        $(python_cmd) setup.py install egg_info --egg-base $OPT_WORKDIR"},{"line_number":135,"context_line":"        if [ $OPT_CLEAN \u003d\u003d 1 ]; then"},{"line_number":136,"context_line":"            $(python_cmd) -m pip install --no-cache-dir --force-reinstall \"${OPT_REQARGS[@]}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_c7669351","line":133,"range":{"start_line":133,"start_character":48,"end_line":133,"end_character":98},"updated":"2020-06-04 12:35:37.000000000","message":"Avoid redirected URLS, it should look like:\nhttps://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt","commit_id":"645d6b84535bebfcc63bd42fabe855f507f96cb1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"58dc07fdfafa83b218c3443d8974206f3ea7c78d","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    pushd $OOOQ_DIR"},{"line_number":132,"context_line":"        export TARGET_RELEASE\u003d$(awk \u0027/release:/ { print $2}\u0027 config/release/$OPT_RELEASE.yml)"},{"line_number":133,"context_line":"        export PIP_CONSTRAINT\u003d${PIP_CONSTRAINT:-https://releases.openstack.org/constraints/upper/${TARGET_RELEASE:-master}}"},{"line_number":134,"context_line":"        $(python_cmd) setup.py install egg_info --egg-base $OPT_WORKDIR"},{"line_number":135,"context_line":"        if [ $OPT_CLEAN \u003d\u003d 1 ]; then"},{"line_number":136,"context_line":"            $(python_cmd) -m pip install --no-cache-dir --force-reinstall \"${OPT_REQARGS[@]}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_db078e81","line":133,"range":{"start_line":133,"start_character":48,"end_line":133,"end_character":98},"in_reply_to":"ff570b3c_c7669351","updated":"2020-06-04 15:04:47.000000000","message":"ack will do that in next PS","commit_id":"645d6b84535bebfcc63bd42fabe855f507f96cb1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2c554d63da538f8f1d05dbcbfa1f1f343c5a73af","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    pushd $OOOQ_DIR"},{"line_number":132,"context_line":"        if [ \"$(python_cmd)\" \u003d\u003d \"python2\" ]; then"},{"line_number":133,"context_line":"            export TARGET_RELEASE\u003d$(awk \u0027/release:/ { print $2}\u0027 config/release/$OPT_RELEASE.yml)"},{"line_number":134,"context_line":"            export PIP_CONSTRAINT\u003d${PIP_CONSTRAINT:-https://opendev.org/openstack/requirements/raw/branch/stable/${TARGET_RELEASE}/upper-constraints.txt}"},{"line_number":135,"context_line":"        fi"},{"line_number":136,"context_line":"        $(python_cmd) setup.py install egg_info --egg-base $OPT_WORKDIR"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_f8224a51","line":133,"range":{"start_line":133,"start_character":81,"end_line":133,"end_character":92},"updated":"2020-06-05 07:56:57.000000000","message":"why not just use OPT_RELEASE directly?\n\nif you do want to go with the awk consider adding ^ so you don\u0027t match e.g. osp_release set in that one https://github.com/openstack/tripleo-quickstart/blob/192ac3d0f4d026720b2940f7484cf177d1bbb002/config/release/rhos-11-rhn-baseos-undercloud.yml.example#L5","commit_id":"b4e79f8c4a1e43e0b04a683c2b67c1daa068a6cc"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"42b5476f55d45d483b6122da520f1c069babc5f4","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    pushd $OOOQ_DIR"},{"line_number":132,"context_line":"        if [ \"$(python_cmd)\" \u003d\u003d \"python2\" ]; then"},{"line_number":133,"context_line":"            export TARGET_RELEASE\u003d$(awk \u0027/release:/ { print $2}\u0027 config/release/$OPT_RELEASE.yml)"},{"line_number":134,"context_line":"            export PIP_CONSTRAINT\u003d${PIP_CONSTRAINT:-https://opendev.org/openstack/requirements/raw/branch/stable/${TARGET_RELEASE}/upper-constraints.txt}"},{"line_number":135,"context_line":"        fi"},{"line_number":136,"context_line":"        $(python_cmd) setup.py install egg_info --egg-base $OPT_WORKDIR"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_b80bb27a","line":133,"range":{"start_line":133,"start_character":81,"end_line":133,"end_character":92},"in_reply_to":"ff570b3c_f8224a51","updated":"2020-06-05 08:08:31.000000000","message":"OPT_RELEASE is bound to release file can be master-tripleo-ci or centosci/queens-current-tripleo etc, so need to pick release var, ack will update with ^, good catch.","commit_id":"b4e79f8c4a1e43e0b04a683c2b67c1daa068a6cc"}]}
