)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c781e4d08f676e9fb6b2569a88a5cef4e390af30","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-11-02 07:38:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use py3 for tq on centos 7.8+"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iccdb29dde7e35bfa612d2e3dba73357d3258e034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1f621f24_8bae0ae5","line":8,"updated":"2020-11-02 08:29:48.000000000","message":"cool story bro\n\nsome more words would be nice pretty please thank you","commit_id":"a948733eb4ff9e80e0089a17b82e0ab0e048827b"}],"install-deps.sh":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1f7352f63d696130cd9c01cb6b04df29c5a1dcac","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    elif [ -f /etc/debian_version ]; then"},{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]"},{"line_number":62,"context_line":"        cat /tmp/foo | awk \u0027{print $4\u0027} | grep ^7.8"},{"line_number":63,"context_line":"        return_val \u003d $?"},{"line_number":64,"context_line":"        if [ $return_val -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f6b1bfe_75043b18","line":61,"updated":"2020-10-15 15:26:34.000000000","message":"also needs to ensure python3 is installed. also ; then missing","commit_id":"4c441d2277264cb6bc2604b845951ab3ca9654fd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1f7352f63d696130cd9c01cb6b04df29c5a1dcac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]"},{"line_number":62,"context_line":"        cat /tmp/foo | awk \u0027{print $4\u0027} | grep ^7.8"},{"line_number":63,"context_line":"        return_val \u003d $?"},{"line_number":64,"context_line":"        if [ $return_val -eq 0 ]; then"},{"line_number":65,"context_line":"            PYTHON_CMD\u003dpython3"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f6b1bfe_7019e977","line":62,"range":{"start_line":62,"start_character":48,"end_line":62,"end_character":51},"updated":"2020-10-15 15:26:34.000000000","message":"and with 7.9?","commit_id":"4c441d2277264cb6bc2604b845951ab3ca9654fd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1f7352f63d696130cd9c01cb6b04df29c5a1dcac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]"},{"line_number":62,"context_line":"        cat /tmp/foo | awk \u0027{print $4\u0027} | grep ^7.8"},{"line_number":63,"context_line":"        return_val \u003d $?"},{"line_number":64,"context_line":"        if [ $return_val -eq 0 ]; then"},{"line_number":65,"context_line":"            PYTHON_CMD\u003dpython3"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f6b1bfe_9507571d","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":20},"updated":"2020-10-15 15:26:34.000000000","message":"from tests?","commit_id":"4c441d2277264cb6bc2604b845951ab3ca9654fd"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"07c788283702612a351d5ad4e47fe3c820a9e989","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]"},{"line_number":62,"context_line":"        cat /tmp/foo | awk \u0027{print $4\u0027} | grep ^7.8"},{"line_number":63,"context_line":"        return_val \u003d $?"},{"line_number":64,"context_line":"        if [ $return_val -eq 0 ]; then"},{"line_number":65,"context_line":"            PYTHON_CMD\u003dpython3"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f6b1bfe_f0a979df","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":20},"in_reply_to":"7f6b1bfe_9507571d","updated":"2020-10-15 15:33:49.000000000","message":"ah duh.. thanks","commit_id":"4c441d2277264cb6bc2604b845951ab3ca9654fd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4efd8114a63e122576b11482c035bf9a42941ec6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    elif [ -f /etc/debian_version ]; then"},{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]; then"},{"line_number":62,"context_line":"        cat /etc/centos-release | awk \u0027{print $4 }\u0027 | grep \u0027^7.8\\|^7.9\u0027"},{"line_number":63,"context_line":"        release_val \u003d $?"},{"line_number":64,"context_line":"        rpm -q python3"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_70f0c991","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":8},"updated":"2020-10-15 16:04:04.000000000","message":"also this if will not be reached as if on line 21 will be matched, so need to handle 7.8/7.9 case there itself.","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4efd8114a63e122576b11482c035bf9a42941ec6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]; then"},{"line_number":62,"context_line":"        cat /etc/centos-release | awk \u0027{print $4 }\u0027 | grep \u0027^7.8\\|^7.9\u0027"},{"line_number":63,"context_line":"        release_val \u003d $?"},{"line_number":64,"context_line":"        rpm -q python3"},{"line_number":65,"context_line":"        python_val \u003d $?"},{"line_number":66,"context_line":"        if [ $return_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_50f94d7e","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":24},"updated":"2020-10-15 16:04:04.000000000","message":"release_val\u003d$?","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4efd8114a63e122576b11482c035bf9a42941ec6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat /etc/centos-release | awk \u0027{print $4 }\u0027 | grep \u0027^7.8\\|^7.9\u0027"},{"line_number":63,"context_line":"        release_val \u003d $?"},{"line_number":64,"context_line":"        rpm -q python3"},{"line_number":65,"context_line":"        python_val \u003d $?"},{"line_number":66,"context_line":"        if [ $return_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"},{"line_number":67,"context_line":"            PYTHON_CMD\u003dpython3"},{"line_number":68,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_30f65191","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":23},"updated":"2020-10-15 16:04:04.000000000","message":"python_val\u003d$?","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4efd8114a63e122576b11482c035bf9a42941ec6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        release_val \u003d $?"},{"line_number":64,"context_line":"        rpm -q python3"},{"line_number":65,"context_line":"        python_val \u003d $?"},{"line_number":66,"context_line":"        if [ $return_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"},{"line_number":67,"context_line":"            PYTHON_CMD\u003dpython3"},{"line_number":68,"context_line":"        fi"},{"line_number":69,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_f004d97d","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":24},"updated":"2020-10-15 16:04:04.000000000","message":"release_val","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4efd8114a63e122576b11482c035bf9a42941ec6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        rpm -q python3"},{"line_number":65,"context_line":"        python_val \u003d $?"},{"line_number":66,"context_line":"        if [ $return_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"},{"line_number":67,"context_line":"            PYTHON_CMD\u003dpython3"},{"line_number":68,"context_line":"        fi"},{"line_number":69,"context_line":"    else"},{"line_number":70,"context_line":"        # Covers for FreeBSD and many others"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_d02a7de5","line":67,"updated":"2020-10-15 16:04:04.000000000","message":"need to set python_cmd instead","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"99c8fdabe5179d45ef9d95aa5ee1fd1c13684621","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    elif [ -f /etc/debian_version ]; then"},{"line_number":59,"context_line":"        distribution\u003d\"Debian\""},{"line_number":60,"context_line":"        distribution_major_version\u003d$(cat /etc/debian_version | cut -d. -f1)"},{"line_number":61,"context_line":"    elif [ -f /etc/centos-release ]; then"},{"line_number":62,"context_line":"        cat /etc/centos-release | awk \u0027{print $4 }\u0027 | grep \u0027^7.8\\|^7.9\u0027"},{"line_number":63,"context_line":"        release_val \u003d $?"},{"line_number":64,"context_line":"        rpm -q python3"},{"line_number":65,"context_line":"        python_val \u003d $?"},{"line_number":66,"context_line":"        if [ $return_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"},{"line_number":67,"context_line":"            PYTHON_CMD\u003dpython3"},{"line_number":68,"context_line":"        fi"},{"line_number":69,"context_line":"    else"},{"line_number":70,"context_line":"        # Covers for FreeBSD and many others"},{"line_number":71,"context_line":"        distribution\u003d$(uname -s)"},{"line_number":72,"context_line":"        if [ $distribution \u003d Darwin ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f6b1bfe_2b7a6223","line":69,"range":{"start_line":61,"start_character":0,"end_line":69,"end_character":8},"updated":"2020-10-15 16:57:37.000000000","message":"I would support hardcoded PYTHON_CMD\u003dpython3 without any conditionals.","commit_id":"c2b2c8e6f54e285a856071e29f8f857d1377b219"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"23e0baf59c4630e208d91345012afe3b0ee54a75","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                if [ \"$distribution_major_version\" -ge \"8\" ]; then"},{"line_number":37,"context_line":"                    PYTHON_CMD\u003dpython3"},{"line_number":38,"context_line":"                elif [ \"$distribution_major_version\" -eq \"7\" ]; then"},{"line_number":39,"context_line":"                    cat /etc/centos-release | awk \u0027{print $4 }\u0027 | grep \u0027^7.8\\|^7.9\u0027"},{"line_number":40,"context_line":"                    release_val\u003d$?"},{"line_number":41,"context_line":"                    rpm -q python3"},{"line_number":42,"context_line":"                    python_val\u003d$?"},{"line_number":43,"context_line":"                    if [ $release_val -eq 0 ] \u0026\u0026 [ $python_val -eq 0 ]; then"},{"line_number":44,"context_line":"                        PYTHON_CMD\u003dpython3"},{"line_number":45,"context_line":"                    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f65232a_8dc2c4e8","line":42,"range":{"start_line":39,"start_character":19,"end_line":42,"end_character":33},"updated":"2020-10-22 11:22:55.000000000","message":"Those statements was wrong because the python_cmd was shown as:\n7.8.2003 python3-3.6.8-13.el7.x86_64 python3\n\ninstead of:\npython3\n\nSo the if condition line #117 was always false in centos7 case according to the logs here:\n\n2020-10-19 19:25:37.157780 | primary | Python Command is:\n2020-10-19 19:25:37.159753 | primary | 7.8.2003\n2020-10-19 19:25:37.211421 | primary | python3-3.6.8-13.el7.x86_64\n2020-10-19 19:25:37.212801 | primary | python3","commit_id":"bf2fabbf5e8819445d3f96b3894ed05adb2b5155"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89db75d0631c124875e9773524d6257415d872db","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    python_val\u003d$(rpm -q python3)"},{"line_number":41,"context_line":"                    if [ ! -z $release_val ] \u0026\u0026 [[ $python_val \u003d~ \"python3-\" ]]; then"},{"line_number":42,"context_line":"                        # declare centos7 python3 variable:"},{"line_number":43,"context_line":"                        centos7py3\u003dtrue"},{"line_number":44,"context_line":"                        PYTHON_CMD\u003dpython3"},{"line_number":45,"context_line":"                    fi"},{"line_number":46,"context_line":"                fi"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1f621f24_a0cca1bc","line":43,"range":{"start_line":43,"start_character":32,"end_line":43,"end_character":37},"updated":"2020-11-04 07:49:43.000000000","message":"i was worried about that (i.e. no \u0027boolean\u0027 in bash) but i see the test you use below should work OK with -z","commit_id":"c4bbc17008dcce91d3eac68212572dab421a90eb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"89db75d0631c124875e9773524d6257415d872db","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        # Install python3 virtualenv via pip on CentOS7"},{"line_number":146,"context_line":"        if [ -z $centos7py3 ]; then"},{"line_number":147,"context_line":"            sudo $(package_manager) install $VIRTUALENV_PACKAGE"},{"line_number":148,"context_line":"        else"},{"line_number":149,"context_line":"            sudo pip3 install virtualenv"},{"line_number":150,"context_line":"            sudo $(package_manager) install gcc python3-devel"},{"line_number":151,"context_line":"        fi"},{"line_number":152,"context_line":"        check_python_module virtualenv \u0026\u003e /dev/null || \\"}],"source_content_type":"text/x-sh","patch_set":28,"id":"1f621f24_c0455d17","line":149,"range":{"start_line":148,"start_character":8,"end_line":149,"end_character":40},"updated":"2020-11-04 07:49:43.000000000","message":"this is the \u0027normal\u0027 case (i.e. what was there before your change) but I see it is changed from what was happening before. Before VIRTUALENV_PACKAGE was installed with package manager but now you are doing it with pip\n\nwhy are we changing this case? there should only be an exception for the centtos7py3 \n\n[EDIT]: ok sorry i see it is -z not -n you used in your test. so in fact this is the exception case not the normal case... the one one line 147 is the normal/no exception case as before with package_manager...","commit_id":"c4bbc17008dcce91d3eac68212572dab421a90eb"}],"quickstart.sh":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b764e5a21ededc0096f13477c55bb69bb511715","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        else"},{"line_number":143,"context_line":"            $(python_cmd) -m pip install --force-reinstall \"${OPT_REQARGS[@]}\""},{"line_number":144,"context_line":"        fi"},{"line_number":145,"context_line":"        if [ ! -z $centos7py3 ]; then"},{"line_number":146,"context_line":"            # Nb: pbr\u003d\u003d3.1.1 install with stable/queens raise a"},{"line_number":147,"context_line":"            # UnicodeDecodeError. We need to push the stable/train version"},{"line_number":148,"context_line":"            # instead: pbr\u003d\u003d5.4.3"}],"source_content_type":"text/x-sh","patch_set":20,"id":"1f621f24_2b753696","line":145,"range":{"start_line":145,"start_character":19,"end_line":145,"end_character":29},"updated":"2020-11-02 08:28:56.000000000","message":"ok i see install-deps is sourced on line 53 above","commit_id":"a948733eb4ff9e80e0089a17b82e0ab0e048827b"}]}