)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f8adc18bbdaf0888b1629e2ceb5a8d28ac1b5aae","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support using ephemeral Heat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updates the containers-multinode job to enable using ephemeral heat"},{"line_number":10,"context_line":"using the newly added ephemeral_heat/ephemeral_heat_args variable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Sets the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"4f9df2ff_21ce8547","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":32},"updated":"2021-05-17 06:39:12.000000000","message":"\"containers-multinode job (featureset010)\" \n\njust suggestion","commit_id":"e80d9efcfb0fbff5d614a2096e9191cbd6b72860"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f8adc18bbdaf0888b1629e2ceb5a8d28ac1b5aae","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Updates the containers-multinode job to enable using ephemeral heat"},{"line_number":10,"context_line":"using the newly added ephemeral_heat/ephemeral_heat_args variable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Sets the"},{"line_number":13,"context_line":"tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates"},{"line_number":14,"context_line":"(featureset037) and tripleo-ci-centos-8-undercloud-containers"},{"line_number":15,"context_line":"(featureset027) to not use ephemeral heat for now so that we can move"},{"line_number":16,"context_line":"forward with changing the default in tripleoclient"},{"line_number":17,"context_line":"(c9c0a5adac08ea2e8465447b4c4a221d8fe4548e)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: I29cf6dd8a32242f27a40946688f9dede8968c7f9"},{"line_number":20,"context_line":"Depends-On: Ib63813b63c37fa2cee57a211535d43d605131529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"69b344a2_22f2b9af","line":17,"range":{"start_line":12,"start_character":2,"end_line":17,"end_character":16},"updated":"2021-05-17 06:39:12.000000000","message":"we can remove this for now please otherwise will be confusing for the archaeologists","commit_id":"e80d9efcfb0fbff5d614a2096e9191cbd6b72860"}],"config/general_config/featureset010.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6ccf224a9da889a23cda3a48257341a5750b424d","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat_args: \u003e-"},{"line_number":65,"context_line":"  {% if not release in [\u0027newton\u0027,\u0027ocata\u0027,\u0027pike\u0027,\u0027queens\u0027,\u0027rocky\u0027,\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027] -%}"},{"line_number":66,"context_line":"  --heat-type pod"},{"line_number":67,"context_line":"  {%- endif %}"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"638633fc_1fe67ae3","line":65,"range":{"start_line":65,"start_character":24,"end_line":65,"end_character":65},"updated":"2021-05-12 10:16:33.000000000","message":"I think we can drop those.","commit_id":"82e8e1e1e07a1a34a4c49606ce137760a32e20db"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6ccf224a9da889a23cda3a48257341a5750b424d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  {%- endif %}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"ephemeral_heat: \u003e-"},{"line_number":70,"context_line":"  {% if not release in [\u0027newton\u0027,\u0027ocata\u0027,\u0027pike\u0027,\u0027queens\u0027,\u0027rocky\u0027,\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027] -%}"},{"line_number":71,"context_line":"  true"},{"line_number":72,"context_line":"  {%- else -%}"},{"line_number":73,"context_line":"  false"},{"line_number":74,"context_line":"  {%- endif -%}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Tempest configuration, keep always at the end of the file"},{"line_number":77,"context_line":"test_ping: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"4e3a6776_21f09ecf","line":74,"range":{"start_line":70,"start_character":2,"end_line":74,"end_character":15},"updated":"2021-05-12 10:16:33.000000000","message":"it\u0027s same condition as above, so maybe:\n\n  ephemeral_heat: \"{{ (not release in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\"\n  ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\"","commit_id":"82e8e1e1e07a1a34a4c49606ce137760a32e20db"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"57e60c9620577aec8247872c85528da2de11fb5d","unresolved":true,"context_lines":[{"line_number":67,"context_line":"  {%- endif %}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"ephemeral_heat: \u003e-"},{"line_number":70,"context_line":"  {% if not release in [\u0027newton\u0027,\u0027ocata\u0027,\u0027pike\u0027,\u0027queens\u0027,\u0027rocky\u0027,\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027] -%}"},{"line_number":71,"context_line":"  true"},{"line_number":72,"context_line":"  {%- else -%}"},{"line_number":73,"context_line":"  false"},{"line_number":74,"context_line":"  {%- endif -%}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Tempest configuration, keep always at the end of the file"},{"line_number":77,"context_line":"test_ping: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a10c0750_69e07715","line":74,"range":{"start_line":70,"start_character":2,"end_line":74,"end_character":15},"in_reply_to":"4e3a6776_21f09ecf","updated":"2021-05-12 11:36:35.000000000","message":"yes, that much nicer. thank you.","commit_id":"82e8e1e1e07a1a34a4c49606ce137760a32e20db"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3be24f0e62273869fabaa407968173a81904aa98","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  -e {{ working_dir }}/config-download.yaml"},{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (not release in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"957a9b41_887b5ece","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":35},"updated":"2021-05-14 06:38:15.000000000","message":"i think \"release not in [] \"  works just as well and possibly easier to read","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b2bf9e9a069b01de5390fba49b8e68762d8e0570","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  -e {{ working_dir }}/config-download.yaml"},{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (not release in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ff271492_ff0f2111","line":64,"range":{"start_line":64,"start_character":21,"end_line":64,"end_character":35},"in_reply_to":"957a9b41_887b5ece","updated":"2021-05-14 12:06:05.000000000","message":"it does work as well. I used this form based on an earlier review from Sagi, but I will change it.","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3be24f0e62273869fabaa407968173a81904aa98","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (not release in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"},{"line_number":68,"context_line":"test_ping: false"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"daed0566_257dfd9d","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":42},"updated":"2021-05-14 06:38:15.000000000","message":"looks good at https://f1ad14c2f18111e05a25-c392e4904ca041b2375209c5c066ffc0.ssl.cf1.rackcdn.com/777108/25/check/tripleo-ci-centos-8-containers-multinode/e0c072f/logs/undercloud/home/zuul/overcloud-deploy.sh\n\nopenstack overcloud deploy --stack overcloud  --override-ansible-cfg /home/zuul/custom_ansible.cfg \\\n    --templates /usr/share/openstack-tripleo-heat-templates \\\n    --libvirt-type qemu  --timeout 90  -e /home/zuul/cloud-names.yaml -e /home/zuul/hostnamemap.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/deployed-server-environment.yaml  --overcloud-ssh-user zuul  --deployed-server       -e /home/zuul/containers-prepare-parameter.yaml   -e /usr/share/openstack-tripleo-heat-templates/environments/podman.yaml  -e /usr/share/openstack-tripleo-heat-templates/ci/environments/multinode-containers.yaml  -e /home/zuul/overcloud_network_params.yaml  -e /home/zuul/overcloud_storage_params.yaml  -e /usr/share/openstack-tripleo-heat-templates/environments/low-memory-usage.yaml -e /home/zuul/src/opendev.org/openstack/tripleo-ci/test-environments/worker-config.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/debug.yaml       --validation-errors-nonfatal  --roles-file /home/zuul/overcloud_roles.yaml  -e /home/zuul/overcloud-topology-config.yaml  -e /home/zuul/config-download.yaml --disable-validations --heat-type pod -e /home/zuul/overcloud-selinux-config.yaml  \\\n    \"$@\" \u0026\u0026 status_code\u003d0 || status_code\u003d$?","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b2bf9e9a069b01de5390fba49b8e68762d8e0570","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (not release in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"},{"line_number":68,"context_line":"test_ping: false"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"d4d40a26_60f626a7","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":42},"in_reply_to":"daed0566_257dfd9d","updated":"2021-05-14 12:06:05.000000000","message":"Ack","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"39dbd82e278fd987d3e5331a12f9840916d2142a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  -e {{ working_dir }}/config-download.yaml"},{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (release not in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3e043b20_1ba46739","line":64,"range":{"start_line":64,"start_character":37,"end_line":64,"end_character":38},"updated":"2021-05-19 07:26:54.000000000","message":"hm i think we need queens there too I see we have it in the conditional on line 55 so this featureset was/is in play for that branch too.","commit_id":"f692fc0579a25e8440ee77c628a0726db2c6d6ec"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a8e649337b06232b28667adc7db352a2bd65e711","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  -e {{ working_dir }}/config-download.yaml"},{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (release not in [\u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"4dc858e0_52f8ada0","line":64,"range":{"start_line":64,"start_character":37,"end_line":64,"end_character":38},"in_reply_to":"3e043b20_1ba46739","updated":"2021-05-19 12:20:34.000000000","message":"added. thank you!","commit_id":"f692fc0579a25e8440ee77c628a0726db2c6d6ec"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7df4dd47595e646ad32ac26991aeea9a195a82b7","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  -e {{ working_dir }}/config-download.yaml"},{"line_number":62,"context_line":"  --disable-validations"},{"line_number":63,"context_line":"  {%- endif -%}"},{"line_number":64,"context_line":"ephemeral_heat: \"{{ (release not in [\u0027queens\u0027, \u0027stein\u0027,\u0027train\u0027,\u0027ussuri\u0027,\u0027victoria\u0027]) | bool }}\""},{"line_number":65,"context_line":"ephemeral_heat_args: \"{{ \u0027--heat-type pod\u0027 if ephemeral_heat|bool else \u0027\u0027 }}\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Tempest configuration, keep always at the end of the file"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"bae3743e_5635ca69","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":44},"updated":"2021-05-19 15:05:17.000000000","message":"ack thanks","commit_id":"2289341399b6efad8725b2de28f1c416a07f3649"}],"config/general_config/featureset027.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3be24f0e62273869fabaa407968173a81904aa98","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"undercloud_enable_paunch: false"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Ephemeral heat enabled"},{"line_number":139,"context_line":"ephemeral_heat: false"},{"line_number":140,"context_line":"ephemeral_heat_args: \"--heat-type\u003dinstalled\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"8bb1ef41_4471fe86","line":138,"range":{"start_line":138,"start_character":17,"end_line":138,"end_character":24},"updated":"2021-05-14 06:38:15.000000000","message":"just wondering what the value of these additions is at this point I mean to enable this we will have to change both of these to look more like what you added in featureset 010\n\nas placeholders they aren\u0027t really needed yet in the sense that the values here are the current defaults right? (i.e. no ephemeral and installed as the heat type)\n\n\nor do you plan to try these out too in this review before we merge it?","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b2bf9e9a069b01de5390fba49b8e68762d8e0570","unresolved":true,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"undercloud_enable_paunch: false"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Ephemeral heat enabled"},{"line_number":139,"context_line":"ephemeral_heat: false"},{"line_number":140,"context_line":"ephemeral_heat_args: \"--heat-type\u003dinstalled\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"cb91bc20_3057e267","line":138,"range":{"start_line":138,"start_character":17,"end_line":138,"end_character":24},"in_reply_to":"8bb1ef41_4471fe86","updated":"2021-05-14 12:06:05.000000000","message":"i was planning on keeping these set as false for now so i can test switching the default in https://review.opendev.org/c/openstack/python-tripleoclient/+/789930/. Was trying to keep  it one patch (per commit message).\n\nI will remove them here and do separate patches instead so it\u0027s clearer.","commit_id":"80f0a36e41f19ae869700e88a23a97ea7f512ce1"}]}