)]}'
{"install-deps.sh":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8f662515ac72e6e1727c7597c42afce560d69989","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        # EPEL could be installed in the same transaction as other packages on CentOS/RHEL"},{"line_number":241,"context_line":"        # This can leave the system with an older ansible version. Ansible 2.7+ required"},{"line_number":242,"context_line":"        # Run through the deps and update them"},{"line_number":243,"context_line":"        sudo $(package_manager)-config-manager enable epel || true"},{"line_number":244,"context_line":"        sudo $(package_manager) update `bindep -b -l newline`"},{"line_number":245,"context_line":"    else"},{"line_number":246,"context_line":"        print_sudo_warning"}],"source_content_type":"text/x-sh","patch_set":1,"id":"4d086d00_2079f835","line":243,"range":{"start_line":243,"start_character":13,"end_line":243,"end_character":46},"updated":"2021-04-07 09:05:47.000000000","message":"For dnf there is no command dnf-config-manager, I think it is dnf config-manager https://dnf-plugins-core.readthedocs.io/en/latest/config_manager.html#synopsis Can you please relook at the fixes? It will break the stuff.","commit_id":"a54cdfe350bac3f865af9c1eb924f8b497487fef"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5615312ca611f11f8fbb0f8c9c219be9e36992bb","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        # EPEL could be installed in the same transaction as other packages on CentOS/RHEL"},{"line_number":241,"context_line":"        # This can leave the system with an older ansible version. Ansible 2.7+ required"},{"line_number":242,"context_line":"        # Run through the deps and update them"},{"line_number":243,"context_line":"        sudo sh -c \"$(package_manager) repolist disabled epel | tail -n +2 | cut -d\u0027 \u0027 -f1 | xargs yum-config-manager --enable \u0026\u0026 $(package_manager) update `bindep -b -l newline`\""},{"line_number":244,"context_line":"    else"},{"line_number":245,"context_line":"        print_sudo_warning"},{"line_number":246,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"40d50911_3f15184e","line":243,"range":{"start_line":243,"start_character":100,"end_line":243,"end_character":102},"updated":"2021-04-08 07:10:11.000000000","message":"also I thought the whole point of this originally was to replace yum-config-manager with dnf config manager? Why did you keep yum-config-manger in your pipe-fest command","commit_id":"f52bdfda550daa5975044c27c43eeefe2dbec11e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5615312ca611f11f8fbb0f8c9c219be9e36992bb","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        # EPEL could be installed in the same transaction as other packages on CentOS/RHEL"},{"line_number":241,"context_line":"        # This can leave the system with an older ansible version. Ansible 2.7+ required"},{"line_number":242,"context_line":"        # Run through the deps and update them"},{"line_number":243,"context_line":"        sudo sh -c \"$(package_manager) repolist disabled epel | tail -n +2 | cut -d\u0027 \u0027 -f1 | xargs yum-config-manager --enable \u0026\u0026 $(package_manager) update `bindep -b -l newline`\""},{"line_number":244,"context_line":"    else"},{"line_number":245,"context_line":"        print_sudo_warning"},{"line_number":246,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"0e7eb47a_99146ae6","line":243,"updated":"2021-04-08 07:10:11.000000000","message":"no. please let\u0027s make this more verbose why do we hate ourselves? I mean you wrote this but for anyone else at any point in the future they will have to stare at it for 10 mins and run it a few times to understand what\u0027s going on. Why do you hate us sorin? what did we ever do to you? 😞\n\nplease consider making it more like \n\nif [ $ENABLED_EPEL ]; then\n sudo yum-config-manager --enable \n  ... update bindep\nfi","commit_id":"f52bdfda550daa5975044c27c43eeefe2dbec11e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"406e2da201a400bd10e478fa5fda7e76ab677777","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        # EPEL could be installed in the same transaction as other packages on CentOS/RHEL"},{"line_number":241,"context_line":"        # This can leave the system with an older ansible version. Ansible 2.7+ required"},{"line_number":242,"context_line":"        # Run through the deps and update them"},{"line_number":243,"context_line":"        sudo sh -c \"$(package_manager) repolist disabled epel | tail -n +2 | cut -d\u0027 \u0027 -f1 | xargs yum-config-manager --enable \u0026\u0026 $(package_manager) update `bindep -b -l newline`\""},{"line_number":244,"context_line":"    else"},{"line_number":245,"context_line":"        print_sudo_warning"},{"line_number":246,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"0147cac0_8cfd8109","line":243,"in_reply_to":"0e7eb47a_99146ae6","updated":"2021-04-08 08:58:07.000000000","message":"Adding the missing sudo was the reactive part, rewriting the logic to avoid ignoring any error is the preventive part.\n\nAlso calling sudo multiple times does not make much sense.\n\nI do not mind using if, but could you please show me the code that loads ENABLED_EPEL var? -- be sure that you do not endup producing undesired output in both cases. My guess is that the result would not be much different that my code.","commit_id":"f52bdfda550daa5975044c27c43eeefe2dbec11e"}]}