)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ec7b2c95e08894dce5096c04bd78dd5bdfef2265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75353cc0_89eea267","updated":"2022-04-01 10:54:10.000000000","message":"Thank you for proposing the patch, from initial review, it looks good.\nAs per the zuul results only cs9 jobs are runned here.\n\nSince these roles are used in Downstream and RDO till CentOS-7, Can we fire up a testproject for RDO and upstream\n- A standalone job on c7 and c8\n- A standalone job on RHEL-8 and RHEL-9\n\nSo that we have full confidence, it does not break anything.\nSetting -W till we have testproject results.","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4a7035889d413faa1e61a93a5e5d82adfbd26de0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4cfe2aeb_61150f78","updated":"2022-04-04 11:24:20.000000000","message":"Thanks for adding the testproject, waiting for downstream results. Few comments , Rest looks good,","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"a6ab48f89158956dc4969673a0042ca68316e2bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fe53d07_03524dff","updated":"2022-04-01 01:50:16.000000000","message":"recheck","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"252a67d03e441744329af9f00d6d8551be23754a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"712d3f7d_5a16f0e0","in_reply_to":"0665bce4_b59a5f24","updated":"2022-04-04 07:59:52.000000000","message":"cs9 ran in the check jobs for this patch and I\u0027m not sure this patch will do anything that would be release dependent.\n\nNevertheless I updated my test patch[1] to test the configs we support to be sure.\n\n[1] https://review.rdoproject.org/r/c/testproject/+/41354","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"de6266782e414e86ba788bb9bbc3f4c2b6c7ee09","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0665bce4_b59a5f24","in_reply_to":"31f59f50_9de8fe7a","updated":"2022-04-04 06:23:40.000000000","message":"Since this is going into master, it might be a good idea to test it against wallaby and master as well. Also some centos 9 tests would be nice. Granted, it is not extremely likely that switch to 9 would have a significant effect, but it\u0027s better to be sure.","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"1f7d26350bde69c3badf57fa824a42bbc56ae78b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd920cf7_afa87490","in_reply_to":"712d3f7d_5a16f0e0","updated":"2022-04-04 08:22:49.000000000","message":"Thanks. I\u0027ll see how they go.","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0756dbd3e705c5443429a72d92c0ab78b80cafa9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31f59f50_9de8fe7a","in_reply_to":"75353cc0_89eea267","updated":"2022-04-01 14:52:58.000000000","message":"Thanks for the review\n\nRDO TP: https://review.rdoproject.org/r/c/testproject/+/41354\nDownstream TP: https://code.engineering.redhat.com/gerrit/c/testproject/+/398653","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"15b4f31e954a513db01e6d5765e478f844eed129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6fa56922_7c004c5d","in_reply_to":"dd920cf7_afa87490","updated":"2022-04-07 07:10:24.000000000","message":"latest results are green https://review.rdoproject.org/r/c/testproject/+/41354","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"47bd47cdf7b2ebca64741b08ec9247ae02a9189d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f47ff10c_37d81ddc","updated":"2022-04-04 12:36:22.000000000","message":"The periodic-tripleo-ci-centos-9-standalone-master seems to be having trouble in testproject.\nAlthough it doesn\u0027t appear to be related, it\u0027s a container image problem, to your patch it stops the process rather early.\n\nI can at least verify that the function is executed and dependencies installed. ","commit_id":"ff948ee33499f20c81823b3c8f9d93d96a2da023"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cfac7b6464d029211d8a268031b47c54aecb983f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f6682575_a91becc1","updated":"2022-04-07 06:29:42.000000000","message":"are we waiting on any more testproject results or is this good to go?\nstared for a bit lgtm","commit_id":"faedf88a583d84b7c9a233d6c6fa36b584b77ce3"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"15b4f31e954a513db01e6d5765e478f844eed129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"37904766_d7413aa8","in_reply_to":"f6682575_a91becc1","updated":"2022-04-07 07:10:24.000000000","message":"latest results are green https://review.rdoproject.org/r/c/testproject/+/41354","commit_id":"faedf88a583d84b7c9a233d6c6fa36b584b77ce3"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"775d43e411fa977f2ed79de2ea495c36296186ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c73a3cff_e655a85d","updated":"2022-04-08 09:32:17.000000000","message":"From technical perspective I think it\u0027s fine. My only concerns are solely in the documentation area.\nThis review makes substantial, although perhaps necessary and sensible, changes to how quickstart pulls critical dependencies. \n\nTherefore, I believe it\u0027s vital that we make sure that the behavior is well described. Ideally, this would entail modification, and expansion, of the upstream documentation, with perhaps a small note in our customer documentation. But if that should prove impossible we should at very least describe the the process in upstream.\n\nCouple of sentences, explaining that collections and roles are installed with ansible-galaxy, and that CI specific checks were implemented to ensure dependencies are not pulled twice, would be enough. ","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"6db40987b6fa566e9d2ddbe0c0503f3d77f663ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"cefb53ec_9a8a4706","updated":"2022-04-11 05:53:40.000000000","message":"Awesome, thanks for the changes!","commit_id":"c339bce2000fddb926e438aee805f54463bee265"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"24f0086f8194d7e0efa9f1c14e39bada88866fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"970229a8_ae47a37c","updated":"2022-04-11 18:06:14.000000000","message":"Just adding my vote here, but was +w already. Thanks Rafael","commit_id":"c339bce2000fddb926e438aee805f54463bee265"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4f87a1e022061f399500e75c0831831e0b5f962d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"dac92c69_0b415f17","updated":"2022-04-13 03:45:32.000000000","message":"https://zuul.opendev.org/t/openstack/builds?job_name\u003dtripleo-ci-centos-9-undercloud-upgrade\u0026project\u003dopenstack/tripleo-quickstart seems to be healthy.","commit_id":"c339bce2000fddb926e438aee805f54463bee265"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4b05f42735f3ed252e36001f7e5cbfa3edec31ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5ae6c806_d6c0e339","updated":"2022-04-13 03:45:37.000000000","message":"recheck","commit_id":"c339bce2000fddb926e438aee805f54463bee265"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3c11c791674ad618ef5d673577e83ebe92c2184a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2431ace6_e39ad2fa","updated":"2022-04-12 15:52:30.000000000","message":"recheck\n\n","commit_id":"c339bce2000fddb926e438aee805f54463bee265"}],"ansible-collection-requirements.yml":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"775d43e411fa977f2ed79de2ea495c36296186ef","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"collections:"},{"line_number":3,"context_line":"  # FIXME(bogdando): LP#1954761: keep these in sync with:"},{"line_number":4,"context_line":"  #   https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/base.yaml"},{"line_number":5,"context_line":"  - name: ansible.utils"},{"line_number":6,"context_line":"    source: https://galaxy.ansible.com"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e38b11ae_cbb52bc5","line":3,"updated":"2022-04-08 09:32:17.000000000","message":"I see the bug is still in progress. Although it has a patch partially addressing the problem I\u0027m wondering what is the long term plan here. Should we have ooo-ci override these, using some argument for the quickstart script? Or is there another approach already in development?","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"}],"quickstart-extras-requirements.txt":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"7f1eda2f712c37d47a4385ed4111cf1a6549cc31","unresolved":true,"context_lines":[{"line_number":2,"context_line":"git+https://opendev.org/openstack/tripleo-ha-utils/#egg\u003dtripleo-ha-utils"},{"line_number":3,"context_line":"# browbeat is no longer supported integrated w/ tq"},{"line_number":4,"context_line":"#git+https://opendev.org/x/browbeat/#egg\u003dbrowbeat"},{"line_number":5,"context_line":"git+https://opendev.org/openstack/ansible-config_template/#egg\u003dansible-config_template"},{"line_number":6,"context_line":"git+https://opendev.org/openstack/ansible-role-collect-logs/#egg\u003dansible-role-collect-logs"},{"line_number":7,"context_line":"git+https://opendev.org/openstack/openstack-tempest-skiplist/#egg\u003dopenstack-tempest-skiplist"},{"line_number":8,"context_line":"git+https://opendev.org/openstack/ansible-collections-openstack/#egg\u003dansible-collections-openstack.cloud"}],"source_content_type":"text/plain","patch_set":2,"id":"1cd22ed7_efc81c1e","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":86},"updated":"2022-04-04 12:57:04.000000000","message":"this should be installable as a collection as we have https://review.opendev.org/c/openstack/ansible-config_template/+/807581","commit_id":"ff948ee33499f20c81823b3c8f9d93d96a2da023"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0584beae57b1803fae3a12c93585519f071091e4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"git+https://opendev.org/openstack/tripleo-ha-utils/#egg\u003dtripleo-ha-utils"},{"line_number":3,"context_line":"# browbeat is no longer supported integrated w/ tq"},{"line_number":4,"context_line":"#git+https://opendev.org/x/browbeat/#egg\u003dbrowbeat"},{"line_number":5,"context_line":"git+https://opendev.org/openstack/ansible-config_template/#egg\u003dansible-config_template"},{"line_number":6,"context_line":"git+https://opendev.org/openstack/ansible-role-collect-logs/#egg\u003dansible-role-collect-logs"},{"line_number":7,"context_line":"git+https://opendev.org/openstack/openstack-tempest-skiplist/#egg\u003dopenstack-tempest-skiplist"},{"line_number":8,"context_line":"git+https://opendev.org/openstack/ansible-collections-openstack/#egg\u003dansible-collections-openstack.cloud"}],"source_content_type":"text/plain","patch_set":2,"id":"f7d6bfea_a74bad93","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":86},"in_reply_to":"1cd22ed7_efc81c1e","updated":"2022-04-07 00:11:02.000000000","message":"Done","commit_id":"ff948ee33499f20c81823b3c8f9d93d96a2da023"}],"quickstart.sh":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"ac8789429385bcac0de4805ab5fa82a161ef7406","unresolved":true,"context_lines":[{"line_number":124,"context_line":"}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"install_ansible_roles(){"},{"line_number":127,"context_line":"    ansible-galaxy install -r r \\"},{"line_number":128,"context_line":"        -r ansible-role-requirements.yml \\"},{"line_number":129,"context_line":"        -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ec4ff9d6_08709015","line":127,"range":{"start_line":127,"start_character":27,"end_line":127,"end_character":31},"updated":"2022-04-04 08:27:02.000000000","message":"Do we have such a file in the repo? If so, wouldn\u0027t it be better to come up with some more elaborate name for it?","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4a7035889d413faa1e61a93a5e5d82adfbd26de0","unresolved":true,"context_lines":[{"line_number":124,"context_line":"}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"install_ansible_roles(){"},{"line_number":127,"context_line":"    ansible-galaxy install -r r \\"},{"line_number":128,"context_line":"        -r ansible-role-requirements.yml \\"},{"line_number":129,"context_line":"        -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"d320442f_12903a0f","line":127,"range":{"start_line":127,"start_character":30,"end_line":127,"end_character":32},"updated":"2022-04-04 11:24:20.000000000","message":"Is it additional r intentional?","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"100d8c82783e19d776fe77f6a2d7a2e69af1be4d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"install_ansible_roles(){"},{"line_number":127,"context_line":"    ansible-galaxy install -r r \\"},{"line_number":128,"context_line":"        -r ansible-role-requirements.yml \\"},{"line_number":129,"context_line":"        -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"92c4cfa9_cdcb9483","line":127,"range":{"start_line":127,"start_character":30,"end_line":127,"end_character":32},"in_reply_to":"d320442f_12903a0f","updated":"2022-04-07 00:10:52.000000000","message":"Done","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"47bd47cdf7b2ebca64741b08ec9247ae02a9189d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"install_ansible_roles(){"},{"line_number":127,"context_line":"    ansible-galaxy install -r r \\"},{"line_number":128,"context_line":"        -r ansible-role-requirements.yml \\"},{"line_number":129,"context_line":"        -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":130,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"af089524_39b40642","line":127,"range":{"start_line":127,"start_character":27,"end_line":127,"end_character":31},"in_reply_to":"ec4ff9d6_08709015","updated":"2022-04-04 12:36:22.000000000","message":"Done","commit_id":"14f7c376755927475789125c37fb696a8575946d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cfac7b6464d029211d8a268031b47c54aecb983f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            -p $VIRTUAL_ENV/share/ansible/collections"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OS_COLLECTIONS\u003d\"ansible-config_template ansible-role-collect-logs \\"},{"line_number":119,"context_line":"        ansible-collections-openstack tripleo-operator-ansible\""},{"line_number":120,"context_line":"    for COLLECTION_REPO in $OS_COLLECTIONS; do"},{"line_number":121,"context_line":"        if [[ -d ~/src/opendev.org/openstack/$COLLECTION_REPO ]]; then"},{"line_number":122,"context_line":"            ansible-galaxy collection install --force \\"}],"source_content_type":"text/x-sh","patch_set":17,"id":"d7f5ac4e_92a8349b","line":119,"range":{"start_line":118,"start_character":20,"end_line":119,"end_character":62},"updated":"2022-04-07 06:29:42.000000000","message":"these are all in the ansible-collection-requirements.yml\n\nso why are we first explicitly installing them here (lines 118-126) and then just installing ansible-collection-requirements.yml anyway?\n\n[EDIT]: so this first part is for when have a locally checked out repo to install from vs the next part is pulling from galaxy","commit_id":"faedf88a583d84b7c9a233d6c6fa36b584b77ce3"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"de103b800352fb91d6adf778988e5b6a14e2674a","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            ~/src/github.com/ansible-collections/openvswitch.openvswitch \\"},{"line_number":115,"context_line":"            -p $VIRTUAL_ENV/share/ansible/collections"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OS_COLLECTIONS\u003d\"ansible-config_template ansible-collections-openstack \\"},{"line_number":119,"context_line":"        tripleo-operator-ansible\""},{"line_number":120,"context_line":"    for COLLECTION_REPO in $OS_COLLECTIONS; do"}],"source_content_type":"text/x-sh","patch_set":20,"id":"57cb894d_71c0558c","line":117,"updated":"2022-04-08 11:52:59.000000000","message":"There is a request for more in line doc here - to explain what this aims to do in the different cases.\nReviewers are ok with the approach but it\u0027s hard to work it out at first glance.","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"ded29e123aa708fcf8dd6f09176d2a4cecd4ad89","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            ~/src/github.com/ansible-collections/openvswitch.openvswitch \\"},{"line_number":115,"context_line":"            -p $VIRTUAL_ENV/share/ansible/collections"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OS_COLLECTIONS\u003d\"ansible-config_template ansible-collections-openstack \\"},{"line_number":119,"context_line":"        tripleo-operator-ansible\""},{"line_number":120,"context_line":"    for COLLECTION_REPO in $OS_COLLECTIONS; do"}],"source_content_type":"text/x-sh","patch_set":20,"id":"9ee5ca9f_ae210c1f","line":117,"in_reply_to":"57cb894d_71c0558c","updated":"2022-04-08 15:49:17.000000000","message":"Added a few comments to the script to hopefully make it clearer what\u0027s going on here.\n\nI also refreshed the comment above to bring it more in line with the changes.","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"775d43e411fa977f2ed79de2ea495c36296186ef","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            -p $VIRTUAL_ENV/share/ansible/collections"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OS_COLLECTIONS\u003d\"ansible-config_template ansible-collections-openstack \\"},{"line_number":119,"context_line":"        tripleo-operator-ansible\""},{"line_number":120,"context_line":"    for COLLECTION_REPO in $OS_COLLECTIONS; do"},{"line_number":121,"context_line":"        if [[ -d ~/src/opendev.org/openstack/$COLLECTION_REPO ]]; then"}],"source_content_type":"text/x-sh","patch_set":20,"id":"00e84e2f_a88bb979","line":118,"updated":"2022-04-08 09:32:17.000000000","message":"I understand the reasoning behind this, in that we sometimes have the collections already pulled and therefore we no longer have to download them from repos.\n\nBut I think that a comment with an explanation of sort would be in order.\nSo that the knowledge doesn\u0027t get lost.","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"ded29e123aa708fcf8dd6f09176d2a4cecd4ad89","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            -p $VIRTUAL_ENV/share/ansible/collections"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    OS_COLLECTIONS\u003d\"ansible-config_template ansible-collections-openstack \\"},{"line_number":119,"context_line":"        tripleo-operator-ansible\""},{"line_number":120,"context_line":"    for COLLECTION_REPO in $OS_COLLECTIONS; do"},{"line_number":121,"context_line":"        if [[ -d ~/src/opendev.org/openstack/$COLLECTION_REPO ]]; then"}],"source_content_type":"text/x-sh","patch_set":20,"id":"99bb1261_dedeed7d","line":118,"in_reply_to":"00e84e2f_a88bb979","updated":"2022-04-08 15:49:17.000000000","message":"Done","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"775d43e411fa977f2ed79de2ea495c36296186ef","unresolved":true,"context_lines":[{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"install_ansible_roles(){"},{"line_number":135,"context_line":"    OS_ROLES\u003d\"openstack-ansible-os_tempest ansible-role-python_venv_build\""},{"line_number":136,"context_line":"    for ROLE_REPO in $OS_ROLES; do"},{"line_number":137,"context_line":"        if [[ -d ~/src/opendev.org/openstack/$ROLE_REPO ]]; then"},{"line_number":138,"context_line":"            ansible-galaxy role install --force \\"}],"source_content_type":"text/x-sh","patch_set":20,"id":"e1d776f2_52929b82","line":135,"updated":"2022-04-08 09:32:17.000000000","message":"Same here. The script is very, very long, and bit of commentary can\u0027t hurt. Especially when it comes to something new.","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"ded29e123aa708fcf8dd6f09176d2a4cecd4ad89","unresolved":false,"context_lines":[{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"install_ansible_roles(){"},{"line_number":135,"context_line":"    OS_ROLES\u003d\"openstack-ansible-os_tempest ansible-role-python_venv_build\""},{"line_number":136,"context_line":"    for ROLE_REPO in $OS_ROLES; do"},{"line_number":137,"context_line":"        if [[ -d ~/src/opendev.org/openstack/$ROLE_REPO ]]; then"},{"line_number":138,"context_line":"            ansible-galaxy role install --force \\"}],"source_content_type":"text/x-sh","patch_set":20,"id":"3b9e262e_ed445867","line":135,"in_reply_to":"e1d776f2_52929b82","updated":"2022-04-08 15:49:17.000000000","message":"Done","commit_id":"675dfb15dc5413a4c7b8a158daa977b6da668699"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"deefd4cb1d5923d44b948bb7be9eb46da0fc2b5d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":143,"context_line":"        fi"},{"line_number":144,"context_line":"    done"},{"line_number":145,"context_line":"    ansible-galaxy role install \\"},{"line_number":146,"context_line":"        -r ansible-role-requirements.yml \\"},{"line_number":147,"context_line":"        -p $VIRTUAL_ENV/share/ansible/roles"},{"line_number":148,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"42a1505e_e8febce9","line":145,"updated":"2022-04-11 06:11:33.000000000","message":"theres a bit of repetition here ... one obvious one would be to move this bit and the one on 129-132 into a function that takes parameter (\u0027collections\u0027 or \u0027roles\u0027).\n\nwill not block on this since the review has been in progress a while already","commit_id":"c339bce2000fddb926e438aee805f54463bee265"}]}