)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7faf67dbd023b7bfac1035d60cc40285b0edbfa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"drop AOC, then role os_tempest fails [2] because it does not use"},{"line_number":26,"context_line":"the AOC release that got installed from RDO RPMs even though the"},{"line_number":27,"context_line":"path to the RPM installed collection is in ansible.cfg [3]"},{"line_number":28,"context_line":"which is used in quickstart.sh [4]."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://opendev.org/openstack/openstack-ansible-os_tempest"},{"line_number":31,"context_line":"[2] https://review.rdoproject.org/r/c/testproject/+/43963/3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b2be7512_08e09d96","line":28,"updated":"2022-07-14 07:16:44.000000000","message":"a lot of context here ... almost sounds like a bug ;) - there may be some followup here I think. like investigate whats up with the os_tempest not finding the right aoc to use. longer term working out how to make different releases of aoc for different branches.","commit_id":"c07cebe50449533417099fb00636dcbcd889e841"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f4a96434639529ac34c674b2cbaf97e8ac648077","unresolved":false,"context_lines":[{"line_number":25,"context_line":"drop AOC, then role os_tempest fails [2] because it does not use"},{"line_number":26,"context_line":"the AOC release that got installed from RDO RPMs even though the"},{"line_number":27,"context_line":"path to the RPM installed collection is in ansible.cfg [3]"},{"line_number":28,"context_line":"which is used in quickstart.sh [4]."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://opendev.org/openstack/openstack-ansible-os_tempest"},{"line_number":31,"context_line":"[2] https://review.rdoproject.org/r/c/testproject/+/43963/3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"70a55e42_9ef081c5","line":28,"in_reply_to":"b2be7512_08e09d96","updated":"2022-07-14 08:01:07.000000000","message":"Not a bug, but this is how Ansible works. Can explain in more detail but that i guess the inner workings of ansible-core are too much for this commit message ;)\n\nWe definitely have to figure out how to support different aoc releases but this is future work for when we actually have to separate releases ^^ (it is on our todo list)","commit_id":"c07cebe50449533417099fb00636dcbcd889e841"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ab47d8381898c0ec591245a3a273ae09a34376bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00fb33e2_dba96fef","updated":"2022-07-13 14:25:18.000000000","message":"The latest patchset installs stable/1.0.0 branch from git instead of using the latest release from Ansible Galaxy. According to Sagi, we should install from opendev.org instead of galaxy because the latter is not always accessible, breaking all tripleo jobs.","commit_id":"c07cebe50449533417099fb00636dcbcd889e841"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"34707673eb40bcf577b39af799a34b2be9fb3ffe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35b9c58d_5e73aa18","updated":"2022-07-14 19:48:36.000000000","message":"LGTM, according with tests:\nhttps://review.rdoproject.org/r/c/testproject/+/43963/3#message-e67630d8ad6c976e6a3037f1cfdc210e719282b7","commit_id":"1bab5780645d597b7b59984c4259f3f38d5db3fd"}],"ansible-collection-requirements.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7faf67dbd023b7bfac1035d60cc40285b0edbfa","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  # FIXME(bogdando): LP#1954761: keep these in sync with:"},{"line_number":4,"context_line":"  #   https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/base.yaml"},{"line_number":5,"context_line":"  #"},{"line_number":6,"context_line":"  # TODO: Keep these in sync with releases installed by TripleO!"},{"line_number":7,"context_line":"  - name: ansible.utils"},{"line_number":8,"context_line":"    source: https://galaxy.ansible.com"},{"line_number":9,"context_line":"    version: 2.4.2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"80a8b293_dc4b98a9","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":10},"updated":"2022-07-14 07:16:44.000000000","message":"convention here is to also include a name so we know who to ask for info like: \" #TODO(jmeng) Keep these in sync... \"\n\nBUT\ndo you mean something different to bogdando comment above? if so maybe point to something specific as above does?","commit_id":"c07cebe50449533417099fb00636dcbcd889e841"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f4a96434639529ac34c674b2cbaf97e8ac648077","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  # FIXME(bogdando): LP#1954761: keep these in sync with:"},{"line_number":4,"context_line":"  #   https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/base.yaml"},{"line_number":5,"context_line":"  #"},{"line_number":6,"context_line":"  # TODO: Keep these in sync with releases installed by TripleO!"},{"line_number":7,"context_line":"  - name: ansible.utils"},{"line_number":8,"context_line":"    source: https://galaxy.ansible.com"},{"line_number":9,"context_line":"    version: 2.4.2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7eb0761f_9285ff50","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":10},"in_reply_to":"80a8b293_dc4b98a9","updated":"2022-07-14 08:01:07.000000000","message":"Good point, the latest patchset switches to the #FIXME(jmeng) style :)\n\nIt is different from bogdando\u0027s comment. He is talking about the required-projects attribute in Zuul jobs. What i tried to say here is that you have to keep those requirements in sync with RDO RPMs as well. Rephrased that sentence in my last patchset, hopefully it is better now.","commit_id":"c07cebe50449533417099fb00636dcbcd889e841"}]}
