)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9fddf58663a52d0be3a2f57734a2db3db15a697a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds support for a platform that returns RHEL8 during"},{"line_number":10,"context_line":"information gathering in a run"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If340ce5d06708cffc073fae5d06f6327ec5a6339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_dcff5fa9","line":11,"updated":"2019-07-03 10:40:26.000000000","message":"also moves supported repos to a map to allow version within a distribution\n\npointer to the task/story please?","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"af93cd378c9ac65bc823bac6b4c4b08374e215ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds support for a platform that returns RHEL8 during"},{"line_number":10,"context_line":"information gathering in a run"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If340ce5d06708cffc073fae5d06f6327ec5a6339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_ff1b35c7","line":11,"updated":"2019-07-03 12:11:00.000000000","message":"right.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"}],"tripleo_repos/main.py":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"3f0ead25c6cceb3abdd66db9683015ace8095e02","unresolved":false,"context_lines":[{"line_number":56,"context_line":"enabled\u003d1"},{"line_number":57,"context_line":"\u0027\u0027\u0027"},{"line_number":58,"context_line":"# unversioned fedora added for backwards compatibility"},{"line_number":59,"context_line":"SUPPORTED_DISTROS \u003d [\u0027centos7\u0027, \u0027fedora28\u0027, \u0027fedora\u0027, \u0027rhel8.0\u0027]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class InvalidArguments(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_c453ca38","line":59,"updated":"2019-06-20 15:48:04.000000000","message":"THis is the first pass, tested and works. Differently from other os-releases RHEL reports major and minor version on ID. I think I\u0027ll create some different parsing templates, to account for  all the variations. Centos 7 doesn\u0027t have a PLATFORM_ID for example.\nAlso, are we sure we want to completely remove dealing with minor versions ? Can it be useful for the minor updates ?","commit_id":"c84322323e8adf004be9c350d745cb5ad0072763"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"9ab600c6ab35d2db1e98f970cb61dc00ebdcc362","unresolved":false,"context_lines":[{"line_number":56,"context_line":"enabled\u003d1"},{"line_number":57,"context_line":"\u0027\u0027\u0027"},{"line_number":58,"context_line":"# unversioned fedora added for backwards compatibility"},{"line_number":59,"context_line":"SUPPORTED_DISTROS \u003d [\u0027centos7\u0027, \u0027fedora28\u0027, \u0027fedora\u0027, \u0027rhel8.0\u0027]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class InvalidArguments(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_842ab27b","line":59,"updated":"2019-06-20 15:16:47.000000000","message":"wondering if we can read /etc/os-release and PLATFORM_ID\u003d\"platform:el8\"\n\nso that we can support centos8/rhel8 w/o minor versions and together","commit_id":"c84322323e8adf004be9c350d745cb5ad0072763"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9fddf58663a52d0be3a2f57734a2db3db15a697a","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                   \u0027with fedora28.\u0027)"},{"line_number":243,"context_line":"        distro_branch \u003d \u0027%s-%s\u0027 % (args.distro, args.branch)"},{"line_number":244,"context_line":"    elif args.distro in [\u0027rhel8\u0027]:"},{"line_number":245,"context_line":"        distro_branch \u003d \u0027%s-%s\u0027 % (args.distro, args.branch)"},{"line_number":246,"context_line":"    else:"},{"line_number":247,"context_line":"        distro_branch \u003d args.distro"},{"line_number":248,"context_line":"    return \u0027%s/%s/\u0027 % (args.rdo_mirror, distro_branch)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_4f049818","line":245,"updated":"2019-07-03 10:40:26.000000000","message":"also check/warn about something other than master for rhel8 ?\nwell maybe not since we\u0027ll want train to work too.","commit_id":"b08eadcc8f8d7c2261195d6afa89a8a15d4c66cd"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"065c97c70d72f48ed525c357d65fbc7c7c978782","unresolved":false,"context_lines":[{"line_number":57,"context_line":"enabled\u003d1"},{"line_number":58,"context_line":"\u0027\u0027\u0027"},{"line_number":59,"context_line":"# unversioned fedora added for backwards compatibility"},{"line_number":60,"context_line":"SUPPORTED_DISTROS \u003d ["},{"line_number":61,"context_line":"    (\u0027centos\u0027, \u00277\u0027),"},{"line_number":62,"context_line":"    (\u0027fedora\u0027, \u002728\u0027),"},{"line_number":63,"context_line":"    (\u0027fedora\u0027, \u0027\u0027),"},{"line_number":64,"context_line":"    (\u0027rhel\u0027, \u00278\u0027)"},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class InvalidArguments(Exception):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fb8cfa7_4cdd183f","line":65,"range":{"start_line":60,"start_character":20,"end_line":65,"end_character":1},"updated":"2019-07-02 08:21:59.000000000","message":"Can we use dict here instead of list?\nSUPPORTED_DISTROS \u003d {\u0027centos\u0027:(7,), \u0027fedora\u0027:(28, \u0027 \u0027), \u0027rhel\u0027: (8,)}","commit_id":"88839ee8491ef947844bc9a05dc2108978990263"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"f9df688a408817fcd9f80af0947c92cfb04a8f4b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    (\u0027fedora\u0027, \u002728\u0027),"},{"line_number":63,"context_line":"    (\u0027fedora\u0027, \u0027\u0027),"},{"line_number":64,"context_line":"    (\u0027rhel\u0027, \u00278\u0027)"},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class InvalidArguments(Exception):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fb8cfa7_afbcc605","line":65,"updated":"2019-07-02 09:23:25.000000000","message":"I don\u0027t seem much advantage. It would probably decrease readability and make lookup more complicated. We are using this to chack support, and we would need nested loops, then we are using it in argpase to build the list of choices, another nested loop to convert everything into a list of strings.","commit_id":"88839ee8491ef947844bc9a05dc2108978990263"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"fc3116b89bce0f061b244a13571c2c7ef5f0067c","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # if distro_version_id is empty string the major version will be empty"},{"line_number":90,"context_line":"    # string too"},{"line_number":91,"context_line":"    distro_major_version_id \u003d distro_version_id.split(\u0027.\u0027)[0]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    if (distro_id, distro_major_version_id) not in SUPPORTED_DISTROS:"},{"line_number":94,"context_line":"        print("}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_ff49f5b6","line":91,"updated":"2019-07-03 12:12:34.000000000","message":"@Chandan, as soring found out, the platform library is not as reliable as the os-release file. And the os-release file is what even ansible uses to undestand what platform we\u0027re in.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"af93cd378c9ac65bc823bac6b4c4b08374e215ad","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # if distro_version_id is empty string the major version will be empty"},{"line_number":90,"context_line":"    # string too"},{"line_number":91,"context_line":"    distro_major_version_id \u003d distro_version_id.split(\u0027.\u0027)[0]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    if (distro_id, distro_major_version_id) not in SUPPORTED_DISTROS:"},{"line_number":94,"context_line":"        print("}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9f76b90c","line":91,"updated":"2019-07-03 12:11:00.000000000","message":"This is a bash source, and would need a bash parsing. Using bash to do the dirty work,  requires subprocess, but then it\u0027s easier to handle the output. Trying to do the parsing in python directly means dealing with all the peculiarities of the os-release file, mainly: 1) stripping newlines at the end of every line (which is the easy part) and 2) stripping the values of the double quotes (e.g. with your method, version_id is \u0027\"9\"\u0027.\nI prefer to let bash handle its parsing and not trying to scrap text.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"62bc5f357270b2bbc0e6abc6813ab24e8260eee4","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def _get_distro():"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    output \u003d subprocess.Popen("},{"line_number":79,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\"\u0027,"},{"line_number":80,"context_line":"        shell\u003dTrue,"},{"line_number":81,"context_line":"        stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"        stderr\u003dopen(os.devnull, \u0027w\u0027),"},{"line_number":83,"context_line":"        executable\u003d\u0027/bin/bash\u0027,"},{"line_number":84,"context_line":"        universal_newlines\u003dTrue).communicate()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # distro_id and distro_version_id will always be at least an empty string"},{"line_number":87,"context_line":"    distro_id, distro_version_id \u003d output[0].split(\u0027\\n\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # if distro_version_id is empty string the major version will be empty"},{"line_number":90,"context_line":"    # string too"},{"line_number":91,"context_line":"    distro_major_version_id \u003d distro_version_id.split(\u0027.\u0027)[0]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    if (distro_id, distro_major_version_id) not in SUPPORTED_DISTROS:"},{"line_number":94,"context_line":"        print("}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_bc306ba0","line":91,"range":{"start_line":77,"start_character":0,"end_line":91,"end_character":61},"updated":"2019-07-03 10:52:55.000000000","message":"you could just open the file:\n\nwith open(\"/etc/os-release\") as f:\n    ids \u003d dict([i.split(\"\u003d\") for i in f.readlines() if \"ID\" in i])","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"585b4a674fe13287f82fa22f5281b3321f5076e6","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def _get_distro():"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    output \u003d subprocess.Popen("},{"line_number":79,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\"\u0027,"},{"line_number":80,"context_line":"        shell\u003dTrue,"},{"line_number":81,"context_line":"        stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"        stderr\u003dopen(os.devnull, \u0027w\u0027),"},{"line_number":83,"context_line":"        executable\u003d\u0027/bin/bash\u0027,"},{"line_number":84,"context_line":"        universal_newlines\u003dTrue).communicate()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # distro_id and distro_version_id will always be at least an empty string"},{"line_number":87,"context_line":"    distro_id, distro_version_id \u003d output[0].split(\u0027\\n\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # if distro_version_id is empty string the major version will be empty"},{"line_number":90,"context_line":"    # string too"},{"line_number":91,"context_line":"    distro_major_version_id \u003d distro_version_id.split(\u0027.\u0027)[0]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    if (distro_id, distro_major_version_id) not in SUPPORTED_DISTROS:"},{"line_number":94,"context_line":"        print("}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_fc7a63b8","line":91,"range":{"start_line":77,"start_character":0,"end_line":91,"end_character":61},"in_reply_to":"9fb8cfa7_bc306ba0","updated":"2019-07-03 11:22:29.000000000","message":"I am not sure does this will help?\n\u003e\u003e\u003e import platform\n\u003e\u003e\u003e platform.linux_distribution()\n(\u0027Fedora\u0027, \u002730\u0027, \u0027Thirty\u0027)","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"af93cd378c9ac65bc823bac6b4c4b08374e215ad","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    distro_id, distro_major_version_id \u003d _get_distro()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    distro \u003d \"{}{}\".format(distro_id, distro_major_version_id)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Calculating arguments default from constants"},{"line_number":111,"context_line":"    default_mirror \u003d DEFAULT_MIRROR_MAP[distro_id]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_bf7b7df2","line":108,"updated":"2019-07-03 12:11:00.000000000","message":"I always try to use the \"new\"(since python 2.6 ..) .format style, but then I don\u0027t try to change much code that was already there.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"62bc5f357270b2bbc0e6abc6813ab24e8260eee4","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    distro_id, distro_major_version_id \u003d _get_distro()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    distro \u003d \"{}{}\".format(distro_id, distro_major_version_id)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Calculating arguments default from constants"},{"line_number":111,"context_line":"    default_mirror \u003d DEFAULT_MIRROR_MAP[distro_id]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_1ce4170e","line":108,"range":{"start_line":108,"start_character":13,"end_line":108,"end_character":27},"updated":"2019-07-03 10:52:55.000000000","message":"in function above you used \"%s%s\", maybe better to keep the same style, not a biggie though","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"af93cd378c9ac65bc823bac6b4c4b08374e215ad","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Calculating arguments default from constants"},{"line_number":111,"context_line":"    default_mirror \u003d DEFAULT_MIRROR_MAP[distro_id]"},{"line_number":112,"context_line":"    distro_choices \u003d list(map(\u0027\u0027.join, SUPPORTED_DISTROS))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":115,"context_line":"        description\u003d\u0027Download and install repos necessary for TripleO. Note \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_5f8041c0","line":112,"updated":"2019-07-03 12:11:00.000000000","message":"Matter of taste, but you\u0027re right, not many know what map does.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"62bc5f357270b2bbc0e6abc6813ab24e8260eee4","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Calculating arguments default from constants"},{"line_number":111,"context_line":"    default_mirror \u003d DEFAULT_MIRROR_MAP[distro_id]"},{"line_number":112,"context_line":"    distro_choices \u003d list(map(\u0027\u0027.join, SUPPORTED_DISTROS))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":115,"context_line":"        description\u003d\u0027Download and install repos necessary for TripleO. Note \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9c9ec767","line":112,"range":{"start_line":112,"start_character":21,"end_line":112,"end_character":58},"updated":"2019-07-03 10:52:55.000000000","message":"[\"\".join(distro) for distro in SUPPORTED_DISTROS] I think is more readable.","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"063c0bce09358de3e04678be42dcfdff6d80db51","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"        stderr\u003dopen(os.devnull, \u0027w\u0027),"},{"line_number":83,"context_line":"        executable\u003d\u0027/bin/bash\u0027,"},{"line_number":84,"context_line":"        universal_newlines\u003dTrue).communicate()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # distro_id and distro_version_id will always be at least an empty string"},{"line_number":87,"context_line":"    distro_id, distro_version_id \u003d output[0].split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_5ae9377e","line":84,"updated":"2019-07-04 13:08:51.000000000","message":"I explained this in details on the previous patchset.","commit_id":"99d78f28f1ee2cf545a473091b668131cece3b16"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a5a27835c6f19a5bb2c76d90d98f89db0af6f56b","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def _get_distro():"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    output \u003d subprocess.Popen("},{"line_number":79,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\"\u0027,"},{"line_number":80,"context_line":"        shell\u003dTrue,"},{"line_number":81,"context_line":"        stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"        stderr\u003dopen(os.devnull, \u0027w\u0027),"},{"line_number":83,"context_line":"        executable\u003d\u0027/bin/bash\u0027,"},{"line_number":84,"context_line":"        universal_newlines\u003dTrue).communicate()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # distro_id and distro_version_id will always be at least an empty string"},{"line_number":87,"context_line":"    distro_id, distro_version_id \u003d output[0].split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_66834358","line":84,"range":{"start_line":78,"start_character":11,"end_line":84,"end_character":24},"updated":"2019-07-04 07:25:05.000000000","message":"i know this is pre-existing and it should really go in a followup and not here, please don\u0027t update it it is already too big a change.\n\nhowever, what is the advantage of doing it that way vs reading the file and parsing ID/VERSION_ID. seems cleaner for me.","commit_id":"99d78f28f1ee2cf545a473091b668131cece3b16"}],"tripleo_repos/tests/test_main.py":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"af93cd378c9ac65bc823bac6b4c4b08374e215ad","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        path \u003d main._get_base_path(args)"},{"line_number":133,"context_line":"        self.assertEqual(\u0027http://trunk.rdoproject.org/fedora-master/\u0027, path)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_get_base_path_fedora_unsup_branch(self):"},{"line_number":136,"context_line":"        args \u003d mock.Mock()"},{"line_number":137,"context_line":"        args.branch \u003d \u0027rocky\u0027"},{"line_number":138,"context_line":"        args.distro \u003d \u0027fedora28\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_7f8505cf","line":135,"updated":"2019-07-03 12:11:00.000000000","message":"It would not add any meaningful test, the rhel8-master falls into the base path test now, the other test you see in fedora are there because fedora as exceptions in the function.\nI will remove one of the test though, as base_path and base_path_branch are now the same","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9fddf58663a52d0be3a2f57734a2db3db15a697a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        path \u003d main._get_base_path(args)"},{"line_number":133,"context_line":"        self.assertEqual(\u0027http://trunk.rdoproject.org/fedora-master/\u0027, path)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_get_base_path_fedora_unsup_branch(self):"},{"line_number":136,"context_line":"        args \u003d mock.Mock()"},{"line_number":137,"context_line":"        args.branch \u003d \u0027rocky\u0027"},{"line_number":138,"context_line":"        args.distro \u003d \u0027fedora28\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9cd0072e","line":135,"updated":"2019-07-03 10:40:26.000000000","message":"how about adding a test for rhel8-master?","commit_id":"3c89c43d141fe249be9e8b90aac7508daeb22ac2"}]}