)]}'
{"tripleo_repos/main.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f50aeb9a4324f985651032550cd41298f12ea154","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        new_content +\u003d \u0027\\npriority\u003d%d\u0027 % new_priority"},{"line_number":314,"context_line":"    return new_content"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def _add_includepkgs(content):"},{"line_number":318,"context_line":"    new_content \u003d []"},{"line_number":319,"context_line":"    for line in content.split(\"\\n\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_320d7937","line":316,"updated":"2020-06-19 08:48:40.000000000","message":"does it work for you?\n\nsince both current-tripleo and current have same repo name and different priority only current repo which has higher priority will be considered and non includepkgs will be not be installed.","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ebf076d807f28c22fd92b2003c26ccca7a83d56e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        new_content +\u003d \u0027\\npriority\u003d%d\u0027 % new_priority"},{"line_number":314,"context_line":"    return new_content"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def _add_includepkgs(content):"},{"line_number":318,"context_line":"    new_content \u003d []"},{"line_number":319,"context_line":"    for line in content.split(\"\\n\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f162dc3d","line":316,"in_reply_to":"bf51134e_320d7937","updated":"2020-06-19 13:31:00.000000000","message":"It worked for me, but i\u0027ll check more on this.","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0df0cdc0faec2eb2f0717393328b4b7fdf06f44e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        new_content +\u003d \u0027\\npriority\u003d%d\u0027 % new_priority"},{"line_number":314,"context_line":"    return new_content"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def _add_includepkgs(content):"},{"line_number":318,"context_line":"    new_content \u003d []"},{"line_number":319,"context_line":"    for line in content.split(\"\\n\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b73694e5","line":316,"in_reply_to":"bf51134e_320d7937","updated":"2020-06-19 14:19:06.000000000","message":"So i tested and delorean-current-tripleo.repo gets priority 20 and delorean.repo gets priority 10 \u0026 includepkgs","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e0d808cf59bcbb349c6fcdda252fe9de7d3038f4","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        new_content +\u003d \u0027\\npriority\u003d%d\u0027 % new_priority"},{"line_number":314,"context_line":"    return new_content"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def _add_includepkgs(content):"},{"line_number":318,"context_line":"    new_content \u003d []"},{"line_number":319,"context_line":"    for line in content.split(\"\\n\"):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e2f04c6a","line":316,"in_reply_to":"bf51134e_b73694e5","updated":"2020-06-19 15:26:43.000000000","message":"yes with PS1 repos will be setup but shouldn\u0027t work, as all packages will not be available due to includepkgs in current repo and same name for all repos in current-tripleo.","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0ade49f38790b7d9a5095103d56dce00a013a626","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":367,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":368,"context_line":"                                args)"},{"line_number":369,"context_line":"            content \u003d TITLE_RE.sub(\u0027[delorean-current-tripleo]\u0027, content)"},{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_9241e53c","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":73},"updated":"2020-06-19 08:53:32.000000000","message":"ok because of this previous comment get invalid, but issue is still there as all repos will have same name and due to it only one component will persist in current-tripleo.","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0df0cdc0faec2eb2f0717393328b4b7fdf06f44e","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":367,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":368,"context_line":"                                args)"},{"line_number":369,"context_line":"            content \u003d TITLE_RE.sub(\u0027[delorean-current-tripleo]\u0027, content)"},{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3758c430","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":73},"in_reply_to":"bf51134e_11395040","updated":"2020-06-19 14:19:06.000000000","message":"It doesn\u0027t seem to impact anything because name\u003d, but i\u0027ll update this","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e0d808cf59bcbb349c6fcdda252fe9de7d3038f4","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":367,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":368,"context_line":"                                args)"},{"line_number":369,"context_line":"            content \u003d TITLE_RE.sub(\u0027[delorean-current-tripleo]\u0027, content)"},{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_42513862","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":73},"in_reply_to":"bf51134e_3758c430","updated":"2020-06-19 15:26:43.000000000","message":"sorry didn\u0027t get, u mean because of name\u003d repoid is not entertained?","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ebf076d807f28c22fd92b2003c26ccca7a83d56e","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":367,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":368,"context_line":"                                args)"},{"line_number":369,"context_line":"            content \u003d TITLE_RE.sub(\u0027[delorean-current-tripleo]\u0027, content)"},{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_11395040","line":369,"range":{"start_line":369,"start_character":12,"end_line":369,"end_character":73},"in_reply_to":"bf51134e_9241e53c","updated":"2020-06-19 13:31:00.000000000","message":"since we specify name\u003d in all the repos bit, this doesn\u0027t actually do anything. This is already a problem today (no change related to this)","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4f244d1ec88417457635fac65cb0d8a5ee64079a","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"},{"line_number":373,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":374,"context_line":"            content \u003d _get_repo(base_path + \u0027current/delorean.repo\u0027, args)"},{"line_number":375,"context_line":"            content \u003d _add_includepkgs(content)"},{"line_number":376,"context_line":"            content \u003d _change_priority(content, 10)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ed2b267f","line":373,"updated":"2020-06-19 09:56:54.000000000","message":"may be worth try below changes to work with both component and non component repos:-\n\n-- content \u003d TITLE_RE.sub(\u0027[delorean-current-tripleo]\u0027, content)\n++ content \u003d TITLE_RE.sub(\u0027[\\\\1-current-tripleo]\u0027, content)\n\n-- _write_repo(content, args.output_path)\n++ _write_repo(content, args.output_path, \u0027delorean-current-tripleo\u0027)","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0df0cdc0faec2eb2f0717393328b4b7fdf06f44e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            # We need to twiddle priorities since we\u0027re mixing multiple repos"},{"line_number":371,"context_line":"            # that are generated with the same priority."},{"line_number":372,"context_line":"            content \u003d _change_priority(content, 20)"},{"line_number":373,"context_line":"            _write_repo(content, args.output_path)"},{"line_number":374,"context_line":"            content \u003d _get_repo(base_path + \u0027current/delorean.repo\u0027, args)"},{"line_number":375,"context_line":"            content \u003d _add_includepkgs(content)"},{"line_number":376,"context_line":"            content \u003d _change_priority(content, 10)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1774a098","line":373,"in_reply_to":"bf51134e_ed2b267f","updated":"2020-06-19 14:19:06.000000000","message":"I\u0027ll update content, but we don\u0027t want to write the repo to delorean-current-tripleo as mentioned above we want both because delorean-current-tripleo.repo gets priority 20 and this one gets priority 10","commit_id":"98ae99913b77a355c79a0692f1407bfa38e372aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de6ff06cdd07b4fe9a1dd2565d54aa8310fe8d97","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            install_deps(args, base_path)"},{"line_number":370,"context_line":"        elif repo \u003d\u003d \u0027current-tripleo-dev\u0027:"},{"line_number":371,"context_line":"            content \u003d _get_repo(base_path + \u0027delorean-deps.repo\u0027, args)"},{"line_number":372,"context_line":"            _write_repo(content, args.output_path, name\u003d\u0027delorean-deps\u0027)"},{"line_number":373,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":374,"context_line":"                                args)"},{"line_number":375,"context_line":"            content \u003d TITLE_RE.sub(\u0027[\\\\1-current-tripleo]\u0027, content)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_bd9e75b5","line":372,"range":{"start_line":372,"start_character":57,"end_line":372,"end_character":69},"updated":"2020-06-19 15:45:03.000000000","message":"i think good to not change this as iirc some jobs relies on naming of repo, like delorean-\u003crelease\u003e-testing etc, apart from this all looks good.","commit_id":"ff6b81c9b2dc7189bb3384dc836c6aaa2fd38f50"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b6832aff6a02322fa8a25b3cdcd9e040a84a33f4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            install_deps(args, base_path)"},{"line_number":370,"context_line":"        elif repo \u003d\u003d \u0027current-tripleo-dev\u0027:"},{"line_number":371,"context_line":"            content \u003d _get_repo(base_path + \u0027delorean-deps.repo\u0027, args)"},{"line_number":372,"context_line":"            _write_repo(content, args.output_path, name\u003d\u0027delorean-deps\u0027)"},{"line_number":373,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":374,"context_line":"                                args)"},{"line_number":375,"context_line":"            content \u003d TITLE_RE.sub(\u0027[\\\\1-current-tripleo]\u0027, content)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_fde0edfc","line":372,"range":{"start_line":372,"start_character":57,"end_line":372,"end_character":69},"in_reply_to":"bf51134e_bd9e75b5","updated":"2020-06-19 15:47:20.000000000","message":"ehhhh i guess? It just takes the first repo in the file if not specified. I guess we can change that though this is only ever going to be master because current-tripleo-dev only works for master","commit_id":"ff6b81c9b2dc7189bb3384dc836c6aaa2fd38f50"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c9393d7b12789e69e824fad62fcf24228cf7d998","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            install_deps(args, base_path)"},{"line_number":370,"context_line":"        elif repo \u003d\u003d \u0027current-tripleo-dev\u0027:"},{"line_number":371,"context_line":"            content \u003d _get_repo(base_path + \u0027delorean-deps.repo\u0027, args)"},{"line_number":372,"context_line":"            _write_repo(content, args.output_path, name\u003d\u0027delorean-deps\u0027)"},{"line_number":373,"context_line":"            content \u003d _get_repo(base_path + \u0027current-tripleo/delorean.repo\u0027,"},{"line_number":374,"context_line":"                                args)"},{"line_number":375,"context_line":"            content \u003d TITLE_RE.sub(\u0027[\\\\1-current-tripleo]\u0027, content)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_3d238507","line":372,"range":{"start_line":372,"start_character":57,"end_line":372,"end_character":69},"in_reply_to":"bf51134e_fde0edfc","updated":"2020-06-19 15:55:47.000000000","message":"ahh right, the jobs i mentioned runs with current-tripleo or tripleo-ci-testing and u changing current-tripleo-dev, but without name it\u0027s good too. Latest PS is fine.","commit_id":"ff6b81c9b2dc7189bb3384dc836c6aaa2fd38f50"}]}