)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"77d0d37b17cc20de30ff5eb024dfefc55076a2e2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adds tripleo_get_hash ansible module, example play \u0026 updates README"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds tripleo_get_hash python module for use with ansible as well"},{"line_number":10,"context_line":"as an example_playbook.yaml. The deafult config path is changed from"},{"line_number":11,"context_line":"/etc/ to /usr/local/etc. Includes updates to the README"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I18c46de71031ca1dd3f1a4f75df651ced12ebff1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4583e478_a4023986","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":40},"updated":"2021-05-17 09:17:21.000000000","message":"Typo: default","commit_id":"32caca4253054e5cf16385b348405124c07aa45d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4a9b0c04d1a9f2acad0210359ca6731b3cb99f37","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds tripleo_get_hash ansible module, example play \u0026 updates README"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds tripleo_get_hash python module for use with ansible as well"},{"line_number":10,"context_line":"as an example_playbook.yaml. The deafult config path is changed from"},{"line_number":11,"context_line":"/etc/ to /usr/local/etc. Includes updates to the README"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I18c46de71031ca1dd3f1a4f75df651ced12ebff1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"379b788f_317ee8f1","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":40},"in_reply_to":"4583e478_a4023986","updated":"2021-05-17 10:10:55.000000000","message":"Ack","commit_id":"32caca4253054e5cf16385b348405124c07aa45d"}],"tripleo-get-hash/example_playbook.yaml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a0c11cb2872018a234fad0372c4adbcd5f49ca16","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Example usage for tripleo-get-hash python module"},{"line_number":3,"context_line":"  hosts: localhost"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: get current-tripleo centos8"},{"line_number":6,"context_line":"      tripleo_get_hash:"},{"line_number":7,"context_line":"      register: centos8_current_tripleo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - debug:"},{"line_number":10,"context_line":"        msg: \"Centos8 current-tripleo master: {{ centos8_current_tripleo[\u0027full_hash\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"056ddb73_0d2f6ec3","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":39},"updated":"2021-05-13 16:13:34.000000000","message":"default is c8 master current-tripleo I guess? It\u0027s good, just not 100% clear","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1e85b723d61db792e8c578b09c0b65bb34e12e9c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Example usage for tripleo-get-hash python module"},{"line_number":3,"context_line":"  hosts: localhost"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: get current-tripleo centos8"},{"line_number":6,"context_line":"      tripleo_get_hash:"},{"line_number":7,"context_line":"      register: centos8_current_tripleo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - debug:"},{"line_number":10,"context_line":"        msg: \"Centos8 current-tripleo master: {{ centos8_current_tripleo[\u0027full_hash\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a5aac352_7c546246","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":39},"in_reply_to":"056ddb73_0d2f6ec3","updated":"2021-05-14 08:45:01.000000000","message":"sure I can add some more comments here","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"}],"tripleo-get-hash/setup.cfg":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"931f509a2cc7ca24c2a2e30d7da914ad8e7257ce","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    tripleo-get-hash \u003d tripleo_get_hash.__main__:cli_entrypoint"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[options.data_files]"},{"line_number":32,"context_line":"    /usr/local/etc/tripleo_get_hash/ \u003d config.yaml"},{"line_number":33,"context_line":"    /usr/share/ansible/plugins/modules/ \u003d tripleo_get_hash.py"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"96e28dd0_77c5235f","line":32,"updated":"2021-05-14 07:42:46.000000000","message":"May be we donot need to add this path here  /usr/local/etc/tripleo_get_hash/, we can just document it, so that user can easily create their own config file and create it there. Just like openstackclient does. It looks for path in ~/.config/openstack if not found go to /etc/openstack. \n\nThen it will remove dependency of sudo.","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3a4ab092b797be18c22f1836e4975e3210959ab5","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    tripleo-get-hash \u003d tripleo_get_hash.__main__:cli_entrypoint"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[options.data_files]"},{"line_number":32,"context_line":"    /usr/local/etc/tripleo_get_hash/ \u003d config.yaml"},{"line_number":33,"context_line":"    /usr/share/ansible/plugins/modules/ \u003d tripleo_get_hash.py"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"e4e42abc_ceca1a86","line":32,"in_reply_to":"6694c269_4cbb4afd","updated":"2021-05-14 10:31:57.000000000","message":"Thank you Marios, Make sense now.","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1e85b723d61db792e8c578b09c0b65bb34e12e9c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    tripleo-get-hash \u003d tripleo_get_hash.__main__:cli_entrypoint"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[options.data_files]"},{"line_number":32,"context_line":"    /usr/local/etc/tripleo_get_hash/ \u003d config.yaml"},{"line_number":33,"context_line":"    /usr/share/ansible/plugins/modules/ \u003d tripleo_get_hash.py"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"6694c269_4cbb4afd","line":32,"in_reply_to":"96e28dd0_77c5235f","updated":"2021-05-14 08:45:01.000000000","message":"no it will not remove dependency of sudo it is still needed for the python install: \n\npython setup.py install \n...\ncreating /usr/local/lib/python3.9/site-packages/tripleo_repos\nerror: could not create \u0027/usr/local/lib/python3.9/site-packages/tripleo_repos\u0027: Permission denied\n\nThe config.yaml has to be installed _somewhere_ otherwise the tripleo-get-hash will not run. It tries to load the config from https://review.opendev.org/c/openstack/tripleo-repos/+/790975/2/tripleo-get-hash/tripleo_get_hash/constants.py#b33 (by default) and if it isn\u0027t there it looks in the source checkout ../config.yaml. https://opendev.org/openstack/tripleo-repos/src/commit/33464b5661a06dce0e78e0b220671177c0461007/tripleo-get-hash/tripleo_get_hash/tripleo_hash_info.py#L106-L107\n\nI don\u0027t want to remove it from this file because then the program wont be able to run after you install it and forcing the user to create/copy the config file before they can run what they just installed is a bad user experience imo.","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"}],"tripleo-get-hash/tripleo_get_hash.py":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a0c11cb2872018a234fad0372c4adbcd5f49ca16","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        description: The operating system and version to fetch hashes for"},{"line_number":34,"context_line":"        required: false"},{"line_number":35,"context_line":"        type: str"},{"line_number":36,"context_line":"        default: centos8"},{"line_number":37,"context_line":"    release:"},{"line_number":38,"context_line":"        description: The release of OpenStack you want the hash info for"},{"line_number":39,"context_line":"        required: false"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e155fd4_bbf9dc59","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":24},"updated":"2021-05-13 16:13:34.000000000","message":"nice","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a0c11cb2872018a234fad0372c4adbcd5f49ca16","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        description: The release of OpenStack you want the hash info for"},{"line_number":39,"context_line":"        required: false"},{"line_number":40,"context_line":"        type: str"},{"line_number":41,"context_line":"        default: master"},{"line_number":42,"context_line":"    component:"},{"line_number":43,"context_line":"        description: The tripleo-ci component you are interested in"},{"line_number":44,"context_line":"        required: false"}],"source_content_type":"text/x-python","patch_set":2,"id":"e936deac_437a8e6b","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":23},"updated":"2021-05-13 16:13:34.000000000","message":"nice","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a0c11cb2872018a234fad0372c4adbcd5f49ca16","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        description: The named tag to fetch"},{"line_number":49,"context_line":"        required: false"},{"line_number":50,"context_line":"        type: str"},{"line_number":51,"context_line":"        default: current-tripleo"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"author:"},{"line_number":54,"context_line":"    - Marios Andreou (@marios)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6221959b_0fcd24e2","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":32},"updated":"2021-05-13 16:13:34.000000000","message":"nice","commit_id":"757e052a399f635fe6b3533d348d99bfe66f87a1"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"77d0d37b17cc20de30ff5eb024dfefc55076a2e2","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    type: str"},{"line_number":84,"context_line":"    returned: when available"},{"line_number":85,"context_line":"    sample: \u0027f47f1db5af04ddd1ab4cc3ccadf95884d335b3f3\u0027"},{"line_number":86,"context_line":"\u0027\u0027\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def run_module():"}],"source_content_type":"text/x-python","patch_set":4,"id":"031f5a70_0ebb6e17","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":3},"updated":"2021-05-17 09:17:21.000000000","message":"We are returning result[\u0027dlrn_url\u0027] as well, i think worth to add return info about dlrn_url as well.","commit_id":"32caca4253054e5cf16385b348405124c07aa45d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4a9b0c04d1a9f2acad0210359ca6731b3cb99f37","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    type: str"},{"line_number":84,"context_line":"    returned: when available"},{"line_number":85,"context_line":"    sample: \u0027f47f1db5af04ddd1ab4cc3ccadf95884d335b3f3\u0027"},{"line_number":86,"context_line":"\u0027\u0027\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def run_module():"}],"source_content_type":"text/x-python","patch_set":4,"id":"42c03c5a_4be8fe97","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":3},"in_reply_to":"031f5a70_0ebb6e17","updated":"2021-05-17 10:10:55.000000000","message":"sure let\u0027s add thanks","commit_id":"32caca4253054e5cf16385b348405124c07aa45d"}]}