)]}'
{"docs/get_hash.md":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e782d29345a642a3c259962cdd7a014c8dd44ce8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"#### Install using pip"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"You can also install using python pip - you can see the"},{"line_number":41,"context_line":"[tripleo-get-hash module here](https://pypi.org/project/tripleo-get-hash/)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"```"},{"line_number":44,"context_line":"    pip install tripleo-repos --user"}],"source_content_type":"text/x-markdown","patch_set":7,"id":"04e3ccdb_a494bdb4","line":41,"range":{"start_line":41,"start_character":58,"end_line":41,"end_character":71},"updated":"2021-07-16 13:31:41.000000000","message":"this will no longer be a thing rename","commit_id":"370cd6453f37c04a909949400db46f2c4f0c4177"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"2645ae81f6ba5ec71c94250c653c0fdc496a75e5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#### Install using pip"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"You can also install using python pip - you can see the"},{"line_number":41,"context_line":"[tripleo-get-hash module here](https://pypi.org/project/tripleo-get-hash/)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"```"},{"line_number":44,"context_line":"    pip install tripleo-repos --user"}],"source_content_type":"text/x-markdown","patch_set":7,"id":"362d4efb_ab59b62a","line":41,"range":{"start_line":41,"start_character":58,"end_line":41,"end_character":71},"in_reply_to":"04e3ccdb_a494bdb4","updated":"2021-07-16 14:00:57.000000000","message":"Done","commit_id":"370cd6453f37c04a909949400db46f2c4f0c4177"}],"setup.cfg":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"50ff04b7db70578a2f9d2adae9b033abd95072a6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"data_files \u003d"},{"line_number":28,"context_line":"    etc/tripleo_get_hash/ \u003d tripleo_repos/get_hash/config.yaml"},{"line_number":29,"context_line":"    # Temporary until we get a proper Ansible collection:"},{"line_number":30,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/yum_config/tripleo_yum_config.py"},{"line_number":31,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/get_hash/tripleo_get_hash.py"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"2e1847bc_2d25c26d","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":35},"updated":"2021-07-20 17:21:30.000000000","message":"Need to ensure these are in our modules path:\n/usr/local/share/ansible/plugins/modules\nBecause currently it\u0027s not: https://github.com/openstack/tripleo-quickstart/blob/master/ansible.cfg#L18","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"216dde369d79a38b7f4fcf6a081c651386fe26cc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"data_files \u003d"},{"line_number":28,"context_line":"    etc/tripleo_get_hash/ \u003d tripleo_repos/get_hash/config.yaml"},{"line_number":29,"context_line":"    # Temporary until we get a proper Ansible collection:"},{"line_number":30,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/yum_config/tripleo_yum_config.py"},{"line_number":31,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/get_hash/tripleo_get_hash.py"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"79e2e6bb_5b821429","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":35},"in_reply_to":"0b6dcbe8_8f7a5309","updated":"2021-07-21 06:34:49.000000000","message":"i am adding the /local in https://review.opendev.org/c/openstack/tripleo-quickstart/+/791486/33/ansible.cfg btw","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"842d0e14a3bc41af3828c34f3ce89ea5e8e594e0","unresolved":true,"context_lines":[{"line_number":27,"context_line":"data_files \u003d"},{"line_number":28,"context_line":"    etc/tripleo_get_hash/ \u003d tripleo_repos/get_hash/config.yaml"},{"line_number":29,"context_line":"    # Temporary until we get a proper Ansible collection:"},{"line_number":30,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/yum_config/tripleo_yum_config.py"},{"line_number":31,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/get_hash/tripleo_get_hash.py"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"e9056b04_5e5e56c8","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":35},"in_reply_to":"2e1847bc_2d25c26d","updated":"2021-07-20 17:34:14.000000000","message":"These paths are taken from the setup.cfg of the individual modules. I do not expect any change, ansible module(s) should endup in the same location as before.","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4bfa674ca93b74b2800a91ef80f2ee393e3c1eae","unresolved":true,"context_lines":[{"line_number":27,"context_line":"data_files \u003d"},{"line_number":28,"context_line":"    etc/tripleo_get_hash/ \u003d tripleo_repos/get_hash/config.yaml"},{"line_number":29,"context_line":"    # Temporary until we get a proper Ansible collection:"},{"line_number":30,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/yum_config/tripleo_yum_config.py"},{"line_number":31,"context_line":"    share/ansible/plugins/modules/ \u003d tripleo_repos/get_hash/tripleo_get_hash.py"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"0b6dcbe8_8f7a5309","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":35},"in_reply_to":"e9056b04_5e5e56c8","updated":"2021-07-20 18:04:36.000000000","message":"it\u0027s /usr/share/ansible/plugins/modules/ vs /usr/local/share/ansible/plugins/modules/\nIDK why it uses \"local\" when installing, but ansible seems like doesn\u0027t know about \"local\" paths\nanyway, I +w this and we\u0027ll see, maybe it\u0027s only on my environment, but anyway better to add /usr/local/share/ansible/plugins/modules/ to modules path in ansible.cfg","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"}],"tripleo_repos/get_hash/tripleo_hash_info.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"daba68bbd56f58779848fdae0f7eb98a4ce9927d","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            paths \u003d ["},{"line_number":96,"context_line":"                # pip install --user"},{"line_number":97,"context_line":"                os.path.expanduser("},{"line_number":98,"context_line":"                    \"~/.local/etc/tripleo_get_hash/config.yaml\"),"},{"line_number":99,"context_line":"                # root install"},{"line_number":100,"context_line":"                \"/etc/tripleo_get_hash/config.yaml\","},{"line_number":101,"context_line":"                # embedded config.yaml as fallback"}],"source_content_type":"text/x-python","patch_set":8,"id":"179c9b74_4dd69214","line":98,"range":{"start_line":98,"start_character":23,"end_line":98,"end_character":24},"updated":"2021-07-19 07:14:44.000000000","message":"on my box (fedora) this is more like /usr/local/etc/tripleo_get_hash/config.yaml (above i had it without the leading / so it would also work from a pip install )\n\nanyway the point is when does it end up in .local? Currently it needs sudo for installation. Does the new setup.cfg no longer need that? If so then perhaps .local is correct.","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"84de4e80fc8c5edaf710f07894c6d88983bd4324","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            paths \u003d ["},{"line_number":96,"context_line":"                # pip install --user"},{"line_number":97,"context_line":"                os.path.expanduser("},{"line_number":98,"context_line":"                    \"~/.local/etc/tripleo_get_hash/config.yaml\"),"},{"line_number":99,"context_line":"                # root install"},{"line_number":100,"context_line":"                \"/etc/tripleo_get_hash/config.yaml\","},{"line_number":101,"context_line":"                # embedded config.yaml as fallback"}],"source_content_type":"text/x-python","patch_set":8,"id":"f7b13953_2f512e2f","line":98,"range":{"start_line":98,"start_character":23,"end_line":98,"end_character":24},"in_reply_to":"179c9b74_4dd69214","updated":"2021-07-19 14:50:15.000000000","message":"Yes, now it will also work when installed as non root.","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"}],"tripleo_repos/main.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e0df74f565f65ebd1926f9bdd4e2ca3f238e30ee","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    returns: distro_id, distro_major_version_id, distro_name"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    # Avoids a crash on unsupported platforms which would prevent even"},{"line_number":120,"context_line":"    # running with `--help`."},{"line_number":121,"context_line":"    if not os.path.exists(\u0027/etc/os-release\u0027):"},{"line_number":122,"context_line":"        return platform.system(), \u0027unknown\u0027, \u0027unknown\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    output \u003d subprocess.Popen("},{"line_number":125,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\\n$NAME\"\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"21d77b80_b83bdc19","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":54},"updated":"2021-07-16 16:35:48.000000000","message":"awesome, but we still would need to do the same for get_hash and yum_config, since they have different entrypoints, right?","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"db15c511146d1ae3f178c64fbd899ec613bf024f","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    returns: distro_id, distro_major_version_id, distro_name"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    # Avoids a crash on unsupported platforms which would prevent even"},{"line_number":120,"context_line":"    # running with `--help`."},{"line_number":121,"context_line":"    if not os.path.exists(\u0027/etc/os-release\u0027):"},{"line_number":122,"context_line":"        return platform.system(), \u0027unknown\u0027, \u0027unknown\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    output \u003d subprocess.Popen("},{"line_number":125,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\\n$NAME\"\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"883504e8_78fd9340","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":54},"in_reply_to":"21d77b80_b83bdc19","updated":"2021-07-16 16:51:44.000000000","message":"Not really. I tested with MacOS and Fedora and all three commands are passing the `--help` test. In fact that is how I found these bugs.","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"614364e21cef47579d8760a4c3b30568bbad49a3","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    returns: distro_id, distro_major_version_id, distro_name"},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    # Avoids a crash on unsupported platforms which would prevent even"},{"line_number":120,"context_line":"    # running with `--help`."},{"line_number":121,"context_line":"    if not os.path.exists(\u0027/etc/os-release\u0027):"},{"line_number":122,"context_line":"        return platform.system(), \u0027unknown\u0027, \u0027unknown\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    output \u003d subprocess.Popen("},{"line_number":125,"context_line":"        \u0027source /etc/os-release \u0026\u0026 echo -e -n \"$ID\\n$VERSION_ID\\n$NAME\"\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"969402da_ec9c713c","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":54},"in_reply_to":"883504e8_78fd9340","updated":"2021-07-16 17:25:42.000000000","message":"Yes, you are right that \u0027--help\u0027 will not break for \u0027get-hash\u0027 and \u0027yum-config\u0027, because only tripleo-repos call `_get_distro()` before parsing the args.\nWe still could fail earlier for \u0027yum-config\u0027 if the plataform is different from the expected.\nI can add this to \u0027yum-config\u0027 afterwards, don\u0027t need to be here indeed. Would be an improvement for the module.","commit_id":"0ecc6e0bbbb0ca788e6924fcfb4925d6d30a108a"}]}