)]}'
{"molecule/default/converge.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0a6094f7c87a9f93eb35450f21802780bef10211","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        # the line below which disables molecule idemptotence test."},{"line_number":14,"context_line":"        - molecule-idempotence-notest"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: \"Check get_hash\""},{"line_number":17,"context_line":"      tripleo.repos.get_hash:"},{"line_number":18,"context_line":"        release: master"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: \"Check get_hash with invalid url\""},{"line_number":21,"context_line":"      tripleo.repos.get_hash:"},{"line_number":22,"context_line":"        release: master"},{"line_number":23,"context_line":"        dlrn_url: \u0027https://httpbin.org/status/404\u0027"},{"line_number":24,"context_line":"      register: result"},{"line_number":25,"context_line":"      failed_when: result is success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6fa9690a_acce9f36","line":24,"range":{"start_line":16,"start_character":9,"end_line":24,"end_character":16},"updated":"2021-09-08 08:13:52.000000000","message":"moved these tests into my patch at https://review.opendev.org/c/openstack/tripleo-repos/+/807709 and added co-authored-by @Sorin is that OK?","commit_id":"e5b95dfa79113e883e25ed126ac1a3ea12b162c0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"d6a8ac2cff407f571860d7ee09da690594bc5608","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        # the line below which disables molecule idemptotence test."},{"line_number":14,"context_line":"        - molecule-idempotence-notest"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: \"Check get_hash\""},{"line_number":17,"context_line":"      tripleo.repos.get_hash:"},{"line_number":18,"context_line":"        release: master"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: \"Check get_hash with invalid url\""},{"line_number":21,"context_line":"      tripleo.repos.get_hash:"},{"line_number":22,"context_line":"        release: master"},{"line_number":23,"context_line":"        dlrn_url: \u0027https://httpbin.org/status/404\u0027"},{"line_number":24,"context_line":"      register: result"},{"line_number":25,"context_line":"      failed_when: result is success"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d5be0691_7f0d768d","line":24,"range":{"start_line":16,"start_character":9,"end_line":24,"end_character":16},"in_reply_to":"6fa9690a_acce9f36","updated":"2021-09-08 08:21:23.000000000","message":"Sure. No problems with that. I can even help you with a review.","commit_id":"e5b95dfa79113e883e25ed126ac1a3ea12b162c0"}],"plugins/module_utils/tripleo_repos/get_hash/tripleo_hash_info.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"edc1dcc71ffe6169465ff72e14fe8f897bb18e92","unresolved":true,"context_lines":[{"line_number":24,"context_line":")"},{"line_number":25,"context_line":"from typing import Any, Tuple"},{"line_number":26,"context_line":"# Portable http_get that uses either ansible recommended way or python native"},{"line_number":27,"context_line":"# urllib. Keep in mind that this can still raise exceptions!"},{"line_number":28,"context_line":"try:"},{"line_number":29,"context_line":"    from ansible.module_utils.urls import open_url"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0e29a441_14b166c7","line":27,"range":{"start_line":27,"start_character":43,"end_line":27,"end_character":59},"updated":"2021-09-07 12:38:31.000000000","message":"and in some cases they cannot be caught/handled gracefully, like something being raised in the code below the except ImportError here","commit_id":"e5b95dfa79113e883e25ed126ac1a3ea12b162c0"}]}
