)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77c83ab2332fad3a8ca6ed456b6ddbde57b5af0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8cb3cdb7_903c64e9","updated":"2021-11-02 10:17:11.000000000","message":"++ for refactoring. It will not break any job as it is just a code movement,","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e720065dd9b58282348ce07bd09ab0cdd7ec358b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82a2afcb_03311a9b","updated":"2021-11-03 11:30:37.000000000","message":"13:30 \u003c marios\u003e rlandy|ruck: dviroel|rover: hitting the workflow but dviroel|rover see inline question please    thanks\n","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"363f420f7362fb1bd56535e2035c6c3d81253f43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04b675e0_c28eb4d4","updated":"2021-11-03 07:19:07.000000000","message":"lgtm/makes sense to have this code shared\ntests look happy and i also sanity check tried a local install and tripleo-get-hash seems to still work ;) ","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e991d53bfb7934279dfa3da2b9f62197138ccfeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"416efe83_91aa85af","updated":"2021-11-03 11:34:55.000000000","message":"thanks for your reviews","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"}],"plugins/module_utils/tripleo_repos/get_hash/tripleo_hash_info.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77c83ab2332fad3a8ca6ed456b6ddbde57b5af0d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from .constants import CONFIG_PATH, CONFIG_KEYS, DEFAULT_CONFIG"},{"line_number":22,"context_line":"from .exceptions import ("},{"line_number":23,"context_line":"    TripleOHashInvalidConfig, TripleOHashInvalidDLRNResponse"},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":"# portable http_get that uses either ansible recommended way or python native"},{"line_number":26,"context_line":"# urllib. Also deals with python2 vs python3 for centos7 train jobs."},{"line_number":27,"context_line":"py_version \u003d sys.version_info.major"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a426fc0_3d5df95c","side":"PARENT","line":24,"updated":"2021-11-02 10:17:11.000000000","message":"Moved here: https://review.opendev.org/c/openstack/tripleo-repos/+/815991/2/plugins/module_utils/tripleo_repos/utils.py#21","commit_id":"5c34a98defeca70e3f37862f34683142f8178f3e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"363f420f7362fb1bd56535e2035c6c3d81253f43","unresolved":true,"context_lines":[{"line_number":23,"context_line":")"},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    from tripleo_repos.utils import http_get"},{"line_number":26,"context_line":"except ImportError:"},{"line_number":27,"context_line":"    from ansible_collections.tripleo.repos.plugins.module_utils. \\"},{"line_number":28,"context_line":"        tripleo_repos.utils import http_get"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3de3849d_6339c1d6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":18},"updated":"2021-11-03 07:19:07.000000000","message":"why do we need that one? when does it fail to find the tripleo_repos.utils","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e991d53bfb7934279dfa3da2b9f62197138ccfeb","unresolved":true,"context_lines":[{"line_number":23,"context_line":")"},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    from tripleo_repos.utils import http_get"},{"line_number":26,"context_line":"except ImportError:"},{"line_number":27,"context_line":"    from ansible_collections.tripleo.repos.plugins.module_utils. \\"},{"line_number":28,"context_line":"        tripleo_repos.utils import http_get"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"093be582_3672c577","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":18},"in_reply_to":"3de3849d_6339c1d6","updated":"2021-11-03 11:34:55.000000000","message":"fails when imported by the ansible module, in molecule tests for instance.","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"}],"plugins/module_utils/tripleo_repos/utils.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6e09d2ae52198e4d553f80a282f1299d9d9c91f1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# portable http_get that uses either ansible recommended way or python native"},{"line_number":23,"context_line":"# urllib. Also deals with python2 vs python3 for centos7 train jobs."},{"line_number":24,"context_line":"py_version \u003d sys.version_info.major"},{"line_number":25,"context_line":"if py_version \u003c 3:"},{"line_number":26,"context_line":"    import urllib2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def http_get(url):"}],"source_content_type":"text/x-python","patch_set":2,"id":"0093782e_13c0adb4","line":25,"updated":"2021-11-02 11:48:49.000000000","message":"I\u0027m not sure it\u0027s worth to create functions inside conditions. Maybe better to have one function in top level of module and all these conditions inside it?","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e991d53bfb7934279dfa3da2b9f62197138ccfeb","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# portable http_get that uses either ansible recommended way or python native"},{"line_number":23,"context_line":"# urllib. Also deals with python2 vs python3 for centos7 train jobs."},{"line_number":24,"context_line":"py_version \u003d sys.version_info.major"},{"line_number":25,"context_line":"if py_version \u003c 3:"},{"line_number":26,"context_line":"    import urllib2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def http_get(url):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b356935_0364c2ea","line":25,"in_reply_to":"0093782e_13c0adb4","updated":"2021-11-03 11:34:55.000000000","message":"yeah, we can try refactor that in next change. This way is simple to read, I think.","commit_id":"da713cb3593018485e5d784e2b5523c416ab3845"}],"plugins/module_utils/tripleo_repos/yum_config/yum_config.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"77c83ab2332fad3a8ca6ed456b6ddbde57b5af0d","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    if it has the the permissions needed. A list of updatable options may be"},{"line_number":114,"context_line":"    provided to the class constructor."},{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @classmethod"},{"line_number":118,"context_line":"    def load_logging(cls):"},{"line_number":119,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"09273359_62350746","side":"PARENT","line":116,"updated":"2021-11-02 10:17:11.000000000","message":"Moved here: https://review.opendev.org/c/openstack/tripleo-repos/+/815991/2/plugins/module_utils/tripleo_repos/utils.py#59","commit_id":"5c34a98defeca70e3f37862f34683142f8178f3e"}]}