)]}'
{"specs/pike/tripleo-predictable-ctlplane-ips.rst":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3bd3d632da69b54c164a141b49ef3f9b00fac4ec","unresolved":false,"context_lines":[{"line_number":16,"context_line":"In a routed network environment, it may be desired to have specific control"},{"line_number":17,"context_line":"over which nodes receive which IP addresses according to their geographic"},{"line_number":18,"context_line":"location. Eventually this may be possible using location awareness in Ironic"},{"line_number":19,"context_line":"and Neutron, but those features are still in the design phase."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a22e58a_5c20134a","line":19,"range":{"start_line":19,"start_character":17,"end_line":19,"end_character":22},"updated":"2017-03-14 16:50:47.000000000","message":"\"those\" or \"these\" - tbh I don\u0027t know. I want to read \"these\" but that might be poor conditioning on my part. Not that important though AFAIAC.","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3bd3d632da69b54c164a141b49ef3f9b00fac4ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Because of this, there is no way to pass a specific IP to a role member"},{"line_number":31,"context_line":"for the Control Plane IP, even though all other IPs may be specified. In"},{"line_number":32,"context_line":"order to allow for the Control Plane IP to be specified, we will need to"},{"line_number":33,"context_line":"pass a FixedIP parameter to the OS::Nova::Server."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In order to provide flexibility for developing spine-and-leaf topology"},{"line_number":36,"context_line":"on top of the control plane, we will also need to allow for passing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a22e58a_9cdb6b1b","line":33,"updated":"2017-03-14 16:50:47.000000000","message":"wording is a bit awkward but the gist is still pretty straightforward.","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"3b4d1e9ea084fba74d8f14d019d2cb5a13a74f4a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"* Pass a subnet rather than a network, so that an IP address is chosen from"},{"line_number":82,"context_line":"  the correct subnet."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* Pass a network, subnet, and fixed_ip parameter (any of which may be null)."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The first approach is not backwards-compatible. The second approach will"},{"line_number":87,"context_line":"allow IPs on a user-selectable subnet but won\u0027t allow a specific IP. The"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_860e8230","line":84,"updated":"2017-02-17 15:55:43.000000000","message":"In Ocata, the Ironic ports have network switch id (chassis_id) associated with them, from LLDP data using the local_link_connection plugin.  As alternative, maybe could do something to bind all port IP addresses to same subnet based on chassis_id.","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3bd3d632da69b54c164a141b49ef3f9b00fac4ec","unresolved":false,"context_lines":[{"line_number":101,"context_line":"There is no security impact expected to the OpenStack deployment itself"},{"line_number":102,"context_line":"as a result of refactoring the role Control Plane IP address, but there"},{"line_number":103,"context_line":"are security implications in the alternate network topologies that will"},{"line_number":104,"context_line":"use these new features features."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"In the traditional isolated networks model, most of the networks are"},{"line_number":107,"context_line":"isolated subnets, and the hosts have no router associated with the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_6b81928f","line":104,"range":{"start_line":104,"start_character":23,"end_line":104,"end_character":31},"updated":"2017-03-14 16:50:47.000000000","message":"duplicate word","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"3b4d1e9ea084fba74d8f14d019d2cb5a13a74f4a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"In the traditional isolated networks model, most of the networks are"},{"line_number":107,"context_line":"isolated subnets, and the hosts have no router associated with the"},{"line_number":108,"context_line":"subnet (with the exception of a single routable network). When an installer"},{"line_number":109,"context_line":"configures IPs and routes for multiple subnets, the security perimiter is"},{"line_number":110,"context_line":"moved up into the network fabric. Therefore, certain best practices should"},{"line_number":111,"context_line":"be maintained in the underlying network configuration."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa31d9ce_fbc99b26","line":109,"range":{"start_line":109,"start_character":61,"end_line":109,"end_character":70},"updated":"2017-02-17 15:55:43.000000000","message":"nit - typo (perimeter)","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3bd3d632da69b54c164a141b49ef3f9b00fac4ec","unresolved":false,"context_lines":[{"line_number":107,"context_line":"isolated subnets, and the hosts have no router associated with the"},{"line_number":108,"context_line":"subnet (with the exception of a single routable network). When an installer"},{"line_number":109,"context_line":"configures IPs and routes for multiple subnets, the security perimiter is"},{"line_number":110,"context_line":"moved up into the network fabric. Therefore, certain best practices should"},{"line_number":111,"context_line":"be maintained in the underlying network configuration."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_6e3440de","line":110,"range":{"start_line":110,"start_character":45,"end_line":110,"end_character":52},"updated":"2017-03-14 16:50:47.000000000","message":"I feel that using the word \"certain\" here implies that you are about to outline or explain the best practices. Maybe \"standard\" or \"the usual\"?","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3bd3d632da69b54c164a141b49ef3f9b00fac4ec","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Assignee(s)"},{"line_number":142,"context_line":"-----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Primary assignee:"},{"line_number":146,"context_line":"  dsneddon@redhat.com"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_ce78d492","line":143,"updated":"2017-03-14 16:50:47.000000000","message":"Is there an extra blank line here?","commit_id":"124b195efa651b639930fbde6c0c31d8042ab868"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7e0421cd87454d4de76ccba8cd0ea592003df152","unresolved":false,"context_lines":[{"line_number":87,"context_line":"allow IPs on a user-selectable subnet but won\u0027t allow a specific IP. The"},{"line_number":88,"context_line":"third approach will select the specific IP if fixed_ip is passed, or"},{"line_number":89,"context_line":"will select the IP from the subnet if passed, and if those values are"},{"line_number":90,"context_line":"both null, the network parameter will be used (current behavior)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security Impact"},{"line_number":93,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_6b62e340","line":90,"updated":"2017-03-31 21:23:19.000000000","message":"So are you proposing the third option?  It sounds the best to me, but if that\u0027s the case I think this should be under the Overview header as part of the proposed change.  The other two would be left here as alternatives that were considered but rejected for the reasons discussed in this paragraph.","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"73fbae1cf172be523809e0e5d0e32491b1150587","unresolved":false,"context_lines":[{"line_number":87,"context_line":"allow IPs on a user-selectable subnet but won\u0027t allow a specific IP. The"},{"line_number":88,"context_line":"third approach will select the specific IP if fixed_ip is passed, or"},{"line_number":89,"context_line":"will select the IP from the subnet if passed, and if those values are"},{"line_number":90,"context_line":"both null, the network parameter will be used (current behavior)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security Impact"},{"line_number":93,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_117cdc1e","line":90,"in_reply_to":"dfeb2761_6b62e340","updated":"2017-05-02 13:40:07.000000000","message":"+1","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"73fbae1cf172be523809e0e5d0e32491b1150587","unresolved":false,"context_lines":[{"line_number":107,"context_line":"isolated subnets, and the hosts have no router associated with the"},{"line_number":108,"context_line":"subnet (with the exception of a single routable network). When an installer"},{"line_number":109,"context_line":"configures IPs and routes for multiple subnets, the security perimeter is"},{"line_number":110,"context_line":"moved up into the network fabric. Therefore, security best practices should"},{"line_number":111,"context_line":"be maintained in the underlying network configuration."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_b102c80a","line":110,"updated":"2017-05-02 13:40:07.000000000","message":"I\u0027m not sure what you mean here. At first glance it is a reiteration or perhaps stating an example of the possible misconfiguration referred first paragraph. If so, would it be better as a \"For example,\" follow up to the first paragraph.","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7e0421cd87454d4de76ccba8cd0ea592003df152","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"When upgrading from a previous version of OpenStack TripleO, the environment"},{"line_number":129,"context_line":"files specifying IP addresses for nodes will have to be updated to follow the"},{"line_number":130,"context_line":"new model."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Developer Impact"},{"line_number":133,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_8bfac73f","line":130,"updated":"2017-03-31 21:23:19.000000000","message":"Even if you haven\u0027t turned on predictable provisioning ips in the resource registry?","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"73fbae1cf172be523809e0e5d0e32491b1150587","unresolved":false,"context_lines":[{"line_number":128,"context_line":"When upgrading from a previous version of OpenStack TripleO, the environment"},{"line_number":129,"context_line":"files specifying IP addresses for nodes will have to be updated to follow the"},{"line_number":130,"context_line":"new model."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Developer Impact"},{"line_number":133,"context_line":"----------------"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5ff73747_0cceff82","line":131,"updated":"2017-05-02 13:40:07.000000000","message":"Is this something that would require a UI change?","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7e0421cd87454d4de76ccba8cd0ea592003df152","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Create a new environment file for setting the ctlplane IP without specifying"},{"line_number":159,"context_line":"  other IP addresses."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* Modify at least one CI job to test functionality of setting IP addresses"},{"line_number":162,"context_line":"  on the Control Plane network."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_ab922bf5","line":161,"updated":"2017-03-31 21:23:19.000000000","message":"Just FYI, we\u0027re currently testing predictable placement/ips in the ovb-ha job: http://git.openstack.org/cgit/openstack-infra/tripleo-ci/tree/README.rst#n110","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7e0421cd87454d4de76ccba8cd0ea592003df152","unresolved":false,"context_lines":[{"line_number":174,"context_line":"This feature should be tested in CI by modifying at least one CI job to use"},{"line_number":175,"context_line":"pre-selected IP addresses for the Control Plane. As additional spine-and-leaf"},{"line_number":176,"context_line":"features are implemented, we will want to use this feature to test routed"},{"line_number":177,"context_line":"networks in CI."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Documentation Impact"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_cbae8f2d","line":177,"updated":"2017-03-31 21:23:19.000000000","message":"That will make for some interesting ovb templates. :-)\n\nShould be doable though, so I have no concerns around being able to test this.","commit_id":"eec5e64d029d1919c7541ee9a3d103710ce90830"}]}
