)]}'
{"specs/victoria/excise-swift.rst":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2f24cc42dd087f9e20013ba605d46d8720720b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Swift is being used to store object related to the deployment which are managed"},{"line_number":20,"context_line":"entirely on the Undercloud. In the past, there was an API / UI to interact with"},{"line_number":21,"context_line":"the deployment tooling; however, with the deprecation of the UI and the removal"},{"line_number":22,"context_line":"of Mistral this is no longer the case. The Undercloud is assumed to be a single"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_d7388ad5","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":35},"updated":"2020-09-17 15:14:10.000000000","message":"nit: \"objects\" (plural)?","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"901b04d3be617437805b97751314f62bb59ebcdd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Swift is being used to store object related to the deployment which are managed"},{"line_number":20,"context_line":"entirely on the Undercloud. In the past, there was an API / UI to interact with"},{"line_number":21,"context_line":"the deployment tooling; however, with the deprecation of the UI and the removal"},{"line_number":22,"context_line":"of Mistral this is no longer the case. The Undercloud is assumed to be a single"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_750c0494","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":35},"in_reply_to":"9f560f44_d7388ad5","updated":"2020-09-18 15:25:32.000000000","message":"Done","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2f24cc42dd087f9e20013ba605d46d8720720b0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"To decommission Swift, we\u0027ll start by removing all of the `tripleoclient` Swift"},{"line_number":39,"context_line":"interactions. These interactions are largely storing and retrieving YAML files"},{"line_number":40,"context_line":"which provide context to the user for current deployment status. To ensure"},{"line_number":41,"context_line":"we\u0027re not breaking deployment expectations, we\u0027ll push everything to the local"},{"line_number":42,"context_line":"file system and retain all of the file properties wherever possible. We will"},{"line_number":43,"context_line":"need coordinate with tripleo-ansible to ensure we\u0027re making all direct Swift"},{"line_number":44,"context_line":"client and module interactions optional."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_d73d2abd","line":42,"range":{"start_line":41,"start_character":50,"end_line":42,"end_character":11},"updated":"2020-09-17 15:14:10.000000000","message":"Is this an interim step to facilitate unraveling the current dependencies/assumptions in other code (e.g. tripleo-common)?","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"901b04d3be617437805b97751314f62bb59ebcdd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"To decommission Swift, we\u0027ll start by removing all of the `tripleoclient` Swift"},{"line_number":39,"context_line":"interactions. These interactions are largely storing and retrieving YAML files"},{"line_number":40,"context_line":"which provide context to the user for current deployment status. To ensure"},{"line_number":41,"context_line":"we\u0027re not breaking deployment expectations, we\u0027ll push everything to the local"},{"line_number":42,"context_line":"file system and retain all of the file properties wherever possible. We will"},{"line_number":43,"context_line":"need coordinate with tripleo-ansible to ensure we\u0027re making all direct Swift"},{"line_number":44,"context_line":"client and module interactions optional."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_35128cb5","line":42,"range":{"start_line":41,"start_character":50,"end_line":42,"end_character":11},"in_reply_to":"9f560f44_d73d2abd","updated":"2020-09-18 15:25:32.000000000","message":"The intention is to move everything to the local file system on the Undercloud instead of relying on an API\u0027able object store. So yes, we\u0027ll see some interim measures taken to unravel bits in tripleo-common, however, there will be some permanence to that work too.","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2f24cc42dd087f9e20013ba605d46d8720720b0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Developer Impact"},{"line_number":102,"context_line":"----------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None, if anything the removal of Swift should make the life of a TripleO"},{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_f714ae43","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"updated":"2020-09-17 15:14:10.000000000","message":"What about support for deployment artifacts? I\u0027m thinking specifically about the ability to patch puppet modules. This is something I rely on when developing puppet patches, and I believe it\u0027s also sometimes used in the field (i.e. its use is not limited to developers).\n\n--UPDATE--\n\nOh, now I see L112. Does that address my concern? Will overcloud nodes have access to deployment artifacts?","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"805c69c2ad1cd9ec911483894c1a74a4a50e5506","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Developer Impact"},{"line_number":102,"context_line":"----------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None, if anything the removal of Swift should make the life of a TripleO"},{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_5cb0e940","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"in_reply_to":"9f560f44_15b948ca","updated":"2020-09-21 20:11:28.000000000","message":"what Alan means is that he needs the artifacts reachable from the Undercloud. Which means we might need something like an apache vhost to serve these files via HTTP?","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Developer Impact"},{"line_number":102,"context_line":"----------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None, if anything the removal of Swift should make the life of a TripleO"},{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_bcb665db","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"in_reply_to":"9f560f44_5cb0e940","updated":"2020-09-21 20:43:12.000000000","message":"I missed that original context; however, yes. If we need to be able to access the artifacts from the overcloud we should be able to do so using HTTPD (which we already run and have access to on the undercloud).","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"901b04d3be617437805b97751314f62bb59ebcdd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Developer Impact"},{"line_number":102,"context_line":"----------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None, if anything the removal of Swift should make the life of a TripleO"},{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_15b948ca","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"in_reply_to":"9f560f44_f714ae43","updated":"2020-09-18 15:25:32.000000000","message":"Yes, we will ensure there\u0027s no loss of deployment artifacts by making them locally available on the file system though regular means; which should be a general improvement when needing to interact with them (no more swift overhead).","commit_id":"e71c8dedb48c4e8558f09b3afc8800a12b8c7539"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"85ebc37f999e561d699a7247e71465c9154f45b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_fb3e2c89","line":1,"updated":"2020-09-21 14:09:11.000000000","message":"Needs to be moved to wallaby since V is almost done","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"93c3d9533d7681434037961a693fedc7d22b367b","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_3c87f5b8","line":1,"in_reply_to":"9f560f44_010f2e39","updated":"2020-09-21 20:44:49.000000000","message":"Done","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"819465326067cc4fe33b7b9e7ea081ad36d5f992","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_010f2e39","line":1,"in_reply_to":"9f560f44_fb3e2c89","updated":"2020-09-21 20:01:45.000000000","message":"yeah and please rebase on top of https://review.opendev.org/753139","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2b4fd513b59dd1a0525ab412c7067ab9735b06e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Security Impact"},{"line_number":61,"context_line":"---------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"There should be no significant security implications with the removal of Swift."},{"line_number":64,"context_line":"It could be argued that removing Swift might make the deployment more secure as"},{"line_number":65,"context_line":"we\u0027ll lessen the attack surface, however, given the fact that Swift on the"},{"line_number":66,"context_line":"Undercloud is only used by director I would consider any benefit insignificant."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Upgrade Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_e84bed5b","line":66,"range":{"start_line":63,"start_character":0,"end_line":66,"end_character":79},"updated":"2020-09-22 12:03:44.000000000","message":"there is security impact, see my comment bellow.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Performance Impact"},{"line_number":83,"context_line":"------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The removal of Swift could make some client interactions faster; however, the"},{"line_number":86,"context_line":"benefit should be negligible. That said, the removal of Swift would remove a"},{"line_number":87,"context_line":"service on the Undercloud, which would make setup faster and reduce the"},{"line_number":88,"context_line":"resources required to run the Undercloud."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Other Deployer Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_9cf3a173","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":41},"updated":"2020-09-21 20:43:12.000000000","message":"because deployed artifacts reaches back into the undercloud we\u0027ll need to outline a high level solution for that, which may have some security implication.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"805c69c2ad1cd9ec911483894c1a74a4a50e5506","unresolved":false,"context_lines":[{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Implementation"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"All of the objects stored within Swift will be stored in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_5c42a93c","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":14},"updated":"2020-09-21 20:11:28.000000000","message":"this is a bit short but I guess your specs is a start, we\u0027ll need a lot more details of course.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":105,"context_line":"developer easier."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Implementation"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"All of the objects stored within Swift will be stored in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_5cd2a9fe","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":14},"in_reply_to":"9f560f44_5c42a93c","updated":"2020-09-21 20:43:12.000000000","message":"Yes this is geared at a start, however, I am intentionally keeping this vague, as it\u0027s almost a forgone conclusion that we\u0027ll need to adjust our implantation as we begin pulling back the layers. That said, this is just a primer for starting the conversation.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"805c69c2ad1cd9ec911483894c1a74a4a50e5506","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Excising Swift client interactions will be handled directly in as few reviews"},{"line_number":117,"context_line":"as possible; hopefully allowing us to backport this change, should it be deemed"},{"line_number":118,"context_line":"valuable to stable releases."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Assignee(s)"},{"line_number":121,"context_line":"-----------"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_bc4b055d","line":119,"updated":"2020-09-21 20:11:28.000000000","message":"Security impact?\nWith swift, the files are reachable if you have the correct credentials (even if technically the objects are stored in clear on the host, by default I believe).\nWithout swift, how would we treat the files? as bare on the host? there is a security impact here anyway.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2b4fd513b59dd1a0525ab412c7067ab9735b06e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Excising Swift client interactions will be handled directly in as few reviews"},{"line_number":117,"context_line":"as possible; hopefully allowing us to backport this change, should it be deemed"},{"line_number":118,"context_line":"valuable to stable releases."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Assignee(s)"},{"line_number":121,"context_line":"-----------"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_c850a90d","line":119,"in_reply_to":"9f560f44_7c716d0d","updated":"2020-09-22 12:03:44.000000000","message":"ack, i commented though.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Excising Swift client interactions will be handled directly in as few reviews"},{"line_number":117,"context_line":"as possible; hopefully allowing us to backport this change, should it be deemed"},{"line_number":118,"context_line":"valuable to stable releases."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Assignee(s)"},{"line_number":121,"context_line":"-----------"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_7c716d0d","line":119,"in_reply_to":"9f560f44_bc4b055d","updated":"2020-09-21 20:43:12.000000000","message":"this is outlined in LN:60","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"805c69c2ad1cd9ec911483894c1a74a4a50e5506","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Enumerate all of the Swift interactions"},{"line_number":137,"context_line":"* Create a space on the Undercloud to house the files"},{"line_number":138,"context_line":"** This location will be on the local file system and will be created into a"},{"line_number":139,"context_line":"   git archive; git is used for easier debug, rapid rollback, and will provide"},{"line_number":140,"context_line":"   simple versioning."},{"line_number":141,"context_line":"* Convert client interactions to using the local file system"},{"line_number":142,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":143,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_dc56b905","line":140,"range":{"start_line":138,"start_character":3,"end_line":140,"end_character":21},"updated":"2020-09-21 20:11:28.000000000","message":"We need to design a bit this before we go with it. We need to draw a flow chart here, and figure out when do we \"commit\" new files (a new plan? new templates? new artifacts?). Making sure there is actual value in there.\n\nWe use git in config-download and it\u0027s useless because it makes it clear what changed in the generated playbooks/data. Do we want the same for the plan/templates? etc","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Enumerate all of the Swift interactions"},{"line_number":137,"context_line":"* Create a space on the Undercloud to house the files"},{"line_number":138,"context_line":"** This location will be on the local file system and will be created into a"},{"line_number":139,"context_line":"   git archive; git is used for easier debug, rapid rollback, and will provide"},{"line_number":140,"context_line":"   simple versioning."},{"line_number":141,"context_line":"* Convert client interactions to using the local file system"},{"line_number":142,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":143,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_1cd671c4","line":140,"range":{"start_line":138,"start_character":3,"end_line":140,"end_character":21},"in_reply_to":"9f560f44_dc56b905","updated":"2020-09-21 20:43:12.000000000","message":"I would think we\u0027d want to commit changes on client exit. So when the tripleoclient is invoked, should any file change, we commit them.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"42cf0267b616fa3860cc0e425f2eb8e8ffbd1345","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Enumerate all of the Swift interactions"},{"line_number":137,"context_line":"* Create a space on the Undercloud to house the files"},{"line_number":138,"context_line":"** This location will be on the local file system and will be created into a"},{"line_number":139,"context_line":"   git archive; git is used for easier debug, rapid rollback, and will provide"},{"line_number":140,"context_line":"   simple versioning."},{"line_number":141,"context_line":"* Convert client interactions to using the local file system"},{"line_number":142,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":143,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_483779e4","line":140,"range":{"start_line":138,"start_character":3,"end_line":140,"end_character":21},"in_reply_to":"9f560f44_dc56b905","updated":"2020-09-22 12:01:50.000000000","message":"s/useless/useful/ :D","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"805c69c2ad1cd9ec911483894c1a74a4a50e5506","unresolved":false,"context_lines":[{"line_number":150,"context_line":"None"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Testing"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The Swift tests will need to be updated to use the local file system, however"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_3c6895b8","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":7},"updated":"2020-09-21 20:11:28.000000000","message":"we need a testing strategy. Since at the beginning we might live in a world with 2 storage backends, until we can get rid of the swift one, we need to explain how we\u0027ll keep testing on both system until things stabilize. New job? New options? toggles to disable swift? etc","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"197bf132c8a65233ca66f52f9bd07de57de31318","unresolved":false,"context_lines":[{"line_number":150,"context_line":"None"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Testing"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The Swift tests will need to be updated to use the local file system, however"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_fc7d7de6","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":7},"in_reply_to":"9f560f44_3c6895b8","updated":"2020-09-21 20:43:12.000000000","message":"The existing functional tests should more than cover this use-case given that we\u0027re talking about an artifact storage solution only used on the undercloud. That said, you are correct in that we will likely have a situation where there\u0027s more than one storage backend and we\u0027ll need a toggle to enable / disable backends in jobs.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2b4fd513b59dd1a0525ab412c7067ab9735b06e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"None"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Testing"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The Swift tests will need to be updated to use the local file system, however"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_e8748d9e","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":7},"in_reply_to":"9f560f44_fc7d7de6","updated":"2020-09-22 12:03:44.000000000","message":"I gave it some thoughts and I think we can make write the necessary functions first in tripleo-common and incrementally make the switch when we stop using swift for e.g. the plan, etc.","commit_id":"be650bcc375395d360d260a0096e58dbe4967332"}],"specs/wallaby/excise-swift.rst":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"77b206b5e68a85428f3250fc030a8eeb2bebea94","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Enumerate all of the Swift interactions"},{"line_number":137,"context_line":"* Create a space on the Undercloud to house the files"},{"line_number":138,"context_line":"** This location will be on the local file system and will be created into a"},{"line_number":139,"context_line":"   git archive; git is used for easier debug, rapid rollback, and will provide"},{"line_number":140,"context_line":"   simple versioning."},{"line_number":141,"context_line":"* Convert client interactions to using the local file system"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f560f44_68ad1de9","line":138,"updated":"2020-09-22 12:05:03.000000000","message":"Bullet list ends without a blank line; unexpected unindent.","commit_id":"43aa003ffef9c72c3e7a905e93c7fc44f140a9b8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"abc610a2cc722206c6623ef04db0aabeefa1ac50","unresolved":false,"context_lines":[{"line_number":167,"context_line":"References"},{"line_number":168,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* https://etherpad.opendev.org/p/tripleo-heat-Swift-removal-Undercloud"},{"line_number":171,"context_line":"* https://pasted.tech/pastes/4280d42698b631b1cb47c087027f8c225a8b4dd4"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f560f44_8eb07942","line":170,"updated":"2020-09-22 13:40:09.000000000","message":"https://etherpad.opendev.org/p/tripleo-heat-swift-removal-undercloud","commit_id":"43aa003ffef9c72c3e7a905e93c7fc44f140a9b8"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c5ff1be605a75a4bbe286e4a606c7d9285ba429d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The goal of this proposal is to introduce the community to the idea of removing"},{"line_number":12,"context_line":"Swift from the TripleO Undercloud. Within this propose we intend to provide a"},{"line_number":13,"context_line":"high-level overview of how we can accomplish this goal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_c4b8ec77","line":13,"updated":"2020-11-02 15:46:07.000000000","message":"We might want to add an explicit note about how the Swift service on the Overcloud will still be available.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"273f31f4f51a176fdabdd33e195767df81d6e45a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and the removal of Mistral this is no longer the case. The Undercloud is"},{"line_number":23,"context_line":"assumed to be a single node which is used to deploy OpenStack clouds, and"},{"line_number":24,"context_line":"requires the user to login to the node to run commands. Because we\u0027re no longer"},{"line_number":25,"context_line":"attempting to make the Undercloud a distributed system there\u0027s no need for an"},{"line_number":26,"context_line":"API\u0027able distributed storage service. Swift, in it\u0027s current state, is"},{"line_number":27,"context_line":"under-utilized and carries unnecessary operational and resource overhead."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_9e4fd98a","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":54},"updated":"2020-10-12 09:40:48.000000000","message":"special mention to minions maybe? I.E. how minion do NOT rely on any API for storage.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"and the removal of Mistral this is no longer the case. The Undercloud is"},{"line_number":23,"context_line":"assumed to be a single node which is used to deploy OpenStack clouds, and"},{"line_number":24,"context_line":"requires the user to login to the node to run commands. Because we\u0027re no longer"},{"line_number":25,"context_line":"attempting to make the Undercloud a distributed system there\u0027s no need for an"},{"line_number":26,"context_line":"API\u0027able distributed storage service. Swift, in it\u0027s current state, is"},{"line_number":27,"context_line":"under-utilized and carries unnecessary operational and resource overhead."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_aebb8abb","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":54},"in_reply_to":"9f560f44_9e4fd98a","updated":"2020-10-12 13:05:38.000000000","message":"+1","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c5ff1be605a75a4bbe286e4a606c7d9285ba429d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We keep everything as-is."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_e4ac0837","line":56,"updated":"2020-11-02 15:46:07.000000000","message":"In the past, I\u0027ve briefly talked to others about potentially using a git server. That was never explored because (1) it is still more complex that a local file system and (2) there were concerns about the supportability of that.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"273f31f4f51a176fdabdd33e195767df81d6e45a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Upgrade Impact"},{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_099a75c3","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":31},"updated":"2020-10-12 09:40:48.000000000","message":"I want to challenge this: SELinux.\nsince swift is running in containers, the setype is something like container_file_t - it should be moved back to something else, and we HAVE to ensure it\u0027s something valid for both security and accessibility.\nUsually, files in /var/lib are of var_lib_t or, in some cases, other dedicated types (such as named_cache_t). IMHO var_lib_t is fine for this case.\n\nIn this case, we\u0027ll need to run a chcon -R, that will have an impact on the first upgrade being done to remove the containers. It can be conditioned with a \"when: swift_container is removed\" or something like that in order to prevent it to re-kick during further actions.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ec65f4f659bfc989c240a4eb97fc6b3092ac7d6a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Upgrade Impact"},{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f6b1bfe_f9c4f342","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":31},"in_reply_to":"7f6b1bfe_76f2b008","updated":"2020-10-13 13:27:30.000000000","message":"After some more discussions on the side: since files are relocating (not moved, just a new storage for the plan things), SELinux is not a concern.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Upgrade Impact"},{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_ced51ee8","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":31},"in_reply_to":"9f560f44_099a75c3","updated":"2020-10-12 13:05:38.000000000","message":"I don\u0027t know if anything mentioned here has an upgrade impact. I think this is more of a setup impact as we chart out the new storage layout. Additionally, I don\u0027t think we should have an object removal task. The old swift data should remain on the undercloud indefinitely. While swift may no longer be operational, I don\u0027t believe there\u0027s any value in destroying the old data.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9489508cb0483e5830d83a17fc11ca513ecfba69","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Upgrade Impact"},{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f6b1bfe_76f2b008","line":71,"range":{"start_line":71,"start_character":17,"end_line":71,"end_character":31},"in_reply_to":"9f560f44_ced51ee8","updated":"2020-10-13 12:28:15.000000000","message":"it actually has - if we keep the files in the same location, the \"chcon\" command will make things slow. More on a \"performance\" side than actual upgrade trick. But as I understand, you\u0027d rather move things to a new location? Is it really something we want? Symlink might be nice(r) if really we want to move things or, at least, expose them to some other place.\n\nNote, I\u0027m in no way talking about destroying old data - just ensuring their selinux type is correct in order to avoid any confusion or denial.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"15ec5c07aab228069194412b2b8e0a357543a2cf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_c81b6019","line":72,"updated":"2020-10-11 15:00:29.000000000","message":"If I have an undercloud with swift objects for a deployed overlcoud and I upgrade it, then doesn\u0027t the process for upgrading the undercloud need to move those swift objects to the local file system?","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"--------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There will be no upgrade impact; this change will be transparent to the"},{"line_number":72,"context_line":"end-user."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_4e090e82","line":72,"in_reply_to":"9f560f44_c81b6019","updated":"2020-10-12 13:05:38.000000000","message":"Based on my investigation into the process I want to say no, though I\u0027m sure there are some instances where I\u0027d be wrong. It seems that whenever we run a deployment all of the objects stored within swift are recreated or updated. This means moving the storage location to the local file system will effectively be an update in the case of an upgrade, and nothing will need to be done to transfer the data.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"15ec5c07aab228069194412b2b8e0a357543a2cf","unresolved":false,"context_lines":[{"line_number":112,"context_line":"valuable to stable releases."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All of the objects stored within Swift will be stored in"},{"line_number":115,"context_line":"`/var/lib/tripleo/{named_artifact_directories}`. This will allow us to"},{"line_number":116,"context_line":"implement all of the same core logic in our various libraries just without the"},{"line_number":117,"context_line":"use of the API call to store the object."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_08c0b849","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":47},"updated":"2020-10-11 15:00:29.000000000","message":"Will the tripleo_plan_parameters_update [1] Ansible module continue to work as it does today after this spec is implemented (though behind the scenes it will store the files in this new path)? \n\nWould there still be a concept of a \"deployment plan\" stored in this directory which has the same behaviors? The behavior I\u0027m interested in is related to the Derived Parameters feature and I interact with it like this:\n\nSome Ansible creates the following YAML at deploy time and puts it in the deployment plan by using the tripleo_plan_parameters_update. The overcloud is deployed and the ComputeHCI nodes have the specified NovaReservedHostMemory. \n\n\"\"\"\nderived_parameters:\n  ComputeHCIParameters:\n    NovaReservedHostMemory: 5120\n\"\"\"\n\n[1] https://review.opendev.org/#/c/712604/7/tripleo_ansible/ansible_plugins/modules/tripleo_plan_parameters_update.py","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"valuable to stable releases."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"All of the objects stored within Swift will be stored in"},{"line_number":115,"context_line":"`/var/lib/tripleo/{named_artifact_directories}`. This will allow us to"},{"line_number":116,"context_line":"implement all of the same core logic in our various libraries just without the"},{"line_number":117,"context_line":"use of the API call to store the object."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_6e669257","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":47},"in_reply_to":"9f560f44_08c0b849","updated":"2020-10-12 13:05:38.000000000","message":"short answer, yes. The plan remain intact, it will just be stored on the local file system instead of within swift. I think long term, this move will open up some possibilities to re-think our plan process, however, that is out of scope for this spec.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"15ec5c07aab228069194412b2b8e0a357543a2cf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"on the internal API we\u0027ll first start by trying to replace the swift object"},{"line_number":121,"context_line":"functions within tripleo-common with local file system calls. By using the"},{"line_number":122,"context_line":"existing functions and replacing the backend we\u0027ll ensure API compatibility and"},{"line_number":123,"context_line":"lessen the likely hood of creating regressions."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_2815bce6","line":123,"range":{"start_line":123,"start_character":11,"end_line":123,"end_character":22},"updated":"2020-10-11 15:00:29.000000000","message":"nit: likelihood","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"on the internal API we\u0027ll first start by trying to replace the swift object"},{"line_number":121,"context_line":"functions within tripleo-common with local file system calls. By using the"},{"line_number":122,"context_line":"existing functions and replacing the backend we\u0027ll ensure API compatibility and"},{"line_number":123,"context_line":"lessen the likely hood of creating regressions."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_ce719e0f","line":123,"range":{"start_line":123,"start_character":11,"end_line":123,"end_character":22},"in_reply_to":"9f560f44_2815bce6","updated":"2020-10-12 13:05:38.000000000","message":"Done","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c5ff1be605a75a4bbe286e4a606c7d9285ba429d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  We\u0027ll need to collaborate with various groups to ensure we\u0027re porting assumed"},{"line_number":128,"context_line":"  functionality correctly. While this spec will not go into the specifics"},{"line_number":129,"context_line":"  implementation details for porting assumed functionality, it should be known"},{"line_number":130,"context_line":"  that we will be accountable for ensuring existing functionality is ported"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_c43bcce8","line":127,"updated":"2020-11-02 15:46:07.000000000","message":"Do we know what groups specifically? Ironic, Edge, etc. teams?","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c5ff1be605a75a4bbe286e4a606c7d9285ba429d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  appropriately."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Assignee(s)"},{"line_number":135,"context_line":"-----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Primary assignee:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_e41fe86d","line":134,"updated":"2020-11-02 15:46:07.000000000","message":"We should probably add people\u0027s real/full names (first and last name) here.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"01f36514415f0674a66ad1e14c317d265b32f88f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f681702_6305c17a","line":161,"updated":"2020-10-18 15:44:31.000000000","message":"This seems to ignore the fact that swift is used by glance and ironic:\n\n1) Glance for storing images (needs migration to a file storage or better removing glance completely)\n\n2) Ironic for serving images via temporary URLs when \"direct\" deploy is used (can be easily replaced with the local HTTP server by setting one option).\n\n3) Inspector for introspection data storage (can be stored in a database, will need migration).","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6fa97dce2bb79e8674c13a563e9fb240f3837eda","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_4d6c7807","line":161,"in_reply_to":"1f621f24_00508c0a","updated":"2020-11-12 22:07:19.000000000","message":"done.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"356332c21a8ec90541a5182f4ca267808bfe5e2f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_00508c0a","line":161,"in_reply_to":"3f65232a_b3038b0d","updated":"2020-11-12 16:21:30.000000000","message":"We need to address the ironic usage. Especially the inspector usage.\n\nAlternatively you could remove these steps:\n* Create an option to disable Swift on the Undercloud.\n* Disable Swift on the Undercloud\n\nAnd update the spec to not say remove and disable swift. But remove the tripleo deployment\u0027s use of swift to store plan etc. Then create a different spec to address the ironic issues, and disable swift on the undercloud.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8b372af2719d7e2b45d6529ebaf7214d59ce726","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f65232a_c230f70a","line":161,"in_reply_to":"3f65232a_bb036f0d","updated":"2020-10-23 11:23:35.000000000","message":"You mean the nova service? Because you certainly do use both ironic and ironic-inspector, so my concerns mostly apply.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d3f3d1bf209a4c7adfedbd45af354bb6568ea01f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f65232a_b3038b0d","line":161,"in_reply_to":"3f65232a_c230f70a","updated":"2020-10-23 13:48:28.000000000","message":"Correct, in master nova and glance are both disabled by default.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"24529eb184e40c2dc82b78c818360d75e950b54f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Ensure all tripleo-ansible Swift client calls are made optional"},{"line_number":159,"context_line":"* Convert tripleo-common Swift interactions to using the local file system"},{"line_number":160,"context_line":"* Disable Swift on the Undercloud"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f65232a_bb036f0d","line":161,"in_reply_to":"5f681702_6305c17a","updated":"2020-10-22 20:08:18.000000000","message":"This spec was written with the use of metalsmith in mind, which has just become the default in master. With metalsmith we\u0027re not using glance or the ironic service; everything is stand alone.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"273f31f4f51a176fdabdd33e195767df81d6e45a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"deployment methodology has been changed to Metalsmith."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Testing"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The Swift tests will need to be updated to use the local file system, however"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_09e8b513","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":7},"updated":"2020-10-12 09:40:48.000000000","message":"We might as well get the validations into that game, with the help of the existing tripleo-operator ansible roles, leading to a full test suit, able to be called as post-upgrade validations.","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"72b492f4aba0003a529d9c6d2747b7f41b97725b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"deployment methodology has been changed to Metalsmith."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Testing"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The Swift tests will need to be updated to use the local file system, however"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9f560f44_ee63c23f","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":7},"in_reply_to":"9f560f44_09e8b513","updated":"2020-10-12 13:05:38.000000000","message":"+1","commit_id":"df254dcad5dfeb7e012d3da66d23ae4de0d84a30"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b5734de60450d4fc5be9e38bddcd804004df0c5","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"61fcfd6b_efbe6de7","line":1,"updated":"2020-11-25 13:25:46.000000000","message":"fyi i created https://blueprints.launchpad.net/tripleo/+spec/disable-undercloud-swift which points back here and i targetted it for wallaby. \n\nwe can track all the wallaby things at https://blueprints.launchpad.net/tripleo/wallaby","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1e6d492829457fca043c275da875ee68c1aa156c","unresolved":true,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"897089ba_430c372e","line":51,"updated":"2020-11-23 16:14:31.000000000","message":"Swift is also used by ironic-inspector to store the introspection data.\n\nThe other option is to store the data in the inspector database. I seem to recall there was some issues with that due to the dataset size(s) which is why it was moved to swift. That will need to be investigated.","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8f392e7ed1a4077232720e712e81631530dbce1d","unresolved":true,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"960cc099_c25f811e","line":51,"in_reply_to":"89018f75_2f03d871","updated":"2020-11-24 17:59:07.000000000","message":"\u003e I seem to recall there was some issues with that due to the dataset size(s) which is why it was moved to swift.\n\nI don\u0027t think it was the case, the database option appeared much later. TL;DR just use the database. That\u0027s what metal3 and bifrost do.","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6b97bdba347a89ef405151446046ddcea8ca3fe6","unresolved":true,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baecff84_37bbc8a9","line":51,"in_reply_to":"897089ba_430c372e","updated":"2020-11-23 16:20:10.000000000","message":"I wonder if this is something we will need to address more broadly within ironic?\n\nThat said, for a first pass, we should be able to proceed with the conversion to use a local file system for everything possible and leave swift running. Then tackle any deficiencies once we have the compatibility layer in place.","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"60595786678029b25cec01a8a5acbe9bf454fc3b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"89018f75_2f03d871","line":51,"in_reply_to":"939a4422_6ffa13de","updated":"2020-11-24 17:51:40.000000000","message":"I think we could document that: in a world where the deployment is operating with purely pre-deployed servers (not using metalsmith) swift can be totally disabled; that is until we can figure out a solution to deal with ironic\u0027s assumptions.","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"37ce220207d04a3cbb8481553c874fdcc578773e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"285fe316_278828c0","line":51,"in_reply_to":"960cc099_c25f811e","updated":"2020-11-30 13:40:34.000000000","message":"alright, excellent","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"291684c45f4dc7bee6cd029586d22d50aee6c374","unresolved":true,"context_lines":[{"line_number":48,"context_line":"to the ones found within the `tripleoclient`, though tripleo-common has some"},{"line_number":49,"context_line":"complexity; we\u0027ll need to ensure we\u0027re not breaking expectations we\u0027ve created"},{"line_number":50,"context_line":"with our puppet deployment methodologies which have some Swift assumptions."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"939a4422_6ffa13de","line":51,"in_reply_to":"baecff84_37bbc8a9","updated":"2020-11-23 17:27:48.000000000","message":"Keep in mind that inspector does not use the tripleoclient/tripleo-common code to talk to swift, it directly uses the Swift API","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"311f09069d25e2768a80fbbc0db5c5165cf04654","unresolved":false,"context_lines":[{"line_number":114,"context_line":"All of the objects stored within Swift will be stored in"},{"line_number":115,"context_line":"`/var/lib/tripleo/{named_artifact_directories}`. This will allow us to"},{"line_number":116,"context_line":"implement all of the same core logic in our various libraries just without the"},{"line_number":117,"context_line":"use of the API call to store the object."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"In terms of enabling us to eliminate swift without having a significant impact"},{"line_number":120,"context_line":"on the internal API we\u0027ll first start by trying to replace the swift object"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_a37a4f20","line":117,"updated":"2020-11-17 15:27:41.000000000","message":"The proposal here is for local disk storage only. Perhaps its worth calling out that by removing API\u0027s which used to support executing commands remotely you would now be required to run this on the local undercloud machine.\n\nUnderstood this use case is already not supported for other reasons, but once upon a time it was a required use case (the ability to run workflows remotely, etc).","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6a161273162e37f8f477d2b25e6c4ddc0d77ecc6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* https://etherpad.opendev.org/p/tripleo-heat-swift-removal-undercloud"},{"line_number":188,"context_line":"* http://paste.openstack.org/show/798208"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f621f24_dd01516c","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":40},"updated":"2020-11-13 07:31:07.000000000","message":"that isn\u0027t being referenced anywhere here but if you want to keep it I suggest you use something more permanent like a github gist?","commit_id":"e83d8aba3a950da83a33c23bcef6ffc38f00002f"}]}