)]}'
{"specs/juno/tripleo-juno-tuskar-template-storage.rst":[{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":23,"context_line":"following needs:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Provide a way to store provider resources, which will typically be Heat"},{"line_number":26,"context_line":"  Orchestration Templates."},{"line_number":27,"context_line":"- Version the stored provider resources."},{"line_number":28,"context_line":"- Securely store related and potentially sensitive configuration files."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_6062553f","line":26,"updated":"2014-06-04 19:07:57.000000000","message":"We need to capture the relationship between multiple templates that make up a single role. For instance, swift-deploy.yaml and swift-source.yaml. It looks like the direction is to split the software config away from the structured deployment definition.\n\nPerhaps it\u0027s another bullet point, but being able to provide a list of the conceptual roles (v. their individual files) is another requirement.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"following needs:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Provide a way to store provider resources, which will typically be Heat"},{"line_number":26,"context_line":"  Orchestration Templates."},{"line_number":27,"context_line":"- Version the stored provider resources."},{"line_number":28,"context_line":"- Securely store related and potentially sensitive configuration files."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_82c9eead","line":26,"in_reply_to":"1ae5cdf2_03019b37","updated":"2014-06-06 09:29:35.000000000","message":"1. So the templates should create an acyclic directed graph with one root, right?\ne.g.:\n\nbase template\n\n----provider-controller\n\n--------controller config\n\n--------controller deployment\n\n--------shared-config                                \n\n----provider-compute\n\n--------compute config\n\n--------compute deployment\n\n--------shared config\n\nSo would it be enough to capture into template metadata what are the dependencies(direct successors)? Or the whole tree?\n\nDo you want to model it like this, in chart the two roles can share shared-config, so that is why it is not tree. How we will store the roles? In global space, so the shared templates are not duplicated? Or per role storage, with some control that the same reference contains different files?\n\n2. So the conceptual role is a role that is scale-able right? That would mean we would have to tag the parameter, so we would recognize what template is scale-able.\nOr should roles always be the second level of the graph? Or both conditions? \nI assume that the scaling parameter has to be always passed in the second level template, even if it would been used farther down the road.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":23,"context_line":"following needs:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Provide a way to store provider resources, which will typically be Heat"},{"line_number":26,"context_line":"  Orchestration Templates."},{"line_number":27,"context_line":"- Version the stored provider resources."},{"line_number":28,"context_line":"- Securely store related and potentially sensitive configuration files."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_03019b37","line":26,"in_reply_to":"1ae5cdf2_6062553f","updated":"2014-06-04 19:36:56.000000000","message":"I hadn\u0027t grasped this requirement, I\u0027m not sure how this relationship would fit a *non-relational* storage model :)\n\nThis one needs to be discussed.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Provide a way to store provider resources, which will typically be Heat"},{"line_number":26,"context_line":"  Orchestration Templates."},{"line_number":27,"context_line":"- Version the stored provider resources."},{"line_number":28,"context_line":"- Securely store related and potentially sensitive configuration files."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_4049d9b5","line":27,"updated":"2014-06-04 19:07:57.000000000","message":"We\u0027ll need a version on the role concept, which itself will force storing multiple versions of the same template file(s).","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Provide a way to store provider resources, which will typically be Heat"},{"line_number":26,"context_line":"  Orchestration Templates."},{"line_number":27,"context_line":"- Version the stored provider resources."},{"line_number":28,"context_line":"- Securely store related and potentially sensitive configuration files."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_626942f8","line":27,"in_reply_to":"1ae5cdf2_4049d9b5","updated":"2014-06-06 09:29:35.000000000","message":"I believe we should version the templates. \n\nThe role itself will be probably represented by the top level template, but it just knows it references other templates. The actual references will be passed in env. file.\n\nSo if you will upload a new compute config, it doesn\u0027t affect the role. You have to upgrade link in enviroment file to point on /..../compute_config/v23.\n\nBut I guess this also depends on whether we are storing templates in the global space or in a role bucket.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d62d58071a163d839340d509b309235fb5ccca00","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This proposal defines an API which will be used for storing provider resource"},{"line_number":35,"context_line":"files and configuration files. The basic API for both of these will be the"},{"line_number":36,"context_line":"same, however, provider resources will be stored in Glance as artefacts and the"},{"line_number":37,"context_line":"configuration will be stored securely in Barbican as they may contain sensitive"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5be63ab1","line":34,"updated":"2014-06-04 11:20:40.000000000","message":"python API (used primarily by/from Tuskar)","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This proposal defines an API which will be used for storing provider resource"},{"line_number":35,"context_line":"files and configuration files. The basic API for both of these will be the"},{"line_number":36,"context_line":"same, however, provider resources will be stored in Glance as artefacts and the"},{"line_number":37,"context_line":"configuration will be stored securely in Barbican as they may contain sensitive"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_80ce812c","line":34,"in_reply_to":"1ae5cdf2_5be63ab1","updated":"2014-06-04 19:07:57.000000000","message":"+1","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d62d58071a163d839340d509b309235fb5ccca00","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This proposal defines an API which will be used for storing provider resource"},{"line_number":35,"context_line":"files and configuration files. The basic API for both of these will be the"},{"line_number":36,"context_line":"same, however, provider resources will be stored in Glance as artefacts and the"},{"line_number":37,"context_line":"configuration will be stored securely in Barbican as they may contain sensitive"},{"line_number":38,"context_line":"information. As the provider resources will be stored as Glance artefacts they"},{"line_number":39,"context_line":"will support versioning."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_7bb3f6e8","line":36,"updated":"2014-06-04 11:20:40.000000000","message":"do you mean object storage (swift)\n\n[EDIT]: have found mention of a Glance Artifact Repository [1] but not much else. Is this a planned extension for Glance discussed at summit? For now should we be looking to use object store?\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2014-May/034425.html","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"89acde1496e8273782a0a77bc485d5da6fa262c6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This proposal defines an API which will be used for storing provider resource"},{"line_number":35,"context_line":"files and configuration files. The basic API for both of these will be the"},{"line_number":36,"context_line":"same, however, provider resources will be stored in Glance as artefacts and the"},{"line_number":37,"context_line":"configuration will be stored securely in Barbican as they may contain sensitive"},{"line_number":38,"context_line":"information. As the provider resources will be stored as Glance artefacts they"},{"line_number":39,"context_line":"will support versioning."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_7112370a","line":36,"in_reply_to":"1ae5cdf2_7bb3f6e8","updated":"2014-06-04 12:00:13.000000000","message":"There are links to the Glance design work in the references at the bottom of this article. Swift is mentioned in the alternatives section further down too.\n\nHowever, I think its good to call these out here at the top and expand on the fallback.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":36,"context_line":"same, however, provider resources will be stored in Glance as artefacts and the"},{"line_number":37,"context_line":"configuration will be stored securely in Barbican as they may contain sensitive"},{"line_number":38,"context_line":"information. As the provider resources will be stored as Glance artefacts they"},{"line_number":39,"context_line":"will support versioning."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"While this proposal assumes these will be the ultimate storage services, it"},{"line_number":42,"context_line":"will be  written is such a way that it should be straightforward to implement"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_60bed566","line":39,"updated":"2014-06-04 19:07:57.000000000","message":"I\u0027d like to see the two concepts separated more cleanly. There are two things going on in this blueprint:\n\n- The definition of an internal storage API for Tuskar to use, which entails operations for role CRUD and plan CRUD.\n- The proposal for how to implement that (Glance, Swift, chiseled into stone tablets, etc.), where the implementation may vary on the type of thing being stored.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d62d58071a163d839340d509b309235fb5ccca00","unresolved":false,"context_lines":[{"line_number":41,"context_line":"While this proposal assumes these will be the ultimate storage services, it"},{"line_number":42,"context_line":"will be  written is such a way that it should be straightforward to implement"},{"line_number":43,"context_line":"others. This may be needed if the artefact work in Glance isn\u0027t completed in"},{"line_number":44,"context_line":"time or for simpler developer setup and testing (for example with a dumb local"},{"line_number":45,"context_line":"file storage.)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The following examples use provider_resources to represent a storage instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5b0aba79","line":44,"updated":"2014-06-04 11:20:40.000000000","message":"right sorry you mentioned it here","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d62d58071a163d839340d509b309235fb5ccca00","unresolved":false,"context_lines":[{"line_number":42,"context_line":"will be  written is such a way that it should be straightforward to implement"},{"line_number":43,"context_line":"others. This may be needed if the artefact work in Glance isn\u0027t completed in"},{"line_number":44,"context_line":"time or for simpler developer setup and testing (for example with a dumb local"},{"line_number":45,"context_line":"file storage.)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The following examples use provider_resources to represent a storage instance"},{"line_number":48,"context_line":"configured with Glance but the same operations will be available on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5b81dac1","line":45,"updated":"2014-06-04 11:20:40.000000000","message":"For version 1... (Juno 1/2) will you be creating files on disk? If so state it here. Then make a plan to move onto ... swift, glance artifacts etc","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"will be  written is such a way that it should be straightforward to implement"},{"line_number":43,"context_line":"others. This may be needed if the artefact work in Glance isn\u0027t completed in"},{"line_number":44,"context_line":"time or for simpler developer setup and testing (for example with a dumb local"},{"line_number":45,"context_line":"file storage.)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The following examples use provider_resources to represent a storage instance"},{"line_number":48,"context_line":"configured with Glance but the same operations will be available on"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_2d080bd9","line":45,"in_reply_to":"1ae5cdf2_5b81dac1","updated":"2014-06-06 09:29:35.000000000","message":"Local file storage is similar to sqlite for db. it won\u0027t be enough for Juno, we should have it production ready. Just saying.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d62d58071a163d839340d509b309235fb5ccca00","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**Common API**"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**\u003cInstantiation\u003e**"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"This proposal assumes only one instance of the storage will be used at any time"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0e4f126c","line":53,"updated":"2014-06-04 11:20:40.000000000","message":"The operations below are basically CRUD for a file ... that describes what? Is there a specific format? (JSON?). Assuming each file is basically a \u0027cloud\u0027 as defined in I54f005486b8c3ec3caa9f9de4e04f9e1af59b50c plus the generated and validated HEAT template... will it be like:\n\n{ \u0027template\u0027 : VALIDATED_HEAT_TEMPLATE,\n    \u0027name\u0027 : \u0027dev-cloud\u0027,\n    \u0027description\u0027 : \u0027Development testing cloud\u0027,\n    \u0027heat_stack_id\u0027 : \u0027d86ed2d5-127e-439c-8b87-dbd733051ef7\u0027,\n    \u0027tuskar_cloud_id\u0027 :  \u00271234\u0027,\n    \u0027roles\u0027: [],\n    \u0027parameters\u0027: []\n    ...\n}","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"89acde1496e8273782a0a77bc485d5da6fa262c6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**Common API**"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**\u003cInstantiation\u003e**"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"This proposal assumes only one instance of the storage will be used at any time"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b11e7f0a","line":53,"in_reply_to":"1ae5cdf2_0e4f126c","updated":"2014-06-04 12:00:13.000000000","message":"The actual contents of the files isn\u0027t intended to be covered by this proposal. Essentially we store whatever is passed to us by the API, but again I\u0027ll verify this is the case and make sure Jay and I are on the same wavelength.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**Common API**"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**\u003cInstantiation\u003e**"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"This proposal assumes only one instance of the storage will be used at any time"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_239137f1","line":53,"in_reply_to":"1ae5cdf2_207f6dac","updated":"2014-06-04 19:36:56.000000000","message":"Good point, that\u0027s fine - adding information here should be trivial.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**Common API**"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**\u003cInstantiation\u003e**"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"This proposal assumes only one instance of the storage will be used at any time"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ad7edb16","line":53,"in_reply_to":"1ae5cdf2_239137f1","updated":"2014-06-06 09:29:35.000000000","message":"@marios\nheat_stack_id should not probably be here\nand roles should be probably dependencies","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**Common API**"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"**\u003cInstantiation\u003e**"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"This proposal assumes only one instance of the storage will be used at any time"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_207f6dac","line":53,"in_reply_to":"1ae5cdf2_b11e7f0a","updated":"2014-06-04 19:07:57.000000000","message":"Not necessarily. The storage API will likely need to overlay some information on top of the file(s), such as UUID, last modified date, potentially user information on who wrote it, etc.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Output: None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"**Create**"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Input:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e3690fbf","line":68,"updated":"2014-06-04 19:07:57.000000000","message":"This is going to get tricky since this document assumes the same APIs for roles and plans (which I think is a mistake), so I\u0027ll try to keep my comments clear.\n\nWhat\u0027s lost here in the case of a plan is to which plan the file belongs. Is the intention that the caller uses some sort of convention to keep that relationship? If the caller wanted a list of all plans, would the process be to retrieve a list of all files (I haven\u0027t read everything yet, I\u0027m not sure this call exists) and then apply the convention logic to strip it down?\n\nMy initial thoughts were that I\u0027d be talking to calls with the specific Tuskar constructs in mind. For instance, create_plan, which would do any sort of allocation in the storage necessary to pave the way to add stuff to a plan (generating an empty directory, generating a UUID to refer to the plan, etc.). There could then be CRUD on the files inside a plan, such as add_to_plan(plan_uuid, ...) or save_in_plan(plan_uuid, ...).\n\nThat\u0027d also give the ability for APIs for list_plans so we can get an understanding of what\u0027s out there.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Output: None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"**Create**"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Input:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_33614aa9","line":68,"in_reply_to":"1ae5cdf2_e3690fbf","updated":"2014-06-06 09:29:35.000000000","message":"My gut feeling is that Jay is right, we should model a plan different way.\n\nSo in my mind, we have plan and plan contains files. Plan is also represented by template and environment file. Plan\u0027s template is also root of our templates graph. So plan\u0027s dependencies(direct successors) should be files representing roles.\n\nSo I would not model roles explicitly, I don\u0027t see the benefit. What do you think?\n\nSo I vote for Plan resource and nested resource Template(or global template resources?). Not sure if environment should be just attribute to plan or separate resource. If stored in barbican, it should be probably separate resource.\n\n\nNow lets say you want to add a new role to your plan, how would it look like? Basically all you need is bunch of templates, after upload you will crunch them, the graph root of those templates should be the role, so you should put reference to the role to your plan template. Right? Additional check, the role should have one scaling parameter. So with this, you could just upload all templates you have and it would find all roles and create plan template automatically. \n\nSo do we need a Role terminology for this?","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Input:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- Name - The name of the file."},{"line_number":73,"context_line":"- file - A file-like object for the file to store."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Output:"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_d36f4690","line":73,"updated":"2014-06-06 09:29:35.000000000","message":"probably some sort of metadata will be nice","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"**Retrieve List**"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Returns a list of all the files stored."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Input: None"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_43e2c32f","line":92,"updated":"2014-06-04 19:07:57.000000000","message":"Again, this puts a large burden on the caller to understand the file structure and organization. It\u0027s one thing for the caller to expect to see plan.yaml and environment.yaml, but it\u0027s another for the caller to have to correlate them into the notion of plans, which as a first-class concept in Tuskar I would expect the storage layer to understand.\n\nIMO, we\u0027re not building a generic ORM layer. We\u0027re building the Tuskar storage APIs, which uses and understands Tuskar terms and can be more specific than just \"create\" and \"list\".","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"**Retrieve List**"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Returns a list of all the files stored."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Input: None"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_730e72e6","line":92,"in_reply_to":"1ae5cdf2_43e2c32f","updated":"2014-06-06 09:29:35.000000000","message":"+1","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Fetch a file by its name and optionally its version. If the version isn\u0027t given"},{"line_number":110,"context_line":"then the latest version is returned. The version parameter will be supported"},{"line_number":111,"context_line":"with Glance and not Barbican."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Input:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e3c58f8e","line":111,"updated":"2014-06-04 19:07:57.000000000","message":"The last line should be irrelevant to the API discussion. We should be talking about what Tuskar needs to support and then in an implementation section, talk about enhancements/issues with proposed solutions.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Fetch a file by its name and optionally its version. If the version isn\u0027t given"},{"line_number":110,"context_line":"then the latest version is returned. The version parameter will be supported"},{"line_number":111,"context_line":"with Glance and not Barbican."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Input:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_332eaafb","line":111,"in_reply_to":"1ae5cdf2_e3c58f8e","updated":"2014-06-06 09:29:35.000000000","message":"+1","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Input:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- Name - The name of the file."},{"line_number":116,"context_line":"- version (optional) - The version to fetch"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Output:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_2353f7e2","line":116,"updated":"2014-06-04 19:07:57.000000000","message":"Is that dictated by the caller or the storage backend? If the latter, what\u0027s the version format going to look like? A simple integer, x.y, a SHA, or some other?\n\nHow do I know what versions are possible for a file? I don\u0027t see an API that lists them.\n\n(Nit: Inconsistent capitalization with \"version\")","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Input:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- Name - The name of the file."},{"line_number":116,"context_line":"- version (optional) - The version to fetch"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Output:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b328fae2","line":116,"in_reply_to":"1ae5cdf2_2353f7e2","updated":"2014-06-06 09:29:35.000000000","message":"+1 we need to be able to list versions","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Output:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- A storage model that will lazily access the file on the configured service"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Exceptions:"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_6307bfca","line":120,"updated":"2014-06-04 19:07:57.000000000","message":"What does this storage model look like? Is it a file-like object with a blanket read() call, or are there other methods, such as letting me tell it to write itself to disk somewhere?","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Output:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- A storage model that will lazily access the file on the configured service"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Exceptions:"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_93d3fed3","line":120,"in_reply_to":"1ae5cdf2_6307bfca","updated":"2014-06-06 09:29:35.000000000","message":"I think that for Heat we also need URL that will point to actual file. Is this included here?\n\nThese urls will be most probably filled into the enviroment file.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Exceptions:"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- If the name can\u0027t be found, an exception will be raised."},{"line_number":125,"context_line":"- If a version if provided when accessing Barbican an exception will be raised."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Example:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_03f8bbc1","line":125,"updated":"2014-06-04 19:07:57.000000000","message":"Third possibility: The name is valid but the version number doesn\u0027t exist.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Exceptions:"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- If the name can\u0027t be found, an exception will be raised."},{"line_number":125,"context_line":"- If a version if provided when accessing Barbican an exception will be raised."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Example:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c37093de","line":125,"in_reply_to":"1ae5cdf2_03f8bbc1","updated":"2014-06-04 19:36:56.000000000","message":"Done","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"fc9bb92b9f7b2550b89a66c3bd4fb2d4c128c2d4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Exceptions:"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- If the name can\u0027t be found, an exception will be raised."},{"line_number":125,"context_line":"- If a version if provided when accessing Barbican an exception will be raised."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Example:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_33986a1b","line":125,"in_reply_to":"1ae5cdf2_c37093de","updated":"2014-06-06 09:29:35.000000000","message":"typo: If a version \u0027s/if/is/\u0027 provided","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Input:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Name - The name of the file."},{"line_number":140,"context_line":"- file - A file-like object for the file to store."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Output:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_43fe43af","line":140,"updated":"2014-06-04 19:07:57.000000000","message":"Nit: Inconsistent capitalization.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Input:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Name - The name of the file."},{"line_number":140,"context_line":"- file - A file-like object for the file to store."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Output:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_836a0bec","line":140,"in_reply_to":"1ae5cdf2_43fe43af","updated":"2014-06-04 19:36:56.000000000","message":"Done","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Name - The name of the file."},{"line_number":140,"context_line":"- file - A file-like object for the file to store."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Output:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- A storage model that will lazily access the file on the configured service"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_83da0b4a","line":141,"updated":"2014-06-04 19:07:57.000000000","message":"This implies that versions are immutable, which I agree with, but it might be worthwhile to explicitly state that.","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Name - The name of the file."},{"line_number":140,"context_line":"- file - A file-like object for the file to store."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Output:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- A storage model that will lazily access the file on the configured service"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a36b87ef","line":141,"in_reply_to":"1ae5cdf2_83da0b4a","updated":"2014-06-04 19:36:56.000000000","message":"Done","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c41582053b31193598752b7fae42a476ffaf1f08","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Input:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"- Name - The name of the file."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Output: None"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c3e093fc","line":161,"updated":"2014-06-04 19:07:57.000000000","message":"Which version is deleted? All of them or can I pinpoint one?","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6f39d40163c2ab9b06b2b71a47cf24da2db0b421","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Input:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"- Name - The name of the file."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Output: None"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_43a56345","line":161,"in_reply_to":"1ae5cdf2_c3e093fc","updated":"2014-06-04 19:36:56.000000000","message":"Good point, this should be clarified. At the moment I had assumed \"all versions\"","commit_id":"1e2710a35254b106ba23e92c66dee05724ec190a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We need to store a set of Heat templates and related configuration files which"},{"line_number":23,"context_line":"together describe a deployment plan for Tuskar. The storage should meet the"},{"line_number":24,"context_line":"following requirements:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_917931ca","line":23,"updated":"2014-06-06 12:50:52.000000000","message":"note: \u0027deployment plan\u0027 - will this correspond to \u0027cloud\u0027 or \u0027plan\u0027 (or whichever name we end up agreeing to) in Jay\u0027s proposal @ I54f005486b8c3ec3caa9f9de4e04f9e1af59b50c","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"following requirements:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Provide a way to store Provider Resources, which will typically be Heat"},{"line_number":28,"context_line":"  Ochestration Templates."},{"line_number":29,"context_line":"- Version the stored Provider Resources (including providing a version ID for"},{"line_number":30,"context_line":"  the latest version."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_114d219a","line":27,"updated":"2014-06-06 12:50:52.000000000","message":"again, is this \u0027Role\u0027 ? You should define these or refer to where they are defined","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":46,"context_line":"- Use `Glance artefacts`_ to store Provider Resources. This provides us with"},{"line_number":47,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":48,"context_line":"  collection of Provider Resources."},{"line_number":49,"context_line":"- Store configuration files in `Barbican`_, a service providing secure storage."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_713d85dc","line":46,"updated":"2014-06-06 12:50:52.000000000","message":"Ideally use Glance Artefacts [ref] - initial version will be with files on localdisk.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":46,"context_line":"- Use `Glance artefacts`_ to store Provider Resources. This provides us with"},{"line_number":47,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":48,"context_line":"  collection of Provider Resources."},{"line_number":49,"context_line":"- Store configuration files in `Barbican`_, a service providing secure storage."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ebf25805","line":46,"in_reply_to":"1ae5cdf2_713d85dc","updated":"2014-06-09 08:53:58.000000000","message":"Done - but database rather than local files as discussed.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"**Storage Models**"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Two storage models will be used to map our concepts to the storage backends."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"**Configuration File Storage Model**"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_a4a18897","line":72,"updated":"2014-06-06 15:07:23.000000000","message":"I am missing \u0027Plan\u0027 model, I think that should be separate. It should have link to base template and environment file. Maybe i would put there also the whole provider resource graph, in serialized JSON maybe. To check if we have all the dependencies and to easily list all the dependencies,","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"**Storage Models**"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Two storage models will be used to map our concepts to the storage backends."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"**Configuration File Storage Model**"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"+------------+-------------------------------+----------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_2c880470","line":73,"updated":"2014-06-06 12:50:52.000000000","message":"Do either of these correspond to either of the resources (cloud, role) defined by Jay? So the config file, is that per cloud? Is that where the heat template lives? I can\u0027t see an attribute","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":81,"context_line":"| updated_at | ``\"2014-06-28T15:23:33\"``     | Managed and provided by Barbican |"},{"line_number":82,"context_line":"+------------+-------------------------------+----------------------------------+"},{"line_number":83,"context_line":"| role_name  | ``\u0027swift-config\u0027``            | An immutable name which refers   |"},{"line_number":84,"context_line":"|            |                               | to the role name used in Glance  |"},{"line_number":85,"context_line":"+------------+-------------------------------+----------------------------------+"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_5e409107","line":84,"updated":"2014-06-06 15:07:23.000000000","message":"possibly provider resource name, not every provider is role","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":81,"context_line":"| updated_at | ``\"2014-06-28T15:23:33\"``     | Managed and provided by Barbican |"},{"line_number":82,"context_line":"+------------+-------------------------------+----------------------------------+"},{"line_number":83,"context_line":"| role_name  | ``\u0027swift-config\u0027``            | An immutable name which refers   |"},{"line_number":84,"context_line":"|            |                               | to the role name used in Glance  |"},{"line_number":85,"context_line":"+------------+-------------------------------+----------------------------------+"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_486ef297","line":84,"in_reply_to":"1ae5cdf2_5e409107","updated":"2014-06-09 08:53:58.000000000","message":"Good point, thanks. I need to clarify this one.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":99,"context_line":"| name       | ``\u0027swift-deploy\u0027``            |                                |"},{"line_number":100,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":101,"context_line":"| roles      | ``[\u0027swift\u0027, ]``               |                                |"},{"line_number":102,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":103,"context_line":"| version    | ``\u00271.2.0\u0027``                   | Versions are provided by us    |"},{"line_number":104,"context_line":"+------------+-------------------------------+--------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_2cef241f","line":101,"updated":"2014-06-06 12:50:52.000000000","message":"is roles just a list of strings? Or does it contain info to describe a (list of) \u0027Role\u0027 as defined in the api rewrite spec","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":98,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":99,"context_line":"| name       | ``\u0027swift-deploy\u0027``            |                                |"},{"line_number":100,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":101,"context_line":"| roles      | ``[\u0027swift\u0027, ]``               |                                |"},{"line_number":102,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":103,"context_line":"| version    | ``\u00271.2.0\u0027``                   | Versions are provided by us    |"},{"line_number":104,"context_line":"+------------+-------------------------------+--------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_61f21208","line":101,"in_reply_to":"1ae5cdf2_2cef241f","updated":"2014-06-06 15:07:23.000000000","message":"I believe it will be list of provider resource types, that is only thing we will be able to scan from the template. The actual reference to file is stored in the environment file.\n\nBetter to call this provider resources.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":98,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":99,"context_line":"| name       | ``\u0027swift-deploy\u0027``            |                                |"},{"line_number":100,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":101,"context_line":"| roles      | ``[\u0027swift\u0027, ]``               |                                |"},{"line_number":102,"context_line":"+------------+-------------------------------+--------------------------------+"},{"line_number":103,"context_line":"| version    | ``\u00271.2.0\u0027``                   | Versions are provided by us    |"},{"line_number":104,"context_line":"+------------+-------------------------------+--------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_282446c5","line":101,"in_reply_to":"1ae5cdf2_61f21208","updated":"2014-06-09 08:53:58.000000000","message":"`roles` is a bad name here, I was struggling to think of something and put this in as a placeholder really, I should have made it clearer. I need to clarify this with jdob today but my intention here was to capture the relationship he described in comments on the previous patchset.\n\nIt\u0027s essentially a grouping/name that can be used to refer to more than one provider resource and build up a dependency. The relevant comment Jay added before:\n\n\"We need to capture the relationship between multiple templates that make up a single role. For instance, swift-deploy.yaml and swift-source.yaml. It looks like the direction is to split the software config away from the structured deployment definition.\"\n\nI\u0027ll follow this up with him and clarify.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"   .. py:method:: create(name, file, roles, version)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"      :param str name: The name of the provider resource"},{"line_number":187,"context_line":"      :param file file: file object containing the contents"},{"line_number":188,"context_line":"      :param list roles: A list of role names for this provider resource"},{"line_number":189,"context_line":"      :param str version: A string version representation i.e. ``\"1.2.3\"``"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_2c3d648f","line":187,"updated":"2014-06-06 12:50:52.000000000","message":"of...? i don\u0027t see this in the params earlier for providerresource","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":184,"context_line":"   .. py:method:: create(name, file, roles, version)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"      :param str name: The name of the provider resource"},{"line_number":187,"context_line":"      :param file file: file object containing the contents"},{"line_number":188,"context_line":"      :param list roles: A list of role names for this provider resource"},{"line_number":189,"context_line":"      :param str version: A string version representation i.e. ``\"1.2.3\"``"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_6b8f2876","line":187,"in_reply_to":"1ae5cdf2_2c3d648f","updated":"2014-06-09 08:53:58.000000000","message":"Good point, I forgot to include the file in the model definition.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"      :raises ValueError: if the name is already used"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"   .. py:method:: list_role(role_name)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      Given the name of a specific role, return all the provider resources for"},{"line_number":199,"context_line":"      that role."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_21d2ca34","line":196,"updated":"2014-06-06 15:07:23.000000000","message":"again, role is not appropriate here","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"      :raises ValueError: if the name is already used"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"   .. py:method:: list_role(role_name)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      Given the name of a specific role, return all the provider resources for"},{"line_number":199,"context_line":"      that role."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0baa24d4","line":196,"in_reply_to":"1ae5cdf2_21d2ca34","updated":"2014-06-09 08:53:58.000000000","message":"Done","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":208,"context_line":"      :return: List of provider resource model instances"},{"line_number":209,"context_line":"      :rtype: [ProviderResource, ]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"   .. py:method:: fetch_resource(name)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      :param str name: The name of the provider resource"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_61b3f20a","line":211,"updated":"2014-06-06 15:07:23.000000000","message":"I still miss an action that point to actual template, we will need that for Heat. In the environment file, the URL has to point to template.\n\nBtw. how should we deal with permissions? Heat has to have rights to get the templates. But it will now be public right?","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"   .. py:method:: update(name, file\u003dNone, roles\u003dNone, version\u003dNone)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"      :param str name: The name of the provider resource"},{"line_number":221,"context_line":"      :param file file: (optional) file object containing the contents"},{"line_number":222,"context_line":"      :param list roles: (optional) A list of role names for this provider resource"},{"line_number":223,"context_line":"      :param str version: (optional) A string version representation i.e. ``\"1.2.3\"``"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ac6fb490","line":221,"updated":"2014-06-06 12:50:52.000000000","message":"ditto (contents to update the provider resource?)","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":240,"context_line":"      :return: Configuration file model instance"},{"line_number":241,"context_line":"      :rtype: ConfigurationFile"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. _alternatives:"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_44c0c4e0","line":243,"updated":"2014-06-06 15:07:23.000000000","message":"I would love to see an example of usage, not sure if there is a section for it here. But i would like to see how we will upload bunch of TripleO templates into tuskar and feed them to heat. I guess it would clear up what logic should be here and what should be in Tuskar API.\n\nE.g when you upload the template file, you will scan it and it will point e.g. to 5 provider resources. Now you need to upload 5 templates and associate them to those provider resources, each of them could point to other provider resources...\n\nDoes it make sense? I think the example would catch the weak spots, cause right now I think there are missing things to have this working.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":240,"context_line":"      :return: Configuration file model instance"},{"line_number":241,"context_line":"      :rtype: ConfigurationFile"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. _alternatives:"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_cb9f5cb3","line":243,"in_reply_to":"1ae5cdf2_44c0c4e0","updated":"2014-06-09 08:53:58.000000000","message":"Good idea, I actually have an example I\u0027ve been using to build out the API (I tend to think better in Python than prose). I\u0027ll include this in the next version.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":273,"context_line":"The filesystem was briefly considered and may be included to provide a simpler"},{"line_number":274,"context_line":"developer setup. However, this would require re-implementing much of what"},{"line_number":275,"context_line":"other databases and services provide for us, so it is a less favourable option"},{"line_number":276,"context_line":"as a robust, production ready solution."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"**Barbican Alternatives**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_2c32c4a6","line":276,"updated":"2014-06-06 12:50:52.000000000","message":"I don\u0027t think you should shy away from stating that to start with, this will be implemented with local files on disk. The glance artefact stuff isn\u0027t ready, you\u0027re watching and will move to it when possible. (kind of spiel).","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":273,"context_line":"The filesystem was briefly considered and may be included to provide a simpler"},{"line_number":274,"context_line":"developer setup. However, this would require re-implementing much of what"},{"line_number":275,"context_line":"other databases and services provide for us, so it is a less favourable option"},{"line_number":276,"context_line":"as a robust, production ready solution."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"**Barbican Alternatives**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0b5ce424","line":276,"in_reply_to":"1ae5cdf2_2c32c4a6","updated":"2014-06-09 08:53:58.000000000","message":"Good point, I didn\u0027t mean to shy away from it but I can see it came across that way. My goal with the previous version was to clarify exactly what we ideally want rather than what was possible right now which was a mistake. Now I think we are starting to figure out that, I\u0027ll be clearer about how we will do that now and then how we will do it further down the line.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"72731e336934db7dca953fbbd7d981069ca442ff","unresolved":false,"context_lines":[{"line_number":273,"context_line":"The filesystem was briefly considered and may be included to provide a simpler"},{"line_number":274,"context_line":"developer setup. However, this would require re-implementing much of what"},{"line_number":275,"context_line":"other databases and services provide for us, so it is a less favourable option"},{"line_number":276,"context_line":"as a robust, production ready solution."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"**Barbican Alternatives**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_443524f6","line":276,"in_reply_to":"1ae5cdf2_2c32c4a6","updated":"2014-06-06 15:07:23.000000000","message":"Rather starting with something HA ready might be better. Database implementation should be even easier than filesystem.\n\nFilesystem would not work even in active-passive, because once the server dies, the data will die with it.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6bbab44baea344785d52ec0cdfcc6ad9873074b3","unresolved":false,"context_lines":[{"line_number":273,"context_line":"The filesystem was briefly considered and may be included to provide a simpler"},{"line_number":274,"context_line":"developer setup. However, this would require re-implementing much of what"},{"line_number":275,"context_line":"other databases and services provide for us, so it is a less favourable option"},{"line_number":276,"context_line":"as a robust, production ready solution."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"**Barbican Alternatives**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_6ec65b4b","line":276,"in_reply_to":"1ae5cdf2_443524f6","updated":"2014-06-09 06:17:17.000000000","message":"I agree (we kind of reached this conclusion after our discussion on friday right?). I am just working on the assumption of \"we are getting rid of the database\" which is the impression Jay\u0027s spec gave me","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":273,"context_line":"The filesystem was briefly considered and may be included to provide a simpler"},{"line_number":274,"context_line":"developer setup. However, this would require re-implementing much of what"},{"line_number":275,"context_line":"other databases and services provide for us, so it is a less favourable option"},{"line_number":276,"context_line":"as a robust, production ready solution."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"**Barbican Alternatives**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_eb6df8cd","line":276,"in_reply_to":"1ae5cdf2_6ec65b4b","updated":"2014-06-09 08:53:58.000000000","message":"Yup, this does seem to be out conclusion from Friday. My current plan for the next revision of this is to go for \"Database and Barbican.\" I don\u0027t think it\u0027s realistic to use the filesystem because we don\u0027t want a database :)\n\nWorst case I\u0027d expect we have a database for Juno with a clear plan to use Glance for K.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51bec67c760783188ffc51f460bf2f030ac50e7e","unresolved":false,"context_lines":[{"line_number":288,"context_line":"---------------"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Some of the configuration values, such as service passwords, will be sensitive."},{"line_number":291,"context_line":"For this reason, Barbican will be used to store all configuration values."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"While access will be controlled by the Tuskar API large files could be provided"},{"line_number":294,"context_line":"in the place of provider resource files or configuration files. These should be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0cd6e827","line":291,"updated":"2014-06-06 12:50:52.000000000","message":"Is this available and possible today?","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"5ef748aa51bf741f24f2276d4bd4148e0c9e3273","unresolved":false,"context_lines":[{"line_number":288,"context_line":"---------------"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"Some of the configuration values, such as service passwords, will be sensitive."},{"line_number":291,"context_line":"For this reason, Barbican will be used to store all configuration values."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"While access will be controlled by the Tuskar API large files could be provided"},{"line_number":294,"context_line":"in the place of provider resource files or configuration files. These should be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_68056e13","line":291,"in_reply_to":"1ae5cdf2_0cd6e827","updated":"2014-06-09 08:53:58.000000000","message":"Yes.","commit_id":"cc12389a9d614fff94b6b80549808a90783506fa"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a list of roles. This"},{"line_number":14,"context_line":"specification is principally intended to be used by Tuskar."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e99e9bb7","line":13,"updated":"2014-06-10 19:10:38.000000000","message":"Technically, the deployment plan doesn\u0027t contain a list of roles. The roles are implied by what\u0027s in the other two files. The environment maps the provider resources to a namespace and the master template will have resources that correspond to those provider resources.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"447324cb6b53f4808dae21effdb0486347ed4e37","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a list of roles. This"},{"line_number":14,"context_line":"specification is principally intended to be used by Tuskar."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d2dec010","line":13,"in_reply_to":"1ae5cdf2_e99e9bb7","updated":"2014-06-11 16:25:14.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a list of roles. This"},{"line_number":14,"context_line":"specification is principally intended to be used by Tuskar."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6096fe4d","line":14,"updated":"2014-06-11 14:08:38.000000000","message":"Ref to where Deployment Plan is defined (or just mention they are defined elsewhere)\n\n[EDIT: seen it below nm]","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"331a71a28f451c2580867d59b6a2e1fd52147252","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a list of roles. This"},{"line_number":14,"context_line":"specification is principally intended to be used by Tuskar."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_5796224d","line":14,"in_reply_to":"1ae5cdf2_6096fe4d","updated":"2014-06-11 15:26:23.000000000","message":"I debated putting the link/note up here but it seemed wrong. I can move it up if its clearer.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"7d064af415200b5ff3d10553f57941660ba588fd","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":29,"context_line":"roles which together describe a deployment plan for Tuskar. The storage should"},{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_efd30036","line":29,"updated":"2014-06-10 17:20:49.000000000","message":"It might be worth clarifying that the list of roles exists independently of a deployment plan.  A deployment plan will include a selection of the list of roles.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"331a71a28f451c2580867d59b6a2e1fd52147252","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":29,"context_line":"roles which together describe a deployment plan for Tuskar. The storage should"},{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_977eeaad","line":29,"in_reply_to":"1ae5cdf2_40ebc277","updated":"2014-06-11 15:26:23.000000000","message":"I intended it as Marios read it - I\u0027ll use his wording to clarify it. Thanks.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":29,"context_line":"roles which together describe a deployment plan for Tuskar. The storage should"},{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4996af95","line":29,"in_reply_to":"1ae5cdf2_efd30036","updated":"2014-06-10 19:10:38.000000000","message":"+1, I made a similar comment above.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":29,"context_line":"roles which together describe a deployment plan for Tuskar. The storage should"},{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_40ebc277","line":29,"in_reply_to":"1ae5cdf2_efd30036","updated":"2014-06-11 14:08:38.000000000","message":"I see where u guys are coming from but I read that as \u0027a list of roles for a particular deployment plan\u0027. He covers Roles as a standalone resource below","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"},{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_89e7d73f","line":33,"updated":"2014-06-10 19:10:38.000000000","message":"Given that there\u0027s discussion over this, you might want to specifically mention that they are stored independently from the plans. In fact, you might want to draw a bigger line between the roles, which are the building blocks that an admin would install v. the plans, which are the actual things being created and likely done by some sort of deployer.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":30,"context_line":"meet the following requirements:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"},{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ad6a96ea","line":33,"in_reply_to":"1ae5cdf2_89e7d73f","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"},{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_89bef7fd","line":35,"updated":"2014-06-10 19:10:38.000000000","message":"Not sure I understand the added note. Why call out that the latest has a version, is that specifically a nod to Swift and how the version number isn\u0027t assigned until the latest is replaced? It reads a bit odd without that understanding.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- Provide a way to store Roles, which will typically be Heat Orchestration"},{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8d695afb","line":35,"in_reply_to":"1ae5cdf2_89bef7fd","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_c9055fc3","line":36,"updated":"2014-06-10 19:10:38.000000000","message":"Not sure of the phrasing here. What does \"store related\" mean? Or do you mean related environments, in which case, what are they related to?\n\nConsider that these may be two distinct and important points, that there\u0027s a relationship between files going on and that some may contain sensitive information.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  Templates."},{"line_number":34,"context_line":"- Version the stored Roles (including providing a version ID for the latest"},{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6d640e22","line":36,"in_reply_to":"1ae5cdf2_c9055fc3","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"},{"line_number":40,"context_line":"  a collection of related Provider Resources."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_49e78f12","line":38,"updated":"2014-06-10 19:10:38.000000000","message":"A few things here:\n\n* Nit: Heat is capitalized elsewhere.\n\n* You\u0027re bouncing between roles (#2), plans (#3), and back to roles (this bullet). Consider the separation I mentioned above and organize accordingly to keep things more clear.\n\n* This might be better phrased as simply indicating a role may be made up of more than one Heat template.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  revision)."},{"line_number":36,"context_line":"- Securely store related and potentially sensitive environments."},{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"},{"line_number":40,"context_line":"  a collection of related Provider Resources."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4da4b24a","line":38,"in_reply_to":"1ae5cdf2_49e78f12","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"},{"line_number":40,"context_line":"  a collection of related Provider Resources."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_09b587ed","line":40,"updated":"2014-06-10 19:10:38.000000000","message":"If you\u0027re going to mention list, you might as well mention create, update, and delete as well. I\u0027d also be ok with omitting it, since the idea of retrieving stuff from storage is somewhat implied :)","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"7d064af415200b5ff3d10553f57941660ba588fd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- Store the relationship between the heat templates which make up an individual"},{"line_number":38,"context_line":"  role."},{"line_number":39,"context_line":"- Provide a way to list the stored roles, which is the conceptual name given to"},{"line_number":40,"context_line":"  a collection of related Provider Resources."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4f13140d","line":40,"updated":"2014-06-10 17:20:49.000000000","message":"Should the master template be mentioned in this list?  Maybe the relationship between the various parts of a deployment plan as well?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"**Change Summary**"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":49,"context_line":"- Define a storage Python API for roles and deployment plans. This needs to support"},{"line_number":50,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":51,"context_line":"  collection of Provider Resources within a role."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_c9a1dfaa","line":48,"updated":"2014-06-10 19:10:38.000000000","message":"IMO, either remove \"initially\" or elaborate to explain who else may consume it in the future (my vote is for the former).","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"**Change Summary**"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":49,"context_line":"- Define a storage Python API for roles and deployment plans. This needs to support"},{"line_number":50,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":51,"context_line":"  collection of Provider Resources within a role."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_caf4565d","line":48,"in_reply_to":"1ae5cdf2_c9a1dfaa","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":46,"context_line":"**Change Summary**"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":49,"context_line":"- Define a storage Python API for roles and deployment plans. This needs to support"},{"line_number":50,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":51,"context_line":"  collection of Provider Resources within a role."},{"line_number":52,"context_line":"- Define a *secure* storage Python API for storing sensitive environments which"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_89ad178b","line":49,"updated":"2014-06-10 19:10:38.000000000","message":"What\u0027s the difference between \"a storage Python API\" in this line and \"Provide a Python API\" in the previous?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"447324cb6b53f4808dae21effdb0486347ed4e37","unresolved":false,"context_lines":[{"line_number":46,"context_line":"**Change Summary**"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Provide a Python API to be consumed initially by Tuskar."},{"line_number":49,"context_line":"- Define a storage Python API for roles and deployment plans. This needs to support"},{"line_number":50,"context_line":"  versioned storage and dependency relations which will be used to describe a"},{"line_number":51,"context_line":"  collection of Provider Resources within a role."},{"line_number":52,"context_line":"- Define a *secure* storage Python API for storing sensitive environments which"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_32ea84ac","line":49,"in_reply_to":"1ae5cdf2_89ad178b","updated":"2014-06-11 16:25:14.000000000","message":"This is a relic that is left over from rushing my edits. I\u0027ll clarify.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":61,"context_line":"- Python API Interface; Defines the querying and CRUD operations for the"},{"line_number":62,"context_line":"  storage backends."},{"line_number":63,"context_line":"- Storage Backends; Discusses the initial backends that will be supported and"},{"line_number":64,"context_line":"  the plans for future backends."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"**Storage Models**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a9d653ef","line":64,"updated":"2014-06-10 19:10:38.000000000","message":"The typical OpenStack terminology I see for this sort of pluggable concept is a \"driver\". I\u0027m not saying you have to use it here, but consider starting to use that term more.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":61,"context_line":"- Python API Interface; Defines the querying and CRUD operations for the"},{"line_number":62,"context_line":"  storage backends."},{"line_number":63,"context_line":"- Storage Backends; Discusses the initial backends that will be supported and"},{"line_number":64,"context_line":"  the plans for future backends."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"**Storage Models**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a055661f","line":64,"in_reply_to":"1ae5cdf2_a9d653ef","updated":"2014-06-11 14:08:38.000000000","message":"+1","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":61,"context_line":"- Python API Interface; Defines the querying and CRUD operations for the"},{"line_number":62,"context_line":"  storage backends."},{"line_number":63,"context_line":"- Storage Backends; Discusses the initial backends that will be supported and"},{"line_number":64,"context_line":"  the plans for future backends."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"**Storage Models**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0aeb9e78","line":64,"in_reply_to":"1ae5cdf2_a9d653ef","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"7d064af415200b5ff3d10553f57941660ba588fd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- Role"},{"line_number":72,"context_line":"- Deployment Plan"},{"line_number":73,"context_line":"- Environment"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"**Role**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4fb874e5","line":73,"updated":"2014-06-10 17:20:49.000000000","message":"Does the master template need to be modeled?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- Role"},{"line_number":72,"context_line":"- Deployment Plan"},{"line_number":73,"context_line":"- Environment"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"**Role**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a9ed73b9","line":73,"in_reply_to":"1ae5cdf2_4fb874e5","updated":"2014-06-10 19:10:38.000000000","message":"+1","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- Role"},{"line_number":72,"context_line":"- Deployment Plan"},{"line_number":73,"context_line":"- Environment"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"**Role**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e3966f93","line":73,"in_reply_to":"1ae5cdf2_a9ed73b9","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. code-block:: python"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_49778fd4","line":89,"updated":"2014-06-10 19:10:38.000000000","message":"Is there going to be a UUID for a Role, or do we need to specify (name, version) each time we want to refer to a particular one?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. code-block:: python"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_9970e641","line":89,"in_reply_to":"1ae5cdf2_49778fd4","updated":"2014-06-11 12:46:51.000000000","message":"I expect to have a UUID.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_c9639f18","line":91,"updated":"2014-06-10 19:10:38.000000000","message":"Should we mention uniqueness constraints for each of these?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"121fa444af365a1084ea494144cf0dd6ae0e5662","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_cca2a9ad","line":91,"in_reply_to":"1ae5cdf2_a348105d","updated":"2014-06-11 14:54:43.000000000","message":"I *think* we want a human readable version. So the user can see\n\ncompute version 1\ncompute version 2\n\nrather than\n\ncompute version 49d0-bfdf-bd9e6f26d71\ncompute version d4ef003-c855-40ba-b5\n\nHowever, the reason I expect to have a UUID is that most (if not all) drivers would provide one - we don\u0027t necessarily need to use it.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f9ad6a85","line":91,"in_reply_to":"1ae5cdf2_c9639f18","updated":"2014-06-11 12:46:51.000000000","message":"Good point. I imagine that the name, version combo must be unique. So, you can have many compute and many version 2\u0027s but only one compute version 2.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a348105d","line":91,"in_reply_to":"1ae5cdf2_f9ad6a85","updated":"2014-06-11 14:08:38.000000000","message":"I think having a uuid renders these constraints unnecessary though needs more thought. Cant we just use uuid for versioning?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"**Environment**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a9e01397","line":92,"updated":"2014-06-10 19:10:38.000000000","message":"The big part that\u0027s missing from here is what the role actually does. We need to be able to go from having a role to getting its configuration parameters for the consolidation. That\u0027s a huge fuzzy area right now since we don\u0027t have a strong convention of how the templates should be structured.\n\nThat\u0027s partly contingent on the THT conversion. But at very least, there has to be a method somewhere that\u0027s used to download the template files so we can do something with them. Not sure if that\u0027s here or in the Role API, but it has to be somewhere.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    class Role:"},{"line_number":90,"context_line":"        name \u003d \u0027compute\u0027"},{"line_number":91,"context_line":"        version \u003d \u00272\u0027"},{"line_number":92,"context_line":"        ..."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"**Environment**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_83007435","line":92,"in_reply_to":"1ae5cdf2_a9e01397","updated":"2014-06-11 14:08:38.000000000","message":"my gut feeling is that this processing/munging (though that\u0027s probably not what you meant) should be in the API side of things, rather than the storage. Associations between them (roles\u003c--\u003eplan\u003c--\u003etemplates\u003c--\u003eheat_env) go in the db.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    class Environment:"},{"line_number":103,"context_line":"        id \u003d \u0027888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\u0027"},{"line_number":104,"context_line":"        updated \u003d \"2014-06-28T15:23:33.092660\""},{"line_number":105,"context_line":"        name \u003d \u0027dev-cloud\u0027"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def get_contents(self):"},{"line_number":108,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2c13310e","line":105,"updated":"2014-06-10 19:10:38.000000000","message":"The environment doesn\u0027t really have a name. The plan it belongs to does, but there\u0027s no need to explicitly name them separate from that. We\u0027d only ever ask for \"Plan dev-cloud\u0027s environment file\", not a further distinction from there.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    class Environment:"},{"line_number":103,"context_line":"        id \u003d \u0027888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\u0027"},{"line_number":104,"context_line":"        updated \u003d \"2014-06-28T15:23:33.092660\""},{"line_number":105,"context_line":"        name \u003d \u0027dev-cloud\u0027"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def get_contents(self):"},{"line_number":108,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_79ef9ab1","line":105,"in_reply_to":"1ae5cdf2_2c13310e","updated":"2014-06-11 12:46:51.000000000","message":"I planned on copying over the name from the plan here. IIUC, Barbican expects a name - if nothing else, it\u0027ll aid debugging in the backend to have a nice name attached. However, I\u0027m open to removing this if needed - the one danger I do see is having to keep it in sync - i.e. when/if the deployment plan is updated.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def get_contents(self):"},{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_69844bb1","line":109,"updated":"2014-06-10 19:10:38.000000000","message":"Nit: In a Python docstring, you don\u0027t need the #\n\nHow does it get a handle to the storage API? It\u0027s not stored as an attribute on the Environment and I really, really hope your answer here isn\u0027t \"It\u0027s a singleton\". :)","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def get_contents(self):"},{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_99ec66bd","line":109,"in_reply_to":"1ae5cdf2_69844bb1","updated":"2014-06-11 12:46:51.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        def get_contents(self):"},{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_c09b2964","line":109,"in_reply_to":"1ae5cdf2_69844bb1","updated":"2014-06-12 14:37:17.000000000","message":"Everything is a singleton! No, wait, I mean, I have to admit I didn\u0027t fully think this through. I think it\u0027ll have to be another method on the API. The alternative is to bind the model to the API class when you create it, but I don\u0027t much like that.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"},{"line_number":113,"context_line":"            \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e9985b1d","line":111,"updated":"2014-06-10 19:10:38.000000000","message":"Typo in secret (I really hope that\u0027s a typo :)","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"},{"line_number":113,"context_line":"            \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ea9cb210","line":111,"in_reply_to":"1ae5cdf2_e9985b1d","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"\"\""},{"line_number":109,"context_line":"            # Calls the storage API and returns the unencrypted contents"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            :return: secrete contents"},{"line_number":112,"context_line":"            :rtype: str"},{"line_number":113,"context_line":"            \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_23108058","line":111,"in_reply_to":"1ae5cdf2_e9985b1d","updated":"2014-06-11 14:08:38.000000000","message":"nah i think he was going for a french accent","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":118,"context_line":".. code-block:: python"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    class DeploymentPlan:"},{"line_number":121,"context_line":"        id \u003d \"dd4ef003-c855-40ba-b5a6-3fe4176a069e\""},{"line_number":122,"context_line":"        name \u003d \"dev-cloud\""},{"line_number":123,"context_line":"        description \u003d \"Development testing cloud\""},{"line_number":124,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_830a3424","line":121,"updated":"2014-06-11 14:08:38.000000000","message":"uuid","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        description \u003d \"Development testing cloud\""},{"line_number":124,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        master_template \u003d \"insecure-storage-scheme://...\""},{"line_number":127,"context_line":"        environment \u003d \"secure-storage-scheme://888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\""},{"line_number":128,"context_line":"        roles \u003d ["},{"line_number":129,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ac182176","line":126,"updated":"2014-06-10 19:10:38.000000000","message":"See my next comment and the earlier comments about a MasterTemplate object.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        description \u003d \"Development testing cloud\""},{"line_number":124,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        master_template \u003d \"insecure-storage-scheme://...\""},{"line_number":127,"context_line":"        environment \u003d \"secure-storage-scheme://888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\""},{"line_number":128,"context_line":"        roles \u003d ["},{"line_number":129,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_20c12d2f","line":126,"in_reply_to":"1ae5cdf2_ac182176","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        master_template \u003d \"insecure-storage-scheme://...\""},{"line_number":127,"context_line":"        environment \u003d \"secure-storage-scheme://888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\""},{"line_number":128,"context_line":"        roles \u003d ["},{"line_number":129,"context_line":"            {"},{"line_number":130,"context_line":"                \"name\" : \"compute\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2c0df137","line":127,"updated":"2014-06-10 19:10:38.000000000","message":"Why is this a URL instead of an Environment object? Presumably we\u0027ll have this object because we loaded it from somewhere, or we created it to save it. In both cases, the URL is less relevant than the object representation.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        master_template \u003d \"insecure-storage-scheme://...\""},{"line_number":127,"context_line":"        environment \u003d \"secure-storage-scheme://888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\""},{"line_number":128,"context_line":"        roles \u003d ["},{"line_number":129,"context_line":"            {"},{"line_number":130,"context_line":"                \"name\" : \"compute\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_593d7e2a","line":127,"in_reply_to":"1ae5cdf2_2c0df137","updated":"2014-06-11 12:46:51.000000000","message":"Good point - this was a silly move due to rushing. I was thinking more about how it would be stored rather than how it would be presented on the class.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \"rel\" : \"bookmark\""},{"line_number":135,"context_line":"                }"},{"line_number":136,"context_line":"            },"},{"line_number":137,"context_line":"        ]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"**Python API Interface**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8c3445df","line":137,"updated":"2014-06-10 19:10:38.000000000","message":"Similar question here, why is this not a list of Role objects?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \"rel\" : \"bookmark\""},{"line_number":135,"context_line":"                }"},{"line_number":136,"context_line":"            },"},{"line_number":137,"context_line":"        ]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"**Python API Interface**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_994386ae","line":137,"in_reply_to":"1ae5cdf2_8c3445df","updated":"2014-06-11 12:46:51.000000000","message":"Same as above.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"     def fetch(self, role_id)"},{"line_number":169,"context_line":"         \"\"\""},{"line_number":170,"context_line":"         :param str role_id: The ID of the role"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"         :return: Role model instance"},{"line_number":173,"context_line":"         :rtype: Role"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e94dbb9a","line":170,"updated":"2014-06-10 19:10:38.000000000","message":"There\u0027s no ID defined in the domain model, so what would we use here?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"     def fetch(self, role_id)"},{"line_number":169,"context_line":"         \"\"\""},{"line_number":170,"context_line":"         :param str role_id: The ID of the role"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"         :return: Role model instance"},{"line_number":173,"context_line":"         :rtype: Role"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2ab13a8f","line":170,"in_reply_to":"1ae5cdf2_e94dbb9a","updated":"2014-06-11 12:36:08.000000000","message":"I imagine there will be, but I was avoiding making too many guesses before the template structure is clearer.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":173,"context_line":"         :rtype: Role"},{"line_number":174,"context_line":"         \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"     def list(self)"},{"line_number":177,"context_line":"         \"\"\""},{"line_number":178,"context_line":"         :return: List of Role model instances"},{"line_number":179,"context_line":"         :rtype: [Role, ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_093ca7e1","line":176,"updated":"2014-06-10 19:10:38.000000000","message":"Consider adding a flag that will only return the latest versions of each role. Perhaps even default it to True, as that\u0027s likely what the UI will want more often than not.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ef1aaa518a6c5f170409b03883d43cefa3e445ea","unresolved":false,"context_lines":[{"line_number":173,"context_line":"         :rtype: Role"},{"line_number":174,"context_line":"         \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"     def list(self)"},{"line_number":177,"context_line":"         \"\"\""},{"line_number":178,"context_line":"         :return: List of Role model instances"},{"line_number":179,"context_line":"         :rtype: [Role, ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e6830654","line":176,"in_reply_to":"1ae5cdf2_093ca7e1","updated":"2014-06-11 14:08:38.000000000","message":"+1 - could even have a stand-alone \u0027list_versions(role_id)\u0027 to get all versions for a particular Role. Otherwise make it explicit that requests for Role resources will return the latest when there are multiple versions","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":173,"context_line":"         :rtype: Role"},{"line_number":174,"context_line":"         \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"     def list(self)"},{"line_number":177,"context_line":"         \"\"\""},{"line_number":178,"context_line":"         :return: List of Role model instances"},{"line_number":179,"context_line":"         :rtype: [Role, ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_aa646a22","line":176,"in_reply_to":"1ae5cdf2_093ca7e1","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"121fa444af365a1084ea494144cf0dd6ae0e5662","unresolved":false,"context_lines":[{"line_number":173,"context_line":"         :rtype: Role"},{"line_number":174,"context_line":"         \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"     def list(self)"},{"line_number":177,"context_line":"         \"\"\""},{"line_number":178,"context_line":"         :return: List of Role model instances"},{"line_number":179,"context_line":"         :rtype: [Role, ]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_cc1389b6","line":176,"in_reply_to":"1ae5cdf2_e6830654","updated":"2014-06-11 14:54:43.000000000","message":"Good idea, I think I\u0027ll add that too. giving us:\n\nlist(latest\u003dTrue) - list latest versions only or all if set to False\nlist_versions(role_id) - List all the versions for that role.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"The operations are intentionally lazy, they will return models with the"},{"line_number":209,"context_line":"metadata and not the secrete contents. They can then be unlocked and accessed"},{"line_number":210,"context_line":"when they are used rather than when querying the storage."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":".. code-block:: python"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6c461923","line":210,"updated":"2014-06-10 19:10:38.000000000","message":"I think the idea of laziness needs to be addressed more generally than this. There are times where we just want some metadata, like to display the list of plans or roles. We should be clear about which calls will download entire files from storage so we\u0027re not incurring any unnecessary bandwidth hits.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"The operations are intentionally lazy, they will return models with the"},{"line_number":209,"context_line":"metadata and not the secrete contents. They can then be unlocked and accessed"},{"line_number":210,"context_line":"when they are used rather than when querying the storage."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":".. code-block:: python"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b99682ee","line":210,"in_reply_to":"1ae5cdf2_6c461923","updated":"2014-06-11 12:46:51.000000000","message":"True, its a bit tricky and i\u0027m open to ideas about this as I\u0027m not totally sure. This may be something that is hard to make equal across drivers (depending what querying options they have).","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":222,"context_line":"         \"\"\""},{"line_number":223,"context_line":"         Given a name and contents, create a new secrete in the secure backend"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"         :param str name: The name of the environment file"},{"line_number":226,"context_line":"         :param str contents: string containing the unencrypted secrete"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"         :return: Environment model instance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0c275565","line":225,"updated":"2014-06-10 19:10:38.000000000","message":"See my earlier comment about not needing a name here.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":222,"context_line":"         \"\"\""},{"line_number":223,"context_line":"         Given a name and contents, create a new secrete in the secure backend"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"         :param str name: The name of the environment file"},{"line_number":226,"context_line":"         :param str contents: string containing the unencrypted secrete"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"         :return: Environment model instance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d99b4e16","line":225,"in_reply_to":"1ae5cdf2_0c275565","updated":"2014-06-11 12:46:51.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":248,"context_line":"         :rtype: [Environment, ]"},{"line_number":249,"context_line":"         \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"     def update(self, environment_id, contents)"},{"line_number":252,"context_line":"         \"\"\""},{"line_number":253,"context_line":"         Update the secrete in the secure backend with the new contents."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2cb891e4","line":251,"updated":"2014-06-10 19:10:38.000000000","message":"Feels a bit weird to me that create returns an object, but update requires you to unpack the object and pass in its guts. Can\u0027t I just change the Environment instance and tell the API to save that?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"d088a104ddbb4c0da39768cdc68715450a97b733","unresolved":false,"context_lines":[{"line_number":248,"context_line":"         :rtype: [Environment, ]"},{"line_number":249,"context_line":"         \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"     def update(self, environment_id, contents)"},{"line_number":252,"context_line":"         \"\"\""},{"line_number":253,"context_line":"         Update the secrete in the secure backend with the new contents."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_59757ec9","line":251,"in_reply_to":"1ae5cdf2_2cb891e4","updated":"2014-06-11 12:46:51.000000000","message":"This was chosen after speaking with tzumainn to match the typical openstack style seen in a few places such as the clients (REST bindings) that typically do this.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":337,"context_line":"**Storage Backends**"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"The eventual goal is to use Glance artefacts with Barbican as it is a natural"},{"line_number":340,"context_line":"fit for the storage requirements. However, The required changes in Glance are"},{"line_number":341,"context_line":"under development during the Juno cycle and we can\u0027t rely on them being ready"},{"line_number":342,"context_line":"in time. For this reason, we plan to create two storage backends as defined"},{"line_number":343,"context_line":"below, the implementation for the secure storage will be the same for both."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8c76053d","line":340,"updated":"2014-06-10 19:10:38.000000000","message":"Nit: lowercase T in \"The\".","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":337,"context_line":"**Storage Backends**"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"The eventual goal is to use Glance artefacts with Barbican as it is a natural"},{"line_number":340,"context_line":"fit for the storage requirements. However, The required changes in Glance are"},{"line_number":341,"context_line":"under development during the Juno cycle and we can\u0027t rely on them being ready"},{"line_number":342,"context_line":"in time. For this reason, we plan to create two storage backends as defined"},{"line_number":343,"context_line":"below, the implementation for the secure storage will be the same for both."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ca50d634","line":340,"in_reply_to":"1ae5cdf2_8c76053d","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":339,"context_line":"The eventual goal is to use Glance artefacts with Barbican as it is a natural"},{"line_number":340,"context_line":"fit for the storage requirements. However, The required changes in Glance are"},{"line_number":341,"context_line":"under development during the Juno cycle and we can\u0027t rely on them being ready"},{"line_number":342,"context_line":"in time. For this reason, we plan to create two storage backends as defined"},{"line_number":343,"context_line":"below, the implementation for the secure storage will be the same for both."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_cc8f2d22","line":342,"updated":"2014-06-10 19:10:38.000000000","message":"Again, drivers feels a bit more natural here.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":339,"context_line":"The eventual goal is to use Glance artefacts with Barbican as it is a natural"},{"line_number":340,"context_line":"fit for the storage requirements. However, The required changes in Glance are"},{"line_number":341,"context_line":"under development during the Juno cycle and we can\u0027t rely on them being ready"},{"line_number":342,"context_line":"in time. For this reason, we plan to create two storage backends as defined"},{"line_number":343,"context_line":"below, the implementation for the secure storage will be the same for both."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ea411264","line":342,"in_reply_to":"1ae5cdf2_cc8f2d22","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":359,"context_line":"ecosystem."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"**Glance and Barbicam**"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The second backend that should be implemented will use Glance and Barbican. For"},{"line_number":365,"context_line":"this work to be completed we need to track the development of the Glance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8cc44541","line":362,"updated":"2014-06-10 19:10:38.000000000","message":"N instead of M at the end of Barbican.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":359,"context_line":"ecosystem."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"**Glance and Barbicam**"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The second backend that should be implemented will use Glance and Barbican. For"},{"line_number":365,"context_line":"this work to be completed we need to track the development of the Glance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0a471e78","line":362,"in_reply_to":"1ae5cdf2_8cc44541","updated":"2014-06-11 12:36:08.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":362,"context_line":"**Glance and Barbicam**"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The second backend that should be implemented will use Glance and Barbican. For"},{"line_number":365,"context_line":"this work to be completed we need to track the development of the Glance"},{"line_number":366,"context_line":"artefacts implementation. When it then becomes stable enough a backend should"},{"line_number":367,"context_line":"be implemented against its client."},{"line_number":368,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ecb949cc","line":365,"updated":"2014-06-10 19:10:38.000000000","message":"Is \"Glance Artefacts\" the name of the feature we\u0027re waiting on? Are there any others? If we\u0027re going to claim that it doesn\u0027t meet the needs of this spec, I\u0027d like to be very clear on what\u0027s missing.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":362,"context_line":"**Glance and Barbicam**"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The second backend that should be implemented will use Glance and Barbican. For"},{"line_number":365,"context_line":"this work to be completed we need to track the development of the Glance"},{"line_number":366,"context_line":"artefacts implementation. When it then becomes stable enough a backend should"},{"line_number":367,"context_line":"be implemented against its client."},{"line_number":368,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0df658f9","line":365,"in_reply_to":"1ae5cdf2_ecb949cc","updated":"2014-06-11 12:36:08.000000000","message":"It\u0027s sort-of the name. I don\u0027t think its been fully settled on yet. The last I heard, is that it may be changed from \"Glance Image Service\" to \"Glance Artifact Repository Service\"","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":394,"context_line":"- The versioning system in Swift doesn\u0027t provide a static reference to the"},{"line_number":395,"context_line":"  current version of an object. Rather it has the version \"latest\" and this is"},{"line_number":396,"context_line":"  dynamic and changes when a new version is added, therefore there is no way to"},{"line_number":397,"context_line":"  stick a deployment to a version."},{"line_number":398,"context_line":"- We need to create a relationship between the provider resources within a Role"},{"line_number":399,"context_line":"  and swift doesn\u0027t support relationships between stored objects."},{"line_number":400,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6ccc5962","line":397,"updated":"2014-06-10 19:10:38.000000000","message":"Has Swift expressed a reason why they wouldn\u0027t add that feature?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4a56a7c93fc3dbefb17f87d325266903eb72a3ff","unresolved":false,"context_lines":[{"line_number":394,"context_line":"- The versioning system in Swift doesn\u0027t provide a static reference to the"},{"line_number":395,"context_line":"  current version of an object. Rather it has the version \"latest\" and this is"},{"line_number":396,"context_line":"  dynamic and changes when a new version is added, therefore there is no way to"},{"line_number":397,"context_line":"  stick a deployment to a version."},{"line_number":398,"context_line":"- We need to create a relationship between the provider resources within a Role"},{"line_number":399,"context_line":"  and swift doesn\u0027t support relationships between stored objects."},{"line_number":400,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ed54ccff","line":397,"in_reply_to":"1ae5cdf2_6ccc5962","updated":"2014-06-11 12:36:08.000000000","message":"As far as I am aware, nobody has asked this question. I will investigate.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":394,"context_line":"- The versioning system in Swift doesn\u0027t provide a static reference to the"},{"line_number":395,"context_line":"  current version of an object. Rather it has the version \"latest\" and this is"},{"line_number":396,"context_line":"  dynamic and changes when a new version is added, therefore there is no way to"},{"line_number":397,"context_line":"  stick a deployment to a version."},{"line_number":398,"context_line":"- We need to create a relationship between the provider resources within a Role"},{"line_number":399,"context_line":"  and swift doesn\u0027t support relationships between stored objects."},{"line_number":400,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_803761fe","line":397,"in_reply_to":"1ae5cdf2_ed54ccff","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":413,"context_line":"Currently the only alternative to Barbican is to implement our own cryptography"},{"line_number":414,"context_line":"with one of the other options listed above. This isn\u0027t a favourable choice as"},{"line_number":415,"context_line":"it adds a technical complexity and risk that should be beyond the scope of this"},{"line_number":416,"context_line":"proposal."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ac4901b9","line":416,"updated":"2014-06-10 19:10:38.000000000","message":"There is another option of not storing *anything* secure. We then build up the environment with all of the safe values and it\u0027s on the caller to pass the sensitive information to Heat at create (update if needed) time.","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":413,"context_line":"Currently the only alternative to Barbican is to implement our own cryptography"},{"line_number":414,"context_line":"with one of the other options listed above. This isn\u0027t a favourable choice as"},{"line_number":415,"context_line":"it adds a technical complexity and risk that should be beyond the scope of this"},{"line_number":416,"context_line":"proposal."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a06a9dea","line":416,"in_reply_to":"1ae5cdf2_ac4901b9","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"c050bd337f3ed3908e24d737ae640418daca6971","unresolved":false,"context_lines":[{"line_number":447,"context_line":"Other Deployer Impact"},{"line_number":448,"context_line":"---------------------"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"TripleO will now require the use of Glance; Tuskar will also require Barbican."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_cc31ed0c","line":450,"updated":"2014-06-10 19:10:38.000000000","message":"I\u0027m not sure I understand the distinction here between TripleO needing glance and Tuskar needing Barbican. Aren\u0027t they both now dependencies due to Tuskar\u0027s use?","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"684530ea81661dcdb9bfc1c7aeda49afb68a9717","unresolved":false,"context_lines":[{"line_number":447,"context_line":"Other Deployer Impact"},{"line_number":448,"context_line":"---------------------"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"TripleO will now require the use of Glance; Tuskar will also require Barbican."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e07745d2","line":450,"in_reply_to":"1ae5cdf2_cc31ed0c","updated":"2014-06-12 14:37:17.000000000","message":"Done","commit_id":"94ec49b6c97b252c41d6aa78e0f4e8a7998aa99f"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a reference to the roles in"},{"line_number":14,"context_line":"that deployment plan. This specification is principally intended to be used by"},{"line_number":15,"context_line":"Tuskar."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_c3b6d3f8","line":13,"updated":"2014-06-12 15:11:18.000000000","message":"I haven\u0027t read the rest of the spec yet, but this still seems to imply that we\u0027re saving both the template and a separate list of roles, which is likely redundant; the template should indicate which roles are in it through its resource_registry entries.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This design specification describes how TripleO might store the required"},{"line_number":12,"context_line":"information for a deployment plan. Deployment plans consists of a master Heat"},{"line_number":13,"context_line":"Orchestration Template, a related environment and a reference to the roles in"},{"line_number":14,"context_line":"that deployment plan. This specification is principally intended to be used by"},{"line_number":15,"context_line":"Tuskar."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8a2bd780","line":13,"in_reply_to":"1ae5cdf2_c3b6d3f8","updated":"2014-06-13 15:39:35.000000000","message":"When you say \"the template should indicate\" do you mean \"the environment should indicate\"? Assuming so...\n\nGotcha, thanks. That clears it up, I had gotten into a confusion here and me and tzumainn both went the opposite way and thought they should be stored on the deployment plan but I see that duplication is pointless.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":30,"context_line":"roles for a particular deployment plan which together describe a deployment"},{"line_number":31,"context_line":"plan for Tuskar. Roles must then be available for re-use within other"},{"line_number":32,"context_line":"deployment plans. The storage should meet the following requirements:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_63a25faf","line":30,"updated":"2014-06-12 15:11:18.000000000","message":"Same comment above on the differentiation between the plan\u0027s template and a list of roles.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. _Tuskar REST API: https://review.openstack.org/#/c/94720/"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"We need to store a master Heat template, a related environment and a list of"},{"line_number":30,"context_line":"roles for a particular deployment plan which together describe a deployment"},{"line_number":31,"context_line":"plan for Tuskar. Roles must then be available for re-use within other"},{"line_number":32,"context_line":"deployment plans. The storage should meet the following requirements:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2a32c3f1","line":30,"in_reply_to":"1ae5cdf2_63a25faf","updated":"2014-06-13 15:39:35.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- Roles need to be versioned to allow deployments to stick to a specific"},{"line_number":38,"context_line":"  version which allows controlled upgrades and downgrades."},{"line_number":39,"context_line":"- Securely store sensitive environment files which may contain passwords and keys."},{"line_number":40,"context_line":"- Provide a model for the master template."},{"line_number":41,"context_line":"- Store references to the environment, master template and list of roles used"},{"line_number":42,"context_line":"  within the deployment plan."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_a37f0716","line":40,"updated":"2014-06-12 15:11:18.000000000","message":"What does this mean? Will the storage layer be parsing and modelling the contents of the master template?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"**Change Summary**"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- Provide a Python API  for the models to be consumed by Tuskar."},{"line_number":51,"context_line":"- Define models for roles, environments, master templates and deployment plans."},{"line_number":52,"context_line":"  This needs to support versioned storage and dependency relations which will"},{"line_number":53,"context_line":"  be used to describe a collection of Provider Resources within a role."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_037a7b23","line":50,"updated":"2014-06-12 15:11:18.000000000","message":"Really dumb nit: two spaces after API  :)","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"**Change Summary**"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- Provide a Python API  for the models to be consumed by Tuskar."},{"line_number":51,"context_line":"- Define models for roles, environments, master templates and deployment plans."},{"line_number":52,"context_line":"  This needs to support versioned storage and dependency relations which will"},{"line_number":53,"context_line":"  be used to describe a collection of Provider Resources within a role."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_b4849b0b","line":50,"in_reply_to":"1ae5cdf2_037a7b23","updated":"2014-06-12 16:17:54.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- Define models for roles, environments, master templates and deployment plans."},{"line_number":52,"context_line":"  This needs to support versioned storage and dependency relations which will"},{"line_number":53,"context_line":"  be used to describe a collection of Provider Resources within a role."},{"line_number":54,"context_line":"- Define a *secure* storage Python API for storing sensitive environments."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The following proposed change is split into three sections:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_03a19b93","line":54,"updated":"2014-06-12 15:11:18.000000000","message":"More and more I\u0027m on board with us not expecting to store anything secure. We should have a separate conversation outside of this spec to hash it out rather than going back and forth on patch sets.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. code-block:: python"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    class ProviderResource:"},{"line_number":113,"context_line":"        id \u003d \u002771c675ab-d94f-49cd-a114-e12490b328d9\u0027"},{"line_number":114,"context_line":"        template \u003d file_object"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_83312b5c","line":112,"updated":"2014-06-12 15:11:18.000000000","message":"I\u0027m not sure this is a correct usage of the term \"provider resource\". What I think is really being modelled here is simple a single resource type that depends on resources defined in multiple files.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**Environment**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"The environment defines the configuration for a deployment plan, it\u0027s"},{"line_number":126,"context_line":"relationship to a deployment plan is 1:1."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_63133fb8","line":125,"updated":"2014-06-12 15:11:18.000000000","message":"Nit: its\n\nThe environment file itself is more than just the configuration values for a deployment plan. It\u0027s the source of where templates are mapped as provider resources in the resource_registry section. I\u0027m not sure that necessarily changes the model, but I want to be clear that the environment file isn\u0027t a configuration file in the normal sense (it\u0027s not just values for parameters).","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**Environment**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"The environment defines the configuration for a deployment plan, it\u0027s"},{"line_number":126,"context_line":"relationship to a deployment plan is 1:1."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2de3bda4","line":125,"in_reply_to":"1ae5cdf2_63133fb8","updated":"2014-06-13 15:39:35.000000000","message":"Good point, clarified.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    class Environment:"},{"line_number":131,"context_line":"        id \u003d \u0027888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\u0027"},{"line_number":132,"context_line":"        updated \u003d \"2014-06-28T15:23:33.092660\""},{"line_number":133,"context_line":"        name \u003d \u0027dev-cloud\u0027"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        def get_contents(self):"},{"line_number":136,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_83668b4f","line":133,"updated":"2014-06-12 15:11:18.000000000","message":"Still not sure what name means here. If it\u0027s 1:1 with the deployment plan, then it\u0027s name isn\u0027t a variable. If this refers to the deployment plan name, then we should either rename it as such or make this a reference to the DeploymentPlan object.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    class Environment:"},{"line_number":131,"context_line":"        id \u003d \u0027888b29a4-c7cf-49d0-bfdf-bd9e6f26d718\u0027"},{"line_number":132,"context_line":"        updated \u003d \"2014-06-28T15:23:33.092660\""},{"line_number":133,"context_line":"        name \u003d \u0027dev-cloud\u0027"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        def get_contents(self):"},{"line_number":136,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_94e4ffe0","line":133,"in_reply_to":"1ae5cdf2_83668b4f","updated":"2014-06-12 16:17:54.000000000","message":"Part of this is due to the fact that most of the backends we want to use expect a name. I\u0027ll remove it from here, but I expect we will have to populate it with something (probably just the deployment plan name)","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        def get_contents(self):"},{"line_number":136,"context_line":"            \"\"\""},{"line_number":137,"context_line":"            Calls the storage API and returns the unencrypted contents"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            :return: secret contents"},{"line_number":140,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_23e217a0","line":137,"updated":"2014-06-12 15:11:18.000000000","message":"It\u0027s weird that we\u0027d go through API classes to make live calls against the storage backend to get these objects, but then have the objects themselves also reach out to the storage backend. It feels like the lines are blurred on where the network calls hit, and this breaks the abstraction that the backend-specific knowledge lies in the drivers.\n\nIt might be more consistent with the other calls to have this done via:\nEnvironmentAPI.get_contents(environment_object)","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        def get_contents(self):"},{"line_number":136,"context_line":"            \"\"\""},{"line_number":137,"context_line":"            Calls the storage API and returns the unencrypted contents"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            :return: secret contents"},{"line_number":140,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_74bcd3bb","line":137,"in_reply_to":"1ae5cdf2_23e217a0","updated":"2014-06-12 16:17:54.000000000","message":"Yup, that\u0027s the plan. I\u0027m working on changing to that api, I commented somewhere on a previous set but I\u0027ve not gotten to it yet.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    class MasterTemplate:"},{"line_number":148,"context_line":"        id \u003d \u0027bd9e6f26d71-c7cf-49d0-bfdf-8888b29a4\u0027"},{"line_number":149,"context_line":"        heat_template \u003d \"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def get_contents(self):"},{"line_number":152,"context_line":"            \"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_a3e547a5","line":149,"updated":"2014-06-12 15:11:18.000000000","message":"Is this the loaded/cached contents or the location of where to load it from?\n\nWhy does this not have a name attribute but environment does? These two files are similar in importance and usage (i.e. both first-class files in the deployment plan) so either both should have a name or neither (my vote is for neither).\n\nThis is missing a last updated timestamp.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def get_contents(self):"},{"line_number":152,"context_line":"            \"\"\""},{"line_number":153,"context_line":"            Calls the storage API and returns the unencrypted contents"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            :return: secret contents"},{"line_number":156,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_634b3f87","line":153,"updated":"2014-06-12 15:11:18.000000000","message":"Same comment as for environments, it feels weird to call the *API classes for loading but also have loading logic in here.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def get_contents(self):"},{"line_number":152,"context_line":"            \"\"\""},{"line_number":153,"context_line":"            Calls the storage API and returns the unencrypted contents"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            :return: secret contents"},{"line_number":156,"context_line":"            :rtype: str"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8df3f171","line":153,"in_reply_to":"1ae5cdf2_634b3f87","updated":"2014-06-13 15:39:35.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        id \u003d \"dd4ef003-c855-40ba-b5a6-3fe4176a069e\""},{"line_number":166,"context_line":"        name \u003d \"dev-cloud\""},{"line_number":167,"context_line":"        description \u003d \"Development testing cloud\""},{"line_number":168,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        master_template \u003d MasterTemplate"},{"line_number":171,"context_line":"        environment \u003d Environment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_035c3b4a","line":168,"updated":"2014-06-12 15:11:18.000000000","message":"Nit: This is called \"updated\" in the environment, missing in deployment plan, and called \"last_modified\" here.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        id \u003d \"dd4ef003-c855-40ba-b5a6-3fe4176a069e\""},{"line_number":166,"context_line":"        name \u003d \"dev-cloud\""},{"line_number":167,"context_line":"        description \u003d \"Development testing cloud\""},{"line_number":168,"context_line":"        last_modified \u003d \"2014-05-28T21:11:09Z\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        master_template \u003d MasterTemplate"},{"line_number":171,"context_line":"        environment \u003d Environment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8dc131e6","line":168,"in_reply_to":"1ae5cdf2_035c3b4a","updated":"2014-06-13 15:39:35.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Each of the models defined above has their own Python storage interface. These"},{"line_number":181,"context_line":"are manager classes that will query and perform CRUD operations against the"},{"line_number":182,"context_line":"storage drivers and typically return instances of the models for use. Their"},{"line_number":183,"context_line":"implementation is likely to share common logic."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_4329e399","line":182,"updated":"2014-06-12 15:11:18.000000000","message":"Curious about \"typically\", when would the calls not return model instances on a CRUD operation?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2d8e5f2140622e368fe792e13b011564a65ba4d8","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Each of the models defined above has their own Python storage interface. These"},{"line_number":181,"context_line":"are manager classes that will query and perform CRUD operations against the"},{"line_number":182,"context_line":"storage drivers and typically return instances of the models for use. Their"},{"line_number":183,"context_line":"implementation is likely to share common logic."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_b47e5b68","line":182,"in_reply_to":"1ae5cdf2_4329e399","updated":"2014-06-12 16:05:39.000000000","message":"Delete wouldn\u0027t return an instance. It may be better to clearly state this.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"     def list_versions(self, role_id)"},{"line_number":225,"context_line":"         \"\"\""},{"line_number":226,"context_line":"         Given a role_id return a list of the available versions."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"         :param str role_id: The role_id of the role"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_bea71a0a","line":226,"updated":"2014-06-12 15:11:18.000000000","message":"Shouldn\u0027t this be a role name? The ID should refer to a specific name, version tuple.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"     def list_versions(self, role_id)"},{"line_number":225,"context_line":"         \"\"\""},{"line_number":226,"context_line":"         Given a role_id return a list of the available versions."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"         :param str role_id: The role_id of the role"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_141d4fbe","line":226,"in_reply_to":"1ae5cdf2_74d69350","updated":"2014-06-12 16:17:54.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2d8e5f2140622e368fe792e13b011564a65ba4d8","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"     def list_versions(self, role_id)"},{"line_number":225,"context_line":"         \"\"\""},{"line_number":226,"context_line":"         Given a role_id return a list of the available versions."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"         :param str role_id: The role_id of the role"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_74d69350","line":226,"in_reply_to":"1ae5cdf2_bea71a0a","updated":"2014-06-12 16:05:39.000000000","message":"Yup, good catch. Blame the copypasta.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"but provides the safest default."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"The operations are intentionally lazy, they will return models with the"},{"line_number":269,"context_line":"metadata and not the secrete contents. They can then be unlocked and accessed"},{"line_number":270,"context_line":"when they are used rather than when querying the storage."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_43000302","line":269,"updated":"2014-06-12 15:11:18.000000000","message":"s/secrete/secret\n\nWhat do you mean by \"unlocked\"?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"2d8e5f2140622e368fe792e13b011564a65ba4d8","unresolved":false,"context_lines":[{"line_number":266,"context_line":"but provides the safest default."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"The operations are intentionally lazy, they will return models with the"},{"line_number":269,"context_line":"metadata and not the secrete contents. They can then be unlocked and accessed"},{"line_number":270,"context_line":"when they are used rather than when querying the storage."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_d4f927c9","line":269,"in_reply_to":"1ae5cdf2_43000302","updated":"2014-06-12 16:05:39.000000000","message":"Oh man, I wish I typo-ed that on purpose this time.\n\nunlocked should have said decrypted","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"         The initialisation method will setup the storage python client."},{"line_number":279,"context_line":"         \"\"\""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"     def create(self, contents)"},{"line_number":282,"context_line":"         \"\"\""},{"line_number":283,"context_line":"         Given a and contents, create a new secrete in the secure driver"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_fe9362a0","line":281,"updated":"2014-06-12 15:11:18.000000000","message":"Same comment as for master template, I don\u0027t think it makes sense to create an environment outside of a plan.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"     def create(self, contents)"},{"line_number":282,"context_line":"         \"\"\""},{"line_number":283,"context_line":"         Given a and contents, create a new secrete in the secure driver"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"         :param str contents: string containing the unencrypted secrete"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_5e4e1670","line":283,"updated":"2014-06-12 15:11:18.000000000","message":"s/secrete/secret\n\nNot sure what \"a and contents\" means, looks like a change was being made and you got interrupted.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3d3c062dc563e30126f3d774c69f1e72efac0490","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"     def create(self, contents)"},{"line_number":282,"context_line":"         \"\"\""},{"line_number":283,"context_line":"         Given a and contents, create a new secrete in the secure driver"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"         :param str contents: string containing the unencrypted secrete"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_9004e615","line":283,"in_reply_to":"1ae5cdf2_5e4e1670","updated":"2014-06-13 15:39:35.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"     def fetch(self, environment_id)"},{"line_number":292,"context_line":"         \"\"\""},{"line_number":293,"context_line":"         Given a environment ID, fetch the metadata for the secrete in the"},{"line_number":294,"context_line":"         secure driver and return an instance of the Environment model."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"         :param str environment_id: The ID of the environment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_de41463a","line":293,"updated":"2014-06-12 15:11:18.000000000","message":"What do you mean \"fetch the metadata for the secret\" ?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":338,"context_line":"         The initialisation method will setup the storage python client."},{"line_number":339,"context_line":"         \"\"\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"     def create(self, contents)"},{"line_number":342,"context_line":"         \"\"\""},{"line_number":343,"context_line":"         :param str contents: string containing the Heat template"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_9e797e84","line":341,"updated":"2014-06-12 15:11:18.000000000","message":"Does it make sense to ever create a master template that\u0027s not related to a deployment plan? I think the deployment plan ID needs to be specified here so we have the relationship.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":390,"context_line":"         The initialisation method will setup the storage python client."},{"line_number":391,"context_line":"         \"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"     def create(self, name, description, master_template, environment, roles)"},{"line_number":394,"context_line":"         \"\"\""},{"line_number":395,"context_line":"         :param str name: The name of the deployment plan"},{"line_number":396,"context_line":"         :param str description: The deployment plan description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_dec4e693","line":393,"updated":"2014-06-12 15:11:18.000000000","message":"To my earlier comments about creating a template/env from a plan, maybe I\u0027m just thinking about the workflow backwards. I envisioned:\n\ncreate plan\ncreate environment inside of plan\ncreate template inside of plan\n\nIt looks like the API is going the opposite direction:\n\ncreate environment\ncreate template\ncreate plan and give it environment and template\n\nSeeing as a plan requires both of these files, I think it should actually just be\n\ncreate plan (which creates an environment and template and automatically associates them)","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"         :param str name: The name of the deployment plan"},{"line_number":396,"context_line":"         :param str description: The deployment plan description"},{"line_number":397,"context_line":"         :param str master_template: URI for the master template"},{"line_number":398,"context_line":"         :param str environment: ID for the environment file"},{"line_number":399,"context_line":"         :param list roles: A list of Python dictionaries defining roles"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"         :return: DeploymentPlan model instance"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_3eb86a10","line":398,"updated":"2014-06-12 15:11:18.000000000","message":"Why is the master template referred to by URI but the environment by ID?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"     def fetch_resource(self, plan_id)"},{"line_number":414,"context_line":"         \"\"\""},{"line_number":415,"context_line":"         :param str plan_id: The ID of the environment"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"         :return: DeploymentPlan model instance"},{"line_number":418,"context_line":"         :rtype: DeploymentPlan"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_fe48c22e","line":415,"updated":"2014-06-12 15:11:18.000000000","message":"s/environment/plan","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"     def fetch_resource(self, plan_id)"},{"line_number":414,"context_line":"         \"\"\""},{"line_number":415,"context_line":"         :param str plan_id: The ID of the environment"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"         :return: DeploymentPlan model instance"},{"line_number":418,"context_line":"         :rtype: DeploymentPlan"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_34488bb2","line":415,"in_reply_to":"1ae5cdf2_fe48c22e","updated":"2014-06-12 16:17:54.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":427,"context_line":"         :param str name: The name of the deployment plan"},{"line_number":428,"context_line":"         :param str description: The deployment plan description"},{"line_number":429,"context_line":"         :param str master_template: URI for the master template"},{"line_number":430,"context_line":"         :param str environment: ID for the environment file"},{"line_number":431,"context_line":"         :param list roles: A list of Python dictionaries defining roles"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"         :return: DeploymentPlan model instance"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_be11da05","line":430,"updated":"2014-06-12 15:11:18.000000000","message":"So when updating a template or environment, the only operation available through this call is to point the plan at an entirely different one? You\u0027ll still need to go through the *API calls to update each object individually. If that\u0027s the case, I don\u0027t see a need to include them in the call (see my comments on create, I\u0027m more leaning towards the idea of the plan creating env and template files and that\u0027s the end of it, they are just edited from there).","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"         :param str description: The deployment plan description"},{"line_number":429,"context_line":"         :param str master_template: URI for the master template"},{"line_number":430,"context_line":"         :param str environment: ID for the environment file"},{"line_number":431,"context_line":"         :param list roles: A list of Python dictionaries defining roles"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"         :return: DeploymentPlan model instance"},{"line_number":434,"context_line":"         :rtype: DeploymentPlan"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_be847a0b","line":431,"updated":"2014-06-12 15:11:18.000000000","message":"What\u0027s in the dictionary? Is this a full set of all roles that should be in the plan after the update?","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"98ec9bfe0e996f4a83e8b2b19f3af04de7d0032f","unresolved":false,"context_lines":[{"line_number":437,"context_line":"         :raises ValueError: if no values were given to update"},{"line_number":438,"context_line":"         \"\"\""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"     def delete(self, ID)"},{"line_number":441,"context_line":"         \"\"\""},{"line_number":442,"context_line":"         :param str plan_id: The ID of the environment"},{"line_number":443,"context_line":"         \"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_fe79a22f","line":440,"updated":"2014-06-12 15:11:18.000000000","message":"Nit: docstring says plan_id but the variable is named ID.","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8efa55f1ea572f16641345f151cc2ff39433eb98","unresolved":false,"context_lines":[{"line_number":437,"context_line":"         :raises ValueError: if no values were given to update"},{"line_number":438,"context_line":"         \"\"\""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"     def delete(self, ID)"},{"line_number":441,"context_line":"         \"\"\""},{"line_number":442,"context_line":"         :param str plan_id: The ID of the environment"},{"line_number":443,"context_line":"         \"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_144b8fb1","line":440,"in_reply_to":"1ae5cdf2_fe79a22f","updated":"2014-06-12 16:17:54.000000000","message":"Done","commit_id":"111a6cb7ce4581ca07a17af4ce729e71f4424d34"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        read_only \u003d boolean"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        def add_provider_resource(self, provider_resource):"},{"line_number":103,"context_line":"            # Template munging."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":106,"context_line":"            # template munging."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_b49d085a","line":103,"updated":"2014-06-24 08:25:02.000000000","message":"If I get it correctly this will be used only by plan to build Master template? In that case it should not be a general method on Template.\n\nThere should be a method build_template on Plan, that will build the template from list of Roles. I don\u0027t think we can easily parse and append chunks of code to template, most likely the master template will need to be rebuilt every time.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        read_only \u003d boolean"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        def add_provider_resource(self, provider_resource):"},{"line_number":103,"context_line":"            # Template munging."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":106,"context_line":"            # template munging."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_d2f44df3","line":103,"in_reply_to":"1ae5cdf2_b49d085a","updated":"2014-06-25 01:03:12.000000000","message":"You\u0027re right - removed.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            # Template munging."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":106,"context_line":"            # template munging."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def get_dependant_templates(self, heat_client):"},{"line_number":109,"context_line":"            # use heat client for this"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_14b4fcd2","line":106,"updated":"2014-06-24 08:25:02.000000000","message":"ditto","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            # Template munging."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":106,"context_line":"            # template munging."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def get_dependant_templates(self, heat_client):"},{"line_number":109,"context_line":"            # use heat client for this"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_92d1e558","line":106,"in_reply_to":"1ae5cdf2_14b4fcd2","updated":"2014-06-25 01:03:12.000000000","message":"Ditto :)","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        def add_provider_resource(self, provider_resource):"},{"line_number":152,"context_line":"            # Template munging."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":155,"context_line":"            # template munging."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        def get_dependant_templates(self, heat_client):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_94ff2c35","line":154,"updated":"2014-06-24 08:25:02.000000000","message":"I would rather have this same as configuration, set_resource_registry, get_resource_registry. Instead of add/remove provider resources.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        def add_provider_resource(self, provider_resource):"},{"line_number":152,"context_line":"            # Template munging."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        def remove_provider_resource(self, provider_resource):"},{"line_number":155,"context_line":"            # template munging."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        def get_dependant_templates(self, heat_client):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_f565b3e2","line":154,"in_reply_to":"1ae5cdf2_94ff2c35","updated":"2014-06-25 01:03:12.000000000","message":"Fair enough!","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            # template munging."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        def get_dependant_templates(self, heat_client):"},{"line_number":158,"context_line":"            # use heat client for this"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":161,"context_line":"            # use heat validate to get the list of parameters"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_344d789a","line":158,"updated":"2014-06-24 08:25:02.000000000","message":"This would mean, that env. file contains URL to actual file, not just name, right? Or does this suppose to return Template objects?","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            # template munging."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        def get_dependant_templates(self, heat_client):"},{"line_number":158,"context_line":"            # use heat client for this"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":161,"context_line":"            # use heat validate to get the list of parameters"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_3560fbce","line":158,"in_reply_to":"1ae5cdf2_344d789a","updated":"2014-06-25 01:03:12.000000000","message":"You\u0027re right, this should be removed.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            # use heat validate to get the list of parameters"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        def set_configuration_parameters(self, heat_client, parameters):"},{"line_number":164,"context_line":"            # use heat client for this"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"**Role Model**"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_74154048","line":164,"updated":"2014-06-24 08:25:02.000000000","message":"heat client for? this will be stored entirely in our storage, right?","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            # use heat validate to get the list of parameters"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        def set_configuration_parameters(self, heat_client, parameters):"},{"line_number":164,"context_line":"            # use heat client for this"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"**Role Model**"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_b5a32bff","line":164,"in_reply_to":"1ae5cdf2_74154048","updated":"2014-06-25 01:03:12.000000000","message":"Hm, you\u0027re right, no reason to specify a heat client here.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    class Role:"},{"line_number":177,"context_line":"        uuid \u003d UUID string"},{"line_number":178,"context_line":"        name \u003d string"},{"line_number":179,"context_line":"        last_updated \u003d datetime"},{"line_number":180,"context_line":"        description \u003d string"},{"line_number":181,"context_line":"        version \u003d string"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_3702da09","line":178,"updated":"2014-06-24 08:25:02.000000000","message":"Is this provider resource type?","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def list_roles(self):"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            for provider_resource in self.environment_file.provider_resources():"},{"line_number":244,"context_line":"                yield provider_resource.template"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def get_templates(self):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_3729fa89","line":243,"updated":"2014-06-24 08:25:02.000000000","message":"not all provider resources are roles","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def list_roles(self):"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            for provider_resource in self.environment_file.provider_resources():"},{"line_number":244,"context_line":"                yield provider_resource.template"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def get_templates(self):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_b006d9cb","line":243,"in_reply_to":"1ae5cdf2_3729fa89","updated":"2014-06-25 01:03:12.000000000","message":"But the way Tuskar constructs the deployment plan, they will be - right?","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"8b0e8b521de45e267e031ecbbe0adbd3a125a9e0","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def list_roles(self):"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            for provider_resource in self.environment_file.provider_resources():"},{"line_number":244,"context_line":"                yield provider_resource.template"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def get_templates(self):"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_d7b7c81f","line":243,"in_reply_to":"1ae5cdf2_b006d9cb","updated":"2014-06-26 08:47:02.000000000","message":"No, you can\u0027t say that upfront. Somebody can put provider resource in THT and we will have to deal with it.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            yield self.master_template"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            for role in self.list_roles():"},{"line_number":251,"context_line":"                yield role.get_templates()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        def get_parameters(self):"},{"line_number":254,"context_line":"            return self.environment_file.get_parameters()"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_57f12600","line":251,"updated":"2014-06-24 08:25:02.000000000","message":"plan should have one method that returns everything we need for heat. We should not make 4 api call for it.\n\nit should return this \n https://github.com/openstack/python-heatclient/blob/93dcf9591dbd0966b2faca8fcc0a87203fbc83eb/heatclient/v1/shell.py#L98","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        def list(self):"},{"line_number":297,"context_line":"            return self.driver.list()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        def get_by_name(self, name):"},{"line_number":300,"context_line":"            return self.driver.retrieve_by(name\u003dname)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_976f2e93","line":299,"updated":"2014-06-24 08:25:02.000000000","message":"and version","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        def list(self):"},{"line_number":297,"context_line":"            return self.driver.list()"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        def get_by_name(self, name):"},{"line_number":300,"context_line":"            return self.driver.retrieve_by(name\u003dname)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_0e6f6961","line":299,"in_reply_to":"1ae5cdf2_976f2e93","updated":"2014-06-25 01:03:12.000000000","message":"Good catch - added.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        def get_by_name(self, name, version\u003dNone):"},{"line_number":352,"context_line":"            return self.driver.retrieve_by(name\u003dname, version\u003dversion)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def get_by_provider_resource(self, provider_resource):"},{"line_number":355,"context_line":"            return self.driver.retrieve_by("},{"line_number":356,"context_line":"                template_uuid\u003dprovider_resource.template.uuid)"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_f7fdd2b2","line":354,"updated":"2014-06-24 08:25:02.000000000","message":"isn\u0027t this get by template_uuid?\n\nprovider_resource !\u003d template_uuid","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        def get_by_name(self, name, version\u003dNone):"},{"line_number":352,"context_line":"            return self.driver.retrieve_by(name\u003dname, version\u003dversion)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def get_by_provider_resource(self, provider_resource):"},{"line_number":355,"context_line":"            return self.driver.retrieve_by("},{"line_number":356,"context_line":"                template_uuid\u003dprovider_resource.template.uuid)"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_0ed4c9e7","line":354,"in_reply_to":"1ae5cdf2_f7fdd2b2","updated":"2014-06-25 01:03:12.000000000","message":"Yeah, I don\u0027t think this is actually needed, it was my mistake.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"443e077f1d0f4cd055831eb47037d15966d522fb","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        def list(self):"},{"line_number":398,"context_line":"            return self.driver.list()"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def get_by_provider_resource(self, provider_resource):"},{"line_number":401,"context_line":"            return self.driver.retrieve_by("},{"line_number":402,"context_line":"                template_uuid\u003dprovider_resource.template.uuid)"},{"line_number":403,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_97cbae72","line":400,"updated":"2014-06-24 08:25:02.000000000","message":"ehm, what is this method for? Retrieving plan by provider resource?","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"0062c8842d457f4e8135ef329c147ffe731102eb","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        def list(self):"},{"line_number":398,"context_line":"            return self.driver.list()"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def get_by_provider_resource(self, provider_resource):"},{"line_number":401,"context_line":"            return self.driver.retrieve_by("},{"line_number":402,"context_line":"                template_uuid\u003dprovider_resource.template.uuid)"},{"line_number":403,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_ce37414a","line":400,"in_reply_to":"1ae5cdf2_97cbae72","updated":"2014-06-25 01:03:12.000000000","message":"Whoops, I think this was my fault again - removed.","commit_id":"be1904b59c558108ab01e003563bfaaebe8ef01a"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. _problem:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_f2c84023","line":21,"updated":"2014-06-25 16:48:59.000000000","message":"Sphinx Nit: These have to be unique globally, across every spec and other document. I\u0027ve taken to namespacing them manually so we don\u0027t run into conflicts later on when we have a ton of specs in here.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"https://blueprints.launchpad.net/tuskar/+spec/tripleo-juno-tuskar-template-storage"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. _problem:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_43520869","line":21,"in_reply_to":"1ae5cdf2_f2c84023","updated":"2014-06-26 04:33:11.000000000","message":"Ah, good to know - fixed in the next iteration.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":39,"context_line":"stable while the former retains enough flexibility to use a variety of backends"},{"line_number":40,"context_line":"as need and availability dictates.  Storage requirements for particular models"},{"line_number":41,"context_line":"include items such as versioning and secure storage."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed Change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_f29680ee","line":42,"updated":"2014-06-25 16:48:59.000000000","message":"IMO, this is a really good summary and breaks apart the two main points to consider.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  order to be usable by the Python API Interface.  Plans for initial and future"},{"line_number":58,"context_line":"  driver support are discussed here."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"It should be noted that there is a storage interfaces will be specified by the"},{"line_number":61,"context_line":"user for use throughout the API through a configurable option.  Thus, the domain"},{"line_number":62,"context_line":"model can assume that the appropriate storage interfaces - a template store,"},{"line_number":63,"context_line":"an environment store, etc - are defined globally and accessible for use."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_d2618412","line":60,"updated":"2014-06-25 16:48:59.000000000","message":"Grammar Nit: Not totally sure what you\u0027re going for here, but this sentence reads incorrectly. I think it\u0027s the combination of two different edits.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  order to be usable by the Python API Interface.  Plans for initial and future"},{"line_number":58,"context_line":"  driver support are discussed here."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"It should be noted that there is a storage interfaces will be specified by the"},{"line_number":61,"context_line":"user for use throughout the API through a configurable option.  Thus, the domain"},{"line_number":62,"context_line":"model can assume that the appropriate storage interfaces - a template store,"},{"line_number":63,"context_line":"an environment store, etc - are defined globally and accessible for use."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1ef5b3ec","line":60,"in_reply_to":"1ae5cdf2_d2618412","updated":"2014-06-26 04:33:11.000000000","message":"Whoops - clarified and fixed.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Each model will contain a save and serialise method. The same method will call"},{"line_number":78,"context_line":"create on the store if the uuid isn\u0027t set, and will call update on the store"},{"line_number":79,"context_line":"if the instance has a uuid. The serialise method will return a python"},{"line_number":80,"context_line":"dictionary containing all the values of the model. For brevity, these are not"},{"line_number":81,"context_line":"repeated in all of the following models."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_922d3cab","line":80,"updated":"2014-06-25 16:48:59.000000000","message":"Why is a dictionary view needed? The benefit of using domain objects with first-class attributes gets lost in a dictionary. If it\u0027s for JSON serialization, that\u0027s not the domain model responsibility, but rather the responsibility of the controllers before it goes out the door.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Each model will contain a save and serialise method. The same method will call"},{"line_number":78,"context_line":"create on the store if the uuid isn\u0027t set, and will call update on the store"},{"line_number":79,"context_line":"if the instance has a uuid. The serialise method will return a python"},{"line_number":80,"context_line":"dictionary containing all the values of the model. For brevity, these are not"},{"line_number":81,"context_line":"repeated in all of the following models."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_958c41d9","line":80,"in_reply_to":"1ae5cdf2_922d3cab","updated":"2014-06-26 04:33:11.000000000","message":"This dictionary view is used by the storage driver; something like Glance might save it in a flat file; a database driver might turn the dictionary into a row in a database table.  I think you\u0027re right that it doesn\u0027t quite belong here, though; I\u0027ll move it to the storage interface layer.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The template model represents a Heat template."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. code-block:: python"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    class Template:"},{"line_number":91,"context_line":"        uuid \u003d UUID string"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_3214684c","line":88,"updated":"2014-06-25 16:48:59.000000000","message":"Nit: This looks awkward that it\u0027s done as a python code block but isn\u0027t actually Python code. Any reason a list of attributes, their types, and a description (when needed) can\u0027t be used?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The template model represents a Heat template."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. code-block:: python"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    class Template:"},{"line_number":91,"context_line":"        uuid \u003d UUID string"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_283874d3","line":88,"in_reply_to":"1ae5cdf2_3214684c","updated":"2014-06-26 04:33:11.000000000","message":"No particular reason, it just felt like a class definition in pseudo-code.  I\u0027ll change it if people feel strongly about this.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        content \u003d string"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":99,"context_line":"            # Uses heat validate to get the list of parameters."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"**Environment File Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1df5bdec","line":99,"updated":"2014-06-25 16:48:59.000000000","message":"This concerns me. It feels weird that the domain object would make a live call out to Heat to parse the template.\n\nA domain object, IMO, is something easily passed around internally. It feels awkward to also require someone using the object to have a handle to a Heat client as well.\n\nPersonally, I\u0027d rather see a separate step when the Template is loaded that calls out to the parser and populates the object. That centralizes who is doing the parsing and leaves the domain objects as representing data instead of a live REST call.\n\nAt that point, the actual parsing is an implementation detail. I\u0027m hoping we can use the Heat code for parsing without needing to contact itself. If we can\u0027t currently, I could see making a blueprint for Heat to extract that out so it\u0027s usable; we can\u0027t be the only people who want an object representation of a template.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        content \u003d string"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":99,"context_line":"            # Uses heat validate to get the list of parameters."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"**Environment File Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_ab247eb2","line":99,"in_reply_to":"1ae5cdf2_1df5bdec","updated":"2014-06-26 04:33:11.000000000","message":"That seems sensible to have this done in the template store - I\u0027ll update the spec.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        content \u003d string"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        def set_resource_registry(self, resources):"},{"line_number":116,"context_line":"            # Sets the resource registry according the values in resources."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def get_resource_registry(self):"},{"line_number":119,"context_line":"            # Returns the resource registry in dict form."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_bd35a9a9","line":116,"updated":"2014-06-25 16:48:59.000000000","message":"A resource_registry entry is two things: the namespace and the file it\u0027s mapped to. What sort of variable is resources? A list of tuples? Is there a reason it\u0027s a set_* (requiring the full list to be re-specified each time) instead of add/remove operations?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        content \u003d string"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        def set_resource_registry(self, resources):"},{"line_number":116,"context_line":"            # Sets the resource registry according the values in resources."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def get_resource_registry(self):"},{"line_number":119,"context_line":"            # Returns the resource registry in dict form."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_cb9c6ac2","line":116,"in_reply_to":"1ae5cdf2_bd35a9a9","updated":"2014-06-26 04:33:11.000000000","message":"Ah, you\u0027re right - I\u0027ll update.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            # Sets the resource registry according the values in resources."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def get_resource_registry(self):"},{"line_number":119,"context_line":"            # Returns the resource registry in dict form."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_7d5321e2","line":119,"updated":"2014-06-25 16:48:59.000000000","message":"The value in a resource registry entry refers to a template file. Is this going to return just the name of that file, or a Template object?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            # Sets the resource registry according the values in resources."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def get_resource_registry(self):"},{"line_number":119,"context_line":"            # Returns the resource registry in dict form."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_8bb26247","line":119,"in_reply_to":"1ae5cdf2_7d5321e2","updated":"2014-06-26 04:33:11.000000000","message":"I\u0027d imagine just the name, since a Template object is versioned and Heat doesn\u0027t do versions.  I\u0027ll specify.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # Returns the resource registry in dict form."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        def set_parameters(self, heat_client, parameters):"},{"line_number":125,"context_line":"            # Updates the parameter values."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_9d4e2d37","line":122,"updated":"2014-06-25 16:48:59.000000000","message":"See above.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # Returns the resource registry in dict form."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        def get_parameters(self, heat_client):"},{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        def set_parameters(self, heat_client, parameters):"},{"line_number":125,"context_line":"            # Updates the parameter values."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_ab80fe49","line":122,"in_reply_to":"1ae5cdf2_9d4e2d37","updated":"2014-06-26 04:33:11.000000000","message":"I\u0027ll fix.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        def set_parameters(self, heat_client, parameters):"},{"line_number":125,"context_line":"            # Updates the parameter values."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"**Role Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_fd249161","line":125,"updated":"2014-06-25 16:48:59.000000000","message":"See above both comments on both the need for everyone calling this to have an active heat client handle as well as the question on set_* v. add_* and remove_*.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # Use heat validate to get the list of parameters."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        def set_parameters(self, heat_client, parameters):"},{"line_number":125,"context_line":"            # Updates the parameter values."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"**Role Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_eb7a0676","line":125,"in_reply_to":"1ae5cdf2_fd249161","updated":"2014-06-26 04:33:11.000000000","message":"I think this is different in the sense that we\u0027re setting a value to an existing parameter, rather than adding new parameters.\n\nThis might be more clear if I remove these four methods, add \"add/remove_provider_resource\" methods which adds/removes a template to the environment file as a provider resource (scraping it for parameters along the way); and then change this method to \"set_parameter_values\".","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def get_parameters(self):"},{"line_number":152,"context_line":"            # Returns a list of parameters from both the role template and the"},{"line_number":153,"context_line":"            # dependent templates."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"**Deployment Plan Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_dd899526","line":153,"updated":"2014-06-25 16:48:59.000000000","message":"I am pretty sure it\u0027s not necessary to say you\u0027re returning the parameters from the dependencies. The role template is a standalone Heat stack, which means its attributes will be enough to drive all of the dependencies as well.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def get_parameters(self):"},{"line_number":152,"context_line":"            # Returns a list of parameters from both the role template and the"},{"line_number":153,"context_line":"            # dependent templates."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"**Deployment Plan Model**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_37f7e38d","line":153,"in_reply_to":"1ae5cdf2_dd899526","updated":"2014-06-26 04:33:11.000000000","message":"Given that, I don\u0027t need this at all, right?  instead of \u0027role.parameters\u0027, I can just call \u0027role.role_template.parameters\u0027","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    class DeploymentPlan:"},{"line_number":168,"context_line":"        uuid \u003d UUID string"},{"line_number":169,"context_line":"        name \u003d string"},{"line_number":170,"context_line":"        last_updated \u003d datetime"},{"line_number":171,"context_line":"        description \u003d string"},{"line_number":172,"context_line":"        role_uuids \u003d list of Role UUID strings"},{"line_number":173,"context_line":"        master_template_uuid \u003d Template UUID string"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_fdae5180","line":170,"updated":"2014-06-25 16:48:59.000000000","message":"If we\u0027re storing this, let\u0027s throw in a created timestamp as well. I don\u0027t have an actual use case for it, just the gut feeling that I typically see them specified together and it should be relatively cheap to do so (if it\u0027s not for some reason, I\u0027m not strongly arguing to go out of our way to add it).","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    class DeploymentPlan:"},{"line_number":168,"context_line":"        uuid \u003d UUID string"},{"line_number":169,"context_line":"        name \u003d string"},{"line_number":170,"context_line":"        last_updated \u003d datetime"},{"line_number":171,"context_line":"        description \u003d string"},{"line_number":172,"context_line":"        role_uuids \u003d list of Role UUID strings"},{"line_number":173,"context_line":"        master_template_uuid \u003d Template UUID string"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_573b8f37","line":170,"in_reply_to":"1ae5cdf2_fdae5180","updated":"2014-06-26 04:33:11.000000000","message":"Done, and renamed to \u0027created_at\u0027 and \u0027updated_at\u0027 to match the current schema.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"8f502fd307a7cebe1a6b46722df7fb25ddca2075","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        def remove_role(self, role):"},{"line_number":191,"context_line":"            # Removes a Role from the plan.  This operation will modify the master"},{"line_number":192,"context_line":"            # template and environment file through template munging operations"},{"line_number":193,"context_line":"            # specified in a separate spec."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        def get_dependent_templates(self):"},{"line_number":196,"context_line":"            # Returns a list of dependent templates.  This consists of the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_fde571dc","line":193,"updated":"2014-06-25 16:48:59.000000000","message":"For what it\u0027s worth, after seeing these v. the set_* methods above that I commented on, I prefer this approach.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    class TemplateStore:"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def create(self, name\u003dNone, content\u003dNone):"},{"line_number":226,"context_line":"            # Creates a Template."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        def retrieve(self, uuid):"},{"line_number":229,"context_line":"            # Retrieves the Template with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b8b857e9","line":226,"updated":"2014-06-25 18:22:29.000000000","message":"Is name really optional?\n\nSame for content, would we want to create a template without any content?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    class TemplateStore:"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        def create(self, name\u003dNone, content\u003dNone):"},{"line_number":226,"context_line":"            # Creates a Template."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        def retrieve(self, uuid):"},{"line_number":229,"context_line":"            # Retrieves the Template with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b7c69314","line":226,"in_reply_to":"1ae5cdf2_b8b857e9","updated":"2014-06-26 04:33:11.000000000","message":"Fixed.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            # version is specified, retrieves the latest version of the Template."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def update(self, model):"},{"line_number":236,"context_line":"            # Updates a Template."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        def delete(self, uuid):"},{"line_number":239,"context_line":"            # Deletes a Template with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_58c75365","line":236,"updated":"2014-06-25 18:22:29.000000000","message":"Do we actually want to support this? Part of the rationale with the versioning was to make a number of these pieces immutable. Changing a template violates that.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            # version is specified, retrieves the latest version of the Template."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def update(self, model):"},{"line_number":236,"context_line":"            # Updates a Template."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        def delete(self, uuid):"},{"line_number":239,"context_line":"            # Deletes a Template with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_37da83e9","line":236,"in_reply_to":"1ae5cdf2_58c75365","updated":"2014-06-26 04:33:11.000000000","message":"I don\u0027t think we do, removed.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            # Deletes a Template with the specified uuid."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def list(self):"},{"line_number":242,"context_line":"            # Returns a list of all Templates."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"**Environment File API**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b89f7764","line":242,"updated":"2014-06-25 18:22:29.000000000","message":"I think we need either a separate call or a flag here similar to only_latest for roles. There will be cases of the same template (by name) with different versions.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            # Deletes a Template with the specified uuid."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        def list(self):"},{"line_number":242,"context_line":"            # Returns a list of all Templates."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"**Environment File API**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_57ac6f35","line":242,"in_reply_to":"1ae5cdf2_b89f7764","updated":"2014-06-26 04:33:11.000000000","message":"Parameter added.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"**Environment File API**"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"The environment file require secure storage to protect parameter values."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. code-block:: python"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_be03dfbc","line":247,"updated":"2014-06-25 18:22:29.000000000","message":"Grammar Nit: requires","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"**Environment File API**"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"The environment file require secure storage to protect parameter values."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. code-block:: python"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b7493390","line":247,"in_reply_to":"1ae5cdf2_be03dfbc","updated":"2014-06-26 04:33:11.000000000","message":"Me fixes sooper gud","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    class EnvironmentFileStore:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        def create(self, name\u003dNone, content\u003dNone):"},{"line_number":254,"context_line":"            # Creates an EnvironmentFile."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        def retrieve(self, uuid):"},{"line_number":257,"context_line":"            # Retrieves the EnvironmentFile with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_9e7aa3b8","line":254,"updated":"2014-06-25 18:22:29.000000000","message":"What is the name here? It shouldn\u0027t be filename, since that should be pretty much standard for each deployment plan. There\u0027s no logical name for the environment file since that\u0027s just what it is; there\u0027s no need to distinguish it from another environment file in the same deployment plan.\n\nContent here is an interesting question. There\u0027s a standard... I don\u0027t want to say template... structure for what an environment file will be. On environment file create, we could presume it\u0027s at the outset of a new plan and generate the skeleton, in which case content isn\u0027t needed at all.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    class EnvironmentFileStore:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        def create(self, name\u003dNone, content\u003dNone):"},{"line_number":254,"context_line":"            # Creates an EnvironmentFile."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        def retrieve(self, uuid):"},{"line_number":257,"context_line":"            # Retrieves the EnvironmentFile with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_370b632c","line":254,"in_reply_to":"1ae5cdf2_9e7aa3b8","updated":"2014-06-26 04:33:11.000000000","message":"Good point; removed the parameters, and removed name from the EnvironmentFile domain model.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        def create(self, name\u003dNone, description\u003dNone, last_updated\u003dFalse,"},{"line_number":276,"context_line":"                   version\u003dNone, template_uuid\u003dNone):"},{"line_number":277,"context_line":"            # Creates a Role."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        def retrieve(self, uuid):"},{"line_number":280,"context_line":"            # Retrieves the Role with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b82a172d","line":277,"updated":"2014-06-25 18:22:29.000000000","message":"Are all of those fields really optional? Description perhaps, but I can\u0027t see a case where name is optional.\n\nShould last_updated even be a field? That should be up to the storage implementation to write.\n\nSame for version. I can\u0027t see a need to manually set a version number. That\u0027s likely going to break however storage automatically increments them.\n\ntemplate_uuid is an interesting one. How do you see the workflow playing out, that you first upload the templates and then associate them to a role, or the opposite? Is there even a logical concept of a role without an associated template?\n\nThere is no way to indicate dependent template UUIDs in this signature.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        def create(self, name\u003dNone, description\u003dNone, last_updated\u003dFalse,"},{"line_number":276,"context_line":"                   version\u003dNone, template_uuid\u003dNone):"},{"line_number":277,"context_line":"            # Creates a Role."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        def retrieve(self, uuid):"},{"line_number":280,"context_line":"            # Retrieves the Role with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_ea77528c","line":277,"in_reply_to":"1ae5cdf2_b82a172d","updated":"2014-06-26 04:33:11.000000000","message":"Updated the signature to remove last_updated and version.  template_uuid should be role_template, and have the actual template object; I imagine the create method will traverse that template, find the dependent template names, and use the latest version of each of those templates from the template store as the dependent templates.\n\nI\u0027ll add descriptions of the above.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        def list(self, only_latest\u003dFalse):"},{"line_number":293,"context_line":"            # Returns a list of all Roles.  If only_latest is True, filters"},{"line_number":294,"context_line":"            # the list to the latest version of each Role."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"**Deployment Plan API**"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_b835b7a9","line":294,"updated":"2014-06-25 18:22:29.000000000","message":"I think the model is correct in that it\u0027s going to return the UUIDs for the templates rather than having to answer the question of whether or not the template is pre-fetched.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"b5d77a0bcab46ea024fc7dc809a8ad4209400a05","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                   master_template_uuid\u003dNone, environment_file_uuid\u003dNone):"},{"line_number":305,"context_line":"            # Creates a DeploymentPlan.  Also creates an associated empty master"},{"line_number":306,"context_line":"            # Template and EnvironmentFile; these will be modified as Roles are"},{"line_number":307,"context_line":"            # added and removed."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        def retrieve(self, uuid):"},{"line_number":310,"context_line":"            # Retrieves the DeploymentPlan with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_12592735","line":307,"updated":"2014-06-25 18:22:29.000000000","message":"Again, name should be required.\n\nlast_updated should be generated by the store implementation, not the caller.\n\nIf this is creating an empty master template and environment file, why are the UUIDs for them in the signature?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                   master_template_uuid\u003dNone, environment_file_uuid\u003dNone):"},{"line_number":305,"context_line":"            # Creates a DeploymentPlan.  Also creates an associated empty master"},{"line_number":306,"context_line":"            # Template and EnvironmentFile; these will be modified as Roles are"},{"line_number":307,"context_line":"            # added and removed."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        def retrieve(self, uuid):"},{"line_number":310,"context_line":"            # Retrieves the DeploymentPlan with the specified uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_cad7f621","line":307,"in_reply_to":"1ae5cdf2_12592735","updated":"2014-06-26 04:33:11.000000000","message":"Whoops, fixed.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"7d7b6420d3f8669bb16d7aed36dbdf29fca81a1f","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    class Driver:"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        def create(self, content):"},{"line_number":335,"context_line":"            # Stores the specified content and returns the resulting uuid."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        def retrieve(self, uuid):"},{"line_number":338,"context_line":"            # Returns the content matching the uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_72e34ba4","line":335,"updated":"2014-06-25 18:36:33.000000000","message":"Don\u0027t we need a filename? The resource_registry is going to have to refer to the template files. They are either hosted somewhere, in which case we\u0027ll need to know the URI, or we download them at files dict creation time, in which case the filename has to be known.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    class Driver:"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        def create(self, content):"},{"line_number":335,"context_line":"            # Stores the specified content and returns the resulting uuid."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        def retrieve(self, uuid):"},{"line_number":338,"context_line":"            # Returns the content matching the uuid."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_4aca066f","line":335,"in_reply_to":"1ae5cdf2_72e34ba4","updated":"2014-06-26 04:33:11.000000000","message":"Added.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"7d7b6420d3f8669bb16d7aed36dbdf29fca81a1f","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        def filter(self, **kwargs):"},{"line_number":350,"context_line":"            # Return a list of filtered content that match the requirements"},{"line_number":351,"context_line":"            # specified in kwargs. kwargs is a mapping of expected values such"},{"line_number":352,"context_line":"            # as \"name\u003ddev-cloud\""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def retrieve_by(self, **kwargs):"},{"line_number":355,"context_line":"            # Returns the content that matches the given keyword arguments. The"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_d2bdff68","line":352,"updated":"2014-06-25 18:36:33.000000000","message":"I\u0027m confused at what this does. Does it grep through the content of every file applying the filter? Does this retrieve the object model for every object in storage and compare its first-class attributes against the keys in kwargs?","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        def filter(self, **kwargs):"},{"line_number":350,"context_line":"            # Return a list of filtered content that match the requirements"},{"line_number":351,"context_line":"            # specified in kwargs. kwargs is a mapping of expected values such"},{"line_number":352,"context_line":"            # as \"name\u003ddev-cloud\""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        def retrieve_by(self, **kwargs):"},{"line_number":355,"context_line":"            # Returns the content that matches the given keyword arguments. The"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_aa8e2a25","line":352,"in_reply_to":"1ae5cdf2_d2bdff68","updated":"2014-06-26 04:33:11.000000000","message":"It\u0027s the latter; I think it\u0027s there to hopefully provide a more efficient querying mechanism, but I\u0027m not absolutely sure it\u0027s necessary.  Removing for now.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":8399,"name":"Jay Dobies","email":"jason.dobies@redhat.com","username":"jdob"},"change_message_id":"7d7b6420d3f8669bb16d7aed36dbdf29fca81a1f","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        def retrieve_by(self, **kwargs):"},{"line_number":355,"context_line":"            # Returns the content that matches the given keyword arguments. The"},{"line_number":356,"context_line":"            # behavior is the same as the filter method, but will result in an"},{"line_number":357,"context_line":"            # error if more than one match is found."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"For Juno, we will aim to use a combination of a relational database and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_12b84774","line":357,"updated":"2014-06-25 18:36:33.000000000","message":"Ditto.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"b5aae3dee4af9b6ca26cb107fcd1673d67f0818d","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        def retrieve_by(self, **kwargs):"},{"line_number":355,"context_line":"            # Returns the content that matches the given keyword arguments. The"},{"line_number":356,"context_line":"            # behavior is the same as the filter method, but will result in an"},{"line_number":357,"context_line":"            # error if more than one match is found."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"For Juno, we will aim to use a combination of a relational database and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_ca93764d","line":357,"in_reply_to":"1ae5cdf2_12b84774","updated":"2014-06-26 04:33:11.000000000","message":"Ditto.","commit_id":"5e554a66b9f49149d8fc16367398a1e947dbb6ca"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        created_at \u003d datetime"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # This is derived from the content from within the template store."},{"line_number":98,"context_line":"        parameter_names \u003d list of parameter names"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"**Environment File Model**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_9ef44c56","line":98,"updated":"2014-06-26 08:48:03.000000000","message":"I would say not list, but dict with parameters (in a format returned by validate template)","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        created_at \u003d datetime"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # This is derived from the content from within the template store."},{"line_number":98,"context_line":"        parameter_names \u003d list of parameter names"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"**Environment File Model**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_69d262d2","line":98,"in_reply_to":"1ae5cdf2_9ef44c56","updated":"2014-06-26 13:53:16.000000000","message":"Oh - right, the parameters include name and default.  Good catch!","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        resource_registry \u003d list of provider resource template names"},{"line_number":116,"context_line":"        parameters \u003d list of parameters and their values"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def add_provider_resource(self, template):"},{"line_number":119,"context_line":"            # Adds the specified template object to the environment file as a"},{"line_number":120,"context_line":"            # provider resource.  This updates the parameters and resource registry"},{"line_number":121,"context_line":"            # in the content."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_7ee06097","line":118,"updated":"2014-06-26 08:48:03.000000000","message":"I \u0027ve commented it on patchset 9. Instead of add_provider_resource/remove_provider_resource I would rather have set_resource_registry/get_resource_registry\n\ne.g. env.set_resource_registry({\nOS::TripleO::Compute: compute.yaml,\nOS::TripleO::Controller: controller.yaml,\nOS::TripleO::BlockStorage: block-storage.yaml,\nOS::TripleO::SwiftStorage: swift-storage.yam})\n\nIn any way add_provider_resource is missing a provider_resource_name parameter","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        resource_registry \u003d list of provider resource template names"},{"line_number":116,"context_line":"        parameters \u003d list of parameters and their values"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        def add_provider_resource(self, template):"},{"line_number":119,"context_line":"            # Adds the specified template object to the environment file as a"},{"line_number":120,"context_line":"            # provider resource.  This updates the parameters and resource registry"},{"line_number":121,"context_line":"            # in the content."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_5ca64210","line":118,"in_reply_to":"1ae5cdf2_7ee06097","updated":"2014-06-26 13:53:16.000000000","message":"A provider resource is just a template, right?  And when you add a provider resource, you have to update the resource_registry and the parameters.  Both are derivable from the template object.\n\nWorking on the provider resource level also makes it impractical to set/get resource registry, as adding/removing a provider resource impacts both the registry and the parameters.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            # environment file.  This updates the parameters and resource registry"},{"line_number":126,"context_line":"            # in the content."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def set_parameters(self, params_dict):"},{"line_number":129,"context_line":"            # The key/value pairs in params_dict correspond to parameter names/"},{"line_number":130,"context_line":"            # desired values.  This method updates the parameters section in the"},{"line_number":131,"context_line":"            # content to the values specified in params_dict."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_fe07106e","line":128,"updated":"2014-06-26 08:48:03.000000000","message":"get_parameters method got lost?","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            # environment file.  This updates the parameters and resource registry"},{"line_number":126,"context_line":"            # in the content."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def set_parameters(self, params_dict):"},{"line_number":129,"context_line":"            # The key/value pairs in params_dict correspond to parameter names/"},{"line_number":130,"context_line":"            # desired values.  This method updates the parameters section in the"},{"line_number":131,"context_line":"            # content to the values specified in params_dict."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_3cefb61e","line":128,"in_reply_to":"1ae5cdf2_fe07106e","updated":"2014-06-26 13:53:16.000000000","message":"See line 116 - the environment file store will handle parsing the parameters from the content.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        name \u003d string"},{"line_number":145,"context_line":"        version \u003d integer"},{"line_number":146,"context_line":"        description \u003d string"},{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_b9d20232","line":147,"updated":"2014-06-26 08:48:03.000000000","message":"so just a question how should be the env. and files build from this\n\nI would say if name is \u0027compute\u0027, we will automatically build a provider resource from that: OS::TripleO::Compute\n\nand file name: os_tripleo_compute.yaml\n\nSo we should be able to easily put this to Heat parameters, right? Unless you had different plan, I would put this somewhere in the spec.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        name \u003d string"},{"line_number":145,"context_line":"        version \u003d integer"},{"line_number":146,"context_line":"        description \u003d string"},{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_fcbb8e72","line":147,"in_reply_to":"1ae5cdf2_b9d20232","updated":"2014-06-26 13:53:16.000000000","message":"I had just imagined that the provider resource type would be constructed from the template file name.  I\u0027ll add that clarification above.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        version \u003d integer"},{"line_number":146,"context_line":"        description \u003d string"},{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def retrieve_role_template(self):"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_7946ba51","line":148,"updated":"2014-06-26 08:48:03.000000000","message":"I believe it should be dict with\n\n{\u0027compute-config.yaml\u0027: \u0027template_uuid\u0027, ...}\n\nIf you will have just UUIDs that mean you will use Template.name as files index. Which is limiting cause you need to have in your storage, template named the same as it is inside template.\n\nThe files mapping is in Heat so you don\u0027t have this limitation.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        version \u003d integer"},{"line_number":146,"context_line":"        description \u003d string"},{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def retrieve_role_template(self):"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_5c0d628e","line":148,"in_reply_to":"1ae5cdf2_7946ba51","updated":"2014-06-26 13:53:16.000000000","message":"Well, the Template UUID points to a Template object, which contains the template name within it - wouldn\u0027t that solve this issue?","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def retrieve_role_template(self):"},{"line_number":152,"context_line":"            # Retrieves the Template with uuid matching role_template_uuid"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_1942160f","line":150,"updated":"2014-06-26 08:48:03.000000000","message":"We need  a way here to scan dependencies that will return files dict so\n\ncalling Role.get_dependency_files would return you\n\n{\u0027compute-config.yaml\u0027: some_uuid, \u0027global-config.yaml\u0027: None}\n\nSo you see that that global_config.yaml dependency is missing\n\nso you call \nRole.set_dependency_files({\u0027compute-config.yaml\u0027: some_uuid, \u0027global-config.yaml\u0027: another_uuid}) \n\n\nnow if you call Role.get_dependency_files again, there could be another dependency created by the new global_config.yaml:\n\n{\u0027compute-config.yaml\u0027: some_uuid, \u0027global-config.yaml\u0027: another_uuid}, \u0027global_rabbit_config.yaml\u0027: None) \n\nSo you need to set the dependency, etc...","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        role_template_uuid \u003d Template UUID string"},{"line_number":148,"context_line":"        dependent_template_uuids \u003d list of Template UUID strings"},{"line_number":149,"context_line":"        created_at \u003d datetime"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        def retrieve_role_template(self):"},{"line_number":152,"context_line":"            # Retrieves the Template with uuid matching role_template_uuid"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_fced4e8f","line":150,"in_reply_to":"1ae5cdf2_1942160f","updated":"2014-06-26 13:53:16.000000000","message":"This sort of scanning would presumably be done when a Role is created.  You have a good point that a flag should be raised if a template is missing; I\u0027ll add it down below in the RoleStore API section.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        def get_dependent_templates(self):"},{"line_number":200,"context_line":"            # Returns a list of dependent templates.  This consists of the"},{"line_number":201,"context_line":"            # associated role templates."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"**Storage API Interface**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_b91122b1","line":201,"updated":"2014-06-26 08:48:03.000000000","message":"actually list of dependent templates is not usable for anything\n\nthe method should be called retrieve_dependency_files and it should be build by\n\nfiles \u003d {}\n\nfor role in Plan.roles:\n    # adding a role template to files, built as mentioned ^\n    # so e.g. files.update({\u0027os_tripleo_compute\u0027: file_uuid_or_content})\n    \n    files.update(role.get_dependency_files)\n\n\nThen we get \u0027files dictionary\u0027 we need send to Heat. So when we want to call heat we will call retrieve_master_template, retrieve_environment_file, retrieve_dependency_files(it will be wrapped by another API but the logic should be here, in Tuskar API, we can just replace the UUIDs with json dumped content). And we just pass that to heat.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        def get_dependent_templates(self):"},{"line_number":200,"context_line":"            # Returns a list of dependent templates.  This consists of the"},{"line_number":201,"context_line":"            # associated role templates."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"**Storage API Interface**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_1c303a55","line":201,"in_reply_to":"1ae5cdf2_b91122b1","updated":"2014-06-26 13:53:16.000000000","message":"Unless I\u0027m misunderstanding your point, that\u0027s basically what this method would do - get the role templates and all their dependencies.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            # Retrieves the Template with the specified uuid.  Queries a Heat"},{"line_number":233,"context_line":"            # template parser for template parameters and dependent template names."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def retrieve_by_name(self, name, version\u003dNone):"},{"line_number":236,"context_line":"            # Retrieves the Template with the specified name and version.  If no"},{"line_number":237,"context_line":"            # version is specified, retrieves the latest version of the Template."},{"line_number":238,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_59fe5e39","line":235,"updated":"2014-06-26 08:48:03.000000000","message":"hm we will need to somehow retrieve_all_versions_by_name\n\nOr should it be uninterrupted row of integer versions? So getting the last will give you version span?","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            # Retrieves the Template with the specified uuid.  Queries a Heat"},{"line_number":233,"context_line":"            # template parser for template parameters and dependent template names."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def retrieve_by_name(self, name, version\u003dNone):"},{"line_number":236,"context_line":"            # Retrieves the Template with the specified name and version.  If no"},{"line_number":237,"context_line":"            # version is specified, retrieves the latest version of the Template."},{"line_number":238,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_bcb90618","line":235,"in_reply_to":"1ae5cdf2_59fe5e39","updated":"2014-06-26 13:53:16.000000000","message":"Yeah, that\u0027s my intention - the greatest existing version will by the latest, and the version number is entirely controlled by the API.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0349bb683d164cca5a01761f03dd4ec3adfd41f0","unresolved":false,"context_lines":[{"line_number":390,"context_line":"versioning of itself and its dependent templates, or the ability to list out"},{"line_number":391,"context_line":"available roles for selection within a plan.  These are not requirements that"},{"line_number":392,"context_line":"Heat intends to fulfill, and fulfilling them entirely within Heat feels like an"},{"line_number":393,"context_line":"abuse of mechanics."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"**Swift as a Storage Backend**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_1de3e1d8","line":393,"updated":"2014-06-26 08:48:03.000000000","message":"I would add that this way would require to modify the templates by Tuskar. Which is not nice thing to do.","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"f35fe987c87f9057ccc843a0c134d43c25c8bd42","unresolved":false,"context_lines":[{"line_number":390,"context_line":"versioning of itself and its dependent templates, or the ability to list out"},{"line_number":391,"context_line":"available roles for selection within a plan.  These are not requirements that"},{"line_number":392,"context_line":"Heat intends to fulfill, and fulfilling them entirely within Heat feels like an"},{"line_number":393,"context_line":"abuse of mechanics."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"**Swift as a Storage Backend**"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_7cd05ef7","line":393,"in_reply_to":"1ae5cdf2_1de3e1d8","updated":"2014-06-26 13:53:16.000000000","message":"Good idea, added!","commit_id":"0b801f04b5f7cfb760bc729591adeed7720d032d"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"886072d6b8138dd9e913ae071ff5c899ce5616c0","unresolved":false,"context_lines":[{"line_number":431,"context_line":"and relationships this would require re-implementing much of what other"},{"line_number":432,"context_line":"databases and services provide for us. Therefore, this option is reserved only"},{"line_number":433,"context_line":"for a development option which will be missing key features."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"**Secure Driver Alternatives**"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"baada198_6f32b511","line":434,"updated":"2014-07-02 03:45:07.000000000","message":"I\u0027d suggest not writing one ever ;)","commit_id":"ea0d529677b986cb47706109e62ccd0d5be74573"}]}
