)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"6d3f5422aa5c73f9220b04b21708422fb0f96a08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Redirect user to login page when token expires"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Note that we can\u0027t implement the logout functionality on the base class because"},{"line_number":10,"context_line":"of circular dependencies."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I99c0a70408b077183f2a4406354e8531cc513ee7"},{"line_number":13,"context_line":"Closes-Bug: 1626556"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a629dbe_10f44c84","line":10,"updated":"2016-11-09 10:35:21.000000000","message":"Nit: IMHO this explanation would better fit into a code comment in the relevant files or alternatively into a gerrit comment.","commit_id":"46dee313f7a41a25bb154d83061cfc97bc180409"}],"src/__tests__/actions/ParametersActions.tests.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"a7b0372159933114417e4510ac27aa3890cf2b53","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      expect(ParametersActions.updateParametersSuccess).not.toHaveBeenCalled();"},{"line_number":125,"context_line":"    });"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    it(\u0027dispatches fetchParametersFailed\u0027, () \u003d\u003e {"},{"line_number":128,"context_line":"      expect(ParametersActions.updateParametersFailed).toHaveBeenCalled();"},{"line_number":129,"context_line":"    });"},{"line_number":130,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba5da102_45a49b07","side":"PARENT","line":127,"updated":"2016-11-04 19:04:12.000000000","message":"this should still happen. there is an error in ZaqarWebSocketService.js in close(). this.socket.close() needs to happen only when this.socket exists","commit_id":"7f60d052bc51c0e7e0f777a46276689c8c2f8d69"}],"src/js/actions/ParametersActions.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"a8b3013364bb09bf9617286866983eb48b211e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a629dbe_d3c57e8e","updated":"2016-11-09 10:38:57.000000000","message":"I am not sure why this change should be needed. \nupdateParameters action is triggered when parameters form is submitted. In case of failure, the errors are displayed as form errors rather than notification message. That is why updateParametersFailed action takes errors and formFieldErrors params.","commit_id":"46dee313f7a41a25bb154d83061cfc97bc180409"}],"src/js/components/utils/BaseHttpRequestErrorHandler.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"a7b0372159933114417e4510ac27aa3890cf2b53","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  get formFieldErrors() {"},{"line_number":39,"context_line":"    return this._formFieldErrors;"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"}"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba5da102_609d0d59","line":41,"updated":"2016-11-04 19:04:12.000000000","message":"remove this change","commit_id":"998aec9ed9ce069a0af23058fe77f1ef5e9ff33b"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"1de6c5020f1946bd86ae7497fd0423e842a645df","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  get formFieldErrors() {"},{"line_number":39,"context_line":"    return this._formFieldErrors;"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"}"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba5da102_80af812a","line":41,"in_reply_to":"ba5da102_609d0d59","updated":"2016-11-04 19:17:17.000000000","message":"ok but it\u0027s so ugly without it :)","commit_id":"998aec9ed9ce069a0af23058fe77f1ef5e9ff33b"}],"src/js/services/MistralApiErrorHandler.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"a7b0372159933114417e4510ac27aa3890cf2b53","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        title: \u0027Failed to run Action\u0027,"},{"line_number":43,"context_line":"        message: errorObj.message"},{"line_number":44,"context_line":"      });"},{"line_number":45,"context_line":"      store.dispatch(LoginActions.logoutUser());"},{"line_number":46,"context_line":"      break;"},{"line_number":47,"context_line":"    default:"},{"line_number":48,"context_line":"      errors.push({"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba5da102_e0c03d2d","line":45,"updated":"2016-11-04 19:04:12.000000000","message":"What is the reason for this one again?","commit_id":"998aec9ed9ce069a0af23058fe77f1ef5e9ff33b"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"1de6c5020f1946bd86ae7497fd0423e842a645df","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        title: \u0027Failed to run Action\u0027,"},{"line_number":43,"context_line":"        message: errorObj.message"},{"line_number":44,"context_line":"      });"},{"line_number":45,"context_line":"      store.dispatch(LoginActions.logoutUser());"},{"line_number":46,"context_line":"      break;"},{"line_number":47,"context_line":"    default:"},{"line_number":48,"context_line":"      errors.push({"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba5da102_c080998e","line":45,"in_reply_to":"ba5da102_e0c03d2d","updated":"2016-11-04 19:17:17.000000000","message":"When you create an execution in Mistral, you will get back a 201 which sometimes includes an error message.  This happens when the token is expired.","commit_id":"998aec9ed9ce069a0af23058fe77f1ef5e9ff33b"}]}
